From 16224b3c02080c1754e9ec0771fb1c2ae7d1c09f Mon Sep 17 00:00:00 2001
From: Donovan Preston <dpreston@mozilla.com>
Date: Fri, 8 Feb 2019 12:44:21 -0500
Subject: [PATCH] =?UTF-8?q?Fix=20#1108=20Hide=20email=20input=20on=20signu?=
 =?UTF-8?q?p=20page=20so=20that=20it=20doesn't=20hide=20par=E2=80=A6=20(#1?=
 =?UTF-8?q?140)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Fix #1108 Hide email input on signup page so that it doesn't hide part of the bottom of the page

* Fix #1115 Prevent clicking on the button more than once in a row.

* Show the email input on desktop
---
 app/ui/signupDialog.js | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/app/ui/signupDialog.js b/app/ui/signupDialog.js
index 61b4e8e7..d4583adf 100644
--- a/app/ui/signupDialog.js
+++ b/app/ui/signupDialog.js
@@ -1,12 +1,11 @@
 /* global LIMITS */
 const html = require('choo/html');
-const { bytes } = require('../utils');
+const { bytes, platform } = require('../utils');
 
 module.exports = function() {
   return function(state, emit, close) {
-    setTimeout(function() {
-      document.getElementById('email-input').focus();
-    });
+    const hidden = platform() === 'android' ? 'hidden' : '';
+    let submitting = false;
     return html`
     <send-signup-dialog class="flex flex-col p-4">
       <p class="p-8">
@@ -25,12 +24,12 @@ module.exports = function() {
         <input
           id="email-input"
           type="text"
-          class="border rounded w-full px-2 py-1 h-12 mb-4 text-lg text-grey-darker leading-loose"
-          placeholder=${state.translate('emailEntryPlaceholder')}/>
+          class="${hidden} border rounded w-full px-2 py-1 h-12 mb-4 text-lg text-grey-darker leading-loose"
+          placeholder=${state.translate('emailEntryPlaceholder')} />
         <input
           class="hidden"
           id="email-submit"
-          type="submit"/>
+          type="submit" />
       </form>
       <label class="btn rounded w-full flex flex-no-shrink items-center justify-center" for="email-submit">
         ${state.translate('signInMenuOption')}
@@ -53,6 +52,11 @@ module.exports = function() {
 
     function submitEmail(event) {
       event.preventDefault();
+      if (submitting) {
+        return;
+      }
+      submitting = true;
+
       const el = document.getElementById('email-input');
       const email = el.value;
       emit('login', emailish(email) ? email : null);