From 3c8a2a1313fa507b6ef9dbb87c44a5473cfdb21c Mon Sep 17 00:00:00 2001 From: Thomas Citharel Date: Tue, 29 Mar 2022 10:39:32 +0200 Subject: [PATCH] Add details of object in exception when AP object as no actor/attributedTo Signed-off-by: Thomas Citharel --- lib/federation/activity_pub/utils.ex | 5 +++-- test/federation/activity_pub/utils_test.exs | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/federation/activity_pub/utils.ex b/lib/federation/activity_pub/utils.ex index 84efe8ff0..6896dc6cc 100644 --- a/lib/federation/activity_pub/utils.ex +++ b/lib/federation/activity_pub/utils.ex @@ -337,8 +337,9 @@ defmodule Mobilizon.Federation.ActivityPub.Utils do message: "Object contains an actor object with invalid type: #{inspect(type)}" end - def get_actor(%{"actor" => nil, "attributedTo" => nil}) do - raise ArgumentError, message: "Object contains both actor and attributedTo fields being null" + def get_actor(%{"actor" => nil, "attributedTo" => nil} = object) do + raise ArgumentError, + message: "Object contains both actor and attributedTo fields being null: #{inspect(object)}" end def get_actor(%{"actor" => _}) do diff --git a/test/federation/activity_pub/utils_test.exs b/test/federation/activity_pub/utils_test.exs index 28a271b76..83f058681 100644 --- a/test/federation/activity_pub/utils_test.exs +++ b/test/federation/activity_pub/utils_test.exs @@ -129,7 +129,7 @@ defmodule Mobilizon.Federation.ActivityPub.UtilsTest do test "with no actor information" do assert_raise ArgumentError, - "Object contains both actor and attributedTo fields being null", + "Object contains both actor and attributedTo fields being null: %{\"actor\" => nil, \"attributedTo\" => nil}", fn -> Utils.get_actor(%{ "actor" => nil,