From 4d4ee80b8c360253efb03d73015e18ba5b00ad08 Mon Sep 17 00:00:00 2001
From: Thomas Citharel <tcit@tcit.fr>
Date: Mon, 29 Mar 2021 18:22:14 +0200
Subject: [PATCH] Handle feeds with unknown formats properly

Closes #660

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
---
 lib/web/controllers/feed_controller.ex | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/lib/web/controllers/feed_controller.ex b/lib/web/controllers/feed_controller.ex
index 4de8e61b4..4db698fea 100644
--- a/lib/web/controllers/feed_controller.ex
+++ b/lib/web/controllers/feed_controller.ex
@@ -7,9 +7,7 @@ defmodule Mobilizon.Web.FeedController do
   action_fallback(Mobilizon.Web.FallbackController)
   alias Mobilizon.Config
 
-  @formats ["ics", "atom"]
-
-  def instance(conn, %{"format" => format}) when format in @formats do
+  def instance(conn, %{"format" => format}) do
     if Config.get([:instance, :enable_instance_feeds], false) do
       return_data(conn, format, "instance", Config.instance_name())
     else
@@ -17,7 +15,7 @@ defmodule Mobilizon.Web.FeedController do
     end
   end
 
-  def actor(conn, %{"format" => format, "name" => name}) when format in @formats do
+  def actor(conn, %{"format" => format, "name" => name}) do
     return_data(conn, format, "actor_" <> name, name)
   end
 
@@ -33,7 +31,7 @@ defmodule Mobilizon.Web.FeedController do
     {:error, :not_found}
   end
 
-  def going(conn, %{"token" => token, "format" => format}) when format in @formats do
+  def going(conn, %{"token" => token, "format" => format}) do
     return_data(conn, format, "token_" <> token, "events")
   end
 
@@ -72,4 +70,8 @@ defmodule Mobilizon.Web.FeedController do
         {:error, :not_found}
     end
   end
+
+  defp return_data(_conn, _, _, _) do
+    {:error, :not_found}
+  end
 end