From e36f8f53ab63ab3fee0f43f668e95bed81f1e591 Mon Sep 17 00:00:00 2001
From: Thomas Citharel <tcit@tcit.fr>
Date: Thu, 21 Apr 2022 11:53:42 +0200
Subject: [PATCH] Hide address blocks when address has no real data

Closes #1085

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
---
 js/src/components/Group/GroupCard.vue |  5 ++++-
 js/src/views/Group/Group.vue          | 11 +++++++----
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/js/src/components/Group/GroupCard.vue b/js/src/components/Group/GroupCard.vue
index 2ac23002d..f2a711b4a 100644
--- a/js/src/components/Group/GroupCard.vue
+++ b/js/src/components/Group/GroupCard.vue
@@ -39,7 +39,7 @@
       <div>
         <inline-address
           class="has-text-grey-dark"
-          v-if="group.physicalAddress"
+          v-if="group.physicalAddress && addressFullName(group.physicalAddress)"
           :physicalAddress="group.physicalAddress"
         />
         <p class="has-text-grey-dark">
@@ -65,6 +65,7 @@ import { displayName, IGroup, usernameWithDomain } from "@/types/actor";
 import LazyImageWrapper from "@/components/Image/LazyImageWrapper.vue";
 import RouteName from "../../router/name";
 import InlineAddress from "@/components/Address/InlineAddress.vue";
+import { addressFullName } from "@/types/address.model";
 
 @Component({
   components: {
@@ -80,6 +81,8 @@ export default class GroupCard extends Vue {
   usernameWithDomain = usernameWithDomain;
 
   displayName = displayName;
+
+  addressFullName = addressFullName;
 }
 </script>
 <style lang="scss" scoped>
diff --git a/js/src/views/Group/Group.vue b/js/src/views/Group/Group.vue
index aa7f353c2..a2c0522c3 100644
--- a/js/src/views/Group/Group.vue
+++ b/js/src/views/Group/Group.vue
@@ -558,9 +558,10 @@
             "
           >
             <div class="address-wrapper">
-              <span v-if="!physicalAddress">{{
-                $t("No address defined")
-              }}</span>
+              <span
+                v-if="!physicalAddress || !addressFullName(physicalAddress)"
+                >{{ $t("No address defined") }}</span
+              >
               <div class="address" v-if="physicalAddress">
                 <div>
                   <address dir="auto">
@@ -739,7 +740,7 @@ import DiscussionListItem from "@/components/Discussion/DiscussionListItem.vue";
 import MultiPostListItem from "@/components/Post/MultiPostListItem.vue";
 import ResourceItem from "@/components/Resource/ResourceItem.vue";
 import FolderItem from "@/components/Resource/FolderItem.vue";
-import { Address } from "@/types/address.model";
+import { Address, addressFullName } from "@/types/address.model";
 import Invitations from "@/components/Group/Invitations.vue";
 import addMinutes from "date-fns/addMinutes";
 import { CONFIG } from "@/graphql/config";
@@ -820,6 +821,8 @@ export default class Group extends mixins(GroupMixin) {
 
   displayName = displayName;
 
+  addressFullName = addressFullName;
+
   PostVisibility = PostVisibility;
 
   Openness = Openness;