diff --git a/lib/Data/Filesystem.php b/lib/Data/Filesystem.php index eabc2719..2235ff24 100644 --- a/lib/Data/Filesystem.php +++ b/lib/Data/Filesystem.php @@ -13,6 +13,7 @@ namespace PrivateBin\Data; use PrivateBin\Model\Paste; +use PrivateBin\Json; /** * Filesystem @@ -61,6 +62,7 @@ class Filesystem extends AbstractData * @access public * @param string $pasteid * @param array $paste + * @throws Exception * @return bool */ public function create($pasteid, $paste) @@ -72,7 +74,7 @@ class Filesystem extends AbstractData if (!is_dir($storagedir)) { mkdir($storagedir, 0700, true); } - return (bool) file_put_contents($storagedir . $pasteid, json_encode($paste)); + return (bool) file_put_contents($storagedir . $pasteid, Json::encode($paste)); } /** @@ -153,6 +155,7 @@ class Filesystem extends AbstractData * @param string $parentid * @param string $commentid * @param array $comment + * @throws Exception * @return bool */ public function createComment($pasteid, $parentid, $commentid, $comment) @@ -165,7 +168,7 @@ class Filesystem extends AbstractData if (!is_dir($storagedir)) { mkdir($storagedir, 0700, true); } - return (bool) file_put_contents($storagedir . $filename, json_encode($comment)); + return (bool) file_put_contents($storagedir . $filename, Json::encode($comment)); } /** diff --git a/lib/Json.php b/lib/Json.php new file mode 100644 index 00000000..ab1f4855 --- /dev/null +++ b/lib/Json.php @@ -0,0 +1,48 @@ +assertFalse($this->_model->existsComment(Helper::getPasteId(), Helper::getPasteId(), Helper::getCommentId()), 'comment does not yet exist'); - $this->assertTrue($this->_model->createComment(Helper::getPasteId(), Helper::getPasteId(), Helper::getCommentId(), Helper::getComment()) !== false, 'store comment'); + $this->assertTrue($this->_model->createComment(Helper::getPasteId(), Helper::getPasteId(), Helper::getCommentId(), Helper::getComment()), 'store comment'); $this->assertTrue($this->_model->existsComment(Helper::getPasteId(), Helper::getPasteId(), Helper::getCommentId()), 'comment exists after storing it'); $comment = json_decode(json_encode(Helper::getComment())); $comment->id = Helper::getCommentId(); @@ -93,4 +93,34 @@ class FilesystemTest extends PHPUnit_Framework_TestCase } } } + + /** + * @expectedException Exception + * @expectedExceptionCode 90 + */ + public function testErrorDetection() + { + $this->_model->delete(Helper::getPasteId()); + $paste = Helper::getPaste(array('formatter' => "Invalid UTF-8 sequence: \xB1\x31")); + $this->assertFalse($this->_model->exists(Helper::getPasteId()), 'paste does not yet exist'); + $this->assertFalse($this->_model->create(Helper::getPasteId(), $paste), 'unable to store broken paste'); + $this->assertFalse($this->_model->exists(Helper::getPasteId()), 'paste does still not exist'); + } + + /** + * @expectedException Exception + * @expectedExceptionCode 90 + */ + public function testCommentErrorDetection() + { + $this->_model->delete(Helper::getPasteId()); + $paste = Helper::getPaste(); + $comment = Helper::getComment(array('formatter' => "Invalid UTF-8 sequence: \xB1\x31")); + $this->assertFalse($this->_model->exists(Helper::getPasteId()), 'paste does not yet exist'); + $this->assertTrue($this->_model->create(Helper::getPasteId(), Helper::getPaste()) === true, 'store new paste'); + $this->assertTrue($this->_model->exists(Helper::getPasteId()), 'paste exists after storing it'); + $this->assertFalse($this->_model->existsComment(Helper::getPasteId(), Helper::getPasteId(), Helper::getCommentId()), 'comment does not yet exist'); + $this->assertFalse($this->_model->createComment(Helper::getPasteId(), Helper::getPasteId(), Helper::getCommentId(), $comment), 'unable to store broken comment'); + $this->assertFalse($this->_model->existsComment(Helper::getPasteId(), Helper::getPasteId(), Helper::getCommentId()), 'comment does still not exist'); + } }