Chapril/xmpp.chapril.org-conversejs
Chapril/xmpp.chapril.org-conversejs
25
0
Fork 0
Code Issues Pull Requests Projects Releases Activity
5a2d361c81
xmpp.chapril.org-conversejs/spec/bookmarks.js

658 lines
31 KiB
JavaScript
Raw Normal View History

Add experimental support for running the XMPP conneciton inside a shared worker Still lacks inter-tab communication to update state across tabs, i.e. when sending a 1-on-1 message in one tab, it doesn't appear in another, because that information is not available via the websocket connection. - Create a new `Connection` class that extends Strophe.Connection and move related code from `converse-core.js` into this class. - Store the session in localStorage when using a worker - Move XEP-0156 code to connection.js This allows us to initialize the connection without needing to know the domain.
2020-06-03 17:59:41 +02:00
/* global mock, converse */
Use Karma as test runner
2020-04-22 13:11:48 +02:00
Don't throw timeout errors for sent IQ#result or IQ#error stanzas
2020-09-25 13:17:56 +02:00
const Strophe = converse.env.Strophe;
Use Karma as test runner
2020-04-22 13:11:48 +02:00
describe("A chat room", function () {
it("can be bookmarked", mock.initConverse(['rosterGroupsFetched'], {}, async function (done, _converse) {
await mock.waitUntilDiscoConfirmed(
_converse, _converse.bare_jid,
[{'category': 'pubsub', 'type': 'pep'}],
['http://jabber.org/protocol/pubsub#publish-options']
);
const { u, $iq } = converse.env;
let sent_stanza, IQ_id;
const sendIQ = _converse.connection.sendIQ;
spyOn(_converse.connection, 'sendIQ').and.callFake(function (iq, callback, errback) {
sent_stanza = iq;
IQ_id = sendIQ.bind(this)(iq, callback, errback);
});
spyOn(_converse.connection, 'getUniqueId').and.callThrough();
await mock.openChatRoom(_converse, 'theplay', 'conference.shakespeare.lit', 'JC');
Don't throw timeout errors for sent IQ#result or IQ#error stanzas
2020-09-25 13:17:56 +02:00
const jid = 'theplay@conference.shakespeare.lit';
Use Karma as test runner
2020-04-22 13:11:48 +02:00
const view = _converse.chatboxviews.get(jid);
spyOn(view, 'renderBookmarkForm').and.callThrough();
spyOn(view, 'closeForm').and.callThrough();
await u.waitUntil(() => view.el.querySelector('.toggle-bookmark') !== null);
const toggle = view.el.querySelector('.toggle-bookmark');
expect(toggle.title).toBe('Bookmark this groupchat');
toggle.click();
expect(view.renderBookmarkForm).toHaveBeenCalled();
view.el.querySelector('.button-cancel').click();
expect(view.closeForm).toHaveBeenCalled();
expect(u.hasClass('on-button', toggle), false);
expect(toggle.title).toBe('Bookmark this groupchat');
toggle.click();
expect(view.renderBookmarkForm).toHaveBeenCalled();
/* Client uploads data:
* --------------------
* <iq from='juliet@capulet.lit/balcony' type='set' id='pip1'>
* <pubsub xmlns='http://jabber.org/protocol/pubsub'>
* <publish node='storage:bookmarks'>
* <item id='current'>
* <storage xmlns='storage:bookmarks'>
* <conference name='The Play&apos;s the Thing'
* autojoin='true'
* jid='theplay@conference.shakespeare.lit'>
* <nick>JC</nick>
* </conference>
* </storage>
* </item>
* </publish>
* <publish-options>
* <x xmlns='jabber:x:data' type='submit'>
* <field var='FORM_TYPE' type='hidden'>
* <value>http://jabber.org/protocol/pubsub#publish-options</value>
* </field>
* <field var='pubsub#persist_items'>
* <value>true</value>
* </field>
* <field var='pubsub#access_model'>
* <value>whitelist</value>
* </field>
* </x>
* </publish-options>
* </pubsub>
* </iq>
*/
expect(view.model.get('bookmarked')).toBeFalsy();
const form = view.el.querySelector('.chatroom-form');
form.querySelector('input[name="name"]').value = 'Play&apos;s the Thing';
form.querySelector('input[name="autojoin"]').checked = 'checked';
form.querySelector('input[name="nick"]').value = 'JC';
_converse.connection.IQ_stanzas = [];
view.el.querySelector('.btn-primary').click();
await u.waitUntil(() => sent_stanza);
Don't throw timeout errors for sent IQ#result or IQ#error stanzas
2020-09-25 13:17:56 +02:00
expect(Strophe.serialize(sent_stanza)).toBe(
Use Karma as test runner
2020-04-22 13:11:48 +02:00
`<iq from="romeo@montague.lit/orchard" id="${IQ_id}" type="set" xmlns="jabber:client">`+
`<pubsub xmlns="http://jabber.org/protocol/pubsub">`+
`<publish node="storage:bookmarks">`+
`<item id="current">`+
`<storage xmlns="storage:bookmarks">`+
`<conference autojoin="true" jid="theplay@conference.shakespeare.lit" name="Play&amp;apos;s the Thing">`+
`<nick>JC</nick>`+
`</conference>`+
`</storage>`+
`</item>`+
`</publish>`+
`<publish-options>`+
`<x type="submit" xmlns="jabber:x:data">`+
`<field type="hidden" var="FORM_TYPE">`+
`<value>http://jabber.org/protocol/pubsub#publish-options</value>`+
`</field>`+
`<field var="pubsub#persist_items">`+
`<value>true</value>`+
`</field>`+
`<field var="pubsub#access_model">`+
`<value>whitelist</value>`+
`</field>`+
`</x>`+
`</publish-options>`+
`</pubsub>`+
`</iq>`
);
/* Server acknowledges successful storage
*
* <iq to='juliet@capulet.lit/balcony' type='result' id='pip1'/>
*/
const stanza = $iq({
'to':_converse.connection.jid,
'type':'result',
'id':IQ_id
});
_converse.connection._dataRecv(mock.createRequest(stanza));
await u.waitUntil(() => view.model.get('bookmarked'));
expect(view.model.get('bookmarked')).toBeTruthy();
await u.waitUntil(() => view.el.querySelector('.toggle-bookmark')?.title === 'Unbookmark this groupchat');
expect(u.hasClass('on-button', view.el.querySelector('.toggle-bookmark')), true);
// We ignore this IQ stanza... (unless it's an error stanza), so
// nothing to test for here.
done();
}));
it("will be automatically opened if 'autojoin' is set on the bookmark", mock.initConverse(
['rosterGroupsFetched'], {},
async function (done, _converse) {
const { u, _ } = converse.env;
await mock.waitUntilDiscoConfirmed(
_converse, _converse.bare_jid,
[{'category': 'pubsub', 'type': 'pep'}],
['http://jabber.org/protocol/pubsub#publish-options']
);
await u.waitUntil(() => _converse.bookmarks);
let jid = 'lounge@montague.lit';
_converse.bookmarks.create({
'jid': jid,
'autojoin': false,
'name': 'The Lounge',
'nick': ' Othello'
});
expect(_converse.chatboxviews.get(jid) === undefined).toBeTruthy();
jid = 'theplay@conference.shakespeare.lit';
_converse.bookmarks.create({
'jid': jid,
'autojoin': true,
'name': 'The Play',
'nick': ' Othello'
});
await new Promise(resolve => _converse.api.listen.once('chatRoomViewInitialized', resolve));
expect(_.isUndefined(_converse.chatboxviews.get(jid))).toBeFalsy();
// Check that we don't auto-join if muc_respect_autojoin is false
_converse.muc_respect_autojoin = false;
jid = 'balcony@conference.shakespeare.lit';
_converse.bookmarks.create({
'jid': jid,
'autojoin': true,
'name': 'Balcony',
'nick': ' Othello'
});
expect(_converse.chatboxviews.get(jid) === undefined).toBe(true);
done();
}));
Initial work on adding chatroom bookmarks.
2016-06-27 23:50:38 +02:00
Use utility method in tests
2019-10-11 23:33:30 +02:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
describe("when bookmarked", function () {
it("will use the nickname from the bookmark", mock.initConverse(
['rosterGroupsFetched'], {}, async function (done, _converse) {
const { u } = converse.env;
await mock.waitUntilBookmarksReturned(_converse);
const muc_jid = 'coven@chat.shakespeare.lit';
_converse.bookmarks.create({
'jid': muc_jid,
'autojoin': false,
'name': 'The Play',
'nick': 'Othello'
});
spyOn(_converse.ChatRoom.prototype, 'getAndPersistNickname').and.callThrough();
const room_creation_promise = _converse.api.rooms.open(muc_jid);
await mock.getRoomFeatures(_converse, muc_jid);
const room = await room_creation_promise;
await u.waitUntil(() => room.getAndPersistNickname.calls.count());
expect(room.get('nick')).toBe('Othello');
done();
}));
Initial work on adding chatroom bookmarks.
2016-06-27 23:50:38 +02:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
it("displays that it's bookmarked through its bookmark icon", mock.initConverse(
['rosterGroupsFetched'], {},
async function (done, _converse) {
Add test to check that #1577 is resolved
2019-05-21 12:05:47 +02:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
const { u } = converse.env;
mock.waitUntilDiscoConfirmed(
Don't allow PEP bookmarks if #publish-options is not advertised
2018-02-08 09:49:05 +01:00
_converse, _converse.bare_jid,
[{'category': 'pubsub', 'type': 'pep'}],
['http://jabber.org/protocol/pubsub#publish-options']
Use async/await in tests
2018-11-22 12:15:35 +01:00
);
Use Karma as test runner
2020-04-22 13:11:48 +02:00
await _converse.api.rooms.open(`lounge@montague.lit`);
const view = _converse.chatboxviews.get('lounge@montague.lit');
expect(view.el.querySelector('.chatbox-title__text .fa-bookmark')).toBe(null);
_converse.bookmarks.create({
'jid': view.model.get('jid'),
'autojoin': false,
'name': 'The lounge',
'nick': ' some1'
});
view.model.set('bookmarked', true);
await u.waitUntil(() => view.el.querySelector('.chatbox-title__text .fa-bookmark') !== null);
view.model.set('bookmarked', false);
await u.waitUntil(() => view.el.querySelector('.chatbox-title__text .fa-bookmark') === null);
done();
}));
it("can be unbookmarked", mock.initConverse(
['rosterGroupsFetched'], {}, async function (done, _converse) {
const { u, Strophe } = converse.env;
await mock.waitUntilBookmarksReturned(_converse);
const muc_jid = 'theplay@conference.shakespeare.lit';
await _converse.api.rooms.open(muc_jid);
const view = _converse.chatboxviews.get(muc_jid);
await u.waitUntil(() => view.el.querySelector('.toggle-bookmark'));
spyOn(view, 'toggleBookmark').and.callThrough();
spyOn(_converse.bookmarks, 'sendBookmarkStanza').and.callThrough();
view.delegateEvents();
_converse.bookmarks.create({
'jid': view.model.get('jid'),
'autojoin': false,
'name': 'The Play',
'nick': ' Othello'
Don't allow PEP bookmarks if #publish-options is not advertised
2018-02-08 09:49:05 +01:00
});
Use async/await in tests
2018-11-22 12:15:35 +01:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
expect(_converse.bookmarks.length).toBe(1);
await u.waitUntil(() => _converse.chatboxes.length >= 1);
expect(view.model.get('bookmarked')).toBeTruthy();
await u.waitUntil(() => view.el.querySelector('.chatbox-title__text .fa-bookmark') !== null);
spyOn(_converse.connection, 'getUniqueId').and.callThrough();
const bookmark_icon = view.el.querySelector('.toggle-bookmark');
bookmark_icon.click();
expect(view.toggleBookmark).toHaveBeenCalled();
await u.waitUntil(() => view.el.querySelector('.chatbox-title__text .fa-bookmark') === null);
expect(_converse.bookmarks.length).toBe(0);
// Check that an IQ stanza is sent out, containing no
// conferences to bookmark (since we removed the one and
// only bookmark).
const sent_stanza = _converse.connection.IQ_stanzas.pop();
expect(Strophe.serialize(sent_stanza)).toBe(
`<iq from="romeo@montague.lit/orchard" id="${sent_stanza.getAttribute('id')}" type="set" xmlns="jabber:client">`+
Use async/await in tests
2018-11-22 12:15:35 +01:00
`<pubsub xmlns="http://jabber.org/protocol/pubsub">`+
`<publish node="storage:bookmarks">`+
`<item id="current">`+
Use Karma as test runner
2020-04-22 13:11:48 +02:00
`<storage xmlns="storage:bookmarks"/>`+
Use async/await in tests
2018-11-22 12:15:35 +01:00
`</item>`+
`</publish>`+
`<publish-options>`+
`<x type="submit" xmlns="jabber:x:data">`+
`<field type="hidden" var="FORM_TYPE">`+
`<value>http://jabber.org/protocol/pubsub#publish-options</value>`+
`</field>`+
`<field var="pubsub#persist_items">`+
`<value>true</value>`+
`</field>`+
`<field var="pubsub#access_model">`+
`<value>whitelist</value>`+
`</field>`+
`</x>`+
`</publish-options>`+
`</pubsub>`+
`</iq>`
);
done();
Don't allow PEP bookmarks if #publish-options is not advertised
2018-02-08 09:49:05 +01:00
}));
Use Karma as test runner
2020-04-22 13:11:48 +02:00
});
Check bookmarks for nicks when joining rooms
2016-09-23 09:41:55 +02:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
describe("and when autojoin is set", function () {
Use async/await in tests
2018-11-22 12:15:35 +01:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
it("will be be opened and joined automatically upon login", mock.initConverse(
['rosterGroupsFetched'], {},
async function (done, _converse) {
Check bookmarks for nicks when joining rooms
2016-09-23 09:41:55 +02:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
await mock.waitUntilBookmarksReturned(_converse);
spyOn(_converse.api.rooms, 'create').and.callThrough();
const jid = 'theplay@conference.shakespeare.lit';
const model = _converse.bookmarks.create({
Use async/await in tests
2018-11-22 12:15:35 +01:00
'jid': jid,
'autojoin': false,
'name': 'The Play',
Use Karma as test runner
2020-04-22 13:11:48 +02:00
'nick': ''
Don't allow PEP bookmarks if #publish-options is not advertised
2018-02-08 09:49:05 +01:00
});
Use Karma as test runner
2020-04-22 13:11:48 +02:00
expect(_converse.api.rooms.create).not.toHaveBeenCalled();
_converse.bookmarks.remove(model);
Add test for muc_respect_autojoin
2019-03-27 08:34:36 +01:00
_converse.bookmarks.create({
'jid': jid,
'autojoin': true,
Use Karma as test runner
2020-04-22 13:11:48 +02:00
'name': 'Hamlet',
'nick': ''
Add test for muc_respect_autojoin
2019-03-27 08:34:36 +01:00
});
Use Karma as test runner
2020-04-22 13:11:48 +02:00
expect(_converse.api.rooms.create).toHaveBeenCalled();
Use async/await in tests
2018-11-22 12:15:35 +01:00
done();
Don't allow PEP bookmarks if #publish-options is not advertised
2018-02-08 09:49:05 +01:00
}));
Initial work on adding chatroom bookmarks.
2016-06-27 23:50:38 +02:00
});
Use Karma as test runner
2020-04-22 13:11:48 +02:00
});
describe("Bookmarks", function () {
it("can be pushed from the XMPP server", mock.initConverse(
Fixes #2302 Bookmarks get duplicated on server push
2020-10-23 16:06:05 +02:00
['connected', 'rosterGroupsFetched', 'chatBoxesFetched'], {}, async function (done, _converse) {
Use Karma as test runner
2020-04-22 13:11:48 +02:00
const { $msg, u } = converse.env;
await mock.waitUntilBookmarksReturned(_converse);
/* The stored data is automatically pushed to all of the user's
Fixes #2302 Bookmarks get duplicated on server push
2020-10-23 16:06:05 +02:00
* connected resources.
*
* Publisher receives event notification
* -------------------------------------
* <message from='juliet@capulet.lit'
* to='juliet@capulet.lit/balcony'
* type='headline'
* id='rnfoo1'>
* <event xmlns='http://jabber.org/protocol/pubsub#event'>
* <items node='storage:bookmarks'>
* <item id='current'>
* <storage xmlns='storage:bookmarks'>
* <conference name='The Play&apos;s the Thing'
* autojoin='true'
* jid='theplay@conference.shakespeare.lit'>
* <nick>JC</nick>
* </conference>
* </storage>
* </item>
* </items>
* </event>
* </message>
*/
let stanza = $msg({
Use Karma as test runner
2020-04-22 13:11:48 +02:00
'from': 'romeo@montague.lit',
Fixes #2302 Bookmarks get duplicated on server push
2020-10-23 16:06:05 +02:00
'to': _converse.jid,
Use Karma as test runner
2020-04-22 13:11:48 +02:00
'type': 'headline',
Fixes #2302 Bookmarks get duplicated on server push
2020-10-23 16:06:05 +02:00
'id': u.getUniqueId()
Use Karma as test runner
2020-04-22 13:11:48 +02:00
}).c('event', {'xmlns': 'http://jabber.org/protocol/pubsub#event'})
.c('items', {'node': 'storage:bookmarks'})
.c('item', {'id': 'current'})
.c('storage', {'xmlns': 'storage:bookmarks'})
Fixes #2302 Bookmarks get duplicated on server push
2020-10-23 16:06:05 +02:00
.c('conference', {
'name': 'The Play&apos;s the Thing',
'autojoin': 'true',
'jid':'theplay@conference.shakespeare.lit'
}).c('nick').t('JC').up().up()
.c('conference', {
'name': 'Another bookmark',
'autojoin': 'false',
'jid':'another@conference.shakespeare.lit'
}).c('nick').t('JC');
Use Karma as test runner
2020-04-22 13:11:48 +02:00
_converse.connection._dataRecv(mock.createRequest(stanza));
await u.waitUntil(() => _converse.bookmarks.length);
Fixes #2302 Bookmarks get duplicated on server push
2020-10-23 16:06:05 +02:00
expect(_converse.bookmarks.length).toBe(2);
expect(_converse.bookmarks.map(b => b.get('name'))).toEqual(['Another bookmark', 'The Play&apos;s the Thing']);
expect(_converse.chatboxviews.get('theplay@conference.shakespeare.lit')).not.toBeUndefined();
stanza = $msg({
'from': 'romeo@montague.lit',
'to': _converse.jid,
'type': 'headline',
'id': u.getUniqueId()
}).c('event', {'xmlns': 'http://jabber.org/protocol/pubsub#event'})
.c('items', {'node': 'storage:bookmarks'})
.c('item', {'id': 'current'})
.c('storage', {'xmlns': 'storage:bookmarks'})
.c('conference', {
'name': 'The Play&apos;s the Thing',
'autojoin': 'true',
'jid':'theplay@conference.shakespeare.lit'
}).c('nick').t('JC').up().up()
.c('conference', {
'name': 'Second bookmark',
'autojoin': 'false',
'jid':'another@conference.shakespeare.lit'
}).c('nick').t('JC').up().up()
.c('conference', {
'name': 'Yet another bookmark',
'autojoin': 'false',
'jid':'yab@conference.shakespeare.lit'
}).c('nick').t('JC');
_converse.connection._dataRecv(mock.createRequest(stanza));
await u.waitUntil(() => _converse.bookmarks.length === 3);
expect(_converse.bookmarks.map(b => b.get('name'))).toEqual(['Second bookmark', 'The Play&apos;s the Thing', 'Yet another bookmark']);
Use Karma as test runner
2020-04-22 13:11:48 +02:00
expect(_converse.chatboxviews.get('theplay@conference.shakespeare.lit')).not.toBeUndefined();
Fixes #2302 Bookmarks get duplicated on server push
2020-10-23 16:06:05 +02:00
expect(Object.keys(_converse.chatboxviews.getAll()).length).toBe(2);
Use Karma as test runner
2020-04-22 13:11:48 +02:00
done();
}));
it("can be retrieved from the XMPP server", mock.initConverse(
['chatBoxesFetched', 'roomsPanelRendered', 'rosterGroupsFetched'], {},
async function (done, _converse) {
Initial work on adding chatroom bookmarks.
2016-06-27 23:50:38 +02:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
const { Strophe, sizzle, u, $iq } = converse.env;
await mock.waitUntilDiscoConfirmed(
_converse, _converse.bare_jid,
[{'category': 'pubsub', 'type': 'pep'}],
['http://jabber.org/protocol/pubsub#publish-options']
);
/* Client requests all items
* -------------------------
*
* <iq from='juliet@capulet.lit/randomID' type='get' id='retrieve1'>
* <pubsub xmlns='http://jabber.org/protocol/pubsub'>
* <items node='storage:bookmarks'/>
* </pubsub>
* </iq>
*/
const IQ_stanzas = _converse.connection.IQ_stanzas;
const sent_stanza = await u.waitUntil(
() => IQ_stanzas.filter(s => sizzle('items[node="storage:bookmarks"]', s).length).pop());
expect(Strophe.serialize(sent_stanza)).toBe(
`<iq from="romeo@montague.lit/orchard" id="${sent_stanza.getAttribute('id')}" type="get" xmlns="jabber:client">`+
'<pubsub xmlns="http://jabber.org/protocol/pubsub">'+
'<items node="storage:bookmarks"/>'+
'</pubsub>'+
'</iq>');
/*
* Server returns all items
* ------------------------
* <iq type='result'
* to='juliet@capulet.lit/randomID'
* id='retrieve1'>
* <pubsub xmlns='http://jabber.org/protocol/pubsub'>
* <items node='storage:bookmarks'>
* <item id='current'>
* <storage xmlns='storage:bookmarks'>
* <conference name='The Play&apos;s the Thing'
* autojoin='true'
* jid='theplay@conference.shakespeare.lit'>
* <nick>JC</nick>
* </conference>
* </storage>
* </item>
* </items>
* </pubsub>
* </iq>
*/
expect(_converse.bookmarks.models.length).toBe(0);
spyOn(_converse.bookmarks, 'onBookmarksReceived').and.callThrough();
var stanza = $iq({'to': _converse.connection.jid, 'type':'result', 'id':sent_stanza.getAttribute('id')})
.c('pubsub', {'xmlns': Strophe.NS.PUBSUB})
Use async/await in tests
2018-11-22 12:15:35 +01:00
.c('items', {'node': 'storage:bookmarks'})
.c('item', {'id': 'current'})
.c('storage', {'xmlns': 'storage:bookmarks'})
Use Karma as test runner
2020-04-22 13:11:48 +02:00
.c('conference', {
'name': 'The Play&apos;s the Thing',
'autojoin': 'true',
'jid': 'theplay@conference.shakespeare.lit'
}).c('nick').t('JC').up().up()
.c('conference', {
'name': 'Another room',
'autojoin': 'false',
'jid': 'another@conference.shakespeare.lit'
}); // Purposefully exclude the <nick> element to test #1043
_converse.connection._dataRecv(mock.createRequest(stanza));
await u.waitUntil(() => _converse.bookmarks.onBookmarksReceived.calls.count());
await _converse.api.waitUntil('bookmarksInitialized');
expect(_converse.bookmarks.models.length).toBe(2);
expect(_converse.bookmarks.findWhere({'jid': 'theplay@conference.shakespeare.lit'}).get('autojoin')).toBe(true);
expect(_converse.bookmarks.findWhere({'jid': 'another@conference.shakespeare.lit'}).get('autojoin')).toBe(false);
done();
}));
describe("The rooms panel", function () {
it("shows a list of bookmarks", mock.initConverse(
['rosterGroupsFetched'], {},
async function (done, _converse) {
Fix broken tests due to using ES2015 promises
2017-07-11 10:41:11 +02:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
await mock.waitUntilDiscoConfirmed(
Don't allow PEP bookmarks if #publish-options is not advertised
2018-02-08 09:49:05 +01:00
_converse, _converse.bare_jid,
[{'category': 'pubsub', 'type': 'pep'}],
['http://jabber.org/protocol/pubsub#publish-options']
Fix failing tests and rewrite to use async/await
2018-10-26 10:15:01 +02:00
);
Use Karma as test runner
2020-04-22 13:11:48 +02:00
mock.openControlBox(_converse);
const { Strophe, u, sizzle, $iq } = converse.env;
Fixes #129 Add support for XEP-0156. Only XML is supported for now.
2018-11-18 19:14:22 +01:00
const IQ_stanzas = _converse.connection.IQ_stanzas;
const sent_stanza = await u.waitUntil(
() => IQ_stanzas.filter(s => sizzle('items[node="storage:bookmarks"]', s).length).pop());
Fix failing tests and rewrite to use async/await
2018-10-26 10:15:01 +02:00
Fixes #129 Add support for XEP-0156. Only XML is supported for now.
2018-11-18 19:14:22 +01:00
expect(Strophe.serialize(sent_stanza)).toBe(
`<iq from="romeo@montague.lit/orchard" id="${sent_stanza.getAttribute('id')}" type="get" xmlns="jabber:client">`+
Fix failing tests and rewrite to use async/await
2018-10-26 10:15:01 +02:00
'<pubsub xmlns="http://jabber.org/protocol/pubsub">'+
'<items node="storage:bookmarks"/>'+
'</pubsub>'+
Use Karma as test runner
2020-04-22 13:11:48 +02:00
'</iq>'
);
const stanza = $iq({'to': _converse.connection.jid, 'type':'result', 'id':sent_stanza.getAttribute('id')})
Fix failing tests and rewrite to use async/await
2018-10-26 10:15:01 +02:00
.c('pubsub', {'xmlns': Strophe.NS.PUBSUB})
.c('items', {'node': 'storage:bookmarks'})
.c('item', {'id': 'current'})
.c('storage', {'xmlns': 'storage:bookmarks'})
.c('conference', {
'name': 'The Play&apos;s the Thing',
Use Karma as test runner
2020-04-22 13:11:48 +02:00
'autojoin': 'false',
Fix failing tests and rewrite to use async/await
2018-10-26 10:15:01 +02:00
'jid': 'theplay@conference.shakespeare.lit'
}).c('nick').t('JC').up().up()
Use Karma as test runner
2020-04-22 13:11:48 +02:00
.c('conference', {
'name': '1st Bookmark',
'autojoin': 'false',
'jid': 'first@conference.shakespeare.lit'
}).c('nick').t('JC').up().up()
.c('conference', {
'autojoin': 'false',
'jid': 'noname@conference.shakespeare.lit'
}).c('nick').t('JC').up().up()
.c('conference', {
'name': 'Bookmark with a very very long name that will be shortened',
'autojoin': 'false',
'jid': 'longname@conference.shakespeare.lit'
}).c('nick').t('JC').up().up()
Fix failing tests and rewrite to use async/await
2018-10-26 10:15:01 +02:00
.c('conference', {
'name': 'Another room',
'autojoin': 'false',
'jid': 'another@conference.shakespeare.lit'
Use Karma as test runner
2020-04-22 13:11:48 +02:00
}).c('nick').t('JC').up().up();
_converse.connection._dataRecv(mock.createRequest(stanza));
await u.waitUntil(() => document.querySelectorAll('#chatrooms div.bookmarks.rooms-list .room-item').length);
expect(document.querySelectorAll('#chatrooms div.bookmarks.rooms-list .room-item').length).toBe(5);
let els = document.querySelectorAll('#chatrooms div.bookmarks.rooms-list .room-item a.list-item-link');
expect(els[0].textContent).toBe("1st Bookmark");
expect(els[1].textContent).toBe("Another room");
expect(els[2].textContent).toBe("Bookmark with a very very long name that will be shortened");
expect(els[3].textContent).toBe("noname@conference.shakespeare.lit");
expect(els[4].textContent).toBe("The Play's the Thing");
spyOn(window, 'confirm').and.returnValue(true);
document.querySelector('#chatrooms .bookmarks.rooms-list .room-item:nth-child(2) a:nth-child(2)').click();
expect(window.confirm).toHaveBeenCalled();
await u.waitUntil(() => document.querySelectorAll('#chatrooms div.bookmarks.rooms-list .room-item').length === 4)
els = document.querySelectorAll('#chatrooms div.bookmarks.rooms-list .room-item a.list-item-link');
expect(els[0].textContent).toBe("1st Bookmark");
expect(els[1].textContent).toBe("Bookmark with a very very long name that will be shortened");
expect(els[2].textContent).toBe("noname@conference.shakespeare.lit");
expect(els[3].textContent).toBe("The Play's the Thing");
Fix failing tests and rewrite to use async/await
2018-10-26 10:15:01 +02:00
done();
}));
Test the `hide_open_bookmarks` setting.
2017-05-23 14:59:37 +02:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
it("remembers the toggle state of the bookmarks list", mock.initConverse(
['rosterGroupsFetched'], {}, async function (done, _converse) {
Test the `hide_open_bookmarks` setting.
2017-05-23 14:59:37 +02:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
await mock.openControlBox(_converse);
await mock.waitUntilDiscoConfirmed(
_converse, _converse.bare_jid,
[{'category': 'pubsub', 'type': 'pep'}],
['http://jabber.org/protocol/pubsub#publish-options']
);
Test the `hide_open_bookmarks` setting.
2017-05-23 14:59:37 +02:00
Use Karma as test runner
2020-04-22 13:11:48 +02:00
const { Strophe, u, sizzle, $iq } = converse.env;
const IQ_stanzas = _converse.connection.IQ_stanzas;
const sent_stanza = await u.waitUntil(
() => IQ_stanzas.filter(s => sizzle('iq items[node="storage:bookmarks"]', s).length).pop());
expect(Strophe.serialize(sent_stanza)).toBe(
`<iq from="romeo@montague.lit/orchard" id="${sent_stanza.getAttribute('id')}" type="get" xmlns="jabber:client">`+
'<pubsub xmlns="http://jabber.org/protocol/pubsub">'+
'<items node="storage:bookmarks"/>'+
'</pubsub>'+
'</iq>'
);
const stanza = $iq({'to': _converse.connection.jid, 'type':'result', 'id': sent_stanza.getAttribute('id')})
.c('pubsub', {'xmlns': Strophe.NS.PUBSUB})
.c('items', {'node': 'storage:bookmarks'})
.c('item', {'id': 'current'})
.c('storage', {'xmlns': 'storage:bookmarks'});
_converse.connection._dataRecv(mock.createRequest(stanza));
await _converse.api.waitUntil('bookmarksInitialized');
Use async/await in tests
2018-11-22 12:15:35 +01:00
_converse.bookmarks.create({
Use Karma as test runner
2020-04-22 13:11:48 +02:00
'jid': 'theplay@conference.shakespeare.lit',
Use async/await in tests
2018-11-22 12:15:35 +01:00
'autojoin': false,
'name': 'The Play',
Use Karma as test runner
2020-04-22 13:11:48 +02:00
'nick': ''
Only initialize bookmarks and show icon if PEP is supported which we check by checking if the PEP identity is provided. https://xmpp.org/extensions/xep-0163.html#support
2018-02-07 17:30:44 +01:00
});
Use Karma as test runner
2020-04-22 13:11:48 +02:00
const el = _converse.chatboxviews.el
const selector = '#chatrooms .bookmarks.rooms-list .room-item';
await u.waitUntil(() => sizzle(selector, el).filter(u.isVisible).length);
expect(u.hasClass('collapsed', sizzle('#chatrooms .bookmarks.rooms-list', el).pop())).toBeFalsy();
expect(sizzle(selector, el).filter(u.isVisible).length).toBe(1);
expect(_converse.bookmarksview.list_model.get('toggle-state')).toBe(_converse.OPENED);
sizzle('#chatrooms .bookmarks-toggle', el).pop().click();
expect(u.hasClass('collapsed', sizzle('#chatrooms .bookmarks.rooms-list', el).pop())).toBeTruthy();
expect(_converse.bookmarksview.list_model.get('toggle-state')).toBe(_converse.CLOSED);
sizzle('#chatrooms .bookmarks-toggle', el).pop().click();
expect(u.hasClass('collapsed', sizzle('#chatrooms .bookmarks.rooms-list', el).pop())).toBeFalsy();
expect(sizzle(selector, el).filter(u.isVisible).length).toBe(1);
expect(_converse.bookmarksview.list_model.get('toggle-state')).toBe(_converse.OPENED);
Use async/await in tests
2018-11-22 12:15:35 +01:00
done();
Test the `hide_open_bookmarks` setting.
2017-05-23 14:59:37 +02:00
}));
});
Remove the need for require.js to run tests
2020-04-22 12:10:39 +02:00
});
Use Karma as test runner
2020-04-22 13:11:48 +02:00
describe("When hide_open_bookmarks is true and a bookmarked room is opened", function () {
it("can be closed", mock.initConverse(
['rosterGroupsFetched'],
{ hide_open_bookmarks: true },
async function (done, _converse) {
await mock.openControlBox(_converse);
await mock.waitUntilBookmarksReturned(_converse);
// Check that it's there
const jid = 'room@conference.example.org';
_converse.bookmarks.create({
'jid': jid,
'autojoin': false,
'name': 'The Play',
'nick': ' Othello'
});
expect(_converse.bookmarks.length).toBe(1);
const u = converse.env.utils;
const bmarks_view = _converse.bookmarksview;
await u.waitUntil(() => bmarks_view.el.querySelectorAll(".open-room").length, 500);
const room_els = bmarks_view.el.querySelectorAll(".open-room");
expect(room_els.length).toBe(1);
const bookmark = _converse.bookmarksview.el.querySelector(".open-room");
bookmark.click();
await u.waitUntil(() => _converse.chatboxviews.get(jid));
expect(u.hasClass('hidden', _converse.bookmarksview.el.querySelector(".available-chatroom"))).toBeTruthy();
// Check that it reappears once the room is closed
const view = _converse.chatboxviews.get(jid);
view.close();
await u.waitUntil(() => !u.hasClass('hidden', _converse.bookmarksview.el.querySelector(".available-chatroom")));
done();
}));
});
Reference in New Issue Copy Permalink