Chapril/xmpp.chapril.org-conversejs
Chapril/xmpp.chapril.org-conversejs
25
0
Fork 0
Code Issues Pull Requests Projects Releases Activity
67bcc00f10
xmpp.chapril.org-conversejs/spec/messages.js

3092 lines
172 KiB
JavaScript
Raw Normal View History

Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
(function (root, factory) {
define([
"jasmine",
"mock",
"test-utils"
], factory);
Remove jquery from spec/messages.js
2019-03-27 09:33:15 +01:00
} (this, function (jasmine, mock, test_utils) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
"use strict";
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
const { Backbone, Promise, Strophe, $iq, $msg, $pres, b64_sha1, dayjs, sizzle, _ } = converse.env;
Add test for receiving message corrections
2018-07-06 00:43:47 +02:00
const u = converse.env.utils;
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
describe("A Chat Message", function () {
Allow messages to be edited by clicking a pencil icon updates #421
2018-07-21 10:41:10 +02:00
it("can be sent as a correction by clicking the pencil icon",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Allow messages to be edited by clicking a pencil icon updates #421
2018-07-21 10:41:10 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Allow messages to be edited by clicking a pencil icon updates #421
2018-07-21 10:41:10 +02:00
test_utils.openControlBox();
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, contact_jid);
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(contact_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const textarea = view.el.querySelector('textarea.chat-textarea');
textarea.value = 'But soft, what light through yonder airlock breaks?';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelector('.chat-msg__text').textContent)
.toBe('But soft, what light through yonder airlock breaks?');
expect(textarea.value).toBe('');
const first_msg = view.model.messages.findWhere({'message': 'But soft, what light through yonder airlock breaks?'});
expect(view.el.querySelectorAll('.chat-msg .chat-msg__action').length).toBe(1);
let action = view.el.querySelector('.chat-msg .chat-msg__action');
expect(action.getAttribute('title')).toBe('Edit this message');
action.style.opacity = 1;
action.click();
expect(textarea.value).toBe('But soft, what light through yonder airlock breaks?');
expect(view.model.messages.at(0).get('correcting')).toBe(true);
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
await new Promise((resolve, reject) => view.model.messages.once('rendered', resolve));
expect(u.hasClass('correcting', view.el.querySelector('.chat-msg'))).toBe(true);
spyOn(_converse.connection, 'send');
textarea.value = 'But soft, what light through yonder window breaks?';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
Allow messages to be edited by clicking a pencil icon updates #421
2018-07-21 10:41:10 +02:00
});
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(_converse.connection.send).toHaveBeenCalled();
await new Promise((resolve, reject) => view.model.messages.once('rendered', resolve));
const msg = _converse.connection.send.calls.all()[0].args[0];
expect(msg.toLocaleString())
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.toBe(`<message from="romeo@montague.lit/orchard" id="${msg.nodeTree.getAttribute("id")}" `+
`to="mercutio@montague.lit" type="chat" `+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`xmlns="jabber:client">`+
`<body>But soft, what light through yonder window breaks?</body>`+
`<active xmlns="http://jabber.org/protocol/chatstates"/>`+
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
`<request xmlns="urn:xmpp:receipts"/>`+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`<replace id="${first_msg.get("msgid")}" xmlns="urn:xmpp:message-correct:0"/>`+
Include `origin-id` in outgoing messages
2019-02-07 14:15:49 +01:00
`<origin-id id="${msg.nodeTree.querySelector('origin-id').getAttribute("id")}" xmlns="urn:xmpp:sid:0"/>`+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`</message>`);
expect(view.model.messages.models.length).toBe(1);
const corrected_message = view.model.messages.at(0);
expect(corrected_message.get('msgid')).toBe(first_msg.get('msgid'));
expect(corrected_message.get('correcting')).toBe(false);
Refactor message corrections - Save date for older message versions and display it in the modal - Properly handle the correction being received *before* the corrected message
2019-05-21 16:18:14 +02:00
const older_versions = corrected_message.get('older_versions');
const keys = Object.keys(older_versions);
expect(keys.length).toBe(1);
expect(older_versions[keys[0]]).toBe('But soft, what light through yonder airlock breaks?');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(u.hasClass('correcting', view.el.querySelector('.chat-msg'))).toBe(false);
// Test that clicking the pencil icon a second time cancels editing.
action = view.el.querySelector('.chat-msg .chat-msg__action');
action.style.opacity = 1;
action.click();
await new Promise((resolve, reject) => view.model.messages.once('rendered', resolve));
expect(textarea.value).toBe('But soft, what light through yonder window breaks?');
expect(view.model.messages.at(0).get('correcting')).toBe(true);
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
await test_utils.waitUntil(() => u.hasClass('correcting', view.el.querySelector('.chat-msg')) === true);
action = view.el.querySelector('.chat-msg .chat-msg__action');
action.style.opacity = 1;
action.click();
expect(textarea.value).toBe('');
expect(view.model.messages.at(0).get('correcting')).toBe(false);
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
Prioritize roster nickname as message and chatbox display name Set reference to roster contact on the message and chatbox object and listen for changes to the nickname. Currently, because chat boxes are fetched and initialized before the roster, messages and chats are repainted with the correct display name only later, causing a "flash" effect. Ideally we would only initialize the chat boxes after the roster contacts have been fetched, but this is currently not easily possible because we need the control box to render before everything else.
2019-04-09 17:10:50 +02:00
await test_utils.waitUntil(() => (u.hasClass('correcting', view.el.querySelector('.chat-msg')) === false), 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// Test that messages from other users don't have the pencil icon
_converse.chatboxes.onMessage(
$msg({
'from': contact_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': (new Date()).getTime()
}).c('body').t('Hello').up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree()
);
Fixes #1142. Show confirmation dialog for editing messages when the textarea contains an unsent message
2019-06-19 08:03:36 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(view.el.querySelectorAll('.chat-msg .chat-msg__action').length).toBe(1);
Fixes #1142. Show confirmation dialog for editing messages when the textarea contains an unsent message
2019-06-19 08:03:36 +02:00
// Test confirmation dialog
spyOn(window, 'confirm').and.returnValue(true);
textarea.value = 'But soft, what light through yonder airlock breaks?';
action = view.el.querySelector('.chat-msg .chat-msg__action');
action.style.opacity = 1;
action.click();
expect(window.confirm).toHaveBeenCalledWith(
'You have an unsent message which will be lost if you continue. Are you sure?');
expect(view.model.messages.at(0).get('correcting')).toBe(true);
expect(textarea.value).toBe('But soft, what light through yonder window breaks?');
textarea.value = 'But soft, what light through yonder airlock breaks?'
action.click();
expect(view.model.messages.at(0).get('correcting')).toBe(false);
expect(window.confirm.calls.count()).toBe(2);
expect(window.confirm.calls.argsFor(0)).toEqual(
['You have an unsent message which will be lost if you continue. Are you sure?']);
expect(window.confirm.calls.argsFor(1)).toEqual(
['You have an unsent message which will be lost if you continue. Are you sure?']);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Allow messages to be edited by clicking a pencil icon updates #421
2018-07-21 10:41:10 +02:00
}));
it("can be sent as a correction by using the up arrow",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Cancel message correction by pressing the down arrow Also, add a class `correcting` to the message being corrected, to provide a visual cue. updates #421
2018-07-08 10:13:15 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Cancel message correction by pressing the down arrow Also, add a class `correcting` to the message being corrected, to provide a visual cue. updates #421
2018-07-08 10:13:15 +02:00
test_utils.openControlBox();
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, contact_jid)
const view = _converse.chatboxviews.get(contact_jid);
const textarea = view.el.querySelector('textarea.chat-textarea');
expect(textarea.value).toBe('');
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
keyCode: 38 // Up arrow
});
expect(textarea.value).toBe('');
Allow any earlier message to be edited. updates #421
2018-07-08 15:20:58 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
textarea.value = 'But soft, what light through yonder airlock breaks?';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelector('.chat-msg__text').textContent)
.toBe('But soft, what light through yonder airlock breaks?');
const first_msg = view.model.messages.findWhere({'message': 'But soft, what light through yonder airlock breaks?'});
expect(textarea.value).toBe('');
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
keyCode: 38 // Up arrow
});
expect(textarea.value).toBe('But soft, what light through yonder airlock breaks?');
expect(view.model.messages.at(0).get('correcting')).toBe(true);
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
Prioritize roster nickname as message and chatbox display name Set reference to roster contact on the message and chatbox object and listen for changes to the nickname. Currently, because chat boxes are fetched and initialized before the roster, messages and chats are repainted with the correct display name only later, causing a "flash" effect. Ideally we would only initialize the chat boxes after the roster contacts have been fetched, but this is currently not easily possible because we need the control box to render before everything else.
2019-04-09 17:10:50 +02:00
await test_utils.waitUntil(() => u.hasClass('correcting', view.el.querySelector('.chat-msg')), 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
spyOn(_converse.connection, 'send');
textarea.value = 'But soft, what light through yonder window breaks?';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
expect(_converse.connection.send).toHaveBeenCalled();
await new Promise((resolve, reject) => view.model.messages.once('rendered', resolve));
const msg = _converse.connection.send.calls.all()[0].args[0];
expect(msg.toLocaleString())
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.toBe(`<message from="romeo@montague.lit/orchard" id="${msg.nodeTree.getAttribute("id")}" `+
`to="mercutio@montague.lit" type="chat" `+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`xmlns="jabber:client">`+
`<body>But soft, what light through yonder window breaks?</body>`+
`<active xmlns="http://jabber.org/protocol/chatstates"/>`+
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
`<request xmlns="urn:xmpp:receipts"/>`+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`<replace id="${first_msg.get("msgid")}" xmlns="urn:xmpp:message-correct:0"/>`+
Include `origin-id` in outgoing messages
2019-02-07 14:15:49 +01:00
`<origin-id id="${msg.nodeTree.querySelector('origin-id').getAttribute("id")}" xmlns="urn:xmpp:sid:0"/>`+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`</message>`);
expect(view.model.messages.models.length).toBe(1);
const corrected_message = view.model.messages.at(0);
expect(corrected_message.get('msgid')).toBe(first_msg.get('msgid'));
expect(corrected_message.get('correcting')).toBe(false);
Refactor message corrections - Save date for older message versions and display it in the modal - Properly handle the correction being received *before* the corrected message
2019-05-21 16:18:14 +02:00
const older_versions = corrected_message.get('older_versions');
const keys = Object.keys(older_versions);
expect(keys.length).toBe(1);
expect(older_versions[keys[0]]).toBe('But soft, what light through yonder airlock breaks?');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
Prioritize roster nickname as message and chatbox display name Set reference to roster contact on the message and chatbox object and listen for changes to the nickname. Currently, because chat boxes are fetched and initialized before the roster, messages and chats are repainted with the correct display name only later, causing a "flash" effect. Ideally we would only initialize the chat boxes after the roster contacts have been fetched, but this is currently not easily possible because we need the control box to render before everything else.
2019-04-09 17:10:50 +02:00
await test_utils.waitUntil(() => (u.hasClass('correcting', view.el.querySelector('.chat-msg')) === false), 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// Test that pressing the down arrow cancels message correction
expect(textarea.value).toBe('');
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
keyCode: 38 // Up arrow
});
expect(textarea.value).toBe('But soft, what light through yonder window breaks?');
expect(view.model.messages.at(0).get('correcting')).toBe(true);
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
Prioritize roster nickname as message and chatbox display name Set reference to roster contact on the message and chatbox object and listen for changes to the nickname. Currently, because chat boxes are fetched and initialized before the roster, messages and chats are repainted with the correct display name only later, causing a "flash" effect. Ideally we would only initialize the chat boxes after the roster contacts have been fetched, but this is currently not easily possible because we need the control box to render before everything else.
2019-04-09 17:10:50 +02:00
await test_utils.waitUntil(() => u.hasClass('correcting', view.el.querySelector('.chat-msg')), 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(textarea.value).toBe('But soft, what light through yonder window breaks?');
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
keyCode: 40 // Down arrow
});
expect(textarea.value).toBe('');
expect(view.model.messages.at(0).get('correcting')).toBe(false);
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
Prioritize roster nickname as message and chatbox display name Set reference to roster contact on the message and chatbox object and listen for changes to the nickname. Currently, because chat boxes are fetched and initialized before the roster, messages and chats are repainted with the correct display name only later, causing a "flash" effect. Ideally we would only initialize the chat boxes after the roster contacts have been fetched, but this is currently not easily possible because we need the control box to render before everything else.
2019-04-09 17:10:50 +02:00
await test_utils.waitUntil(() => (u.hasClass('correcting', view.el.querySelector('.chat-msg')) === false), 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
textarea.value = 'It is the east, and Juliet is the one.';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(2);
textarea.value = 'Arise, fair sun, and kill the envious moon';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(3);
Allow any earlier message to be edited. updates #421
2018-07-08 15:20:58 +02:00
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
keyCode: 38 // Up arrow
});
expect(textarea.value).toBe('Arise, fair sun, and kill the envious moon');
expect(view.model.messages.at(0).get('correcting')).toBeFalsy();
expect(view.model.messages.at(1).get('correcting')).toBeFalsy();
expect(view.model.messages.at(2).get('correcting')).toBe(true);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
await test_utils.waitUntil(() => u.hasClass('correcting', sizzle('.chat-msg:last', view.el).pop()), 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
textarea.selectionEnd = 0; // Happens by pressing up,
// but for some reason not in tests, so we set it manually.
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
keyCode: 38 // Up arrow
});
expect(textarea.value).toBe('It is the east, and Juliet is the one.');
expect(view.model.messages.at(0).get('correcting')).toBeFalsy();
expect(view.model.messages.at(1).get('correcting')).toBe(true);
expect(view.model.messages.at(2).get('correcting')).toBeFalsy();
Prioritize roster nickname as message and chatbox display name Set reference to roster contact on the message and chatbox object and listen for changes to the nickname. Currently, because chat boxes are fetched and initialized before the roster, messages and chats are repainted with the correct display name only later, causing a "flash" effect. Ideally we would only initialize the chat boxes after the roster contacts have been fetched, but this is currently not easily possible because we need the control box to render before everything else.
2019-04-09 17:10:50 +02:00
await test_utils.waitUntil(() => u.hasClass('correcting', sizzle('.chat-msg', view.el)[1]), 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
textarea.value = 'It is the east, and Juliet is the sun.';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
Allow any earlier message to be edited. updates #421
2018-07-08 15:20:58 +02:00
});
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.model.messages.once('rendered', resolve));
expect(textarea.value).toBe('');
const messages = view.el.querySelectorAll('.chat-msg');
expect(messages.length).toBe(3);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(messages[0].querySelector('.chat-msg__text').textContent)
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
.toBe('But soft, what light through yonder window breaks?');
expect(messages[1].querySelector('.chat-msg__text').textContent)
.toBe('It is the east, and Juliet is the sun.');
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(messages[2].querySelector('.chat-msg__text').textContent)
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
.toBe('Arise, fair sun, and kill the envious moon');
expect(view.model.messages.at(0).get('correcting')).toBeFalsy();
expect(view.model.messages.at(1).get('correcting')).toBeFalsy();
expect(view.model.messages.at(2).get('correcting')).toBeFalsy();
done();
Cancel message correction by pressing the down arrow Also, add a class `correcting` to the message being corrected, to provide a visual cue. updates #421
2018-07-08 10:13:15 +02:00
}));
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("can be received out of order, and will still be displayed in the right order",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
Allow messages to be edited by clicking a pencil icon updates #421
2018-07-21 10:41:10 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let message, msg;
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => _converse.rosterview.el.querySelectorAll('.roster-group').length)
spyOn(_converse, 'log');
spyOn(_converse.chatboxes, 'getChatBox').and.callThrough();
_converse.filter_by_resource = true;
/* <message id='aeb213' to='juliet@capulet.lit/chamber'>
* <forwarded xmlns='urn:xmpp:forward:0'>
* <delay xmlns='urn:xmpp:delay' stamp='2010-07-10T23:08:25Z'/>
* <message xmlns='jabber:client'
* to='juliet@capulet.lit/balcony'
* from='romeo@montague.lit/orchard'
* type='chat'>
* <body>Call me but love, and I'll be new baptized; Henceforth I never will be Romeo.</body>
* </message>
* </forwarded>
* </message>
*/
msg = $msg({'id': 'aeb213', 'to': _converse.bare_jid})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('delay', {'xmlns': 'urn:xmpp:delay', 'stamp':'2018-01-02T13:08:25Z'}).up()
.c('message', {
'xmlns': 'jabber:client',
'to': _converse.bare_jid,
'from': sender_jid,
'type': 'chat'})
.c('body').t("message")
.tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => _converse.api.chats.get().length);
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(sender_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
msg = $msg({'id': 'aeb214', 'to': _converse.bare_jid})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('delay', {'xmlns': 'urn:xmpp:delay', 'stamp':'2017-12-31T22:08:25Z'}).up()
.c('message', {
'xmlns': 'jabber:client',
'to': _converse.bare_jid,
'from': sender_jid,
'type': 'chat'})
.c('body').t("Older message")
.tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
msg = $msg({'id': 'aeb215', 'to': _converse.bare_jid})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('delay', {'xmlns': 'urn:xmpp:delay', 'stamp':'2018-01-01T13:18:23Z'}).up()
.c('message', {
'xmlns': 'jabber:client',
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
'to': _converse.bare_jid,
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'from': sender_jid,
'type': 'chat'})
.c('body').t("Inbetween message").up()
.tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
msg = $msg({'id': 'aeb216', 'to': _converse.bare_jid})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('delay', {'xmlns': 'urn:xmpp:delay', 'stamp':'2018-01-01T13:18:23Z'}).up()
.c('message', {
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
'xmlns': 'jabber:client',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'to': _converse.bare_jid,
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
'from': sender_jid,
'type': 'chat'})
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
.c('body').t("another inbetween message")
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
.tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
msg = $msg({'id': 'aeb217', 'to': _converse.bare_jid})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('delay', {'xmlns': 'urn:xmpp:delay', 'stamp':'2018-01-02T12:18:23Z'}).up()
.c('message', {
'xmlns': 'jabber:client',
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
'to': _converse.bare_jid,
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'from': sender_jid,
'type': 'chat'})
.c('body').t("An earlier message on the next day")
.tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
msg = $msg({'id': 'aeb218', 'to': _converse.bare_jid})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('delay', {'xmlns': 'urn:xmpp:delay', 'stamp':'2018-01-02T22:28:23Z'}).up()
.c('message', {
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
'xmlns': 'jabber:client',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'to': _converse.bare_jid,
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
'from': sender_jid,
'type': 'chat'})
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
.c('body').t("newer message from the next day")
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
.tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
// Insert <composing> message, to also check that
// text messages are inserted correctly with
// temporary chat events in the chat contents.
msg = $msg({
'id': 'aeb219',
'to': _converse.bare_jid,
'xmlns': 'jabber:client',
'from': sender_jid,
'type': 'chat'})
.c('composing', {'xmlns': Strophe.NS.CHATSTATES}).up()
.tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
msg = $msg({
'id': 'aeb220',
'to': _converse.bare_jid,
'xmlns': 'jabber:client',
'from': sender_jid,
'type': 'chat'})
.c('composing', {'xmlns': Strophe.NS.CHATSTATES}).up()
.c('body').t("latest message")
.tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const chat_content = view.el.querySelector('.chat-content');
view.clearSpinner(); //cleanup
expect(chat_content.querySelectorAll('.date-separator').length).toEqual(4);
Add test for receiving message corrections
2018-07-06 00:43:47 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
let day = sizzle('.date-separator:first', chat_content).pop();
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
expect(day.getAttribute('data-isodate')).toEqual(dayjs('2017-12-31T00:00:00').toISOString());
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
let time = sizzle('time:first', chat_content).pop();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(time.textContent).toEqual('Sunday Dec 31st 2017')
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
day = sizzle('.date-separator:first', chat_content).pop();
expect(day.nextElementSibling.querySelector('.chat-msg__text').textContent).toBe('Older message');
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
let el = sizzle('.chat-msg:first', chat_content).pop().querySelector('.chat-msg__text')
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(u.hasClass('chat-msg--followup', el)).toBe(false);
expect(el.textContent).toEqual('Older message');
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
time = sizzle('time.separator-text:eq(1)', chat_content).pop();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(time.textContent).toEqual("Monday Jan 1st 2018");
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
day = sizzle('.date-separator:eq(1)', chat_content).pop();
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
expect(day.getAttribute('data-isodate')).toEqual(dayjs('2018-01-01T00:00:00').toISOString());
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(day.nextElementSibling.querySelector('.chat-msg__text').textContent).toBe('Inbetween message');
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
el = sizzle('.chat-msg:eq(1)', chat_content).pop();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(el.querySelector('.chat-msg__text').textContent).toEqual('Inbetween message');
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(el.nextElementSibling.querySelector('.chat-msg__text').textContent).toEqual('another inbetween message');
el = sizzle('.chat-msg:eq(2)', chat_content).pop();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(el.querySelector('.chat-msg__text').textContent)
.toEqual('another inbetween message');
expect(u.hasClass('chat-msg--followup', el)).toBe(true);
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
time = sizzle('time.separator-text:nth(2)', chat_content).pop();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(time.textContent).toEqual("Tuesday Jan 2nd 2018");
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
day = sizzle('.date-separator:nth(2)', chat_content).pop();
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
expect(day.getAttribute('data-isodate')).toEqual(dayjs('2018-01-02T00:00:00').toISOString());
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(day.nextElementSibling.querySelector('.chat-msg__text').textContent).toBe('An earlier message on the next day');
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
el = sizzle('.chat-msg:eq(3)', chat_content).pop();
expect(el.querySelector('.chat-msg__text').textContent).toEqual('An earlier message on the next day');
expect(u.hasClass('chat-msg--followup', el)).toBe(false);
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
el = sizzle('.chat-msg:eq(4)', chat_content).pop();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(el.querySelector('.chat-msg__text').textContent).toEqual('message');
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(el.nextElementSibling.querySelector('.chat-msg__text').textContent).toEqual('newer message from the next day');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(u.hasClass('chat-msg--followup', el)).toBe(false);
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
day = sizzle('.date-separator:last', chat_content).pop();
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
expect(day.getAttribute('data-isodate')).toEqual(dayjs().startOf('day').toISOString());
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(day.nextElementSibling.querySelector('.chat-msg__text').textContent).toBe('latest message');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(u.hasClass('chat-msg--followup', el)).toBe(false);
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("is ignored if it's a malformed headline message",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched'], {},
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
/* Ideally we wouldn't have to filter out headline
* messages, but Prosody gives them the wrong 'type' :(
*/
sinon.spy(_converse, 'log');
sinon.spy(_converse.chatboxes, 'getChatBox');
sinon.spy(u, 'isHeadlineMessage');
const msg = $msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
from: 'montague.lit',
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
to: _converse.bare_jid,
type: 'chat',
id: (new Date()).getTime()
}).c('body').t("This headline message will not be shown").tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
expect(_converse.log.calledWith(
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
"onMessage: Ignoring incoming headline message from JID: montague.lit",
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
Strophe.LogLevel.INFO
)).toBeTruthy();
expect(u.isHeadlineMessage.called).toBeTruthy();
expect(u.isHeadlineMessage.returned(true)).toBeTruthy();
expect(_converse.chatboxes.getChatBox.called).toBeFalsy();
// Remove sinon spies
_converse.log.restore();
_converse.chatboxes.getChatBox.restore();
u.isHeadlineMessage.restore();
done();
}));
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("can be a carbon message, as defined in XEP-0280",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Fix failing tests due to avatar changes
2018-11-14 16:37:16 +01:00
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
const include_nick = false;
await test_utils.waitForRoster(_converse, 'current', 2, include_nick);
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
// Send a message from a different resource
spyOn(_converse, 'log');
`createMessage` now returns a promise. Also, fix all broken tests, mostly related to this.
2018-08-18 11:28:51 +02:00
const msgtext = 'This is a carbon message';
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[1].replace(/ /g,'.').toLowerCase() + '@montague.lit';
`createMessage` now returns a promise. Also, fix all broken tests, mostly related to this.
2018-08-18 11:28:51 +02:00
const msg = $msg({
Fixes #1550 Legitimate carbons messages blocked due to erroneous forgery check
2019-05-03 14:10:26 +02:00
'from': _converse.bare_jid,
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
'id': (new Date()).getTime(),
'to': _converse.connection.jid,
'type': 'chat',
'xmlns': 'jabber:client'
}).c('received', {'xmlns': 'urn:xmpp:carbons:2'})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('message', {
'xmlns': 'jabber:client',
'from': sender_jid,
'to': _converse.bare_jid+'/another-resource',
'type': 'chat'
}).c('body').t(msgtext).tree();
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Use the API in tests
2019-02-22 21:43:49 +01:00
await test_utils.waitUntil(() => (_converse.api.chats.get().length > 1))
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const chatbox = _converse.chatboxes.get(sender_jid);
const view = _converse.chatboxviews.get(sender_jid);
Fixes #1550 Legitimate carbons messages blocked due to erroneous forgery check
2019-05-03 14:10:26 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(chatbox).toBeDefined();
expect(view).toBeDefined();
// Check that the message was received and check the message parameters
expect(chatbox.messages.length).toEqual(1);
const msg_obj = chatbox.messages.models[0];
expect(msg_obj.get('message')).toEqual(msgtext);
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
expect(msg_obj.get('fullname')).toBeUndefined();
expect(msg_obj.get('nickname')).toBeUndefined();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg_obj.get('sender')).toEqual('them');
expect(msg_obj.get('is_delayed')).toEqual(false);
// Now check that the message appears inside the chatbox in the DOM
const chat_content = view.el.querySelector('.chat-content');
Fix failing tests
2019-02-13 15:24:24 +01:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(chat_content.querySelector('.chat-msg .chat-msg__text').textContent).toEqual(msgtext);
expect(chat_content.querySelector('.chat-msg__time').textContent.match(/^[0-9][0-9]:[0-9][0-9]/)).toBeTruthy();
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.waitUntil(() => chatbox.vcard.get('fullname') === 'Juliet Capulet')
expect(chat_content.querySelector('span.chat-msg__author').textContent.trim()).toBe('Juliet Capulet');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("can be a carbon message that this user sent from a different client, as defined in XEP-0280",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.waitUntilDiscoConfirmed(_converse, 'montague.lit', [], ['vcard-temp']);
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
test_utils.openControlBox();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// Send a message from a different resource
spyOn(_converse, 'log');
const msgtext = 'This is a sent carbon message';
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const recipient_jid = mock.cur_names[5].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const msg = $msg({
'from': _converse.bare_jid,
'id': (new Date()).getTime(),
'to': _converse.connection.jid,
'type': 'chat',
'xmlns': 'jabber:client'
}).c('sent', {'xmlns': 'urn:xmpp:carbons:2'})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('message', {
'xmlns': 'jabber:client',
'from': _converse.bare_jid+'/another-resource',
'to': recipient_jid,
'type': 'chat'
}).c('body').t(msgtext).tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => _converse.api.chats.get().length);
// Check that the chatbox and its view now exist
const chatbox = _converse.chatboxes.get(recipient_jid);
const view = _converse.chatboxviews.get(recipient_jid);
expect(chatbox).toBeDefined();
expect(view).toBeDefined();
Fix failing tests
2019-02-13 15:24:24 +01:00
await new Promise(resolve => view.once('messageInserted', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// Check that the message was received and check the message parameters
expect(chatbox.messages.length).toEqual(1);
const msg_obj = chatbox.messages.models[0];
expect(msg_obj.get('message')).toEqual(msgtext);
expect(msg_obj.get('fullname')).toEqual(_converse.xmppstatus.get('fullname'));
expect(msg_obj.get('sender')).toEqual('me');
expect(msg_obj.get('is_delayed')).toEqual(false);
// Now check that the message appears inside the chatbox in the DOM
const msg_txt = view.el.querySelector('.chat-content .chat-msg .chat-msg__text').textContent;
expect(msg_txt).toEqual(msgtext);
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("will be discarded if it's a malicious message meant to look like a carbon copy",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched'], {},
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
async function (done, _converse) {
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
/* <message from="mallory@evil.example" to="b@xmpp.example">
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
* <received xmlns='urn:xmpp:carbons:2'>
* <forwarded xmlns='urn:xmpp:forward:0'>
* <message from="alice@xmpp.example" to="bob@xmpp.example/client1">
* <body>Please come to Creepy Valley tonight, alone!</body>
* </message>
* </forwarded>
* </received>
* </message>
*/
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
spyOn(_converse, 'log');
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
const msgtext = 'Please come to Creepy Valley tonight, alone!';
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[1].replace(/ /g,'.').toLowerCase() + '@montague.lit';
const impersonated_jid = mock.cur_names[2].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
const msg = $msg({
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
'from': sender_jid,
'id': (new Date()).getTime(),
'to': _converse.connection.jid,
'type': 'chat',
'xmlns': 'jabber:client'
}).c('received', {'xmlns': 'urn:xmpp:carbons:2'})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('message', {
'xmlns': 'jabber:client',
'from': impersonated_jid,
'to': _converse.connection.jid,
'type': 'chat'
}).c('body').t(msgtext).tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
// Check that chatbox for impersonated user is not created.
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
let chatbox = _converse.chatboxes.get(impersonated_jid);
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
expect(chatbox).not.toBeDefined();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
// Check that the chatbox for the malicous user is not created
chatbox = _converse.chatboxes.get(sender_jid);
expect(chatbox).not.toBeDefined();
done();
}));
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("received for a minimized chat box will increment a counter on its header",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
Use async/await
2018-11-20 18:10:55 +01:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
if (_converse.view_mode === 'fullscreen') {
return done();
}
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
const contact_name = mock.cur_names[0];
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = contact_name.replace(/ /g,'.').toLowerCase() + '@montague.lit';
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
spyOn(_converse.api, "trigger").and.callThrough();
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Use async/await
2018-11-20 18:10:55 +01:00
await test_utils.waitUntil(() => _converse.rosterview.el.querySelectorAll('.roster-group').length);
await test_utils.openChatBoxFor(_converse, contact_jid);
Use the API in tests
2019-02-22 21:43:49 +01:00
const chatview = _converse.api.chatviews.get(contact_jid);
Use async/await
2018-11-20 18:10:55 +01:00
expect(u.isVisible(chatview.el)).toBeTruthy();
expect(chatview.model.get('minimized')).toBeFalsy();
chatview.el.querySelector('.toggle-chatbox-button').click();
expect(chatview.model.get('minimized')).toBeTruthy();
var message = 'This message is sent to a minimized chatbox';
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
var sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Use async/await
2018-11-20 18:10:55 +01:00
var msg = $msg({
from: sender_jid,
to: _converse.connection.jid,
type: 'chat',
id: (new Date()).getTime()
}).c('body').t(message).up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Use async/await
2018-11-20 18:10:55 +01:00
await test_utils.waitUntil(() => chatview.model.messages.length);
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
expect(_converse.api.trigger).toHaveBeenCalledWith('message', jasmine.any(Object));
Use async/await
2018-11-20 18:10:55 +01:00
const trimmed_chatboxes = _converse.minimized_chats;
const trimmedview = trimmed_chatboxes.get(contact_jid);
let count = trimmedview.el.querySelector('.message-count');
expect(u.isVisible(chatview.el)).toBeFalsy();
expect(trimmedview.model.get('minimized')).toBeTruthy();
expect(u.isVisible(count)).toBeTruthy();
expect(count.textContent).toBe('1');
_converse.chatboxes.onMessage(
$msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
from: mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit',
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
to: _converse.connection.jid,
type: 'chat',
id: (new Date()).getTime()
Use async/await
2018-11-20 18:10:55 +01:00
}).c('body').t('This message is also sent to a minimized chatbox').up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree()
);
await test_utils.waitUntil(() => (chatview.model.messages.length > 1));
expect(u.isVisible(chatview.el)).toBeFalsy();
expect(trimmedview.model.get('minimized')).toBeTruthy();
count = trimmedview.el.querySelector('.message-count');
expect(u.isVisible(count)).toBeTruthy();
expect(count.textContent).toBe('2');
trimmedview.el.querySelector('.restore-chat').click();
expect(trimmed_chatboxes.keys().length).toBe(0);
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("will indicate when it has a time difference of more than a day between it and its predecessor",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
const include_nick = false;
await test_utils.waitForRoster(_converse, 'current', 2, include_nick);
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
spyOn(_converse.api, "trigger");
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
const contact_name = mock.cur_names[1];
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = contact_name.replace(/ /g,'.').toLowerCase() + '@montague.lit';
`createMessage` now returns a promise. Also, fix all broken tests, mostly related to this.
2018-08-18 11:28:51 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => _converse.rosterview.el.querySelectorAll('.roster-group').length);
await test_utils.openChatBoxFor(_converse, contact_jid);
test_utils.clearChatBoxMessages(_converse, contact_jid);
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
const one_day_ago = dayjs().subtract(1, 'day');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const chatbox = _converse.chatboxes.get(contact_jid);
const view = _converse.chatboxviews.get(contact_jid);
let message = 'This is a day old message';
let msg = $msg({
from: contact_jid,
to: _converse.connection.jid,
type: 'chat',
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
id: one_day_ago.toDate().getTime()
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
}).c('body').t(message).up()
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.c('delay', { xmlns:'urn:xmpp:delay', from: 'montague.lit', stamp: one_day_ago.toISOString() })
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
expect(_converse.api.trigger).toHaveBeenCalledWith('message', jasmine.any(Object));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(chatbox.messages.length).toEqual(1);
let msg_obj = chatbox.messages.models[0];
expect(msg_obj.get('message')).toEqual(message);
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
expect(msg_obj.get('fullname')).toBeUndefined();
Refactor initialization and defaults for chat boxes - Let box_id start with char for valid HTML. - No need to use SHA1 for box id - No need for the user_id attribute. - Set nickname when we set the roster contact. Also... - _converse.api.contacts.get is now async - _converse.api.chats.create is now async
2019-04-17 11:52:41 +02:00
expect(msg_obj.get('nickname')).toBe(null);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg_obj.get('sender')).toEqual('them');
expect(msg_obj.get('is_delayed')).toEqual(true);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.waitUntil(() => chatbox.vcard.get('fullname') === 'Juliet Capulet')
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const chat_content = view.el.querySelector('.chat-content');
expect(chat_content.querySelector('.chat-msg .chat-msg__text').textContent).toEqual(message);
expect(chat_content.querySelector('.chat-msg__time').textContent.match(/^[0-9][0-9]:[0-9][0-9]/)).toBeTruthy();
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
expect(chat_content.querySelector('span.chat-msg__author').textContent.trim()).toBe('Juliet Capulet');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(chat_content.querySelectorAll('.date-separator').length).toEqual(1);
let day = chat_content.querySelector('.date-separator');
expect(day.getAttribute('class')).toEqual('message date-separator');
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
expect(day.getAttribute('data-isodate')).toEqual(dayjs(one_day_ago.startOf('day')).toISOString());
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let time = chat_content.querySelector('time.separator-text');
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
expect(time.textContent).toEqual(dayjs(one_day_ago.startOf('day')).format("dddd MMM Do YYYY"));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
message = 'This is a current message';
msg = $msg({
from: contact_jid,
to: _converse.connection.jid,
type: 'chat',
id: new Date().getTime()
}).c('body').t(message).up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
expect(_converse.api.trigger).toHaveBeenCalledWith('message', jasmine.any(Object));
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
// Check that there is a <time> element, with the required props.
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(chat_content.querySelectorAll('time.separator-text').length).toEqual(2); // There are now two time elements
const message_date = new Date();
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
day = sizzle('.date-separator:last', chat_content);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(day.length).toEqual(1);
expect(day[0].getAttribute('class')).toEqual('message date-separator');
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
expect(day[0].getAttribute('data-isodate')).toEqual(dayjs(message_date).startOf('day').toISOString());
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
time = sizzle('time.separator-text:last', chat_content).pop();
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
expect(time.textContent).toEqual(dayjs(message_date).startOf('day').format("dddd MMM Do YYYY"));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// Normal checks for the 2nd message
expect(chatbox.messages.length).toEqual(2);
msg_obj = chatbox.messages.models[1];
expect(msg_obj.get('message')).toEqual(message);
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
expect(msg_obj.get('fullname')).toBeUndefined();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg_obj.get('sender')).toEqual('them');
expect(msg_obj.get('is_delayed')).toEqual(false);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
const msg_txt = sizzle('.chat-msg:last .chat-msg__text', chat_content).pop().textContent;
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg_txt).toEqual(message);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(chat_content.querySelector('.chat-msg:last-child .chat-msg__text').textContent).toEqual(message);
expect(chat_content.querySelector('.chat-msg:last-child .chat-msg__time').textContent.match(/^[0-9][0-9]:[0-9][0-9]/)).toBeTruthy();
expect(chat_content.querySelector('.chat-msg:last-child .chat-msg__author').textContent.trim()).toBe('Juliet Capulet');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
}));
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
it("is sanitized to prevent Javascript injection attacks",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, contact_jid)
const view = _converse.chatboxviews.get(contact_jid);
const message = '<p>This message contains <em>some</em> <b>markup</b></p>';
spyOn(view.model, 'sendMessage').and.callThrough();
await test_utils.sendMessage(view, message);
expect(view.model.sendMessage).toHaveBeenCalled();
Remove jquery from spec/messages.js
2019-03-27 09:33:15 +01:00
const msg = sizzle('.chat-content .chat-msg:last .chat-msg__text', view.el).pop();
expect(msg.textContent).toEqual(message);
expect(msg.innerHTML).toEqual('&lt;p&gt;This message contains &lt;em&gt;some&lt;/em&gt; &lt;b&gt;markup&lt;/b&gt;&lt;/p&gt;');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
it("can contain hyperlinks, which will be clickable",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
test_utils.openControlBox();
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, contact_jid)
const view = _converse.chatboxviews.get(contact_jid);
const message = 'This message contains a hyperlink: www.opkode.com';
spyOn(view.model, 'sendMessage').and.callThrough();
test_utils.sendMessage(view, message);
expect(view.model.sendMessage).toHaveBeenCalled();
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Remove jquery from spec/messages.js
2019-03-27 09:33:15 +01:00
const msg = sizzle('.chat-content .chat-msg:last .chat-msg__text', view.el).pop();
expect(msg.textContent).toEqual(message);
expect(msg.innerHTML)
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
.toEqual('This message contains a hyperlink: <a target="_blank" rel="noopener" href="http://www.opkode.com">www.opkode.com</a>');
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
it("will have properly escaped URLs",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, contact_jid)
const view = _converse.chatboxviews.get(contact_jid);
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let message = "http://www.opkode.com/'onmouseover='alert(1)'whatever";
await test_utils.sendMessage(view, message);
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Remove jquery from spec/messages.js
2019-03-27 09:33:15 +01:00
let msg = sizzle('.chat-content .chat-msg:last .chat-msg__text', view.el).pop();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg.textContent).toEqual(message);
Remove jquery from spec/messages.js
2019-03-27 09:33:15 +01:00
expect(msg.innerHTML)
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
.toEqual('<a target="_blank" rel="noopener" href="http://www.opkode.com/%27onmouseover=%27alert%281%29%27whatever">http://www.opkode.com/\'onmouseover=\'alert(1)\'whatever</a>');
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
message = 'http://www.opkode.com/"onmouseover="alert(1)"whatever';
await test_utils.sendMessage(view, message);
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
msg = sizzle('.chat-content .chat-msg:last .chat-msg__text', view.el).pop();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg.textContent).toEqual(message);
Remove jquery from spec/messages.js
2019-03-27 09:33:15 +01:00
expect(msg.innerHTML).toEqual('<a target="_blank" rel="noopener" href="http://www.opkode.com/%22onmouseover=%22alert%281%29%22whatever">http://www.opkode.com/"onmouseover="alert(1)"whatever</a>');
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
message = "https://en.wikipedia.org/wiki/Ender's_Game";
await test_utils.sendMessage(view, message);
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
msg = sizzle('.chat-content .chat-msg:last .chat-msg__text', view.el).pop();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg.textContent).toEqual(message);
Remove jquery from spec/messages.js
2019-03-27 09:33:15 +01:00
expect(msg.innerHTML).toEqual('<a target="_blank" rel="noopener" href="https://en.wikipedia.org/wiki/Ender%27s_Game">'+message+'</a>');
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Fixes #1467. Fix rendering of URLs enclosed with sharp brackets such as <https://example.org>
2019-03-27 10:56:09 +01:00
message = "<https://bugs.documentfoundation.org/show_bug.cgi?id=123737>";
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.sendMessage(view, message);
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
msg = sizzle('.chat-content .chat-msg:last .chat-msg__text', view.el).pop();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg.textContent).toEqual(message);
Fixes #1467. Fix rendering of URLs enclosed with sharp brackets such as <https://example.org>
2019-03-27 10:56:09 +01:00
expect(msg.innerHTML).toEqual(
`&lt;<a target="_blank" rel="noopener" href="https://bugs.documentfoundation.org/show_bug.cgi?id=123737">https://bugs.documentfoundation.org/show_bug.cgi?id=123737</a>&gt;`);
message = '<http://www.opkode.com/"onmouseover="alert(1)"whatever>';
await test_utils.sendMessage(view, message);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
msg = sizzle('.chat-content .chat-msg:last .chat-msg__text', view.el).pop();
Fixes #1467. Fix rendering of URLs enclosed with sharp brackets such as <https://example.org>
2019-03-27 10:56:09 +01:00
expect(msg.textContent).toEqual(message);
expect(msg.innerHTML).toEqual(
'&lt;<a target="_blank" rel="noopener" href="http://www.opkode.com/%22onmouseover=%22alert%281%29%22whatever">http://www.opkode.com/"onmouseover="alert(1)"whatever</a>&gt;');
Add tests for tricky URLs
2019-03-27 11:00:53 +01:00
message = `https://www.google.com/maps/place/Kochstraat+6,+2041+CE+Zandvoort/@52.3775999,4.548971,3a,15y,170.85h,88.39t/data=!3m6!1e1!3m4!1sQ7SdHo_bPLPlLlU8GSGWaQ!2e0!7i13312!8i6656!4m5!3m4!1s0x47c5ec1e56f845ad:0x1de0bc4a5771fb08!8m2!3d52.3773668!4d4.5489388!5m1!1e2`
await test_utils.sendMessage(view, message);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
msg = sizzle('.chat-content .chat-msg:last .chat-msg__text', view.el).pop();
Add tests for tricky URLs
2019-03-27 11:00:53 +01:00
expect(msg.textContent).toEqual(message);
expect(msg.innerHTML).toEqual(
`<a target="_blank" rel="noopener" href="https://www.google.com/maps/place/Kochstraat+6,+2041+CE+Zandvoort/@52.3775999,4.548971,3a,15y,170.85h,88.39t/data=%213m6%211e1%213m4%211sQ7SdHo_bPLPlLlU8GSGWaQ%212e0%217i13312%218i6656%214m5%213m4%211s0x47c5ec1e56f845ad:0x1de0bc4a5771fb08%218m2%213d52.3773668%214d4.5489388%215m1%211e2">https://www.google.com/maps/place/Kochstraat+6,+2041+CE+Zandvoort/@52.3775999,4.548971,3a,15y,170.85h,88.39t/data=!3m6!1e1!3m4!1sQ7SdHo_bPLPlLlU8GSGWaQ!2e0!7i13312!8i6656!4m5!3m4!1s0x47c5ec1e56f845ad:0x1de0bc4a5771fb08!8m2!3d52.3773668!4d4.5489388!5m1!1e2</a>`);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Fixes #1400. When chat message is only an emoji, enlarge it
2019-02-27 10:34:47 +01:00
it("will display larger if it's a single emoji",
mock.initConverse(
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
await test_utils.waitForRoster(_converse, 'current');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[1].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Fixes #1400. When chat message is only an emoji, enlarge it
2019-02-27 10:34:47 +01:00
_converse.chatboxes.onMessage($msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': (new Date()).getTime()
}).c('body').t('😇').up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree());
Remove `chatBoxOpened` event
2019-05-16 11:40:30 +02:00
await new Promise(resolve => _converse.on('chatBoxInitialized', resolve));
Fixes #1400. When chat message is only an emoji, enlarge it
2019-02-27 10:34:47 +01:00
const view = _converse.api.chatviews.get(sender_jid);
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
const chat_content = view.el.querySelector('.chat-content');
const message = chat_content.querySelector('.chat-msg__text');
expect(u.hasClass('chat-msg__text--larger', message)).toBe(true);
done();
}));
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("will render newlines",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const view = await test_utils.openChatBoxFor(_converse, contact_jid);
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
let stanza = u.toStanza(`
<message from="${contact_jid}"
type="chat"
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to="romeo@montague.lit/orchard">
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
<body>Hey\nHave you heard the news?</body>
</message>`);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
const chat_content = view.el.querySelector('.chat-content');
expect(chat_content.querySelector('.chat-msg__text').innerHTML).toBe('Hey<br>Have you heard the news?');
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
stanza = u.toStanza(`
<message from="${contact_jid}"
type="chat"
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to="romeo@montague.lit/orchard">
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
<body>Hey\n\n\nHave you heard the news?</body>
</message>`);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(chat_content.querySelector('.message:last-child .chat-msg__text').innerHTML).toBe('Hey<br><br>Have you heard the news?');
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
stanza = u.toStanza(`
<message from="${contact_jid}"
type="chat"
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to="romeo@montague.lit/orchard">
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
<body>Hey\nHave you heard\nthe news?</body>
</message>`);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(chat_content.querySelector('.message:last-child .chat-msg__text').innerHTML).toBe('Hey<br>Have you heard<br>the news?');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("will render images from their URLs",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Use async/await
2018-11-18 15:24:34 +01:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Don't render http (i.e. non-TLS) resources Causes "Mixed Content" TLS errors
2018-11-18 15:56:14 +01:00
let base_url = 'https://conversejs.org';
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
let message = base_url+"/logo/conversejs-filled.svg";
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Use async/await
2018-11-18 15:24:34 +01:00
await test_utils.openChatBoxFor(_converse, contact_jid);
const view = _converse.chatboxviews.get(contact_jid);
spyOn(view.model, 'sendMessage').and.callThrough();
test_utils.sendMessage(view, message);
await test_utils.waitUntil(() => view.el.querySelectorAll('.chat-content .chat-image').length, 1000)
expect(view.model.sendMessage).toHaveBeenCalled();
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
let msg = sizzle('.chat-content .chat-msg:last .chat-msg__text').pop();
Remove jquery from spec/messages.js
2019-03-27 09:33:15 +01:00
expect(msg.innerHTML.trim()).toEqual(
Use async/await
2018-11-18 15:24:34 +01:00
'<!-- src/templates/image.html -->\n'+
'<a href="'+base_url+'/logo/conversejs-filled.svg" target="_blank" rel="noopener"><img class="chat-image img-thumbnail"'+
' src="' + message + '"></a>');
message += "?param1=val1&param2=val2";
test_utils.sendMessage(view, message);
await test_utils.waitUntil(() => view.el.querySelectorAll('.chat-content .chat-image').length === 2, 1000);
expect(view.model.sendMessage).toHaveBeenCalled();
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
msg = sizzle('.chat-content .chat-msg:last .chat-msg__text').pop();
Remove jquery from spec/messages.js
2019-03-27 09:33:15 +01:00
expect(msg.innerHTML.trim()).toEqual(
Use async/await
2018-11-18 15:24:34 +01:00
'<!-- src/templates/image.html -->\n'+
'<a href="'+base_url+'/logo/conversejs-filled.svg?param1=val1&amp;param2=val2" target="_blank" rel="noopener"><img'+
' class="chat-image img-thumbnail" src="'+message.replace(/&/g, '&amp;')+'"></a>')
// Test now with two images in one message
message += ' hello world '+base_url+"/logo/conversejs-filled.svg";
test_utils.sendMessage(view, message);
await test_utils.waitUntil(() => view.el.querySelectorAll('.chat-content .chat-image').length === 4, 1000);
expect(view.model.sendMessage).toHaveBeenCalled();
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
msg = sizzle('.chat-content .chat-msg:last .chat-msg__text').pop();
Remove jquery from spec/messages.js
2019-03-27 09:33:15 +01:00
expect(msg.textContent.trim()).toEqual('hello world');
expect(msg.querySelectorAll('img').length).toEqual(2);
Don't render http (i.e. non-TLS) resources Causes "Mixed Content" TLS errors
2018-11-18 15:56:14 +01:00
// Non-https images aren't rendered
base_url = document.URL.split(window.location.pathname)[0];
message = base_url+"/logo/conversejs-filled.svg";
expect(view.el.querySelectorAll('img').length).toBe(4);
test_utils.sendMessage(view, message);
expect(view.el.querySelectorAll('img').length).toBe(4);
Use async/await
2018-11-18 15:24:34 +01:00
done();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
}));
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("will render the message time as configured",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
_converse.time_format = 'hh:mm';
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, contact_jid)
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(contact_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const message = 'This message is sent from this chatbox';
await test_utils.sendMessage(view, message);
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Use the API in tests
2019-02-22 21:43:49 +01:00
const chatbox = _converse.api.chats.get(contact_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(chatbox.messages.models.length, 1);
const msg_object = chatbox.messages.models[0];
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
const msg_author = view.el.querySelector('.chat-content .chat-msg:last-child .chat-msg__author');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
expect(msg_author.textContent.trim()).toBe('Romeo Montague');
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
const msg_time = view.el.querySelector('.chat-content .chat-msg:last-child .chat-msg__time');
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
const time = dayjs(msg_object.get('time')).format(_converse.time_format);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg_time.textContent).toBe(time);
done();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
}));
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("will be correctly identified and rendered as a followup message",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let message, msg;
`createMessage` now returns a promise. Also, fix all broken tests, mostly related to this.
2018-08-18 11:28:51 +02:00
const base_time = new Date();
const ONE_MINUTE_LATER = 60000;
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => _converse.rosterview.el.querySelectorAll('.roster-group').length, 300);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.filter_by_resource = true;
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
jasmine.clock().install();
jasmine.clock().mockDate(base_time);
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.chatboxes.onMessage($msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': (new Date()).getTime()
}).c('body').t('A message').up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree());
Remove `chatBoxOpened` event
2019-05-16 11:40:30 +02:00
await new Promise(resolve => _converse.on('chatBoxInitialized', resolve));
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(sender_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
jasmine.clock().tick(3*ONE_MINUTE_LATER);
_converse.chatboxes.onMessage($msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': (new Date()).getTime()
}).c('body').t("Another message 3 minutes later").up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree());
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
jasmine.clock().tick(11*ONE_MINUTE_LATER);
_converse.chatboxes.onMessage($msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': (new Date()).getTime()
}).c('body').t("Another message 14 minutes since we started").up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree());
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
jasmine.clock().tick(1000);
// Insert <composing> message, to also check that
// text messages are inserted correctly with
// temporary chat events in the chat contents.
_converse.chatboxes.onMessage($msg({
'id': 'aeb219',
'to': _converse.bare_jid,
'xmlns': 'jabber:client',
'from': sender_jid,
'type': 'chat'})
.c('composing', {'xmlns': Strophe.NS.CHATSTATES}).up()
.tree());
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
jasmine.clock().tick(1*ONE_MINUTE_LATER);
_converse.chatboxes.onMessage($msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': (new Date()).getTime()
}).c('body').t("Another message 1 minute and 1 second since the previous one").up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree());
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
jasmine.clock().tick(1*ONE_MINUTE_LATER);
const chat_content = view.el.querySelector('.chat-content');
await test_utils.sendMessage(view, "Another message within 10 minutes, but from a different person");
expect(chat_content.querySelectorAll('.message').length).toBe(6);
expect(chat_content.querySelectorAll('.chat-msg').length).toBe(5);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(2)'))).toBe(false);
expect(chat_content.querySelector('.message:nth-child(2) .chat-msg__text').textContent).toBe("A message");
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(3)'))).toBe(true);
Use flexbox to keep the chat scrolled down By using `display: flex` and `flex-direction: column-reverse`, the chat now automatically scrolls down when loaded, without requiring any extra JavaScript. We still need to scroll down with JavaScript when sending a message. By using `column-reverse`, the messages container now works in reverse. So the newest message is the first element in the container and the oldest message is the last. This is the reverse of before. Due to this, this change will likely break some plugins.
2019-06-17 21:42:55 +02:00
expect(chat_content.querySelector('.message:nth-child(3) .chat-msg__text').textContent).toBe(
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
"Another message 3 minutes later");
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(4)'))).toBe(false);
expect(chat_content.querySelector('.message:nth-child(4) .chat-msg__text').textContent).toBe(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
"Another message 14 minutes since we started");
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(5)'))).toBe(true);
expect(chat_content.querySelector('.message:nth-child(5) .chat-msg__text').textContent).toBe(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
"Another message 1 minute and 1 second since the previous one");
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(6)'))).toBe(false);
expect(chat_content.querySelector('.message:nth-child(6) .chat-msg__text').textContent).toBe(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
"Another message within 10 minutes, but from a different person");
// Let's add a delayed, inbetween message
_converse.chatboxes.onMessage($msg({'id': 'aeb218', 'to': _converse.bare_jid})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('delay', {'xmlns': 'urn:xmpp:delay',
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
'stamp': dayjs(base_time).add(5, 'minutes').toISOString()
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
}).up()
.c('message', {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
'xmlns': 'jabber:client',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'to': _converse.bare_jid,
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
'from': sender_jid,
'type': 'chat'})
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
.c('body').t("A delayed message, sent 5 minutes since we started")
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
.tree());
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(chat_content.querySelectorAll('.message').length).toBe(7);
expect(chat_content.querySelectorAll('.chat-msg').length).toBe(6);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(2)'))).toBe(false);
expect(chat_content.querySelector('.message:nth-child(2) .chat-msg__text').textContent).toBe("A message");
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(3)'))).toBe(true);
expect(chat_content.querySelector('.message:nth-child(3) .chat-msg__text').textContent).toBe(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
"Another message 3 minutes later");
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(4)'))).toBe(true);
expect(chat_content.querySelector('.message:nth-child(4) .chat-msg__text').textContent).toBe(
"A delayed message, sent 5 minutes since we started");
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(5)'))).toBe(true);
expect(chat_content.querySelector('.message:nth-child(5) .chat-msg__text').textContent).toBe(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
"Another message 14 minutes since we started");
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(6)'))).toBe(true);
expect(chat_content.querySelector('.message:nth-child(6) .chat-msg__text').textContent).toBe(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
"Another message 1 minute and 1 second since the previous one");
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(7)'))).toBe(false);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.chatboxes.onMessage($msg({'id': 'aeb213', 'to': _converse.bare_jid})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
Replace moment with DayJS
2019-05-06 11:16:56 +02:00
.c('delay', {'xmlns': 'urn:xmpp:delay', 'stamp':dayjs(base_time).add(4, 'minutes').toISOString()}).up()
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
.c('message', {
'xmlns': 'jabber:client',
'to': sender_jid,
'from': _converse.bare_jid+"/some-other-resource",
'type': 'chat'})
.c('body').t("A carbon message 4 minutes later")
Fixes #1550 Legitimate carbons messages blocked due to erroneous forgery check
2019-05-03 14:10:26 +02:00
.tree());
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(chat_content.querySelectorAll('.message').length).toBe(8);
expect(chat_content.querySelectorAll('.chat-msg').length).toBe(7);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(2)'))).toBe(false);
expect(chat_content.querySelector('.message:nth-child(2) .chat-msg__text').textContent).toBe("A message");
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(3)'))).toBe(true);
expect(chat_content.querySelector('.message:nth-child(3) .chat-msg__text').textContent).toBe(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
"Another message 3 minutes later");
Use flexbox to keep the chat scrolled down By using `display: flex` and `flex-direction: column-reverse`, the chat now automatically scrolls down when loaded, without requiring any extra JavaScript. We still need to scroll down with JavaScript when sending a message. By using `column-reverse`, the messages container now works in reverse. So the newest message is the first element in the container and the oldest message is the last. This is the reverse of before. Due to this, this change will likely break some plugins.
2019-06-17 21:42:55 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(4)'))).toBe(false);
expect(chat_content.querySelector('.message:nth-child(4) .chat-msg__text').textContent).toBe(
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
"A carbon message 4 minutes later");
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(5)'))).toBe(false);
expect(chat_content.querySelector('.message:nth-child(5) .chat-msg__text').textContent).toBe(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
"A delayed message, sent 5 minutes since we started");
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(6)'))).toBe(true);
expect(chat_content.querySelector('.message:nth-child(6) .chat-msg__text').textContent).toBe(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
"Another message 14 minutes since we started");
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(7)'))).toBe(true);
expect(chat_content.querySelector('.message:nth-child(7) .chat-msg__text').textContent).toBe(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
"Another message 1 minute and 1 second since the previous one");
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(u.hasClass('chat-msg--followup', chat_content.querySelector('.message:nth-child(8)'))).toBe(false);
expect(chat_content.querySelector('.message:nth-child(8) .chat-msg__text').textContent).toBe(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
"Another message within 10 minutes, but from a different person");
jasmine.clock().uninstall();
done();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
}));
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
it("received may emit a message delivery receipt",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
async function (done, _converse) {
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
const msg_id = u.getUniqueId();
const sent_stanzas = [];
spyOn(_converse.connection, 'send').and.callFake(function (stanza) {
sent_stanzas.push(stanza);
});
const msg = $msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': msg_id,
}).c('body').t('Message!').up()
.c('request', {'xmlns': Strophe.NS.RECEIPTS}).tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Also check for duplicates in one-on-one messages
2019-02-14 13:43:24 +01:00
const sent_messages = sent_stanzas.map(s => _.isElement(s) ? s : s.nodeTree).filter(s => s.nodeName === 'message');
expect(sent_messages.length).toBe(1);
const receipt = sizzle(`received[xmlns="${Strophe.NS.RECEIPTS}"]`, sent_messages[0]).pop();
Don't use `outerHTML` in tests, it's not consistent across browsers
2018-11-20 17:56:52 +01:00
expect(Strophe.serialize(receipt)).toBe(`<received id="${msg_id}" xmlns="${Strophe.NS.RECEIPTS}"/>`);
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
done();
}));
prevent message delivery receipts for carbons and own
2018-12-12 16:42:29 +01:00
it("carbon received does not emit a message delivery receipt",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
prevent message delivery receipts for carbons and own
2018-12-12 16:42:29 +01:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
prevent message delivery receipts for carbons and own
2018-12-12 16:42:29 +01:00
const msg_id = u.getUniqueId();
const sent_stanzas = [];
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
const view = await test_utils.openChatBoxFor(_converse, sender_jid);
spyOn(view.model, 'sendReceiptStanza').and.callThrough();
prevent message delivery receipts for carbons and own
2018-12-12 16:42:29 +01:00
const msg = $msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': u.getUniqueId(),
}).c('received', {'xmlns': 'urn:xmpp:carbons:2'})
.c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('message', {
'xmlns': 'jabber:client',
'from': sender_jid,
'to': _converse.bare_jid+'/another-resource',
'type': 'chat',
'id': msg_id
}).c('body').t('Message!').up()
.c('request', {'xmlns': Strophe.NS.RECEIPTS}).tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
prevent message delivery receipts for carbons and own
2018-12-12 16:42:29 +01:00
await test_utils.waitUntil(() => _converse.api.chats.get().length);
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
expect(view.model.sendReceiptStanza).not.toHaveBeenCalled();
prevent message delivery receipts for carbons and own
2018-12-12 16:42:29 +01:00
done();
}));
it("forwarded does not emit a message delivery receipt if it's mine",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
prevent message delivery receipts for carbons and own
2018-12-12 16:42:29 +01:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const recipient_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
prevent message delivery receipts for carbons and own
2018-12-12 16:42:29 +01:00
const msg_id = u.getUniqueId();
const sent_stanzas = [];
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
const view = await test_utils.openChatBoxFor(_converse, recipient_jid);
spyOn(view.model, 'sendReceiptStanza').and.callThrough();
prevent message delivery receipts for carbons and own
2018-12-12 16:42:29 +01:00
const msg = $msg({
'from': converse.bare_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': u.getUniqueId(),
}).c('forwarded', {'xmlns': 'urn:xmpp:forward:0'})
.c('message', {
'xmlns': 'jabber:client',
'from': _converse.bare_jid+'/another-resource',
'to': recipient_jid,
'type': 'chat',
'id': msg_id
}).c('body').t('Message!').up()
.c('request', {'xmlns': Strophe.NS.RECEIPTS}).tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
prevent message delivery receipts for carbons and own
2018-12-12 16:42:29 +01:00
await test_utils.waitUntil(() => _converse.api.chats.get().length);
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
expect(view.model.sendReceiptStanza).not.toHaveBeenCalled();
prevent message delivery receipts for carbons and own
2018-12-12 16:42:29 +01:00
done();
}));
Re-group some message specs
2019-06-26 11:09:07 +02:00
describe("when sent", function () {
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
Re-group some message specs
2019-06-26 11:09:07 +02:00
it("can have its delivery acknowledged by a receipt",
mock.initConverse(
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Fixes #1353 Don't expect delivery receipts to have type `chat`
2018-12-16 10:58:48 +01:00
Re-group some message specs
2019-06-26 11:09:07 +02:00
await test_utils.waitForRoster(_converse, 'current', 1);
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
await test_utils.openChatBoxFor(_converse, contact_jid);
const view = _converse.chatboxviews.get(contact_jid);
const textarea = view.el.querySelector('textarea.chat-textarea');
textarea.value = 'But soft, what light through yonder airlock breaks?';
view.onKeyDown({
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
await test_utils.waitUntil(() => _converse.api.chats.get().length);
const chatbox = _converse.chatboxes.get(contact_jid);
expect(chatbox).toBeDefined();
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
let msg_obj = chatbox.messages.models[0];
let msg_id = msg_obj.get('msgid');
let msg = $msg({
'from': contact_jid,
'to': _converse.connection.jid,
'id': u.getUniqueId(),
}).c('received', {'id': msg_id, xmlns: Strophe.NS.RECEIPTS}).up().tree();
_converse.connection._dataRecv(test_utils.createRequest(msg));
await new Promise((resolve, reject) => view.model.messages.once('rendered', resolve));
expect(view.el.querySelectorAll('.chat-msg__receipt').length).toBe(1);
// Also handle receipts with type 'chat'. See #1353
spyOn(_converse.chatboxes, 'onMessage').and.callThrough();
textarea.value = 'Another message';
view.onKeyDown({
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
msg_obj = chatbox.messages.models[1];
msg_id = msg_obj.get('msgid');
msg = $msg({
'from': contact_jid,
'type': 'chat',
'to': _converse.connection.jid,
'id': u.getUniqueId(),
}).c('received', {'id': msg_id, xmlns: Strophe.NS.RECEIPTS}).up().tree();
_converse.connection._dataRecv(test_utils.createRequest(msg));
await new Promise((resolve, reject) => view.model.messages.once('rendered', resolve));
expect(view.el.querySelectorAll('.chat-msg__receipt').length).toBe(2);
expect(_converse.chatboxes.onMessage.calls.count()).toBe(1);
done();
}));
Fixes #1353 Don't expect delivery receipts to have type `chat`
2018-12-16 10:58:48 +01:00
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
Re-group some message specs
2019-06-26 11:09:07 +02:00
it("will appear inside the chatbox it was sent from",
mock.initConverse(
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
await test_utils.waitForRoster(_converse, 'current');
test_utils.openControlBox();
spyOn(_converse.api, "trigger");
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
await test_utils.openChatBoxFor(_converse, contact_jid)
expect(_converse.api.trigger).toHaveBeenCalledWith('chatBoxFocused', jasmine.any(Object));
const view = _converse.chatboxviews.get(contact_jid);
const message = 'This message is sent from this chatbox';
spyOn(view.model, 'sendMessage').and.callThrough();
await test_utils.sendMessage(view, message);
expect(view.model.sendMessage).toHaveBeenCalled();
expect(view.model.messages.length, 2);
expect(_converse.api.trigger.calls.mostRecent().args, ['messageSend', message]);
expect(sizzle('.chat-content .chat-msg:last .chat-msg__text', view.el).pop().textContent).toEqual(message);
done();
}));
Fixes #1494. Trim whitespace around messages
2019-06-26 10:59:02 +02:00
it("will be trimmed of leading and trailing whitespace",
mock.initConverse(
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
await test_utils.waitForRoster(_converse, 'current', 1);
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
await test_utils.openChatBoxFor(_converse, contact_jid)
const view = _converse.chatboxviews.get(contact_jid);
const message = ' \nThis message is sent from this chatbox \n \n';
await test_utils.sendMessage(view, message);
expect(view.model.messages.at(0).get('message')).toEqual(message.trim());
const message_el = sizzle('.chat-content .chat-msg:last .chat-msg__text', view.el).pop();
expect(message_el.textContent).toEqual(message.trim());
done();
}));
});
Add method to determine references from message text
2018-08-15 17:22:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
describe("when received from someone else", function () {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("will open a chatbox and be displayed inside it",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
const include_nick = false;
await test_utils.waitForRoster(_converse, 'current', 1, include_nick);
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => _converse.rosterview.el.querySelectorAll('.roster-group').length, 300);
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
spyOn(_converse.api, "trigger").and.callThrough();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const message = 'This is a received message';
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// We don't already have an open chatbox for this user
expect(_converse.chatboxes.get(sender_jid)).not.toBeDefined();
_converse.chatboxes.onMessage(
$msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': (new Date()).getTime()
}).c('body').t(message).up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree()
);
Use the API in tests
2019-02-22 21:43:49 +01:00
await test_utils.waitUntil(() => (_converse.api.chats.get().length === 2));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const chatbox = _converse.chatboxes.get(sender_jid);
expect(chatbox).toBeDefined();
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(sender_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(view).toBeDefined();
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
expect(_converse.api.trigger).toHaveBeenCalledWith('message', jasmine.any(Object));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// Check that the message was received and check the message parameters
expect(chatbox.messages.length).toEqual(1);
const msg_obj = chatbox.messages.models[0];
expect(msg_obj.get('message')).toEqual(message);
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
expect(msg_obj.get('fullname')).toBeUndefined();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg_obj.get('sender')).toEqual('them');
expect(msg_obj.get('is_delayed')).toEqual(false);
// Now check that the message appears inside the chatbox in the DOM
const chat_content = view.el.querySelector('.chat-content');
expect(chat_content.querySelector('.chat-msg .chat-msg__text').textContent).toEqual(message);
expect(chat_content.querySelector('.chat-msg__time').textContent.match(/^[0-9][0-9]:[0-9][0-9]/)).toBeTruthy();
await test_utils.waitUntil(() => chatbox.vcard.get('fullname') === mock.cur_names[0]);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
expect(chat_content.querySelector('span.chat-msg__author').textContent.trim()).toBe('Mercutio');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Fixes #1494. Trim whitespace around messages
2019-06-26 10:59:02 +02:00
it("will be trimmed of leading and trailing whitespace",
mock.initConverse(
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
await test_utils.waitForRoster(_converse, 'current', 1, false);
await test_utils.waitUntil(() => _converse.rosterview.el.querySelectorAll('.roster-group').length, 300);
const message = '\n\n This is a received message \n\n';
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
_converse.chatboxes.onMessage(
$msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': (new Date()).getTime()
}).c('body').t(message).up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree()
);
await test_utils.waitUntil(() => (_converse.api.chats.get().length === 2));
const view = _converse.api.chatviews.get(sender_jid);
expect(view.model.messages.length).toEqual(1);
const msg_obj = view.model.messages.at(0);
expect(msg_obj.get('message')).toEqual(message.trim());
const chat_content = view.el.querySelector('.chat-content');
expect(chat_content.querySelector('.chat-msg .chat-msg__text').textContent).toEqual(message.trim());
done();
}));
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("can be replaced with a correction",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
const message = 'This is a received message';
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
`createMessage` now returns a promise. Also, fix all broken tests, mostly related to this.
2018-08-18 11:28:51 +02:00
const msg_id = u.getUniqueId();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const view = await test_utils.openChatBoxFor(_converse, sender_jid);
_converse.chatboxes.onMessage($msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': msg_id,
}).c('body').t('But soft, what light through yonder airlock breaks?').tree());
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelector('.chat-msg__text').textContent)
.toBe('But soft, what light through yonder airlock breaks?');
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.chatboxes.onMessage($msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': u.getUniqueId(),
}).c('body').t('But soft, what light through yonder chimney breaks?').up()
.c('replace', {'id': msg_id, 'xmlns': 'urn:xmpp:message-correct:0'}).tree());
await new Promise((resolve, reject) => view.model.messages.once('rendered', resolve));
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(view.el.querySelector('.chat-msg__text').textContent)
.toBe('But soft, what light through yonder chimney breaks?');
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelectorAll('.chat-msg__content .fa-edit').length).toBe(1);
Corrections bugfix. Don't save new `id` on message model otherwise a new cache entry gets created, causing multiple messages to be restored from cache later on.
2019-06-25 12:06:47 +02:00
expect(view.model.messages.models.length).toBe(1);
expect(view.model.messages.browserStorage.records.length).toBe(1);
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.chatboxes.onMessage($msg({
'from': sender_jid,
'to': _converse.connection.jid,
'type': 'chat',
'id': u.getUniqueId(),
}).c('body').t('But soft, what light through yonder window breaks?').up()
.c('replace', {'id': msg_id, 'xmlns': 'urn:xmpp:message-correct:0'}).tree());
await new Promise((resolve, reject) => view.model.messages.once('rendered', resolve));
expect(view.el.querySelector('.chat-msg__text').textContent)
.toBe('But soft, what light through yonder window breaks?');
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelectorAll('.chat-msg__content .fa-edit').length).toBe(1);
view.el.querySelector('.chat-msg__content .fa-edit').click();
const modal = view.model.messages.at(0).message_versions_modal;
await test_utils.waitUntil(() => u.isVisible(modal.el), 1000);
const older_msgs = modal.el.querySelectorAll('.older-msg');
expect(older_msgs.length).toBe(2);
Refactor message corrections - Save date for older message versions and display it in the modal - Properly handle the correction being received *before* the corrected message
2019-05-21 16:18:14 +02:00
expect(older_msgs[0].childNodes[0].nodeName).toBe('TIME');
expect(older_msgs[0].childNodes[1].textContent).toBe(': But soft, what light through yonder airlock breaks?');
Corrections bugfix. Don't save new `id` on message model otherwise a new cache entry gets created, causing multiple messages to be restored from cache later on.
2019-06-25 12:06:47 +02:00
expect(view.model.messages.models.length).toBe(1);
expect(view.model.messages.browserStorage.records.length).toBe(1);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
}));
describe("when a chatbox is opened for someone who is not in the roster", function () {
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("the VCard for that user is fetched and the chatbox updated with the results",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
_converse.api.trigger('rosterContactsFetched');
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
_converse.allow_non_roster_messaging = true;
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
spyOn(_converse.api, "trigger").and.callThrough();
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
var vcard_fetched = false;
spyOn(_converse.api.vcard, "get").and.callFake(function () {
vcard_fetched = true;
return Promise.resolve({
'fullname': mock.cur_names[0],
Use native Date methods instead of moment - Use native `getTime` method instead of moment's `valueOf` - Use toISOString() instead of moment().format() This makes the code timezone independent since we're now globally using UTC.
2019-05-05 19:05:45 +02:00
'vcard_updated': (new Date()).toISOString(),
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
'jid': sender_jid
});
});
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const message = 'This is a received message from someone not on the roster';
const msg = $msg({
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
from: sender_jid,
to: _converse.connection.jid,
type: 'chat',
id: (new Date()).getTime()
}).c('body').t(message).up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
// We don't already have an open chatbox for this user
expect(_converse.chatboxes.get(sender_jid)).not.toBeDefined();
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => _converse.api.chats.get().length);
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
expect(_converse.api.trigger).toHaveBeenCalledWith('message', jasmine.any(Object));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// Check that the chatbox and its view now exist
const chatbox = _converse.chatboxes.get(sender_jid);
const view = _converse.chatboxviews.get(sender_jid);
expect(chatbox).toBeDefined();
expect(view).toBeDefined();
expect(chatbox.get('fullname') === sender_jid);
Fix failing tests
2019-02-13 15:24:24 +01:00
await new Promise(resolve => view.once('messageInserted', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.waitUntil(() => view.el.querySelector('.chat-msg__author').textContent.trim() === 'Mercutio');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let author_el = view.el.querySelector('.chat-msg__author');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
expect( _.includes(author_el.textContent.trim(), 'Mercutio')).toBeTruthy();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => vcard_fetched, 100);
expect(_converse.api.vcard.get).toHaveBeenCalled();
await test_utils.waitUntil(() => chatbox.vcard.get('fullname') === mock.cur_names[0])
author_el = view.el.querySelector('.chat-msg__author');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
expect( _.includes(author_el.textContent.trim(), 'Mercutio')).toBeTruthy();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
});
Render newlines
2018-06-30 15:07:30 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
describe("who is not on the roster", function () {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("will open a chatbox and be displayed inside it if allow_non_roster_messaging is true",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
_converse.allow_non_roster_messaging = false;
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
_converse.api.trigger('rosterContactsFetched');
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
spyOn(_converse.api, "trigger");
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const message = 'This is a received message from someone not on the roster';
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const msg = $msg({
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
from: sender_jid,
to: _converse.connection.jid,
type: 'chat',
id: (new Date()).getTime()
}).c('body').t(message).up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
// We don't already have an open chatbox for this user
expect(_converse.chatboxes.get(sender_jid)).not.toBeDefined();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Use the API in tests
2019-02-22 21:43:49 +01:00
let chatbox = await _converse.api.chats.get(sender_jid);
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
expect(chatbox).not.toBeDefined();
// onMessage is a handler for received XMPP messages
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Fix failing tests
2019-02-13 15:24:24 +01:00
expect(_converse.api.chats.get().length).toBe(1);
let view = _converse.chatboxviews.get(sender_jid);
expect(view).not.toBeDefined();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// onMessage is a handler for received XMPP messages
Fix failing tests
2019-02-13 15:24:24 +01:00
_converse.allow_non_roster_messaging = true;
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Fix failing tests
2019-02-13 15:24:24 +01:00
view = _converse.chatboxviews.get(sender_jid);
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
expect(_converse.api.trigger).toHaveBeenCalledWith('message', jasmine.any(Object));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// Check that the chatbox and its view now exist
chatbox = _converse.chatboxes.get(sender_jid);
expect(chatbox).toBeDefined();
expect(view).toBeDefined();
// Check that the message was received and check the message parameters
expect(chatbox.messages.length).toEqual(1);
const msg_obj = chatbox.messages.models[0];
expect(msg_obj.get('message')).toEqual(message);
expect(msg_obj.get('fullname')).toEqual(undefined);
expect(msg_obj.get('sender')).toEqual('them');
expect(msg_obj.get('is_delayed')).toEqual(false);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.waitUntil(() => view.el.querySelector('.chat-msg__author').textContent.trim() === 'Mercutio');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// Now check that the message appears inside the chatbox in the DOM
const chat_content = view.el.querySelector('.chat-content');
expect(chat_content.querySelector('.chat-msg .chat-msg__text').textContent).toEqual(message);
expect(chat_content.querySelector('.chat-msg__time').textContent.match(/^[0-9][0-9]:[0-9][0-9]/)).toBeTruthy();
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
expect(chat_content.querySelector('span.chat-msg__author').textContent.trim()).toBe('Mercutio');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
});
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Mark followup messags so that they can be styled differently
2018-04-30 12:15:26 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
describe("and for which then an error message is received from the server", function () {
Mark followup messags so that they can be styled differently
2018-04-30 12:15:26 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("will have the error message displayed after itself",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Mark followup messags so that they can be styled differently
2018-04-30 12:15:26 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
test_utils.openControlBox();
Mark followup messags so that they can be styled differently
2018-04-30 12:15:26 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
// TODO: what could still be done for error
// messages... if the <error> element has type
// "cancel", then we know the messages wasn't sent,
// and can give the user a nicer indication of
// that.
Mark followup messags so that they can be styled differently
2018-04-30 12:15:26 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
/* <message from="scotty@enterprise.com/_converse.js-84843526"
* to="kirk@enterprise.com.com"
* type="chat"
* id="82bc02ce-9651-4336-baf0-fa04762ed8d2"
* xmlns="jabber:client">
* <body>yo</body>
* <active xmlns="http://jabber.org/protocol/chatstates"/>
* </message>
*/
`createMessage` now returns a promise. Also, fix all broken tests, mostly related to this.
2018-08-18 11:28:51 +02:00
const error_txt = 'Server-to-server connection failed: Connecting failed: connection timeout';
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[5].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let fullname = _converse.xmppstatus.get('fullname');
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
fullname = _.isEmpty(fullname)? _converse.bare_jid: fullname;
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await _converse.api.chats.open(sender_jid)
Hide the textarea when a user is muted in a groupchat
2019-04-10 23:25:14 +02:00
let msg_text = 'This message will not be sent, due to an error';
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(sender_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let message = view.model.messages.create({
'msgid': '82bc02ce-9651-4336-baf0-fa04762ed8d2',
'fullname': fullname,
'sender': 'me',
Use native Date methods instead of moment - Use native `getTime` method instead of moment's `valueOf` - Use toISOString() instead of moment().format() This makes the code timezone independent since we're now globally using UTC.
2019-05-05 19:05:45 +02:00
'time': (new Date()).toISOString(),
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'message': msg_text
});
Hide the textarea when a user is muted in a groupchat
2019-04-10 23:25:14 +02:00
view.model.sendMessage(msg_text);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
const chat_content = view.el.querySelector('.chat-content');
let msg_txt = sizzle('.chat-msg:last .chat-msg__text', chat_content).pop().textContent;
expect(msg_txt).toEqual(msg_text);
// We send another message, for which an error will
// not be received, to test that errors appear
// after the relevant message.
msg_text = 'This message will be sent, and also receive an error';
message = view.model.messages.create({
'msgid': '6fcdeee3-000f-4ce8-a17e-9ce28f0ae104',
'fullname': fullname,
'sender': 'me',
Use native Date methods instead of moment - Use native `getTime` method instead of moment's `valueOf` - Use toISOString() instead of moment().format() This makes the code timezone independent since we're now globally using UTC.
2019-05-05 19:05:45 +02:00
'time': (new Date()).toISOString(),
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'message': msg_text
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
});
Hide the textarea when a user is muted in a groupchat
2019-04-10 23:25:14 +02:00
view.model.sendMessage(msg_text);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
msg_txt = sizzle('.chat-msg:last .chat-msg__text', chat_content).pop().textContent;
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg_txt).toEqual(msg_text);
/* <message xmlns="jabber:client"
* to="scotty@enterprise.com/_converse.js-84843526"
* type="error"
* id="82bc02ce-9651-4336-baf0-fa04762ed8d2"
* from="kirk@enterprise.com.com">
* <error type="cancel">
* <remote-server-not-found xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
* <text xmlns="urn:ietf:params:xml:ns:xmpp-stanzas">Server-to-server connection failed: Connecting failed: connection timeout</text>
* </error>
* </message>
*/
let stanza = $msg({
'to': _converse.connection.jid,
Fix failing test
2018-11-14 15:15:29 +01:00
'type': 'error',
'id': '82bc02ce-9651-4336-baf0-fa04762ed8d2',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'from': sender_jid
})
.c('error', {'type': 'cancel'})
.c('remote-server-not-found', { 'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas" }).up()
.c('text', { 'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas" })
.t('Server-to-server connection failed: Connecting failed: connection timeout');
_converse.connection._dataRecv(test_utils.createRequest(stanza));
Fix failing tests by waiting and slightly improve code
2018-12-06 12:45:30 +01:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(chat_content.querySelector('.chat-error').textContent).toEqual(error_txt);
stanza = $msg({
'to': _converse.connection.jid,
Fix failing test
2018-11-14 15:15:29 +01:00
'type': 'error',
'id': '6fcdeee3-000f-4ce8-a17e-9ce28f0ae104',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'from': sender_jid
})
.c('error', {'type': 'cancel'})
.c('remote-server-not-found', { 'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas" }).up()
.c('text', { 'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas" })
.t('Server-to-server connection failed: Connecting failed: connection timeout');
_converse.connection._dataRecv(test_utils.createRequest(stanza));
Fix failing tests by waiting and slightly improve code
2018-12-06 12:45:30 +01:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(chat_content.querySelectorAll('.chat-error').length).toEqual(2);
Fix failing test
2018-11-14 15:15:29 +01:00
// We don't render duplicates
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
stanza = $msg({
'to': _converse.connection.jid,
'type':'error',
Fix failing test
2018-11-14 15:15:29 +01:00
'id': '6fcdeee3-000f-4ce8-a17e-9ce28f0ae104',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'from': sender_jid
})
.c('error', {'type': 'cancel'})
.c('remote-server-not-found', { 'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas" }).up()
.c('text', { 'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas" })
.t('Server-to-server connection failed: Connecting failed: connection timeout');
_converse.connection._dataRecv(test_utils.createRequest(stanza));
expect(chat_content.querySelectorAll('.chat-error').length).toEqual(2);
Fix failing test
2018-11-14 15:15:29 +01:00
// We send another message, for which an error will
// not be received, to test that errors appear
// after the relevant message.
msg_text = 'This message will be sent, and also receive an error';
message = view.model.messages.create({
'msgid': 'another-id',
'fullname': fullname,
'sender': 'me',
Use native Date methods instead of moment - Use native `getTime` method instead of moment's `valueOf` - Use toISOString() instead of moment().format() This makes the code timezone independent since we're now globally using UTC.
2019-05-05 19:05:45 +02:00
'time': (new Date()).toISOString(),
Fix failing test
2018-11-14 15:15:29 +01:00
'message': msg_text
});
Hide the textarea when a user is muted in a groupchat
2019-04-10 23:25:14 +02:00
view.model.sendMessage(msg_text);
Fix failing test
2018-11-14 15:15:29 +01:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
msg_txt = sizzle('.chat-msg:last .chat-msg__text', chat_content).pop().textContent;
Fix failing test
2018-11-14 15:15:29 +01:00
expect(msg_txt).toEqual(msg_text);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// A different error message will however render
stanza = $msg({
'to': _converse.connection.jid,
'type':'error',
Fix failing test
2018-11-14 15:15:29 +01:00
'id': 'another-id',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'from': sender_jid
})
.c('error', {'type': 'cancel'})
.c('remote-server-not-found', { 'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas" }).up()
.c('text', { 'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas" })
.t('Something else went wrong as well');
_converse.connection._dataRecv(test_utils.createRequest(stanza));
Fix failing tests by waiting and slightly improve code
2018-12-06 12:45:30 +01:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(chat_content.querySelectorAll('.chat-error').length).toEqual(3);
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Fixes #1317 Don't show errors for CSI messages
2018-11-14 14:33:07 +01:00
it("will not show to the user an error message for a CSI message",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Fixes #1317 Don't show errors for CSI messages
2018-11-14 14:33:07 +01:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
// See #1317
// https://github.com/conversejs/converse.js/issues/1317
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Fixes #1317 Don't show errors for CSI messages
2018-11-14 14:33:07 +01:00
test_utils.openControlBox();
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[5].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Fixes #1317 Don't show errors for CSI messages
2018-11-14 14:33:07 +01:00
await test_utils.openChatBoxFor(_converse, contact_jid);
const messages = _converse.connection.sent_stanzas.filter(s => s.nodeName === 'message');
expect(messages.length).toBe(1);
expect(Strophe.serialize(messages[0])).toBe(
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
`<message id="${messages[0].getAttribute('id')}" to="tybalt@montague.lit" type="chat" xmlns="jabber:client">`+
Fixes #1317 Don't show errors for CSI messages
2018-11-14 14:33:07 +01:00
`<active xmlns="http://jabber.org/protocol/chatstates"/>`+
`<no-store xmlns="urn:xmpp:hints"/>`+
`<no-permanent-store xmlns="urn:xmpp:hints"/>`+
`</message>`);
const stanza = $msg({
'from': contact_jid,
'type': 'error',
'id': messages[0].getAttribute('id')
}).c('error', {'type': 'cancel', 'code': '503'})
.c('service-unavailable', { 'xmlns': 'urn:ietf:params:xml:ns:xmpp-stanzas' }).up()
.c('text', { 'xmlns': 'urn:ietf:params:xml:ns:xmpp-stanzas' })
.t('User session not found')
_converse.connection._dataRecv(test_utils.createRequest(stanza));
const view = _converse.chatboxviews.get(contact_jid);
const chat_content = view.el.querySelector('.chat-content');
expect(chat_content.querySelectorAll('.chat-error').length).toEqual(0);
done();
}));
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
});
Mark followup messags so that they can be styled differently
2018-04-30 12:15:26 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("will cause the chat area to be scrolled down only if it was at the bottom originally",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Mark followup messags so that they can be styled differently
2018-04-30 12:15:26 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, sender_jid)
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(sender_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// Create enough messages so that there's a scrollbar.
const promises = [];
for (let i=0; i<20; i++) {
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
_converse.chatboxes.onMessage($msg({
from: sender_jid,
to: _converse.connection.jid,
type: 'chat',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
id: _converse.connection.getUniqueId(),
}).c('body').t('Message: '+i).up()
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree());
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
promises.push(new Promise((resolve, reject) => view.once('messageInserted', resolve)));
}
await Promise.all(promises);
Cheat to get two failing test to pass on Travis Since recently these tests have been failing consistently on Travis, even though they're passing locally. Ran out of time debugging the issue, so disabling some stuff for now.
2019-05-24 08:39:21 +02:00
// XXX Fails on Travis
// await test_utils.waitUntil(() => view.content.scrollTop, 1000)
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => !view.model.get('auto_scrolled'), 500);
view.content.scrollTop = 0;
Cheat to get two failing test to pass on Travis Since recently these tests have been failing consistently on Travis, even though they're passing locally. Ran out of time debugging the issue, so disabling some stuff for now.
2019-05-24 08:39:21 +02:00
// XXX Fails on Travis
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
// await test_utils.waitUntil(() => view.model.get('scrolled'), 900);
view.model.set('scrolled', true);
Cheat to get two failing test to pass on Travis Since recently these tests have been failing consistently on Travis, even though they're passing locally. Ran out of time debugging the issue, so disabling some stuff for now.
2019-05-24 08:39:21 +02:00
const message = 'This message is received while the chat area is scrolled up';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.chatboxes.onMessage($msg({
from: sender_jid,
to: _converse.connection.jid,
type: 'chat',
id: (new Date()).getTime()
}).c('body').t(message).up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree());
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
await test_utils.waitUntil(() => view.model.messages.length > 20, 1000);
// Now check that the message appears inside the chatbox in the DOM
const chat_content = view.el.querySelector('.chat-content');
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
const msg_txt = sizzle('.chat-content .chat-msg:last .chat-msg__text', view.el).pop().textContent;
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg_txt).toEqual(message);
await test_utils.waitUntil(() => u.isVisible(view.el.querySelector('.new-msgs-indicator')), 900);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(view.model.get('scrolled')).toBe(true);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(view.content.scrollTop).toBe(0);
expect(u.isVisible(view.el.querySelector('.new-msgs-indicator'))).toBeTruthy();
// Scroll down again
view.content.scrollTop = view.content.scrollHeight;
Cheat to get two failing test to pass on Travis Since recently these tests have been failing consistently on Travis, even though they're passing locally. Ran out of time debugging the issue, so disabling some stuff for now.
2019-05-24 08:39:21 +02:00
// XXX Fails on Travis
// await test_utils.waitUntil(() => !u.isVisible(view.el.querySelector('.new-msgs-indicator')), 900);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
Mark followup messags so that they can be styled differently
2018-04-30 12:15:26 +02:00
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
it("is ignored if it's intended for a different resource and filter_by_resource is set to true",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Mark followup messags so that they can be styled differently
2018-04-30 12:15:26 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => _converse.rosterview.el.querySelectorAll('.roster-group').length)
// Send a message from a different resource
spyOn(_converse, 'log');
spyOn(_converse.chatboxes, 'getChatBox').and.callThrough();
_converse.filter_by_resource = true;
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let msg = $msg({
from: sender_jid,
to: _converse.bare_jid+"/some-other-resource",
type: 'chat',
id: (new Date()).getTime()
}).c('body').t("This message will not be shown").up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => _converse.api.chats.get().length);
expect(_converse.log).toHaveBeenCalledWith(
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
"onMessage: Ignoring incoming message intended for a different resource: romeo@montague.lit/some-other-resource",
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
Strophe.LogLevel.INFO);
expect(_converse.chatboxes.getChatBox).not.toHaveBeenCalled();
_converse.filter_by_resource = false;
const message = "This message sent to a different resource will be shown";
msg = $msg({
from: sender_jid,
to: _converse.bare_jid+"/some-other-resource",
type: 'chat',
id: '134234623462346'
}).c('body').t(message).up()
.c('active', {'xmlns': 'http://jabber.org/protocol/chatstates'}).tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await _converse.chatboxes.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => _converse.chatboxviews.keys().length > 1, 1000);
const view = _converse.chatboxviews.get(sender_jid);
await test_utils.waitUntil(() => view.model.messages.length);
expect(_converse.chatboxes.getChatBox).toHaveBeenCalled();
Remove jquery from spec/messages.js
2019-03-27 09:33:15 +01:00
const chat_content = sizzle('.chat-content:last', view.el).pop();
const msg_txt = chat_content.querySelector('.chat-msg .chat-msg__text').textContent;
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg_txt).toEqual(message);
done();
Rearrange: move non-nested tests to top of `describe`
2018-08-15 11:02:24 +02:00
}));
});
Mark followup messags so that they can be styled differently
2018-04-30 12:15:26 +02:00
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
describe("which contains an OOB URL", function () {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
it("will render audio from oob mp3 URLs",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, contact_jid);
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(contact_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
spyOn(view.model, 'sendMessage').and.callThrough();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
let stanza = u.toStanza(`
<message from="${contact_jid}"
type="chat"
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to="romeo@montague.lit/orchard">
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
<body>Have you heard this funny audio?</body>
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
<x xmlns="jabber:x:oob"><url>https://montague.lit/audio.mp3</url></x>
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
</message>`)
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
await test_utils.waitUntil(() => view.el.querySelectorAll('.chat-content .chat-msg audio').length, 1000);
let msg = view.el.querySelector('.chat-msg .chat-msg__text');
Fixes #1400. When chat message is only an emoji, enlarge it
2019-02-27 10:34:47 +01:00
expect(msg.classList.length).toEqual(1);
expect(u.hasClass('chat-msg__text', msg)).toBe(true);
expect(msg.textContent).toEqual('Have you heard this funny audio?');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let media = view.el.querySelector('.chat-msg .chat-msg__media');
expect(media.innerHTML.replace(/(\r\n|\n|\r)/gm, "")).toEqual(
'<!-- src/templates/audio.html -->'+
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'<audio controls="" src="https://montague.lit/audio.mp3"></audio>'+
'<a target="_blank" rel="noopener" href="https://montague.lit/audio.mp3">Download audio file "audio.mp3"</a>');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// If the <url> and <body> contents is the same, don't duplicate.
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
stanza = u.toStanza(`
<message from="${contact_jid}"
type="chat"
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to="romeo@montague.lit/orchard">
<body>https://montague.lit/audio.mp3</body>
<x xmlns="jabber:x:oob"><url>https://montague.lit/audio.mp3</url></x>
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
</message>`);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
msg = view.el.querySelector('.chat-msg:last-child .chat-msg__text');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg.innerHTML).toEqual('<!-- message gets added here via renderMessage -->'); // Emtpy
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
media = view.el.querySelector('.chat-msg:last-child .chat-msg__media');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(media.innerHTML.replace(/(\r\n|\n|\r)/gm, "")).toEqual(
'<!-- src/templates/audio.html -->'+
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'<audio controls="" src="https://montague.lit/audio.mp3"></audio>'+
'<a target="_blank" rel="noopener" href="https://montague.lit/audio.mp3">Download audio file "audio.mp3"</a>'
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
);
done();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
}));
it("will render video from oob mp4 URLs",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, contact_jid)
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(contact_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
spyOn(view.model, 'sendMessage').and.callThrough();
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
let stanza = u.toStanza(`
<message from="${contact_jid}"
type="chat"
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to="romeo@montague.lit/orchard">
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
<body>Have you seen this funny video?</body>
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
<x xmlns="jabber:x:oob"><url>https://montague.lit/video.mp4</url></x>
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
</message>`);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await test_utils.waitUntil(() => view.el.querySelectorAll('.chat-content .chat-msg video').length, 2000)
let msg = view.el.querySelector('.chat-msg .chat-msg__text');
Fixes #1400. When chat message is only an emoji, enlarge it
2019-02-27 10:34:47 +01:00
expect(msg.classList.length).toBe(1);
expect(msg.textContent).toEqual('Have you seen this funny video?');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let media = view.el.querySelector('.chat-msg .chat-msg__media');
expect(media.innerHTML.replace(/(\r\n|\n|\r)/gm, "")).toEqual(
'<!-- src/templates/video.html -->'+
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'<video controls="" src="https://montague.lit/video.mp4" style="max-height: 50vh"></video>'+
'<a target="_blank" rel="noopener" href="https://montague.lit/video.mp4">Download video file "video.mp4"</a>');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// If the <url> and <body> contents is the same, don't duplicate.
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
stanza = u.toStanza(`
<message from="${contact_jid}"
type="chat"
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to="romeo@montague.lit/orchard">
<body>https://montague.lit/video.mp4</body>
<x xmlns="jabber:x:oob"><url>https://montague.lit/video.mp4</url></x>
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
</message>`);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
msg = view.el.querySelector('.chat-msg:last-child .chat-msg__text');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(msg.innerHTML).toEqual('<!-- message gets added here via renderMessage -->'); // Emtpy
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
media = view.el.querySelector('.chat-msg:last-child .chat-msg__media');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(media.innerHTML.replace(/(\r\n|\n|\r)/gm, "")).toEqual(
'<!-- src/templates/video.html -->'+
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'<video controls="" src="https://montague.lit/video.mp4" style="max-height: 50vh"></video>'+
'<a target="_blank" rel="noopener" href="https://montague.lit/video.mp4">Download video file "video.mp4"</a>');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
}));
it("will render download links for files from oob URLs",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Wait for promises before opening chats in API methods
2018-07-30 18:16:32 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, contact_jid);
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(contact_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
spyOn(view.model, 'sendMessage').and.callThrough();
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
const stanza = u.toStanza(`
<message from="${contact_jid}"
type="chat"
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to="romeo@montague.lit/orchard">
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
<body>Have you downloaded this funny file?</body>
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
<x xmlns="jabber:x:oob"><url>https://montague.lit/funny.pdf</url></x>
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
</message>`);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
await test_utils.waitUntil(() => view.el.querySelectorAll('.chat-content .chat-msg a').length, 1000);
const msg = view.el.querySelector('.chat-msg .chat-msg__text');
Fixes #1400. When chat message is only an emoji, enlarge it
2019-02-27 10:34:47 +01:00
expect(u.hasClass('chat-msg__text', msg)).toBe(true);
expect(msg.textContent).toEqual('Have you downloaded this funny file?');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const media = view.el.querySelector('.chat-msg .chat-msg__media');
expect(media.innerHTML.replace(/(\r\n|\n|\r)/gm, "")).toEqual(
'<!-- src/templates/file.html -->'+
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'<a target="_blank" rel="noopener" href="https://montague.lit/funny.pdf">Download file "funny.pdf"</a>');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
}));
it("will render images from oob URLs",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Use async/await
2018-11-20 18:10:55 +01:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
Don't render http (i.e. non-TLS) resources Causes "Mixed Content" TLS errors
2018-11-18 15:56:14 +01:00
const base_url = 'https://conversejs.org';
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Use async/await
2018-11-20 18:10:55 +01:00
await test_utils.openChatBoxFor(_converse, contact_jid)
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(contact_jid);
Use async/await
2018-11-20 18:10:55 +01:00
spyOn(view.model, 'sendMessage').and.callThrough();
const url = base_url+"/logo/conversejs-filled.svg";
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
const stanza = u.toStanza(`
<message from="${contact_jid}"
type="chat"
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to="romeo@montague.lit/orchard">
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
<body>Have you seen this funny image?</body>
<x xmlns="jabber:x:oob"><url>${url}</url></x>
</message>`);
Use async/await
2018-11-20 18:10:55 +01:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await test_utils.waitUntil(() => view.el.querySelectorAll('.chat-content .chat-msg img').length, 2000);
const msg = view.el.querySelector('.chat-msg .chat-msg__text');
Fixes #1400. When chat message is only an emoji, enlarge it
2019-02-27 10:34:47 +01:00
expect(u.hasClass('chat-msg__text', msg)).toBe(true);
expect(msg.textContent).toEqual('Have you seen this funny image?');
Use async/await
2018-11-20 18:10:55 +01:00
const media = view.el.querySelector('.chat-msg .chat-msg__media');
expect(media.innerHTML.replace(/(\r\n|\n|\r)/gm, "")).toEqual(
`<!-- src/templates/image.html -->`+
`<a href="${base_url}/logo/conversejs-filled.svg" target="_blank" rel="noopener">`+
`<img class="chat-image img-thumbnail" src="${base_url}/logo/conversejs-filled.svg">`+
`</a>`);
done();
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
}));
});
});
Add test for groupchat message corrections
2018-07-07 14:20:49 +02:00
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
describe("A XEP-0333 Chat Marker", function () {
Don't send markers to someone not on your roster Updates #324
2019-02-13 19:31:05 +01:00
it("is sent when a markable message is received from a roster contact",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
await test_utils.openChatBoxFor(_converse, contact_jid);
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(contact_jid);
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
const msgid = u.getUniqueId();
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
const stanza = u.toStanza(`
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
<message from='${contact_jid}'
id='${msgid}'
type="chat"
to='${_converse.jid}'>
<body>My lord, dispatch; read o'er these articles.</body>
<markable xmlns='urn:xmpp:chat-markers:0'/>
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
</message>`);
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
const sent_stanzas = [];
spyOn(_converse.connection, 'send').and.callFake(s => sent_stanzas.push(s));
spyOn(view.model, 'sendMarker').and.callThrough();
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await test_utils.waitUntil(() => view.model.sendMarker.calls.count() === 1);
expect(Strophe.serialize(sent_stanzas[0])).toBe(
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
`<message from="romeo@montague.lit/orchard" `+
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
`id="${sent_stanzas[0].nodeTree.getAttribute('id')}" `+
`to="${contact_jid}" type="chat" xmlns="jabber:client">`+
`<received id="${msgid}" xmlns="urn:xmpp:chat-markers:0"/>`+
`</message>`);
done();
}));
Don't send markers to someone not on your roster Updates #324
2019-02-13 19:31:05 +01:00
it("is not sent when a markable message is received from someone not on the roster",
mock.initConverse(
null, ['rosterGroupsFetched'], {'allow_non_roster_messaging': true},
async function (done, _converse) {
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
_converse.api.trigger('rosterContactsFetched');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = 'someone@montague.lit';
Don't send markers to someone not on your roster Updates #324
2019-02-13 19:31:05 +01:00
const msgid = u.getUniqueId();
const stanza = u.toStanza(`
<message from='${contact_jid}'
id='${msgid}'
type="chat"
to='${_converse.jid}'>
<body>My lord, dispatch; read o'er these articles.</body>
<markable xmlns='urn:xmpp:chat-markers:0'/>
</message>`);
const sent_stanzas = [];
spyOn(_converse.connection, 'send').and.callFake(s => sent_stanzas.push(s));
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await test_utils.waitUntil(() => _converse.api.chats.get().length == 2);
const sent_messages = sent_stanzas
.map(s => _.isElement(s) ? s : s.nodeTree)
.filter(e => e.nodeName === 'message');
// Only one message is sent out, and it's not a chat marker
expect(sent_messages.length).toBe(1);
expect(Strophe.serialize(sent_messages[0])).toBe(
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
`<message id="${sent_messages[0].getAttribute('id')}" to="someone@montague.lit" type="chat" xmlns="jabber:client">`+
Don't send markers to someone not on your roster Updates #324
2019-02-13 19:31:05 +01:00
`<active xmlns="http://jabber.org/protocol/chatstates"/>`+
`<no-store xmlns="urn:xmpp:hints"/>`+
`<no-permanent-store xmlns="urn:xmpp:hints"/>`+
`</message>`);
done();
}));
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
it("is ignored if it's a carbon copy of one that I sent from a different client",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Also check for duplicates in one-on-one messages
2019-02-14 13:43:24 +01:00
await test_utils.waitUntilDiscoConfirmed(_converse, _converse.bare_jid, [], [Strophe.NS.SID]);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
await test_utils.openChatBoxFor(_converse, contact_jid);
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(contact_jid);
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
let stanza = u.toStanza(`
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
<message xmlns="jabber:client"
to="${_converse.bare_jid}"
type="chat"
id="2e972ea0-0050-44b7-a830-f6638a2595b3"
from="${contact_jid}">
<body>😊</body>
<markable xmlns="urn:xmpp:chat-markers:0"/>
<origin-id xmlns="urn:xmpp:sid:0" id="2e972ea0-0050-44b7-a830-f6638a2595b3"/>
<stanza-id xmlns="urn:xmpp:sid:0" id="IxVDLJ0RYbWcWvqC" by="${_converse.bare_jid}"/>
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
</message>`);
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.model.messages.length).toBe(1);
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
stanza = u.toStanza(
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
`<message xmlns="jabber:client" to="${_converse.bare_jid}" type="chat" from="${contact_jid}">
<sent xmlns="urn:xmpp:carbons:2">
<forwarded xmlns="urn:xmpp:forward:0">
<message xmlns="jabber:client" to="${contact_jid}" type="chat" from="${_converse.bare_jid}/other-resource">
<received xmlns="urn:xmpp:chat-markers:0" id="2e972ea0-0050-44b7-a830-f6638a2595b3"/>
<store xmlns="urn:xmpp:hints"/>
<stanza-id xmlns="urn:xmpp:sid:0" id="F4TC6CvHwzqRbeHb" by="jc@opkode.com"/>
</message>
</forwarded>
</sent>
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
</message>`);
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
spyOn(_converse.api, "trigger").and.callThrough();
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
await test_utils.waitUntil(() => _converse.api.trigger.calls.count() === 1);
Initial support for chat markers. Updates #324
2019-01-31 19:22:30 +01:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.model.messages.length).toBe(1);
done();
}));
});
Add test for groupchat message corrections
2018-07-07 14:20:49 +02:00
describe("A Groupchat Message", function () {
Bugfix. Own groupchat messages weren't being recognized
2018-08-01 18:30:19 +02:00
it("is specially marked when you are mentioned in it",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Bugfix. Own groupchat messages weren't being recognized
2018-08-01 18:30:19 +02:00
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'romeo');
const view = _converse.api.chatviews.get('lounge@montague.lit');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
if (!view.el.querySelectorAll('.chat-area').length) { view.renderChatArea(); }
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const message = 'romeo: Your attention is required';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const nick = mock.chatroom_names[0],
msg = $msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
from: 'lounge@montague.lit/'+nick,
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
id: (new Date()).getTime(),
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to: 'romeo@montague.lit',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
type: 'groupchat'
}).c('body').t(message).tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await view.model.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
expect(u.hasClass('mentioned', view.el.querySelector('.chat-msg'))).toBeTruthy();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Bugfix. Own groupchat messages weren't being recognized
2018-08-01 18:30:19 +02:00
}));
Fix failing tests
2019-02-13 15:24:24 +01:00
it("can not be expected to have a unique id attribute",
mock.initConverse(
null, ['rosterGroupsFetched', 'chatBoxesFetched'], {},
async function (done, _converse) {
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'romeo');
const view = _converse.chatboxviews.get('lounge@montague.lit');
Fix failing tests
2019-02-13 15:24:24 +01:00
if (!view.el.querySelectorAll('.chat-area').length) { view.renderChatArea(); }
const id = u.getUniqueId();
let msg = $msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
from: 'lounge@montague.lit/some1',
Fix failing tests
2019-02-13 15:24:24 +01:00
id: id,
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to: 'romeo@montague.lit',
Fix failing tests
2019-02-13 15:24:24 +01:00
type: 'groupchat'
}).c('body').t('First message').tree();
await view.model.onMessage(msg);
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
msg = $msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
from: 'lounge@montague.lit/some2',
Fix failing tests
2019-02-13 15:24:24 +01:00
id: id,
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to: 'romeo@montague.lit',
Fix failing tests
2019-02-13 15:24:24 +01:00
type: 'groupchat'
}).c('body').t('Another message').tree();
await view.model.onMessage(msg);
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(2);
done();
}));
XEP-0359: Better usage of `stanza-id` to check for dupes
2019-02-13 22:06:14 +01:00
it("is ignored if it has the same stanza-id of an already received on",
mock.initConverse(
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'room', 'muc.example.com', 'romeo');
XEP-0359: Better usage of `stanza-id` to check for dupes
2019-02-13 22:06:14 +01:00
const view = _converse.chatboxviews.get('room@muc.example.com');
No need for a separate `archive_id` value. With MAM2 we can just use stanza-id
2019-03-07 15:44:58 +01:00
spyOn(view.model, 'findDuplicateFromStanzaID').and.callThrough();
XEP-0359: Better usage of `stanza-id` to check for dupes
2019-02-13 22:06:14 +01:00
let stanza = u.toStanza(`
<message xmlns="jabber:client"
from="room@muc.example.com/some1"
to="${_converse.connection.jid}"
type="groupchat">
<body>Typical body text</body>
<stanza-id xmlns="urn:xmpp:sid:0"
id="5f3dbc5e-e1d3-4077-a492-693f3769c7ad"
by="room@muc.example.com"/>
</message>`);
_converse.connection._dataRecv(test_utils.createRequest(stanza));
await test_utils.waitUntil(() => _converse.api.chats.get().length);
await test_utils.waitUntil(() => view.model.messages.length === 1);
No need for a separate `archive_id` value. With MAM2 we can just use stanza-id
2019-03-07 15:44:58 +01:00
await test_utils.waitUntil(() => view.model.findDuplicateFromStanzaID.calls.count() === 1);
let result = await view.model.findDuplicateFromStanzaID.calls.all()[0].returnValue;
expect(result).toBe(undefined);
XEP-0359: Better usage of `stanza-id` to check for dupes
2019-02-13 22:06:14 +01:00
stanza = u.toStanza(`
<message xmlns="jabber:client"
from="room@muc.example.com/some1"
to="${_converse.connection.jid}"
type="groupchat">
<body>Typical body text</body>
<stanza-id xmlns="urn:xmpp:sid:0"
id="5f3dbc5e-e1d3-4077-a492-693f3769c7ad"
by="room@muc.example.com"/>
</message>`);
Clear messages when closing a chat
2019-05-16 08:24:25 +02:00
spyOn(view.model, 'updateMessage');
XEP-0359: Better usage of `stanza-id` to check for dupes
2019-02-13 22:06:14 +01:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
No need for a separate `archive_id` value. With MAM2 we can just use stanza-id
2019-03-07 15:44:58 +01:00
await test_utils.waitUntil(() => view.model.findDuplicateFromStanzaID.calls.count() === 2);
result = await view.model.findDuplicateFromStanzaID.calls.all()[1].returnValue;
expect(result instanceof _converse.Message).toBe(true);
XEP-0359: Better usage of `stanza-id` to check for dupes
2019-02-13 22:06:14 +01:00
expect(view.model.messages.length).toBe(1);
Clear messages when closing a chat
2019-05-16 08:24:25 +02:00
await test_utils.waitUntil(() => view.model.updateMessage.calls.count());
XEP-0359: Better usage of `stanza-id` to check for dupes
2019-02-13 22:06:14 +01:00
done();
}));
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
it("keeps track of the sender's role and affiliation",
mock.initConverse(
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'romeo');
const view = _converse.api.chatviews.get('lounge@montague.lit');
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
let msg = $msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
from: 'lounge@montague.lit/romeo',
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
id: (new Date()).getTime(),
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to: 'romeo@montague.lit',
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
type: 'groupchat'
}).c('body').t('I wrote this message!').tree();
await view.model.onMessage(msg);
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Associate `ChatRoomOccupant` to `ChatRoomMessage` and use promises to indicate when an occupant or contact has been set
2019-07-01 10:44:59 +02:00
expect(view.model.messages.last().occupant.get('affiliation')).toBe('owner');
expect(view.model.messages.last().occupant.get('role')).toBe('moderator');
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
Message display improvements * Checkmark and edit modal button are now on the right * Instead of showing checkmarks for MUC messages, we now show them as light grey before MUC reflection * Simplify message markup by requiring less `if` statements
2019-06-03 21:53:19 +02:00
expect(sizzle('.chat-msg__author', view.el).pop().classList.value.trim()).toBe('chat-msg__author moderator');
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
let presence = $pres({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to:'romeo@montague.lit/orchard',
from:'lounge@montague.lit/romeo',
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
id: u.getUniqueId()
}).c('x').attrs({xmlns:'http://jabber.org/protocol/muc#user'})
.c('item').attrs({
affiliation: 'member',
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
jid: 'romeo@montague.lit/orchard',
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
role: 'participant'
}).up()
.c('status').attrs({code:'110'}).up()
.c('status').attrs({code:'210'}).nodeTree;
_converse.connection._dataRecv(test_utils.createRequest(presence));
msg = $msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
from: 'lounge@montague.lit/romeo',
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
id: (new Date()).getTime(),
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to: 'romeo@montague.lit',
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
type: 'groupchat'
}).c('body').t('Another message!').tree();
await view.model.onMessage(msg);
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Associate `ChatRoomOccupant` to `ChatRoomMessage` and use promises to indicate when an occupant or contact has been set
2019-07-01 10:44:59 +02:00
expect(view.model.messages.last().occupant.get('affiliation')).toBe('member');
expect(view.model.messages.last().occupant.get('role')).toBe('participant');
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(2);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
expect(sizzle('.chat-msg__author', view.el).pop().classList.value.trim()).toBe('chat-msg__author participant');
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
presence = $pres({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to:'romeo@montague.lit/orchard',
from:'lounge@montague.lit/romeo',
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
id: u.getUniqueId()
}).c('x').attrs({xmlns:'http://jabber.org/protocol/muc#user'})
.c('item').attrs({
affiliation: 'owner',
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
jid: 'romeo@montague.lit/orchard',
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
role: 'moderator'
}).up()
.c('status').attrs({code:'110'}).up()
.c('status').attrs({code:'210'}).nodeTree;
_converse.connection._dataRecv(test_utils.createRequest(presence));
view.model.sendMessage('hello world');
converse-muc: Create `info` and `error` messages on the model instead of on the view.
2019-06-11 12:16:27 +02:00
await test_utils.waitUntil(() => view.el.querySelectorAll('.chat-msg').length === 3);
Associate `ChatRoomOccupant` to `ChatRoomMessage` and use promises to indicate when an occupant or contact has been set
2019-07-01 10:44:59 +02:00
expect(view.model.messages.last().occupant.get('affiliation')).toBe('owner');
expect(view.model.messages.last().occupant.get('role')).toBe('moderator');
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(3);
Message display improvements * Checkmark and edit modal button are now on the right * Instead of showing checkmarks for MUC messages, we now show them as light grey before MUC reflection * Simplify message markup by requiring less `if` statements
2019-06-03 21:53:19 +02:00
expect(sizzle('.chat-msg__author', view.el).pop().classList.value.trim()).toBe('chat-msg__author moderator');
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
done();
}));
Bugfix. Own groupchat messages weren't being recognized
2018-08-01 18:30:19 +02:00
it("keeps track whether you are the sender or not",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
Bugfix. Own groupchat messages weren't being recognized
2018-08-01 18:30:19 +02:00
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'romeo');
const view = _converse.api.chatviews.get('lounge@montague.lit');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const msg = $msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
from: 'lounge@montague.lit/romeo',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
id: (new Date()).getTime(),
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to: 'romeo@montague.lit',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
type: 'groupchat'
}).c('body').t('I wrote this message!').tree();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await view.model.onMessage(msg);
Add class on MUC message to indicate author's role
2019-05-13 20:10:48 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(view.model.messages.last().get('sender')).toBe('me');
done();
Bugfix. Own groupchat messages weren't being recognized
2018-08-01 18:30:19 +02:00
}));
Add test for groupchat message corrections
2018-07-07 14:20:49 +02:00
it("can be replaced with a correction",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Add test for groupchat message corrections
2018-07-07 14:20:49 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'romeo');
const jid = 'lounge@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const room = _converse.api.rooms.get(jid);
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const stanza = $pres({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to: 'romeo@montague.lit/_converse.js-29092160',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
from: 'coven@chat.shakespeare.lit/newguy'
})
.c('x', {xmlns: Strophe.NS.MUC_USER})
.c('item', {
'affiliation': 'none',
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'jid': 'newguy@montague.lit/_converse.js-290929789',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'role': 'participant'
}).tree();
_converse.connection._dataRecv(test_utils.createRequest(stanza));
const msg_id = u.getUniqueId();
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await view.model.onMessage($msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'from': 'lounge@montague.lit/newguy',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'to': _converse.connection.jid,
'type': 'groupchat',
'id': msg_id,
}).c('body').t('But soft, what light through yonder airlock breaks?').tree());
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelector('.chat-msg__text').textContent)
.toBe('But soft, what light through yonder airlock breaks?');
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await view.model.onMessage($msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'from': 'lounge@montague.lit/newguy',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'to': _converse.connection.jid,
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
'type': 'groupchat',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'id': u.getUniqueId(),
}).c('body').t('But soft, what light through yonder chimney breaks?').up()
.c('replace', {'id': msg_id, 'xmlns': 'urn:xmpp:message-correct:0'}).tree());
await test_utils.waitUntil(() => view.el.querySelector('.chat-msg__text').textContent ===
Prioritize roster nickname as message and chatbox display name Set reference to roster contact on the message and chatbox object and listen for changes to the nickname. Currently, because chat boxes are fetched and initialized before the roster, messages and chats are repainted with the correct display name only later, causing a "flash" effect. Ideally we would only initialize the chat boxes after the roster contacts have been fetched, but this is currently not easily possible because we need the control box to render before everything else.
2019-04-09 17:10:50 +02:00
'But soft, what light through yonder chimney breaks?', 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelectorAll('.chat-msg__content .fa-edit').length).toBe(1);
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await view.model.onMessage($msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'from': 'lounge@montague.lit/newguy',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'to': _converse.connection.jid,
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
'type': 'groupchat',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'id': u.getUniqueId(),
}).c('body').t('But soft, what light through yonder window breaks?').up()
.c('replace', {'id': msg_id, 'xmlns': 'urn:xmpp:message-correct:0'}).tree());
Add test for groupchat message corrections
2018-07-07 14:20:49 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.waitUntil(() => view.el.querySelector('.chat-msg__text').textContent ===
Prioritize roster nickname as message and chatbox display name Set reference to roster contact on the message and chatbox object and listen for changes to the nickname. Currently, because chat boxes are fetched and initialized before the roster, messages and chats are repainted with the correct display name only later, causing a "flash" effect. Ideally we would only initialize the chat boxes after the roster contacts have been fetched, but this is currently not easily possible because we need the control box to render before everything else.
2019-04-09 17:10:50 +02:00
'But soft, what light through yonder window breaks?', 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelectorAll('.chat-msg__content .fa-edit').length).toBe(1);
view.el.querySelector('.chat-msg__content .fa-edit').click();
const modal = view.model.messages.at(0).message_versions_modal;
await test_utils.waitUntil(() => u.isVisible(modal.el), 1000);
const older_msgs = modal.el.querySelectorAll('.older-msg');
expect(older_msgs.length).toBe(2);
Refactor message corrections - Save date for older message versions and display it in the modal - Properly handle the correction being received *before* the corrected message
2019-05-21 16:18:14 +02:00
expect(older_msgs[0].childNodes[1].textContent).toBe(': But soft, what light through yonder airlock breaks?');
expect(older_msgs[0].childNodes[0].nodeName).toBe('TIME');
expect(older_msgs[1].childNodes[0].nodeName).toBe('TIME');
expect(older_msgs[1].childNodes[1].textContent).toBe(': But soft, what light through yonder chimney breaks?');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Add test for groupchat message corrections
2018-07-07 14:20:49 +02:00
}));
Cancel message correction by pressing the down arrow Also, add a class `correcting` to the message being corrected, to provide a visual cue. updates #421
2018-07-08 10:13:15 +02:00
Allow messages to be edited by clicking a pencil icon updates #421
2018-07-21 10:41:10 +02:00
it("can be sent as a correction by using the up arrow",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Cancel message correction by pressing the down arrow Also, add a class `correcting` to the message being corrected, to provide a visual cue. updates #421
2018-07-08 10:13:15 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'romeo');
const room_jid = 'lounge@montague.lit';
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const room = _converse.api.rooms.get(room_jid);
Use the API in tests
2019-02-22 21:43:49 +01:00
const view = _converse.api.chatviews.get(room_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const textarea = view.el.querySelector('textarea.chat-textarea');
expect(textarea.value).toBe('');
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
keyCode: 38 // Up arrow
});
expect(textarea.value).toBe('');
Only own messages should be editable. Fixes #1139
2018-07-21 08:12:33 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
textarea.value = 'But soft, what light through yonder airlock breaks?';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelector('.chat-msg__text').textContent)
.toBe('But soft, what light through yonder airlock breaks?');
const first_msg = view.model.messages.findWhere({'message': 'But soft, what light through yonder airlock breaks?'});
expect(textarea.value).toBe('');
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
keyCode: 38 // Up arrow
});
await new Promise((resolve, reject) => view.model.messages.once('rendered', resolve));
expect(textarea.value).toBe('But soft, what light through yonder airlock breaks?');
expect(view.model.messages.at(0).get('correcting')).toBe(true);
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(u.hasClass('correcting', view.el.querySelector('.chat-msg'))).toBe(true);
spyOn(_converse.connection, 'send');
textarea.value = 'But soft, what light through yonder window breaks?';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
expect(_converse.connection.send).toHaveBeenCalled();
await new Promise((resolve, reject) => view.model.messages.once('rendered', resolve));
const msg = _converse.connection.send.calls.all()[0].args[0];
expect(msg.toLocaleString())
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.toBe(`<message from="romeo@montague.lit/orchard" id="${msg.nodeTree.getAttribute("id")}" `+
`to="lounge@montague.lit" type="groupchat" `+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`xmlns="jabber:client">`+
`<body>But soft, what light through yonder window breaks?</body>`+
`<active xmlns="http://jabber.org/protocol/chatstates"/>`+
`<replace id="${first_msg.get("msgid")}" xmlns="urn:xmpp:message-correct:0"/>`+
Include `origin-id` in outgoing messages
2019-02-07 14:15:49 +01:00
`<origin-id id="${msg.nodeTree.querySelector('origin-id').getAttribute("id")}" xmlns="urn:xmpp:sid:0"/>`+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`</message>`);
expect(view.model.messages.models.length).toBe(1);
const corrected_message = view.model.messages.at(0);
expect(corrected_message.get('msgid')).toBe(first_msg.get('msgid'));
expect(corrected_message.get('correcting')).toBe(false);
Refactor message corrections - Save date for older message versions and display it in the modal - Properly handle the correction being received *before* the corrected message
2019-05-21 16:18:14 +02:00
const older_versions = corrected_message.get('older_versions');
const keys = Object.keys(older_versions);
expect(keys.length).toBe(1);
expect(older_versions[keys[0]]).toBe('But soft, what light through yonder airlock breaks?');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(u.hasClass('correcting', view.el.querySelector('.chat-msg'))).toBe(false);
// Check that messages from other users are skipped
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await view.model.onMessage($msg({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'from': room_jid+'/someone-else',
'id': (new Date()).getTime(),
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'to': 'romeo@montague.lit',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'type': 'groupchat'
}).c('body').t('Hello world').tree());
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(2);
// Test that pressing the down arrow cancels message correction
expect(textarea.value).toBe('');
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
keyCode: 38 // Up arrow
});
expect(textarea.value).toBe('But soft, what light through yonder window breaks?');
expect(view.model.messages.at(0).get('correcting')).toBe(true);
expect(view.el.querySelectorAll('.chat-msg').length).toBe(2);
Revert `flexbox`, `column-reverse` changes Unfortunately this doesn't work on Firefox and there's no proper workaround. https://github.com/philipwalton/flexbugs/issues/108 Reverts: Revert "Bugfix. Properly insert error messages and spinner" This reverts commit 6a419cc145f939d5fc6a2c70a3f64f2913395770. Revert "Use flexbox to keep the chat scrolled down" This reverts commit dd91d3cc55cda7e111647b32f1a75bc13cd8b9fe.
2019-06-19 11:04:09 +02:00
await test_utils.waitUntil(() => u.hasClass('correcting', view.el.querySelector('.chat-msg')), 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(textarea.value).toBe('But soft, what light through yonder window breaks?');
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
keyCode: 40 // Down arrow
});
expect(textarea.value).toBe('');
expect(view.model.messages.at(0).get('correcting')).toBe(false);
expect(view.el.querySelectorAll('.chat-msg').length).toBe(2);
Prioritize roster nickname as message and chatbox display name Set reference to roster contact on the message and chatbox object and listen for changes to the nickname. Currently, because chat boxes are fetched and initialized before the roster, messages and chats are repainted with the correct display name only later, causing a "flash" effect. Ideally we would only initialize the chat boxes after the roster contacts have been fetched, but this is currently not easily possible because we need the control box to render before everything else.
2019-04-09 17:10:50 +02:00
await test_utils.waitUntil(() => !u.hasClass('correcting', view.el.querySelector('.chat-msg')), 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Cancel message correction by pressing the down arrow Also, add a class `correcting` to the message being corrected, to provide a visual cue. updates #421
2018-07-08 10:13:15 +02:00
}));
Inlcude references in the outgoing XMPP stanza
2018-08-16 09:44:14 +02:00
Fixes #1442
2019-02-12 19:10:46 +01:00
it("will be shown as received upon MUC reflection",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'romeo');
const view = _converse.chatboxviews.get('lounge@montague.lit');
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
const textarea = view.el.querySelector('textarea.chat-textarea');
textarea.value = 'But soft, what light through yonder airlock breaks?';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Message display improvements * Checkmark and edit modal button are now on the right * Instead of showing checkmarks for MUC messages, we now show them as light grey before MUC reflection * Simplify message markup by requiring less `if` statements
2019-06-03 21:53:19 +02:00
expect(view.el.querySelectorAll('.chat-msg__body.chat-msg__body--received').length).toBe(0);
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
const msg_obj = view.model.messages.at(0);
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
const stanza = u.toStanza(`
<message xmlns="jabber:client"
from="${msg_obj.get('from')}"
to="${_converse.connection.jid}"
type="groupchat">
Message display improvements * Checkmark and edit modal button are now on the right * Instead of showing checkmarks for MUC messages, we now show them as light grey before MUC reflection * Simplify message markup by requiring less `if` statements
2019-06-03 21:53:19 +02:00
<msg_body>${msg_obj.get('message')}</msg_body>
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
<stanza-id xmlns="urn:xmpp:sid:0"
id="5f3dbc5e-e1d3-4077-a492-693f3769c7ad"
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
by="lounge@montague.lit"/>
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
<origin-id xmlns="urn:xmpp:sid:0" id="${msg_obj.get('origin_id')}"/>
</message>`);
await view.model.onMessage(stanza);
Message display improvements * Checkmark and edit modal button are now on the right * Instead of showing checkmarks for MUC messages, we now show them as light grey before MUC reflection * Simplify message markup by requiring less `if` statements
2019-06-03 21:53:19 +02:00
await test_utils.waitUntil(() => view.el.querySelectorAll('.chat-msg__body.chat-msg__body--received').length, 500);
expect(view.el.querySelectorAll('.chat-msg__receipt').length).toBe(0);
expect(view.el.querySelectorAll('.chat-msg__body.chat-msg__body--received').length).toBe(1);
No need for a separate `archive_id` value. With MAM2 we can just use stanza-id
2019-03-07 15:44:58 +01:00
expect(view.model.messages.length).toBe(1);
const message = view.model.messages.at(0);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
expect(message.get('stanza_id lounge@montague.lit')).toBe('5f3dbc5e-e1d3-4077-a492-693f3769c7ad');
No need for a separate `archive_id` value. With MAM2 we can just use stanza-id
2019-03-07 15:44:58 +01:00
expect(message.get('origin_id')).toBe(msg_obj.get('origin_id'));
implement XEP-0184: Message Delivery Receipts
2018-11-03 14:37:57 +01:00
done();
}));
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
it("gets updated with its stanza-id upon MUC reflection",
mock.initConverse(
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'room', 'muc.example.com', 'romeo');
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
const view = _converse.chatboxviews.get('room@muc.example.com');
Document `_converse.ChatBox.prototype.sendMessage` as an API method Until now, we've only been explicitly documenting the `_converse.api` namespace and only considered the methods under it as forming the API contract (which determines how we do semver releases). It appears as if we've reached a point where trying to keep everything under the `_converse.api` namespace no longer makes sense. Certain methods are applicable to particular models and trying to shoehorn them into the `_converse.api` namespace seems clunky and non-intuitive. I've therefore decided to slightly refactor `sendMessage` to let it take two simple parameters and to document it with JSDoc so that it's presented as an API method, albeit only available on a chat model. updates #1496 updates #1504
2019-03-21 20:55:07 +01:00
view.model.sendMessage('hello world');
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
await test_utils.waitUntil(() => _converse.api.chats.get().length);
await test_utils.waitUntil(() => view.model.messages.length === 1);
Document `_converse.ChatBox.prototype.sendMessage` as an API method Until now, we've only been explicitly documenting the `_converse.api` namespace and only considered the methods under it as forming the API contract (which determines how we do semver releases). It appears as if we've reached a point where trying to keep everything under the `_converse.api` namespace no longer makes sense. Certain methods are applicable to particular models and trying to shoehorn them into the `_converse.api` namespace seems clunky and non-intuitive. I've therefore decided to slightly refactor `sendMessage` to let it take two simple parameters and to document it with JSDoc so that it's presented as an API method, albeit only available on a chat model. updates #1496 updates #1504
2019-03-21 20:55:07 +01:00
const msg = view.model.messages.at(0);
expect(msg.get('stanza_id')).toBeUndefined();
expect(msg.get('origin_id')).toBe(msg.get('origin_id'));
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
const stanza = u.toStanza(`
<message xmlns="jabber:client"
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
from="room@muc.example.com/romeo"
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
to="${_converse.connection.jid}"
type="groupchat">
<body>Hello world</body>
<stanza-id xmlns="urn:xmpp:sid:0"
id="5f3dbc5e-e1d3-4077-a492-693f3769c7ad"
by="room@muc.example.com"/>
Document `_converse.ChatBox.prototype.sendMessage` as an API method Until now, we've only been explicitly documenting the `_converse.api` namespace and only considered the methods under it as forming the API contract (which determines how we do semver releases). It appears as if we've reached a point where trying to keep everything under the `_converse.api` namespace no longer makes sense. Certain methods are applicable to particular models and trying to shoehorn them into the `_converse.api` namespace seems clunky and non-intuitive. I've therefore decided to slightly refactor `sendMessage` to let it take two simple parameters and to document it with JSDoc so that it's presented as an API method, albeit only available on a chat model. updates #1496 updates #1504
2019-03-21 20:55:07 +01:00
<origin-id xmlns="urn:xmpp:sid:0" id="${msg.get('origin_id')}"/>
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
</message>`);
No need for a separate `archive_id` value. With MAM2 we can just use stanza-id
2019-03-07 15:44:58 +01:00
spyOn(view.model, 'updateMessage').and.callThrough();
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
No need for a separate `archive_id` value. With MAM2 we can just use stanza-id
2019-03-07 15:44:58 +01:00
await test_utils.waitUntil(() => view.model.updateMessage.calls.count() === 1);
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
expect(view.model.messages.length).toBe(1);
Add support for handling multiple `stanza-id` elements
2019-02-14 12:13:07 +01:00
expect(view.model.messages.at(0).get('stanza_id room@muc.example.com')).toBe("5f3dbc5e-e1d3-4077-a492-693f3769c7ad");
Document `_converse.ChatBox.prototype.sendMessage` as an API method Until now, we've only been explicitly documenting the `_converse.api` namespace and only considered the methods under it as forming the API contract (which determines how we do semver releases). It appears as if we've reached a point where trying to keep everything under the `_converse.api` namespace no longer makes sense. Certain methods are applicable to particular models and trying to shoehorn them into the `_converse.api` namespace seems clunky and non-intuitive. I've therefore decided to slightly refactor `sendMessage` to let it take two simple parameters and to document it with JSDoc so that it's presented as an API method, albeit only available on a chat model. updates #1496 updates #1504
2019-03-21 20:55:07 +01:00
expect(view.model.messages.at(0).get('origin_id')).toBe(msg.get('origin_id'));
Use `origin-id` to check for reflected messages. Also, store the returned `stanza-id` on the message.
2019-02-14 11:32:45 +01:00
done();
}));
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
it("can cause a delivery receipt to be returned",
Fixes #1442
2019-02-12 19:10:46 +01:00
mock.initConverse(
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'romeo');
const view = _converse.chatboxviews.get('lounge@montague.lit');
Fixes #1442
2019-02-12 19:10:46 +01:00
const textarea = view.el.querySelector('textarea.chat-textarea');
textarea.value = 'But soft, what light through yonder airlock breaks?';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Fixes #1442
2019-02-12 19:10:46 +01:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
const msg_obj = view.model.messages.at(0);
const stanza = u.toStanza(`
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
<message xml:lang="en" to="romeo@montague.lit/orchard"
from="lounge@montague.lit/some1" type="groupchat" xmlns="jabber:client">
Fixes #1442
2019-02-12 19:10:46 +01:00
<received xmlns="urn:xmpp:receipts" id="${msg_obj.get('msgid')}"/>
<origin-id xmlns="urn:xmpp:sid:0" id="CE08D448-5ED8-4B6A-BB5B-07ED9DFE4FF0"/>
</message>`);
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
spyOn(_converse.api, "trigger").and.callThrough();
Fetch messages in MUC model
2019-05-19 22:11:26 +02:00
spyOn(view.model, "isReceipt").and.callThrough();
Fixes #1442
2019-02-12 19:10:46 +01:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
Fetch messages in MUC model
2019-05-19 22:11:26 +02:00
await test_utils.waitUntil(() => view.model.isReceipt.calls.count() === 1);
Fixes #1442
2019-02-12 19:10:46 +01:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelectorAll('.chat-msg__receipt').length).toBe(0);
Rename `emit` to `trigger` for consistency with Backbone.Events
2019-03-29 21:10:45 +01:00
expect(_converse.api.trigger).toHaveBeenCalledWith('message', jasmine.any(Object));
Fixes #1442
2019-02-12 19:10:46 +01:00
done();
}));
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
it("can cause a chat marker to be returned",
mock.initConverse(
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'romeo');
const view = _converse.chatboxviews.get('lounge@montague.lit');
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
const textarea = view.el.querySelector('textarea.chat-textarea');
textarea.value = 'But soft, what light through yonder airlock breaks?';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
target: textarea,
preventDefault: _.noop,
keyCode: 13 // Enter
});
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
Change `muc_show_disconnection_status` to `muc_show_join_leave_status`
2019-05-18 06:33:42 +02:00
expect(view.el.querySelector('.chat-msg .chat-msg__body').textContent.trim())
.toBe("But soft, what light through yonder airlock breaks?");
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
const msg_obj = view.model.messages.at(0);
let stanza = u.toStanza(`
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
<message xml:lang="en" to="romeo@montague.lit/orchard"
from="lounge@montague.lit/some1" type="groupchat" xmlns="jabber:client">
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
<received xmlns="urn:xmpp:chat-markers:0" id="${msg_obj.get('msgid')}"/>
</message>`);
Fetch messages in MUC model
2019-05-19 22:11:26 +02:00
spyOn(view.model, "isChatMarker").and.callThrough();
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
_converse.connection._dataRecv(test_utils.createRequest(stanza));
Fetch messages in MUC model
2019-05-19 22:11:26 +02:00
await test_utils.waitUntil(() => view.model.isChatMarker.calls.count() === 1);
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelectorAll('.chat-msg__receipt').length).toBe(0);
stanza = u.toStanza(`
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
<message xml:lang="en" to="romeo@montague.lit/orchard"
from="lounge@montague.lit/some1" type="groupchat" xmlns="jabber:client">
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
<displayed xmlns="urn:xmpp:chat-markers:0" id="${msg_obj.get('msgid')}"/>
</message>`);
_converse.connection._dataRecv(test_utils.createRequest(stanza));
Fetch messages in MUC model
2019-05-19 22:11:26 +02:00
await test_utils.waitUntil(() => view.model.isChatMarker.calls.count() === 2);
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelectorAll('.chat-msg__receipt').length).toBe(0);
stanza = u.toStanza(`
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
<message xml:lang="en" to="romeo@montague.lit/orchard"
from="lounge@montague.lit/some1" type="groupchat" xmlns="jabber:client">
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
<acknowledged xmlns="urn:xmpp:chat-markers:0" id="${msg_obj.get('msgid')}"/>
</message>`);
_converse.connection._dataRecv(test_utils.createRequest(stanza));
Clear messages when closing a chat
2019-05-16 08:24:25 +02:00
Fetch messages in MUC model
2019-05-19 22:11:26 +02:00
await test_utils.waitUntil(() => view.model.isChatMarker.calls.count() === 3);
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
expect(view.el.querySelectorAll('.chat-msg__receipt').length).toBe(0);
stanza = u.toStanza(`
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
<message xml:lang="en" to="romeo@montague.lit/orchard"
from="lounge@montague.lit/some1" type="groupchat" xmlns="jabber:client">
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
<body>'tis I!</body>
<markable xmlns="urn:xmpp:chat-markers:0"/>
</message>`);
_converse.connection._dataRecv(test_utils.createRequest(stanza));
Fetch messages in MUC model
2019-05-19 22:11:26 +02:00
await test_utils.waitUntil(() => view.model.isChatMarker.calls.count() === 4);
More specific selector for markers and another test Updates #1442
2019-02-13 08:47:38 +01:00
expect(view.el.querySelectorAll('.chat-msg').length).toBe(2);
expect(view.el.querySelectorAll('.chat-msg__receipt').length).toBe(0);
done();
}));
Render mentions in a message
2018-08-16 12:15:23 +02:00
describe("when received", function () {
Add support for editing messages containing mentions
2018-08-16 15:12:03 +02:00
it("highlights all users mentioned via XEP-0372 references",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Render mentions in a message
2018-08-16 12:15:23 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'tom');
const view = _converse.api.chatviews.get('lounge@montague.lit');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
['z3r0', 'mr.robot', 'gibson', 'sw0rdf1sh'].forEach((nick) => {
_converse.connection._dataRecv(test_utils.createRequest(
$pres({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'to': 'tom@montague.lit/resource',
'from': `lounge@montague.lit/${nick}`
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
})
.c('x', {xmlns: Strophe.NS.MUC_USER})
.c('item', {
'affiliation': 'none',
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'jid': `${nick}@montague.lit/resource`,
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'role': 'participant'
}))
);
});
const msg = $msg({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
from: 'lounge@montague.lit/gibson',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
id: (new Date()).getTime(),
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
to: 'romeo@montague.lit',
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
type: 'groupchat'
}).c('body').t('hello z3r0 tom mr.robot, how are you?').up()
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.c('reference', {'xmlns':'urn:xmpp:reference:0', 'begin':'6', 'end':'10', 'type':'mention', 'uri':'xmpp:z3r0@montague.lit'}).up()
.c('reference', {'xmlns':'urn:xmpp:reference:0', 'begin':'11', 'end':'14', 'type':'mention', 'uri':'xmpp:romeo@montague.lit'}).up()
.c('reference', {'xmlns':'urn:xmpp:reference:0', 'begin':'15', 'end':'23', 'type':'mention', 'uri':'xmpp:mr.robot@montague.lit'}).nodeTree;
Refactor out `createMessage`. Changes: * Avoids leaky abstraction of MUC code into converse-chatboxes * Avoid creating unnecessary message objects (e.g. without <body) * Add fix for #1369. * Rename spec/chatroom.js to spec/muc.js
2019-01-25 11:53:07 +01:00
await view.model.onMessage(msg);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
Fixes #1400. When chat message is only an emoji, enlarge it
2019-02-27 10:34:47 +01:00
const messages = view.el.querySelectorAll('.chat-msg__text');
expect(messages.length).toBe(1);
expect(messages[0].classList.length).toEqual(1);
expect(messages[0].innerHTML).toBe(
'hello <span class="mention">z3r0</span> '+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'<span class="mention mention--self badge badge-info">tom</span> '+
Fixes #1400. When chat message is only an emoji, enlarge it
2019-02-27 10:34:47 +01:00
'<span class="mention">mr.robot</span>, how are you?');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Render mentions in a message
2018-08-16 12:15:23 +02:00
}));
});
Inlcude references in the outgoing XMPP stanza
2018-08-16 09:44:14 +02:00
describe("in which someone is mentioned", function () {
Add support for editing messages containing mentions
2018-08-16 15:12:03 +02:00
it("gets parsed for mentions which get turned into references",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Inlcude references in the outgoing XMPP stanza
2018-08-16 09:44:14 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'tom');
const view = _converse.api.chatviews.get('lounge@montague.lit');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
['z3r0', 'mr.robot', 'gibson', 'sw0rdf1sh', 'Link Mauve'].forEach((nick) => {
_converse.connection._dataRecv(test_utils.createRequest(
$pres({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'to': 'tom@montague.lit/resource',
'from': `lounge@montague.lit/${nick}`
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
})
.c('x', {xmlns: Strophe.NS.MUC_USER})
.c('item', {
'affiliation': 'none',
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'jid': `${nick.replace(/\s/g, '-')}@montague.lit/resource`,
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'role': 'participant'
})));
Inlcude references in the outgoing XMPP stanza
2018-08-16 09:44:14 +02:00
});
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
// Run a few unit tests for the parseTextForReferences method
let [text, references] = view.model.parseTextForReferences('hello z3r0')
expect(references.length).toBe(0);
expect(text).toBe('hello z3r0');
[text, references] = view.model.parseTextForReferences('hello @z3r0')
expect(references.length).toBe(1);
expect(text).toBe('hello z3r0');
expect(JSON.stringify(references))
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.toBe('[{"begin":6,"end":10,"value":"z3r0","type":"mention","uri":"xmpp:z3r0@montague.lit"}]');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
[text, references] = view.model.parseTextForReferences('hello @some1 @z3r0 @gibson @mr.robot, how are you?')
expect(text).toBe('hello @some1 z3r0 gibson mr.robot, how are you?');
expect(JSON.stringify(references))
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.toBe('[{"begin":13,"end":17,"value":"z3r0","type":"mention","uri":"xmpp:z3r0@montague.lit"},'+
'{"begin":18,"end":24,"value":"gibson","type":"mention","uri":"xmpp:gibson@montague.lit"},'+
'{"begin":25,"end":33,"value":"mr.robot","type":"mention","uri":"xmpp:mr.robot@montague.lit"}]');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
[text, references] = view.model.parseTextForReferences('yo @gib')
expect(text).toBe('yo @gib');
expect(references.length).toBe(0);
[text, references] = view.model.parseTextForReferences('yo @gibsonian')
expect(text).toBe('yo @gibsonian');
expect(references.length).toBe(0);
[text, references] = view.model.parseTextForReferences('@gibson')
expect(text).toBe('gibson');
expect(references.length).toBe(1);
expect(JSON.stringify(references))
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.toBe('[{"begin":0,"end":6,"value":"gibson","type":"mention","uri":"xmpp:gibson@montague.lit"}]');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
[text, references] = view.model.parseTextForReferences('hi @Link Mauve how are you?')
expect(text).toBe('hi Link Mauve how are you?');
expect(references.length).toBe(1);
expect(JSON.stringify(references))
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.toBe('[{"begin":3,"end":13,"value":"Link Mauve","type":"mention","uri":"xmpp:Link-Mauve@montague.lit"}]');
Add tests for tricky URLs
2019-03-27 11:00:53 +01:00
[text, references] = view.model.parseTextForReferences('https://example.org/@gibson')
expect(text).toBe('https://example.org/@gibson');
expect(references.length).toBe(0);
expect(JSON.stringify(references))
.toBe('[]');
[text, references] = view.model.parseTextForReferences('mail@gibson.com')
expect(text).toBe('mail@gibson.com');
expect(references.length).toBe(0);
expect(JSON.stringify(references))
.toBe('[]');
[text, references] = view.model.parseTextForReferences(
'https://linkmauve.fr@Link Mauve/ https://linkmauve.fr/@github/is_back gibson@gibson.com gibson@Link Mauve.fr')
expect(text).toBe(
'https://linkmauve.fr@Link Mauve/ https://linkmauve.fr/@github/is_back gibson@gibson.com gibson@Link Mauve.fr');
expect(references.length).toBe(0);
expect(JSON.stringify(references))
.toBe('[]');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
done();
Inlcude references in the outgoing XMPP stanza
2018-08-16 09:44:14 +02:00
}));
Fix #1327: Refusing url and email as mentions Before the function `extractReference` in `/src/headless/converse-muc.js` matched url and email. Fix: https://github.com/conversejs/converse.js/issues/1327
2019-03-04 20:47:06 +01:00
it("parses for mentions as indicated with an @ preceded by a space or at the start of the text",
mock.initConverse(
null, ['rosterGroupsFetched'], {},
async function (done, _converse) {
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'tom');
const view = _converse.api.chatviews.get('lounge@montague.lit');
Fix #1327: Refusing url and email as mentions Before the function `extractReference` in `/src/headless/converse-muc.js` matched url and email. Fix: https://github.com/conversejs/converse.js/issues/1327
2019-03-04 20:47:06 +01:00
['NotAnAdress', 'darnuria'].forEach((nick) => {
_converse.connection._dataRecv(test_utils.createRequest(
$pres({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'to': 'tom@montague.lit/resource',
'from': `lounge@montague.lit/${nick}`
Fix #1327: Refusing url and email as mentions Before the function `extractReference` in `/src/headless/converse-muc.js` matched url and email. Fix: https://github.com/conversejs/converse.js/issues/1327
2019-03-04 20:47:06 +01:00
})
.c('x', {xmlns: Strophe.NS.MUC_USER})
.c('item', {
'affiliation': 'none',
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'jid': `${nick.replace(/\s/g, '-')}@montague.lit/resource`,
Fix #1327: Refusing url and email as mentions Before the function `extractReference` in `/src/headless/converse-muc.js` matched url and email. Fix: https://github.com/conversejs/converse.js/issues/1327
2019-03-04 20:47:06 +01:00
'role': 'participant'
})));
});
// Test that we don't match @nick in email adresses.
let [text, references] = view.model.parseTextForReferences('contact contact@NotAnAdress.eu');
expect(references.length).toBe(0);
expect(text).toBe('contact contact@NotAnAdress.eu');
// Test that we don't match @nick in url
[text, references] = view.model.parseTextForReferences('nice website https://darnuria.eu/@darnuria');
expect(references.length).toBe(0);
expect(text).toBe('nice website https://darnuria.eu/@darnuria');
done();
}));
Add support for editing messages containing mentions
2018-08-16 15:12:03 +02:00
it("can get corrected and given new references",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Add support for editing messages containing mentions
2018-08-16 15:12:03 +02:00
null, ['rosterGroupsFetched'], {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
async function (done, _converse) {
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'tom');
Associate `ChatRoomOccupant` to `ChatRoomMessage` and use promises to indicate when an occupant or contact has been set
2019-07-01 10:44:59 +02:00
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const view = _converse.api.chatviews.get('lounge@montague.lit');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
['z3r0', 'mr.robot', 'gibson', 'sw0rdf1sh'].forEach((nick) => {
_converse.connection._dataRecv(test_utils.createRequest(
$pres({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'to': 'tom@montague.lit/resource',
'from': `lounge@montague.lit/${nick}`
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
})
.c('x', {xmlns: Strophe.NS.MUC_USER})
.c('item', {
'affiliation': 'none',
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'jid': `${nick}@montague.lit/resource`,
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
'role': 'participant'
})));
});
Add support for editing messages containing mentions
2018-08-16 15:12:03 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const textarea = view.el.querySelector('textarea.chat-textarea');
textarea.value = 'hello @z3r0 @gibson @mr.robot, how are you?'
const enter_event = {
'target': textarea,
'preventDefault': _.noop,
'stopPropagation': _.noop,
'keyCode': 13 // Enter
}
spyOn(_converse.connection, 'send');
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown(enter_event);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await new Promise((resolve, reject) => view.once('messageInserted', resolve));
const msg = _converse.connection.send.calls.all()[0].args[0];
expect(msg.toLocaleString())
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.toBe(`<message from="romeo@montague.lit/orchard" id="${msg.nodeTree.getAttribute("id")}" `+
`to="lounge@montague.lit" type="groupchat" `+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`xmlns="jabber:client">`+
`<body>hello z3r0 gibson mr.robot, how are you?</body>`+
`<active xmlns="http://jabber.org/protocol/chatstates"/>`+
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
`<reference begin="18" end="26" type="mention" uri="xmpp:mr.robot@montague.lit" xmlns="urn:xmpp:reference:0"/>`+
`<reference begin="11" end="17" type="mention" uri="xmpp:gibson@montague.lit" xmlns="urn:xmpp:reference:0"/>`+
`<reference begin="6" end="10" type="mention" uri="xmpp:z3r0@montague.lit" xmlns="urn:xmpp:reference:0"/>`+
Include `origin-id` in outgoing messages
2019-02-07 14:15:49 +01:00
`<origin-id id="${msg.nodeTree.querySelector('origin-id').getAttribute("id")}" xmlns="urn:xmpp:sid:0"/>`+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`</message>`);
const first_msg = view.model.messages.findWhere({'message': 'hello z3r0 gibson mr.robot, how are you?'});
const action = view.el.querySelector('.chat-msg .chat-msg__action');
action.style.opacity = 1;
action.click();
Add support for editing messages containing mentions
2018-08-16 15:12:03 +02:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(textarea.value).toBe('hello @z3r0 @gibson @mr.robot, how are you?');
expect(view.model.messages.at(0).get('correcting')).toBe(true);
expect(view.el.querySelectorAll('.chat-msg').length).toBe(1);
Prioritize roster nickname as message and chatbox display name Set reference to roster contact on the message and chatbox object and listen for changes to the nickname. Currently, because chat boxes are fetched and initialized before the roster, messages and chats are repainted with the correct display name only later, causing a "flash" effect. Ideally we would only initialize the chat boxes after the roster contacts have been fetched, but this is currently not easily possible because we need the control box to render before everything else.
2019-04-09 17:10:50 +02:00
await test_utils.waitUntil(() => u.hasClass('correcting', view.el.querySelector('.chat-msg')), 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
textarea.value = 'hello @z3r0 @gibson @sw0rdf1sh, how are you?';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown(enter_event);
Prioritize roster nickname as message and chatbox display name Set reference to roster contact on the message and chatbox object and listen for changes to the nickname. Currently, because chat boxes are fetched and initialized before the roster, messages and chats are repainted with the correct display name only later, causing a "flash" effect. Ideally we would only initialize the chat boxes after the roster contacts have been fetched, but this is currently not easily possible because we need the control box to render before everything else.
2019-04-09 17:10:50 +02:00
await test_utils.waitUntil(() => view.el.querySelector('.chat-msg__text').textContent ===
'hello z3r0 gibson sw0rdf1sh, how are you?', 500);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
Associate `ChatRoomOccupant` to `ChatRoomMessage` and use promises to indicate when an occupant or contact has been set
2019-07-01 10:44:59 +02:00
const correction = _converse.connection.send.calls.all()[2].args[0];
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(correction.toLocaleString())
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.toBe(`<message from="romeo@montague.lit/orchard" id="${correction.nodeTree.getAttribute("id")}" `+
`to="lounge@montague.lit" type="groupchat" `+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`xmlns="jabber:client">`+
`<body>hello z3r0 gibson sw0rdf1sh, how are you?</body>`+
`<active xmlns="http://jabber.org/protocol/chatstates"/>`+
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
`<reference begin="6" end="10" type="mention" uri="xmpp:z3r0@montague.lit" xmlns="urn:xmpp:reference:0"/>`+
`<reference begin="11" end="17" type="mention" uri="xmpp:gibson@montague.lit" xmlns="urn:xmpp:reference:0"/>`+
`<reference begin="18" end="27" type="mention" uri="xmpp:sw0rdf1sh@montague.lit" xmlns="urn:xmpp:reference:0"/>`+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`<replace id="${msg.nodeTree.getAttribute("id")}" xmlns="urn:xmpp:message-correct:0"/>`+
Fix failing test
2019-06-13 17:12:37 +02:00
`<origin-id id="${correction.nodeTree.querySelector('origin-id').getAttribute("id")}" xmlns="urn:xmpp:sid:0"/>`+
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
`</message>`);
done();
Add support for editing messages containing mentions
2018-08-16 15:12:03 +02:00
}));
Inlcude references in the outgoing XMPP stanza
2018-08-16 09:44:14 +02:00
it("includes XEP-0372 references to that person",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Inlcude references in the outgoing XMPP stanza
2018-08-16 09:44:14 +02:00
null, ['rosterGroupsFetched'], {},
Use the API in tests
2019-02-22 21:43:49 +01:00
async function (done, _converse) {
Inlcude references in the outgoing XMPP stanza
2018-08-16 09:44:14 +02:00
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
await test_utils.openAndEnterChatRoom(_converse, 'lounge', 'montague.lit', 'tom');
const view = _converse.api.chatviews.get('lounge@montague.lit');
Use the API in tests
2019-02-22 21:43:49 +01:00
['z3r0', 'mr.robot', 'gibson', 'sw0rdf1sh'].forEach((nick) => {
_converse.connection._dataRecv(test_utils.createRequest(
$pres({
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'to': 'tom@montague.lit/resource',
'from': `lounge@montague.lit/${nick}`
Use the API in tests
2019-02-22 21:43:49 +01:00
})
.c('x', {xmlns: Strophe.NS.MUC_USER})
.c('item', {
'affiliation': 'none',
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'jid': `${nick}@montague.lit/resource`,
Use the API in tests
2019-02-22 21:43:49 +01:00
'role': 'participant'
})));
});
spyOn(_converse.connection, 'send');
const textarea = view.el.querySelector('textarea.chat-textarea');
textarea.value = 'hello @z3r0 @gibson @mr.robot, how are you?'
const enter_event = {
'target': textarea,
'preventDefault': _.noop,
'stopPropagation': _.noop,
'keyCode': 13 // Enter
}
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown(enter_event);
Use the API in tests
2019-02-22 21:43:49 +01:00
const msg = _converse.connection.send.calls.all()[0].args[0];
expect(msg.toLocaleString())
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
.toBe(`<message from="romeo@montague.lit/orchard" id="${msg.nodeTree.getAttribute("id")}" `+
`to="lounge@montague.lit" type="groupchat" `+
Use the API in tests
2019-02-22 21:43:49 +01:00
`xmlns="jabber:client">`+
`<body>hello z3r0 gibson mr.robot, how are you?</body>`+
`<active xmlns="http://jabber.org/protocol/chatstates"/>`+
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
`<reference begin="18" end="26" type="mention" uri="xmpp:mr.robot@montague.lit" xmlns="urn:xmpp:reference:0"/>`+
`<reference begin="11" end="17" type="mention" uri="xmpp:gibson@montague.lit" xmlns="urn:xmpp:reference:0"/>`+
`<reference begin="6" end="10" type="mention" uri="xmpp:z3r0@montague.lit" xmlns="urn:xmpp:reference:0"/>`+
Use the API in tests
2019-02-22 21:43:49 +01:00
`<origin-id id="${msg.nodeTree.querySelector('origin-id').getAttribute("id")}" xmlns="urn:xmpp:sid:0"/>`+
`</message>`);
done();
Inlcude references in the outgoing XMPP stanza
2018-08-16 09:44:14 +02:00
}));
});
Add test for groupchat message corrections
2018-07-07 14:20:49 +02:00
});
Move message-related tests into their own file
2018-04-29 15:40:24 +02:00
}));
Reference in New Issue Copy Permalink