Chapril/xmpp.chapril.org-conversejs
Chapril/xmpp.chapril.org-conversejs
25
0
Fork 0
Code Issues Pull Requests Projects Releases Activity
e3bd7b45f5
xmpp.chapril.org-conversejs/spec/spoilers.js

238 lines
12 KiB
JavaScript
Raw Normal View History

Add spec for spoilers, clean up linting errors
2018-02-02 19:33:19 +01:00
(function (root, factory) {
Get tests to run agains the webpack build
2018-06-03 16:40:20 +02:00
define(["jasmine", "mock", "test-utils"], factory);
} (this, function (jasmine, mock, test_utils) {
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const _ = converse.env._;
const Strophe = converse.env.Strophe;
const $msg = converse.env.$msg;
const $pres = converse.env.$pres;
const u = converse.env.utils;
Add spec for spoilers, clean up linting errors
2018-02-02 19:33:19 +01:00
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
describe("A spoiler message", function () {
Add spec for spoilers, clean up linting errors
2018-02-02 19:33:19 +01:00
Add an (incomplete) test for a received spoiler message
2018-02-02 21:54:06 +01:00
it("can be received with a hint",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Remove need to pass in spies to `initConverse` They aren't used anymore.
2019-10-11 16:38:01 +02:00
['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
async (done, _converse) => {
Add an (incomplete) test for a received spoiler message
2018-02-02 21:54:06 +01:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Add an (incomplete) test for a received spoiler message
2018-02-02 21:54:06 +01:00
/* <message to='romeo@montague.net/orchard' from='juliet@capulet.net/balcony' id='spoiler2'>
* <body>And at the end of the story, both of them die! It is so tragic!</body>
* <spoiler xmlns='urn:xmpp:spoiler:0'>Love story end</spoiler>
* </message>
*/
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const spoiler_hint = "Love story end"
const spoiler = "And at the end of the story, both of them die! It is so tragic!";
const msg = $msg({
Add an (incomplete) test for a received spoiler message
2018-02-02 21:54:06 +01:00
'xmlns': 'jabber:client',
'to': _converse.bare_jid,
'from': sender_jid,
'type': 'chat'
}).c('body').t(spoiler).up()
.c('spoiler', {
'xmlns': 'urn:xmpp:spoiler:0',
}).t(spoiler_hint)
.tree();
Refactoring - Move headless one-on-one chat functionality into converse-chat - Split converse-headline into converse-headlines and converse-headlines-views - Add api in `_converse.api.chatboxes` for creating chatboxes - Add `_converse.api.controlbox.get` method
2019-11-01 16:04:55 +01:00
_converse.connection._dataRecv(test_utils.createRequest(msg));
Set VCards via events, thereby reducing coupling - Rename `chatRoomOpened` event to `chatRoomViewInitialized` - Rename `chatBoxInitialized` to `chatBoxViewInitialized` and trigger only for `ChatBoxView` instances. - New event `headlinesBoxViewInitialized` - Trigger the `chatBoxInitialized` event when a new `_converse.ChatBox` is opened.
2019-12-18 12:42:40 +01:00
await new Promise(resolve => _converse.api.listen.once('chatBoxViewInitialized', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const view = _converse.chatboxviews.get(sender_jid);
Fix linting errors (no-unused-vars)
2019-10-09 16:01:38 +02:00
await new Promise(resolve => view.once('messageInserted', resolve));
Replace wait-until-promise with utility method and bump default timeout Also let `_converse.api.waitUntil` use it if a function is passed in.
2019-07-11 22:50:30 +02:00
await u.waitUntil(() => view.model.vcard.get('fullname') === 'Mercutio')
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
expect(view.el.querySelector('.chat-msg__author').textContent.trim()).toBe('Mercutio');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const message_content = view.el.querySelector('.chat-msg__text');
expect(message_content.textContent).toBe(spoiler);
const spoiler_hint_el = view.el.querySelector('.spoiler-hint');
expect(spoiler_hint_el.textContent).toBe(spoiler_hint);
done();
Expand the spoiler tests
2018-02-06 21:21:21 +01:00
}));
it("can be received without a hint",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Remove need to pass in spies to `initConverse` They aren't used anymore.
2019-10-11 16:38:01 +02:00
['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
async (done, _converse) => {
Expand the spoiler tests
2018-02-06 21:21:21 +01:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current');
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const sender_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Expand the spoiler tests
2018-02-06 21:21:21 +01:00
/* <message to='romeo@montague.net/orchard' from='juliet@capulet.net/balcony' id='spoiler2'>
* <body>And at the end of the story, both of them die! It is so tragic!</body>
* <spoiler xmlns='urn:xmpp:spoiler:0'>Love story end</spoiler>
* </message>
*/
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const spoiler = "And at the end of the story, both of them die! It is so tragic!";
const msg = $msg({
Expand the spoiler tests
2018-02-06 21:21:21 +01:00
'xmlns': 'jabber:client',
'to': _converse.bare_jid,
'from': sender_jid,
'type': 'chat'
}).c('body').t(spoiler).up()
.c('spoiler', {
'xmlns': 'urn:xmpp:spoiler:0',
}).tree();
Refactoring - Move headless one-on-one chat functionality into converse-chat - Split converse-headline into converse-headlines and converse-headlines-views - Add api in `_converse.api.chatboxes` for creating chatboxes - Add `_converse.api.controlbox.get` method
2019-11-01 16:04:55 +01:00
_converse.connection._dataRecv(test_utils.createRequest(msg));
Set VCards via events, thereby reducing coupling - Rename `chatRoomOpened` event to `chatRoomViewInitialized` - Rename `chatBoxInitialized` to `chatBoxViewInitialized` and trigger only for `ChatBoxView` instances. - New event `headlinesBoxViewInitialized` - Trigger the `chatBoxInitialized` event when a new `_converse.ChatBox` is opened.
2019-12-18 12:42:40 +01:00
await new Promise(resolve => _converse.api.listen.once('chatBoxViewInitialized', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const view = _converse.chatboxviews.get(sender_jid);
Change when/how chats are shown Goal is to fix a timing bug that results in `show` being triggered before the `ChatBoxView` has been initialized, which means that 1:1 chats aren't opened when you reload the page.
2020-02-02 15:38:37 +01:00
await new Promise(resolve => view.model.messages.once('rendered', resolve));
Refactoring - Move headless one-on-one chat functionality into converse-chat - Split converse-headline into converse-headlines and converse-headlines-views - Add api in `_converse.api.chatboxes` for creating chatboxes - Add `_converse.api.controlbox.get` method
2019-11-01 16:04:55 +01:00
await u.waitUntil(() => u.isVisible(view.el));
Replace wait-until-promise with utility method and bump default timeout Also let `_converse.api.waitUntil` use it if a function is passed in.
2019-07-11 22:50:30 +02:00
await u.waitUntil(() => view.model.vcard.get('fullname') === 'Mercutio')
Add Skeletor as dependency
2019-09-19 16:54:55 +02:00
expect(view.el.querySelector('.chat-msg__author').textContent.includes('Mercutio')).toBeTruthy();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const message_content = view.el.querySelector('.chat-msg__text');
expect(message_content.textContent).toBe(spoiler);
const spoiler_hint_el = view.el.querySelector('.spoiler-hint');
expect(spoiler_hint_el.textContent).toBe('');
done();
Add an (incomplete) test for a received spoiler message
2018-02-02 21:54:06 +01:00
}));
Add spec for spoilers, clean up linting errors
2018-02-02 19:33:19 +01:00
it("can be sent without a hint",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Remove need to pass in spies to `initConverse` They aren't used anymore.
2019-10-11 16:38:01 +02:00
['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
async (done, _converse) => {
Add spec for spoilers, clean up linting errors
2018-02-02 19:33:19 +01:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Support for IndexedDB. updates #1105 Depend on latest backbone.browserStorage which has support for IndexedDB via localforage. Storage operations are now asynchronous and transactional. Bugs fixed (mostly by waiting for operations to complete): * Rooms are now fetched asynchronously, so wait before triggering `show` or when closing. * Make sure chat create/update transactions complete before firing events * Make sure chats and messages have been fetched before creating new ones. * When doing a `fetch` with `wait: false` on a collection and then creating a model in that collection, then once the read operation finishes (after creating the model), the collection is emptied again. * Patch and wait when saving. Otherwise we have previously set attributes overriding later ones. * Make sure api.roomviews.close returns a promise Test fixes: * Chats are now asynchronously returned, so we need to use `await` * Wait for the storage transaction to complete when creating and updating messages * Wait for all chatboxes to close Otherwise we get sessionStorage inconsistencies due to the async nature of localforage. * Wait for room views to close in spec/chatroom.js In the process, remove the `closeAllChatBoxes` override in converse-controlbox by letting the `close` method decide whether it should be closed or not.
2019-10-24 14:29:15 +02:00
test_utils.openControlBox(_converse);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Add spec for spoilers, clean up linting errors
2018-02-02 19:33:19 +01:00
Asynchronously render spoiler button only if all clients support it
2018-02-08 17:06:53 +01:00
// XXX: We need to send a presence from the contact, so that we
// have a resource, that resource is then queried to see
// whether Strophe.NS.SPOILER is supported, in which case
// the spoiler button will appear.
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const presence = $pres({
Asynchronously render spoiler button only if all clients support it
2018-02-08 17:06:53 +01:00
'from': contact_jid+'/phone',
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'to': 'romeo@montague.lit'
Asynchronously render spoiler button only if all clients support it
2018-02-08 17:06:53 +01:00
});
_converse.connection._dataRecv(test_utils.createRequest(presence));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, contact_jid);
await test_utils.waitUntilDiscoConfirmed(_converse, contact_jid+'/phone', [], [Strophe.NS.SPOILER]);
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
const view = _converse.api.chatviews.get(contact_jid);
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
spyOn(_converse.connection, 'send');
Replace wait-until-promise with utility method and bump default timeout Also let `_converse.api.waitUntil` use it if a function is passed in.
2019-07-11 22:50:30 +02:00
await u.waitUntil(() => view.el.querySelector('.toggle-compose-spoiler'));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let spoiler_toggle = view.el.querySelector('.toggle-compose-spoiler');
spoiler_toggle.click();
const textarea = view.el.querySelector('.chat-textarea');
textarea.value = 'This is the spoiler';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
Fix linting errors
2019-08-05 11:14:49 +02:00
preventDefault: function preventDefault () {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
keyCode: 13
});
Fix linting errors (no-unused-vars)
2019-10-09 16:01:38 +02:00
await new Promise(resolve => view.once('messageInserted', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
Add support for XEP-0198 Stream Management - New plugin `converse-smacks` - New config option `enable_smacks` - Rename session cache id from `converse.bosh-session` to `converse.session` - Refactor logout and login as consistently used api methods - Refactor session cache to store per JID Fixes #316
2018-05-29 12:00:23 +02:00
/* Test the XML stanza
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
*
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
* <message from="romeo@montague.lit/orchard"
* to="max.frankfurter@montague.lit"
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
* type="chat"
* id="4547c38b-d98b-45a5-8f44-b4004dbc335e"
* xmlns="jabber:client">
* <body>This is the spoiler</body>
* <active xmlns="http://jabber.org/protocol/chatstates"/>
* <spoiler xmlns="urn:xmpp:spoiler:0"/>
* </message>"
*/
const stanza = _converse.connection.send.calls.argsFor(0)[0].tree();
const spoiler_el = stanza.querySelector('spoiler[xmlns="urn:xmpp:spoiler:0"]');
Stop using certain lodash methods. * _.isNil * _.noop * _.isNull
2019-08-05 01:39:57 +02:00
expect(spoiler_el === null).toBeFalsy();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(spoiler_el.textContent).toBe('');
const body_el = stanza.querySelector('body');
expect(body_el.textContent).toBe('This is the spoiler');
/* Test the HTML spoiler message */
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
expect(view.el.querySelector('.chat-msg__author').textContent.trim()).toBe('Romeo Montague');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const spoiler_msg_el = view.el.querySelector('.chat-msg__text.spoiler');
expect(spoiler_msg_el.textContent).toBe('This is the spoiler');
expect(_.includes(spoiler_msg_el.classList, 'collapsed')).toBeTruthy();
spoiler_toggle = view.el.querySelector('.spoiler-toggle');
expect(spoiler_toggle.textContent).toBe('Show more');
spoiler_toggle.click();
expect(_.includes(spoiler_msg_el.classList, 'collapsed')).toBeFalsy();
expect(spoiler_toggle.textContent).toBe('Show less');
spoiler_toggle.click();
expect(_.includes(spoiler_msg_el.classList, 'collapsed')).toBeTruthy();
done();
Add spec for spoilers, clean up linting errors
2018-02-02 19:33:19 +01:00
}));
it("can be sent with a hint",
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
mock.initConverse(
Remove need to pass in spies to `initConverse` They aren't used anymore.
2019-10-11 16:38:01 +02:00
['rosterGroupsFetched', 'chatBoxesFetched'], {},
Make `converse.initialize` an `async` function - Combine all test init functions into `initConverse` - Use `async` functions in more tests - Replace `var` with `let` and `const` in more tests - New utils method `toStanza` which converts a string to a Node
2019-02-12 14:21:45 +01:00
async (done, _converse) => {
Add spec for spoilers, clean up linting errors
2018-02-02 19:33:19 +01:00
Two changes, see below * Add new test helper to create contacts via IQ exchange * Use roster nickname to set message fullname
2019-02-24 11:44:34 +01:00
await test_utils.waitForRoster(_converse, 'current', 1);
Support for IndexedDB. updates #1105 Depend on latest backbone.browserStorage which has support for IndexedDB via localforage. Storage operations are now asynchronous and transactional. Bugs fixed (mostly by waiting for operations to complete): * Rooms are now fetched asynchronously, so wait before triggering `show` or when closing. * Make sure chat create/update transactions complete before firing events * Make sure chats and messages have been fetched before creating new ones. * When doing a `fetch` with `wait: false` on a collection and then creating a model in that collection, then once the read operation finishes (after creating the model), the collection is emptied again. * Patch and wait when saving. Otherwise we have previously set attributes overriding later ones. * Make sure api.roomviews.close returns a promise Test fixes: * Chats are now asynchronously returned, so we need to use `await` * Wait for the storage transaction to complete when creating and updating messages * Wait for all chatboxes to close Otherwise we get sessionStorage inconsistencies due to the async nature of localforage. * Wait for room views to close in spec/chatroom.js In the process, remove the `closeAllChatBoxes` override in converse-controlbox by letting the `close` method decide whether it should be closed or not.
2019-10-24 14:29:15 +02:00
test_utils.openControlBox(_converse);
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
const contact_jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@montague.lit';
Add spec for spoilers, clean up linting errors
2018-02-02 19:33:19 +01:00
Asynchronously render spoiler button only if all clients support it
2018-02-08 17:06:53 +01:00
// XXX: We need to send a presence from the contact, so that we
// have a resource, that resource is then queried to see
// whether Strophe.NS.SPOILER is supported, in which case
// the spoiler button will appear.
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const presence = $pres({
Asynchronously render spoiler button only if all clients support it
2018-02-08 17:06:53 +01:00
'from': contact_jid+'/phone',
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
'to': 'romeo@montague.lit'
Asynchronously render spoiler button only if all clients support it
2018-02-08 17:06:53 +01:00
});
_converse.connection._dataRecv(test_utils.createRequest(presence));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
await test_utils.openChatBoxFor(_converse, contact_jid);
await test_utils.waitUntilDiscoConfirmed(_converse, contact_jid+'/phone', [], [Strophe.NS.SPOILER]);
Support for IndexedDB. updates #1105 Depend on latest backbone.browserStorage which has support for IndexedDB via localforage. Storage operations are now asynchronous and transactional. Bugs fixed (mostly by waiting for operations to complete): * Rooms are now fetched asynchronously, so wait before triggering `show` or when closing. * Make sure chat create/update transactions complete before firing events * Make sure chats and messages have been fetched before creating new ones. * When doing a `fetch` with `wait: false` on a collection and then creating a model in that collection, then once the read operation finishes (after creating the model), the collection is emptied again. * Patch and wait when saving. Otherwise we have previously set attributes overriding later ones. * Make sure api.roomviews.close returns a promise Test fixes: * Chats are now asynchronously returned, so we need to use `await` * Wait for the storage transaction to complete when creating and updating messages * Wait for all chatboxes to close Otherwise we get sessionStorage inconsistencies due to the async nature of localforage. * Wait for room views to close in spec/chatroom.js In the process, remove the `closeAllChatBoxes` override in converse-controlbox by letting the `close` method decide whether it should be closed or not.
2019-10-24 14:29:15 +02:00
const view = _converse.api.chatviews.get(contact_jid);
Fix failing tests and rewrite to use async/await
2018-10-26 10:15:01 +02:00
Replace wait-until-promise with utility method and bump default timeout Also let `_converse.api.waitUntil` use it if a function is passed in.
2019-07-11 22:50:30 +02:00
await u.waitUntil(() => view.el.querySelector('.toggle-compose-spoiler'));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
let spoiler_toggle = view.el.querySelector('.toggle-compose-spoiler');
spoiler_toggle.click();
spyOn(_converse.connection, 'send');
const textarea = view.el.querySelector('.chat-textarea');
textarea.value = 'This is the spoiler';
const hint_input = view.el.querySelector('.spoiler-hint');
hint_input.value = 'This is the hint';
Rename key event handler methods to avoid confusion
2019-05-26 10:58:52 +02:00
view.onKeyDown({
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
target: textarea,
Fix linting errors
2019-08-05 11:14:49 +02:00
preventDefault: function preventDefault () {},
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
keyCode: 13
Expand the spoiler tests
2018-02-06 21:21:21 +01:00
});
Fix linting errors (no-unused-vars)
2019-10-09 16:01:38 +02:00
await new Promise(resolve => view.once('messageInserted', resolve));
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
Add support for XEP-0198 Stream Management - New plugin `converse-smacks` - New config option `enable_smacks` - Rename session cache id from `converse.bosh-session` to `converse.session` - Refactor logout and login as consistently used api methods - Refactor session cache to store per JID Fixes #316
2018-05-29 12:00:23 +02:00
/* Test the XML stanza
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
*
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
* <message from="romeo@montague.lit/orchard"
* to="max.frankfurter@montague.lit"
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
* type="chat"
* id="4547c38b-d98b-45a5-8f44-b4004dbc335e"
* xmlns="jabber:client">
* <body>This is the spoiler</body>
* <active xmlns="http://jabber.org/protocol/chatstates"/>
* <spoiler xmlns="urn:xmpp:spoiler:0">This is the hint</spoiler>
* </message>"
*/
const stanza = _converse.connection.send.calls.argsFor(0)[0].tree();
const spoiler_el = stanza.querySelector('spoiler[xmlns="urn:xmpp:spoiler:0"]');
Stop using certain lodash methods. * _.isNil * _.noop * _.isNull
2019-08-05 01:39:57 +02:00
expect(spoiler_el === null).toBeFalsy();
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
expect(spoiler_el.textContent).toBe('This is the hint');
const body_el = stanza.querySelector('body');
expect(body_el.textContent).toBe('This is the spoiler');
/* Test the HTML spoiler message */
Use shakespearean character names in tests
2019-06-03 07:58:51 +02:00
expect(view.el.querySelector('.chat-msg__author').textContent.trim()).toBe('Romeo Montague');
Make the message view's `render` method async So that we first render dynamic content (e.g. images) before inserting it into the chat. Also, add the `show_images_inline` setting (which is the cause of this whole change). Updated tests to handle this new change and start using async/await instead of promise callbacks.
2018-10-13 23:25:01 +02:00
const spoiler_msg_el = view.el.querySelector('.chat-msg__text.spoiler');
expect(spoiler_msg_el.textContent).toBe('This is the spoiler');
expect(_.includes(spoiler_msg_el.classList, 'collapsed')).toBeTruthy();
spoiler_toggle = view.el.querySelector('.spoiler-toggle');
expect(spoiler_toggle.textContent).toBe('Show more');
spoiler_toggle.click();
expect(_.includes(spoiler_msg_el.classList, 'collapsed')).toBeFalsy();
expect(spoiler_toggle.textContent).toBe('Show less');
spoiler_toggle.click();
expect(_.includes(spoiler_msg_el.classList, 'collapsed')).toBeTruthy();
done();
Add spec for spoilers, clean up linting errors
2018-02-02 19:33:19 +01:00
}));
});
}));
Reference in New Issue Copy Permalink