From 01888b9ba4ba65fc91b9ff72a678015b4f09c366 Mon Sep 17 00:00:00 2001 From: JC Brand Date: Wed, 9 Aug 2017 14:37:33 +0200 Subject: [PATCH] vcard: Properly handle case where FN is empty in VCard --- src/converse-vcard.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/converse-vcard.js b/src/converse-vcard.js index 290e7f60f..0d4342cd3 100644 --- a/src/converse-vcard.js +++ b/src/converse-vcard.js @@ -82,15 +82,14 @@ const vcard = iq.querySelector('vCard'), img_type = _.get(vcard.querySelector('TYPE'), 'textContent'), img = _.get(vcard.querySelector('BINVAL'), 'textContent'), - url = _.get(vcard.querySelector('URL'), 'textContent'); + url = _.get(vcard.querySelector('URL'), 'textContent'), + fullname = _.get(vcard.querySelector('FN'), 'textContent'); - let fullname = _.get(vcard.querySelector('FN'), 'textContent'); if (jid) { const contact = _converse.roster.get(jid); if (contact) { - fullname = _.isUndefined(fullname) ? _.get(contact, 'fullname', jid) : fullname; contact.save({ - 'fullname': fullname, + 'fullname': fullname || _.get(contact, 'fullname', jid), 'image_type': img_type, 'image': img, 'url': url,