From 1966d5ab56a42b0e006c2ac190a65ac8371a6cc5 Mon Sep 17 00:00:00 2001
From: JC Brand <jc@opkode.com>
Date: Tue, 5 Mar 2013 18:35:06 +0200
Subject: [PATCH] Fix RosterHandler through proper closure.

---
 converse.js | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/converse.js b/converse.js
index bd89dfbc5..bb7098d14 100644
--- a/converse.js
+++ b/converse.js
@@ -1524,14 +1524,11 @@
         },
 
         rosterHandler: function (items) {
-            var model, item, i, items_length = items.length,
-                last_item = items[items_length - 1],
-                options = {}, vcard, img_src;
-            for (i=0; i<items_length; i+=1) {
-                item = items[i];
-                model = this.getItem(item.jid);
+            _.each(items, function (item, index, items) {
+                var model = this.getItem(item.jid),
+                    options = {};
                 if (!model) {
-                    if (item === last_item) {
+                    if (index === (items.length-1)) {
                         options.isLast = true;
                     }
                     xmppchat.getVCard(item.jid, $.proxy(function (jid, fullname, img, img_type, url) {
@@ -1545,7 +1542,8 @@
                         model.set({'subscription': item.subscription, 'ask': item.ask});
                     }
                 }
-            }
+
+            }, this);
         },
 
         presenceHandler: function (presence) {