Chapril/xmpp.chapril.org-conversejs
Chapril/xmpp.chapril.org-conversejs
25
0
Fork 0
Code Issues Pull Requests Projects Releases Activity

Don't add resources from message stanzas. Fixes #632

Browse Source 
For each user we keep a list of currently online resources. These resources
were taken from both presence and message stanzas.

Receiving a message doesn't however indicate that the user is online,
especially in the case of archived messages.

This also abused the semantics of messages, which are meant to indicate
user presence.
This commit is contained in:
JC Brand 2016-08-12 19:41:32 +00:00
parent 1f805fa1e2
commit 4402798dcd
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/CHANGES.md
View File

@ -1,6 +1,8 @@
# Changelog # Changelog
## 1.0.6 (Unreleased) ## 1.0.6 (Unreleased)
- #632 Offline and Logout states do not properly update once users start
chatting. [chrisuehlinger, jcband]
- #674 Polish translation updated to the current master. [ser] - #674 Polish translation updated to the current master. [ser]
- Typing (i.e. chat state) notifications are now also sent out from MUC rooms. [jcbrand] - Typing (i.e. chat state) notifications are now also sent out from MUC rooms. [jcbrand]
- `ChatRoomView.onChatRoomMessageSubmitted` has been renamed to - `ChatRoomView.onChatRoomMessageSubmitted` has been renamed to

1
src/converse-core.js
View File

@ -1376,7 +1376,6 @@
return true; // We already have this message stored. return true; // We already have this message stored.
} }
chatbox.createMessage($message, $delay, message); chatbox.createMessage($message, $delay, message);
converse.roster.addResource(contact_jid, resource);
converse.emit('message', message); converse.emit('message', message);
return true; return true;
}, },