From 5c487d2fafd0ea4ee115c714d6bdfbd69f31db45 Mon Sep 17 00:00:00 2001
From: JC Brand <jc@opkode.com>
Date: Mon, 17 Jul 2017 21:53:33 +0200
Subject: [PATCH] Refactored the slide methods

so that slider does not have fixed height after being opened and can therefore
shrink or expand appropriately when its children change.
---
 src/utils.js | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/utils.js b/src/utils.js
index 18a007676..2ce7b3dde 100755
--- a/src/utils.js
+++ b/src/utils.js
@@ -197,14 +197,14 @@
     };
 
     utils.slideToggleElement = function (el) {
-        if (!el.offsetHeight) {
+        if (_.includes(el.classList, 'collapsed')) {
             return utils.slideOut(el);
         } else {
             return utils.slideIn(el);
         }
     };
 
-    utils.slideOut = function (el, duration=600) {
+    utils.slideOut = function (el, duration=900) {
         /* Shows/expands an element by sliding it out of itself. */
 
         function calculateEndHeight (el) {
@@ -236,6 +236,7 @@
             const step = calculateSlideStep(end_height),
                   interval = end_height/duration*step;
             let h = 0;
+
             interval_marker = window.setInterval(function () {
                 h += step;
                 if (h < end_height) {
@@ -247,6 +248,9 @@
                     el.style.height = calculateEndHeight(el) + 'px';
                     window.clearInterval(interval_marker);
                     el.removeAttribute('data-slider-marker');
+                    el.classList.remove('collapsed');
+                    el.style.overflow = "";
+                    el.style.height = "";
                     resolve();
                 }
             }, interval);
@@ -261,7 +265,7 @@
                 const err = "Undefined or null element passed into slideIn";
                 console.warn(err);
                 return reject(new Error(err));
-            } else if (!el.offsetHeight) {
+            } else if (_.includes(el.classList, 'collapsed')) {
                 return resolve();
             } else if ($.fx.off) { // Effects are disabled (for tests)
                 el.style.height = 0 + 'px';
@@ -283,7 +287,8 @@
                 if (h > 0) {
                     el.style.height = h + 'px';
                 } else {
-                    el.style.height = 0 + 'px';
+                    el.classList.add('collapsed');
+                    el.style.height = "";
                     window.clearInterval(interval_marker);
                     el.removeAttribute('data-slider-marker');
                     resolve();