From 5e1a4bd9f4930092b2aca008ee7cd7382e8d9b25 Mon Sep 17 00:00:00 2001 From: JC Brand Date: Fri, 27 Feb 2015 21:42:40 +0100 Subject: [PATCH] Remove tests for old deprecated API methods. --- docs/CHANGES.rst | 23 +++++++++++----------- spec/converse.js | 50 ------------------------------------------------ 2 files changed, 12 insertions(+), 61 deletions(-) diff --git a/docs/CHANGES.rst b/docs/CHANGES.rst index a1114f421..e52843d89 100644 --- a/docs/CHANGES.rst +++ b/docs/CHANGES.rst @@ -4,23 +4,24 @@ Changelog 0.9.0 (Unreleased) ------------------ -* Bugfix. Custom status message form doesn't submit/disappear. [jcbrand] -* Add new API method ``chats.open`` to open chat boxes. [jcbrand] -* Add new API method to set and get configuration settings. [jcbrand] -* Add responsiveness to CSS. We now use Sass preprocessor for generating CSS. [jcbrand] -* Calling the API method ``contacts.get()`` without parameters now returns all contacts. [jcbrand] -* Don't send out the message carbons IQ stanza on each page load. [jcbrand] -* New Makefile.win to build in Windows environments. [gbonvehi] -* Norwegian Bokmål translations. [Andreas Lorentsen] -* Strophe.log and Strophe.error now uses converse.log to output messages. [gbonvehi] -* The API method ``chats.get`` now only returns already opened chat boxes. [jcbrand] -* Updated Afrikaans translations. [jcbrand] * #204 Support websocket connections. [jcbrand] * #252, 253 Add fullname and jid to contact's tooltip in roster. [gbonvehi] * #292 Better support for XEP-0085 Chat State Notifications. [jcbrand] * #295 Document "allow_registration". [gbonvehi] * #304 Added Polish translations. [ser] * #305 presence/show text in XMPP request isn't allowed by specification. [gbonvehi] +* Add new API method ``chats.open`` to open chat boxes. [jcbrand] +* Add new API method to set and get configuration settings. [jcbrand] +* Add responsiveness to CSS. We now use Sass preprocessor for generating CSS. [jcbrand] +* Bugfix. Custom status message form doesn't submit/disappear. [jcbrand] +* Calling the API method ``contacts.get()`` without parameters now returns all contacts. [jcbrand] +* Don't send out the message carbons IQ stanza on each page load. [jcbrand] +* New Makefile.win to build in Windows environments. [gbonvehi] +* Norwegian Bokmål translations. [Andreas Lorentsen] +* Removed deprecated API methods. [jcbrand] +* Strophe.log and Strophe.error now uses converse.log to output messages. [gbonvehi] +* The API method ``chats.get`` now only returns already opened chat boxes. [jcbrand] +* Updated Afrikaans translations. [jcbrand] 0.8.6 (2014-12-07) ------------------ diff --git a/spec/converse.js b/spec/converse.js index 58e9d5685..b41038388 100644 --- a/spec/converse.js +++ b/spec/converse.js @@ -154,55 +154,5 @@ expect(typeof converse_api.settings.get("non_existing")).toBe("undefined"); }, converse)); }, converse)); - - describe("The DEPRECATED API", $.proxy(function() { - beforeEach($.proxy(function () { - test_utils.closeAllChatBoxes(); - test_utils.clearBrowserStorage(); - converse.rosterview.model.reset(); - test_utils.createContacts('current'); - }, converse)); - - it("has a method for retrieving the next RID", $.proxy(function () { - var old_connection = converse.connection; - converse.connection._proto.rid = '1234'; - converse.expose_rid_and_sid = false; - expect(converse_api.getRID()).toBe(null); - - converse.expose_rid_and_sid = true; - expect(converse_api.getRID()).toBe('1234'); - - converse.connection = undefined; - expect(converse_api.getRID()).toBe(null); - // Restore the connection - converse.connection = old_connection; - }, converse)); - - it("has a method for retrieving the SID", $.proxy(function () { - var old_connection = converse.connection; - converse.connection._proto.sid = '1234'; - converse.expose_rid_and_sid = false; - expect(converse_api.getSID()).toBe(null); - - converse.expose_rid_and_sid = true; - expect(converse_api.getSID()).toBe('1234'); - - converse.connection = undefined; - expect(converse_api.getSID()).toBe(null); - // Restore the connection - converse.connection = old_connection; - }, converse)); - - it("has a method for retrieving a buddy's attributes", $.proxy(function () { - var jid = mock.cur_names[0].replace(/ /g,'.').toLowerCase() + '@localhost'; - expect(converse_api.getBuddy('non-existing@jabber.org')).toBeFalsy(); - var attrs = converse_api.getBuddy(jid); - expect(typeof attrs).toBe('object'); - expect(attrs.fullname).toBe(mock.cur_names[0]); - expect(attrs.jid).toBe(jid); - }, converse)); - }, converse)); - - }, converse, mock, test_utils)); }));