From 5efb7b2a84ace3ce29fea6a6b07989147d7d6a3d Mon Sep 17 00:00:00 2001
From: JC Brand <jc@opkode.com>
Date: Mon, 27 Apr 2020 18:31:56 +0200
Subject: [PATCH] MUC: provide feedback when no rooms found

---
 src/converse-muc-views.js             | 7 ++++---
 src/templates/list_chatrooms_modal.js | 2 +-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/converse-muc-views.js b/src/converse-muc-views.js
index e80785531..a2cebddef 100644
--- a/src/converse-muc-views.js
+++ b/src/converse-muc-views.js
@@ -468,15 +468,16 @@ converse.plugins.add('converse-muc-views', {
              * @param { HTMLElement } iq
              */
             onRoomsFound (iq) {
+                this.loading_items = false;
                 const rooms = iq ? sizzle('query item', iq) : [];
                 if (rooms.length) {
                     this.model.set({'feedback_text': __('Groupchats found')}, {'silent': true});
                     this.items = rooms.map(st.getAttributes);
-                    this.loading_items = false;
-                    this.render();
                 } else {
-                    this.model.set('feedback_text', __('No groupchats found'));
+                    this.items = [];
+                    this.model.set({'feedback_text': __('No groupchats found')}, {'silent': true});
                 }
+                this.render();
                 return true;
             },
 
diff --git a/src/templates/list_chatrooms_modal.js b/src/templates/list_chatrooms_modal.js
index b19ec2c75..68f6ff4d7 100644
--- a/src/templates/list_chatrooms_modal.js
+++ b/src/templates/list_chatrooms_modal.js
@@ -59,7 +59,7 @@ export default (o) => html`
                 ${o.show_form ? form(o) : '' }
                 <ul class="available-chatrooms list-group">
                     ${ o.loading_items ? html`<li class="list-group-item"> ${spinner()} </li>` : '' }
-                    ${ o.items.length ? html`<li class="list-group-item active">${ o.feedback_text }:</li>` : '' }
+                    ${ o.feedback_text ? html`<li class="list-group-item active">${ o.feedback_text }</li>` : '' }
                     ${repeat(o.items, item => item.jid, item => tpl_item(o, item))}
                 </ul>
             </div>