Chapril/xmpp.chapril.org-conversejs
Chapril/xmpp.chapril.org-conversejs
25
0
Fork 0
Code Issues Pull Requests Projects Releases Activity

Changed the following:

Browse Source 
- Subscribe event with help of jQuery one instead of delegate, now that
  the rosterView is no longer emptied on every render to avoid
  registring several handlers of remove action, which meant you had to
  click 4 times for the jQuery Dialog to go away
- Remove the element from the rosterView when the remove event is
  triggered on the model which removes just that item instead of
  emptying the list and appending the remaining models again
This commit is contained in:
ichim-david 2013-02-23 16:17:00 +02:00
parent d8d3a34737
commit 85e9c7cecc
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
converse.js
View File

@ -1327,7 +1327,7 @@
} }
// Event handlers // Event handlers
this.$el.delegate('a.remove-xmpp-contact','click', function (ev) { this.$el.find('.remove-xmpp-contact').one('click', function (ev) {
ev.preventDefault(); ev.preventDefault();
that.removeContact(); that.removeContact();
}); });
@ -1608,8 +1608,10 @@
}, this); }, this);
this.model.on("remove", function (item) { this.model.on("remove", function (item) {
// remove element from the rosterView instance
this.rosteritemviews[item.id].$el.remove();
delete this.rosteritemviews[item.id]; delete this.rosteritemviews[item.id];
this.render(item);
}, this); }, this);
this.$el.hide(); this.$el.hide();