diff --git a/CHANGES.md b/CHANGES.md index f79cf1e66..3c8da1fa6 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -30,6 +30,7 @@ - Documentation includes utf-8 charset to make minfied versions compatible across platforms. #1017 - #1026 Typing in MUC shows "Typing from another device" - #1039 Multi-option data form elements not shown and saved correctly +- #1143 Able to send blank message ### API changes diff --git a/dist/converse.js b/dist/converse.js index c2d64884f..0074c1191 100644 --- a/dist/converse.js +++ b/dist/converse.js @@ -70266,6 +70266,11 @@ var __WEBPACK_AMD_DEFINE_FACTORY__, __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_ ev.preventDefault(); const textarea = this.el.querySelector('.chat-textarea'), message = textarea.value; + + if (!message.replace(/\s/g, '').length) { + return; + } + let spoiler_hint; if (this.model.get('composing_spoiler')) { @@ -70280,12 +70285,9 @@ var __WEBPACK_AMD_DEFINE_FACTORY__, __WEBPACK_AMD_DEFINE_ARRAY__, __WEBPACK_AMD_ const event = document.createEvent('Event'); event.initEvent('input', true, true); textarea.dispatchEvent(event); + this.onMessageSubmitted(message, spoiler_hint); - if (message !== '') { - this.onMessageSubmitted(message, spoiler_hint); - - _converse.emit('messageSend', message); - } + _converse.emit('messageSend', message); this.setChatState(_converse.ACTIVE); }, diff --git a/src/converse-chatview.js b/src/converse-chatview.js index a3ced0ff0..035d9ad9e 100644 --- a/src/converse-chatview.js +++ b/src/converse-chatview.js @@ -890,6 +890,9 @@ const textarea = this.el.querySelector('.chat-textarea'), message = textarea.value; + if (!message.replace(/\s/g, '').length) { + return; + } let spoiler_hint; if (this.model.get('composing_spoiler')) { const hint_el = this.el.querySelector('form.sendXMPPMessage input.spoiler-hint'); @@ -903,10 +906,8 @@ event.initEvent('input', true, true); textarea.dispatchEvent(event); - if (message !== '') { - this.onMessageSubmitted(message, spoiler_hint); - _converse.emit('messageSend', message); - } + this.onMessageSubmitted(message, spoiler_hint); + _converse.emit('messageSend', message); this.setChatState(_converse.ACTIVE); },