From c966c4930477dcd98f08419156db7525a3da9921 Mon Sep 17 00:00:00 2001 From: JC Brand Date: Mon, 7 Jun 2021 13:43:00 +0200 Subject: [PATCH] Fixes #2500 This wrongly stored value wasn't inlcuded in the published the bundle because the libsignal store was used, which had the right value for the public key. Instead, this value was used locally by being passed to the libsignal session builder to verify signed prekey. --- CHANGES.md | 6 +++++- src/plugins/omemo/store.js | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index de39668af..285f2fb54 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -42,7 +42,11 @@ Removed events: The `chatBoxClosed`, `chatBoxMaximized` and `chatBoxMinimized` events now have the `model` as payload and not the `view`. -## 7.0.5 (Unreleased) +## 7.0.6 (unreleased) + +- #2500: Wrong assignment in OMEMO code + +## 7.0.5 (2021-03-16) - #2377: The @converse/headless NPM package is missing the dist directory, causing import errors - #2396: @converse/headless wrongly depends on `CustomElement` from the view layer diff --git a/src/plugins/omemo/store.js b/src/plugins/omemo/store.js index a87e5c4c1..48944ce32 100644 --- a/src/plugins/omemo/store.js +++ b/src/plugins/omemo/store.js @@ -237,7 +237,7 @@ const OMEMOStore = Model.extend({ _converse.omemo_store.storeSignedPreKey(signed_prekey); bundle['signed_prekey'] = { 'id': signed_prekey.keyId, - 'public_key': u.arrayBufferToBase64(signed_prekey.keyPair.privKey), + 'public_key': u.arrayBufferToBase64(signed_prekey.keyPair.pubKey), 'signature': u.arrayBufferToBase64(signed_prekey.signature) }; const keys = await Promise.all(