Chapril/xmpp.chapril.org-conversejs
Chapril/xmpp.chapril.org-conversejs
25
0
Fork 0
Code Issues Pull Requests Projects Releases Activity

bugfix in positionGroup.

Browse Source 
Index must always be 0 if there aren't any group elements in the dom yet.
This commit is contained in:
JC Brand 2014-10-26 23:11:58 +01:00
parent 902e833dec
commit d03a9a0192
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
converse.js
View File

@ -4077,13 +4077,14 @@
/* Place the group's DOM element in the correct alphabetical /* Place the group's DOM element in the correct alphabetical
* position amongst the other groups in the roster. * position amongst the other groups in the roster.
*/ */
var index = this.model.indexOf(view.model); var $groups = this.$('.roster-group'),
index = $groups.length ? this.model.indexOf(view.model) : 0;
if (index === 0) { if (index === 0) {
this.$roster.prepend(view.$el); this.$roster.prepend(view.$el);
} else if (index == (this.model.length-1)) { } else if (index == (this.model.length-1)) {
this.appendGroup(view); this.appendGroup(view);
} else { } else {
$(this.$('.roster-group').eq(index)).before(view.$el); $($groups.eq(index)).before(view.$el);
} }
return this; return this;
}, },

2
spec/profiling.js
View File

@ -53,7 +53,7 @@
}); });
_.each(['Friends', 'Colleagues', 'Family', 'Acquaintances'], function (group) { _.each(['Friends', 'Colleagues', 'Family', 'Acquaintances'], function (group) {
var i; var i;
for (i=0; i<500; i++) { for (i=0; i<100; i++) {
stanza = stanza.c('item', { stanza = stanza.c('item', {
jid: Math.random().toString().replace('0.', '')+'@example.net', jid: Math.random().toString().replace('0.', '')+'@example.net',
subscription:'both' subscription:'both'