Chapril/xmpp.chapril.org-conversejs
Chapril/xmpp.chapril.org-conversejs
24
0
Fork 0
Code Issues Pull Requests Projects Releases Activity

updates #1691: Use listenTo

Browse Source 
so that we have automatic event deregistration when the model gets removed.
This commit is contained in:
JC Brand 2019-09-06 13:10:37 +02:00
parent b52b3e5503
commit d9c1bbf95b
1 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/headless/converse-muc.js
View File

@ -264,30 +264,48 @@ converse.plugins.add('converse-muc', {
},
onOccupantRemoved (occupant) {
this.stopListening(this.occupant);
delete this.occupant;
const chatbox = _.get(this, 'collection.chatbox');
chatbox.occupants.on('add', this.onOccupantAdded, this);
if (!chatbox) {
return _converse.log(
`Could not get collection.chatbox for message: ${this.get('id')}`,
Strophe.LogLevel.ERROR
);
}
this.listenTo(chatbox.occupants, 'add', this.onOccupantAdded);
},
onOccupantAdded (occupant) {
if (occupant.get('nick') === Strophe.getResourceFromJid(this.get('from'))) {
this.occupant = occupant;
this.occupant.on('destroy', this.onOccupantRemoved, this);
this.listenTo(this.occupant, 'destroy', this.onOccupantRemoved);
const chatbox = _.get(this, 'collection.chatbox');
chatbox.occupants.off('add', this.onOccupantAdded, this);
if (!chatbox) {
return _converse.log(
`Could not get collection.chatbox for message: ${this.get('id')}`,
Strophe.LogLevel.ERROR
);
}
this.stopListening(chatbox.occupants, 'add', this.onOccupantAdded);
}
},
setOccupant () {
if (this.get('type') !== 'groupchat') { return; }
const chatbox = _.get(this, 'collection.chatbox');
if (!chatbox) { return; }
if (!chatbox) {
return _converse.log(
`Could not get collection.chatbox for message: ${this.get('id')}`,
Strophe.LogLevel.ERROR
);
}
const nick = Strophe.getResourceFromJid(this.get('from'));
this.occupant = chatbox.occupants.findWhere({'nick': nick});
if (this.occupant) {
this.occupant.on('destroy', this.onOccupantRemoved, this);
this.listenTo(this.occupant, 'destroy', this.onOccupantRemoved);
} else {
chatbox.occupants.on('add', this.onOccupantAdded, this);
this.listenTo(chatbox.occupants, 'add', this.onOccupantAdded);
}
},