Chapril/xmpp.chapril.org-conversejs
Chapril/xmpp.chapril.org-conversejs
25
0
Fork 0
Code Issues Pull Requests Projects Releases Activity

Optimize showing of chatrooms

Browse Source 
- by using documentFragment
This commit is contained in:
JC Brand 2013-05-08 22:31:33 +02:00
parent bbf6e036c3
commit da483d63f3
1 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
converse.js
View File

@ -721,8 +721,10 @@
var name, jid, i, var name, jid, i,
rooms = $(iq).find('query').find('item'), rooms = $(iq).find('query').find('item'),
rooms_length = rooms.length, rooms_length = rooms.length,
$available_chatrooms = this.$el.find('#available-chatrooms'); $available_chatrooms = this.$el.find('#available-chatrooms'),
$available_chatrooms.find('dd.available-chatroom').remove(); fragment = document.createDocumentFragment();
$available_chatrooms.html('<dt>Available chatrooms</dt>');
if (rooms.length) { if (rooms.length) {
$available_chatrooms.find('dt').show(); $available_chatrooms.find('dt').show();
} else { } else {
@ -731,8 +733,9 @@
for (i=0; i<rooms_length; i++) { for (i=0; i<rooms_length; i++) {
name = Strophe.unescapeNode($(rooms[i]).attr('name')||$(rooms[i]).attr('jid')); name = Strophe.unescapeNode($(rooms[i]).attr('name')||$(rooms[i]).attr('jid'));
jid = $(rooms[i]).attr('jid'); jid = $(rooms[i]).attr('jid');
$available_chatrooms.append(this.room_template({'name':name, 'jid':jid})); fragment.appendChild($(this.room_template({'name':name, 'jid':jid}))[0]);
} }
$available_chatrooms.append(fragment);
return true; return true;
}, this)); }, this));
}, },
@ -1890,9 +1893,10 @@
converse.Feature = Backbone.Model.extend(); converse.Feature = Backbone.Model.extend();
converse.Features = Backbone.Collection.extend({ converse.Features = Backbone.Collection.extend({
/* This collection stores Feature Models, representing features /* Service Discovery
* -----------------
* This collection stores Feature Models, representing features
* provided by available XMPP entities (e.g. servers) * provided by available XMPP entities (e.g. servers)
*
* See XEP-0030 for more details: http://xmpp.org/extensions/xep-0030.html * See XEP-0030 for more details: http://xmpp.org/extensions/xep-0030.html
*/ */
model: converse.Feature, model: converse.Feature,
@ -1902,8 +1906,8 @@
if (this.localStorage.records.length === 0) { if (this.localStorage.records.length === 0) {
// localStorage is empty, so we've likely never queried this // localStorage is empty, so we've likely never queried this
// domain for features yet // domain for features yet
converse.connection.disco.info(converse.domain, null, $.proxy(this.onInfo, this), $.proxy(this.onError, this)); converse.connection.disco.info(converse.domain, null, $.proxy(this.onInfo, this));
converse.connection.disco.items(converse.domain, null, $.proxy(this.onItems, this), $.proxy(this.onError, this)); converse.connection.disco.items(converse.domain, null, $.proxy(this.onItems, this));
} else { } else {
this.fetch({add:true}); this.fetch({add:true});
} }
@ -1914,8 +1918,7 @@
converse.connection.disco.info( converse.connection.disco.info(
$(item).attr('jid'), $(item).attr('jid'),
null, null,
$.proxy(this.onInfo, this), $.proxy(this.onInfo, this));
$.proxy(this.onError, this));
}, this)); }, this));
}, },
@ -1932,10 +1935,6 @@
'from': $stanza.attr('from') 'from': $stanza.attr('from')
}); });
}, this)); }, this));
},
onError: function (stanza) {
console.log("Error while doing service discovery");
} }
}); });