From dc7249f07d7adf84734d6fc6882f794f1eaf4557 Mon Sep 17 00:00:00 2001 From: JC Brand Date: Thu, 13 Jul 2017 23:53:42 +0200 Subject: [PATCH] roomslist: Room name wasn't being shown in `confirm` dialog --- spec/roomslist.js | 2 +- src/templates/rooms_list_item.html | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/spec/roomslist.js b/spec/roomslist.js index 7ade3110d..4880e29e7 100644 --- a/spec/roomslist.js +++ b/spec/roomslist.js @@ -75,7 +75,7 @@ var close_el = _converse.rooms_list_view.el.querySelector(".close-room"); close_el.click(); expect(window.confirm).toHaveBeenCalledWith( - 'Are you sure you want to leave the room ""?'); + 'Are you sure you want to leave the room "lounge"?'); room_els = _converse.rooms_list_view.el.querySelectorAll(".open-room"); expect(room_els.length).toBe(0); expect(_converse.chatboxes.length).toBe(1); diff --git a/src/templates/rooms_list_item.html b/src/templates/rooms_list_item.html index 388f0d36f..e1af31dc6 100644 --- a/src/templates/rooms_list_item.html +++ b/src/templates/rooms_list_item.html @@ -2,9 +2,13 @@ {[ if (num_unread) { ]} {{{ num_unread }}} {[ } ]} -{{{name}}} +{{{name}}}   + data-room-jid="{{{jid}}}" + data-room-name="{{{name}}}" + title="{{{info_leave_room}}}" href="#">