Chapril/xmpp.chapril.org-conversejs
Chapril/xmpp.chapril.org-conversejs
24
0
Fork 0
Code Issues Pull Requests Projects Releases Activity

try/catch clauses should contain as little code as possible

Browse Source 
To avoid catching unrelated errors, which can mask other issues in the
code and make debugging more difficult
This commit is contained in:
JC Brand 2020-08-31 20:41:08 +02:00
parent 831a9fa224
commit eb016a2aa4
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/utils/html.js
View File

@ -84,10 +84,11 @@ u.isImageURL = url => {
return regex ? regex.test(url) : u.isURLWithImageExtension(url);
}
u.isImageDomainAllowed = url => {
const show_images_inline = api.settings.get('show_images_inline');
if (!Array.isArray(show_images_inline)) {
return true;
}
try {
const show_images_inline = api.settings.get('show_images_inline');
const is_domains_array = Array.isArray(show_images_inline);
if (!is_domains_array) return true;
const image_domain = getURI(url).domain();
return show_images_inline.includes(image_domain);
} catch (error) {