try/catch clauses should contain as little code as possible
To avoid catching unrelated errors, which can mask other issues in the code and make debugging more difficult
This commit is contained in:
parent
831a9fa224
commit
eb016a2aa4
@ -84,10 +84,11 @@ u.isImageURL = url => {
|
|||||||
return regex ? regex.test(url) : u.isURLWithImageExtension(url);
|
return regex ? regex.test(url) : u.isURLWithImageExtension(url);
|
||||||
}
|
}
|
||||||
u.isImageDomainAllowed = url => {
|
u.isImageDomainAllowed = url => {
|
||||||
try {
|
|
||||||
const show_images_inline = api.settings.get('show_images_inline');
|
const show_images_inline = api.settings.get('show_images_inline');
|
||||||
const is_domains_array = Array.isArray(show_images_inline);
|
if (!Array.isArray(show_images_inline)) {
|
||||||
if (!is_domains_array) return true;
|
return true;
|
||||||
|
}
|
||||||
|
try {
|
||||||
const image_domain = getURI(url).domain();
|
const image_domain = getURI(url).domain();
|
||||||
return show_images_inline.includes(image_domain);
|
return show_images_inline.includes(image_domain);
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
|
Loading…
Reference in New Issue
Block a user