Chapril/xmpp.chapril.org-conversejs
Chapril/xmpp.chapril.org-conversejs
25
0
Fork 0
Code Issues Pull Requests Projects Releases Activity

Fix bug where auto-complete list would jump to top

Browse Source
This commit is contained in:
JC Brand 2022-08-26 23:13:08 +02:00
parent a74bbd093f
commit ed1099490c
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/shared/autocomplete/autocomplete.js
View File

@ -162,7 +162,7 @@ export class AutoComplete {
this.goto(this.selected && pos !== -1 ? pos : count - 1);
}
goto (i) {
goto (i, scroll=true) {
// Should not be used directly, highlights specific item without any checks!
const list = this.ul.children;
if (this.selected) {
@ -174,8 +174,11 @@ export class AutoComplete {
list[i].setAttribute("aria-selected", "true");
list[i].focus();
this.status.textContent = list[i].textContent;
// scroll to highlighted element in case parent's height is fixed
this.ul.scrollTop = list[i].offsetTop - this.ul.clientHeight + list[i].clientHeight;
if (scroll) {
// scroll to highlighted element in case parent's height is fixed
this.ul.scrollTop = list[i].offsetTop - this.ul.clientHeight + list[i].clientHeight;
}
this.trigger("suggestion-box-highlight", {'text': this.suggestions[this.index]});
}
}
@ -198,7 +201,8 @@ export class AutoComplete {
onMouseOver (ev) {
const li = u.ancestor(ev.target, 'li');
if (li) {
this.goto(Array.prototype.slice.call(this.ul.children).indexOf(li))
const index = Array.prototype.slice.call(this.ul.children).indexOf(li);
this.goto(index, false);
}
}