Emoji picker: Make sure events persist across add/remove from DOM
This commit is contained in:
parent
d615cebcfe
commit
fbcd7cf737
@ -35,9 +35,7 @@ export default class EmojiPicker extends CustomElement {
|
|||||||
super();
|
super();
|
||||||
this._search_results = [];
|
this._search_results = [];
|
||||||
this.debouncedFilter = debounce(input => this.model.set({'query': input.value}), 250);
|
this.debouncedFilter = debounce(input => this.model.set({'query': input.value}), 250);
|
||||||
this.onGlobalKeyDown = ev => this._onGlobalKeyDown(ev);
|
this.registerEvents();
|
||||||
const body = document.querySelector('body');
|
|
||||||
body.addEventListener('keydown', this.onGlobalKeyDown);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
get search_results () {
|
get search_results () {
|
||||||
@ -109,10 +107,21 @@ export default class EmojiPicker extends CustomElement {
|
|||||||
this.requestUpdate();
|
this.requestUpdate();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
registerEvents () {
|
||||||
|
this.onGlobalKeyDown = ev => this._onGlobalKeyDown(ev);
|
||||||
|
const body = document.querySelector('body');
|
||||||
|
body.addEventListener('keydown', this.onGlobalKeyDown);
|
||||||
|
}
|
||||||
|
|
||||||
|
connectedCallback () {
|
||||||
|
super.connectedCallback();
|
||||||
|
this.registerEvents();
|
||||||
|
}
|
||||||
|
|
||||||
disconnectedCallback() {
|
disconnectedCallback() {
|
||||||
super.disconnectedCallback()
|
|
||||||
const body = document.querySelector('body');
|
const body = document.querySelector('body');
|
||||||
body.removeEventListener('keydown', this.onGlobalKeyDown);
|
body.removeEventListener('keydown', this.onGlobalKeyDown);
|
||||||
|
super.disconnectedCallback()
|
||||||
}
|
}
|
||||||
|
|
||||||
_onGlobalKeyDown (ev) {
|
_onGlobalKeyDown (ev) {
|
||||||
@ -313,6 +322,11 @@ export class EmojiDropdown extends BaseDropdown {
|
|||||||
</div>`;
|
</div>`;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
connectedCallback () {
|
||||||
|
super.connectedCallback();
|
||||||
|
this.render_emojis = false;
|
||||||
|
}
|
||||||
|
|
||||||
toggleMenu (ev) {
|
toggleMenu (ev) {
|
||||||
ev.stopPropagation();
|
ev.stopPropagation();
|
||||||
ev.preventDefault();
|
ev.preventDefault();
|
||||||
|
Loading…
Reference in New Issue
Block a user