From feac7363aed7a4c05dc6f61429b2a5de63be156b Mon Sep 17 00:00:00 2001
From: JC Brand <jc@opkode.com>
Date: Mon, 20 May 2013 22:16:35 +0200
Subject: [PATCH] Bugfix in room configuration code.

---
 converse.css | 1 +
 converse.js  | 9 +++++----
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/converse.css b/converse.css
index de2376398..d02e35f0c 100644
--- a/converse.css
+++ b/converse.css
@@ -536,6 +536,7 @@ p.room-info {
 a.room-info {
     background: url('images/information.png') no-repeat right top;
     width: 22px;
+    height: 22px;
     float: right;
     display: none;
 }
diff --git a/converse.js b/converse.js
index 2598a8a2d..486ca0b69 100644
--- a/converse.js
+++ b/converse.js
@@ -1138,6 +1138,7 @@
             for (i=0; i<$fields.length; i++) {
                 $field = $($fields[i]);
                 if ($field.attr('type') == 'list-single') {
+                    options = [];
                     $options = $field.find('option');
                     for (j=0; j<$options.length; j++) {
                         options.push(this.select_option_template({
@@ -1155,7 +1156,7 @@
                         name: $field.attr('var'),
                         type: input_types[$field.attr('type')],
                         label: $field.attr('label') || '',
-                        checked: $field.find('value').text() && 'checked="1"' || ''
+                        checked: $field.find('value').text() === "1" && 'checked="1"' || ''
                     }));
                 } else {
                     $form.append(this.form_input_template({
@@ -1196,8 +1197,8 @@
                     converse.connection.muc.saveConfiguration(
                         that.model.get('jid'),
                         configArray,
-                        that.onConfigSaved,
-                        that.onErrorConfigSaved
+                        $.proxy(that.onConfigSaved, that),
+                        $.proxy(that.onErrorConfigSaved, that)
                     );
                 }
             });
@@ -1214,7 +1215,7 @@
         },
 
         onErrorConfigSaved: function (stanza) {
-            // XXX
+            this.insertStatusNotification("An error occurred while trying to save the form.");
         },
 
         cancelConfiguration: function (ev) {