Commit Graph

2578 Commits

Author SHA1 Message Date
JC Brand
e3fa8325b8 Add initial vcard support 2013-03-03 17:27:14 +02:00
JC Brand
65bbe800e2 Merge pull request #6 from ichim-david/master
More code optimizations
2013-03-03 07:24:44 -08:00
ichim-david
a9df31e184 Added changes.rst entry for this pull request 2013-03-02 09:38:41 +02:00
ichim-david
c4cafb8c4f Changed the following:
- Chain calls on initialize method of RosterView
- Moved dom insertion out of loops on initialize method of
  XMPPStatusView
2013-03-02 09:32:26 +02:00
ichim-david
d8e4f848b6 Wrap this with jQuery only once in subscribeToSuggestedItems; Same thing with presence in presenceHandler 2013-03-02 09:05:23 +02:00
ichim-david
58bbbe8b9d Cached message from attribute of messageReceived method 2013-03-02 08:54:41 +02:00
ichim-david
e635fb4fc4 Chain jQuery methods for show and render of onChatRoomMessage 2013-03-02 08:41:51 +02:00
ichim-david
5ee9a678c9 Changed the following:
- removed extra jQuerify wrapping of message at onChatRoomMessage
- Construct an array of strings and add it to onChatRoomRoster only
  after loop is done in order to have only 1 dom insertion
2013-03-02 08:36:47 +02:00
ichim-david
764a710158 Cached presence for onChatRoomPresence and removed length comparision to > 0 2013-03-02 08:28:50 +02:00
ichim-david
300b069a0e Use ; Do only one dom insertion in case of /help 2013-03-01 21:53:48 +02:00
ichim-david
6afb091d12 Cached available-chatrooms calls to avoid dom calls on updateRoomList 2013-03-01 21:46:02 +02:00
ichim-david
18f877b59c Changed the following:
- Chained call to render and show methods of ChatBoxView
- Cached target for subscribeToContact
- Removed check of length > 0
2013-03-01 21:38:47 +02:00
ichim-david
5c5b7b9dd7 Changed the following:
- Removed situation where extra data passed in keyPressed was overriden
  with the same result because of the two assignments inside the if
  statements
- Cached fullname and presence_type at initialize of ChatBoxView
2013-03-01 21:23:55 +02:00
ichim-david
87d66b0dec Changed the following:
- Cached length of every iteration in order to avoid having to calculate
  length on every iteration
- Changed insertClientStoredMessaged length check to use the simple length of
  the array instead of using underscore size since
- Added description with need of underscore size method for roster on
  onChatRoomRoster since the roster is an object not an array
2013-03-01 21:07:27 +02:00
ichim-david
fdddecbeb2 Fixed the following:
- Added missing var statements for variable declarations
- Added TODO entries for code that needs to be used or further tested
- Removed unused variables
- Removed check of length > 0 as it's enought to check just item.length
  as a boolean
- Renamed scrolldown to scrollDown to keep a consitent style of method
  naming
- Removed extra jQuery wrapping for many objects and instead define it
  once and use it in the other places
- Use jQuery chaining for modifying connecting message in
  jarn.disconnect
- Define wrapped message in messageReceived from line 342 instead of
  expecting it to be received from the other messageReceived function
2013-03-01 20:43:41 +02:00
JC Brand
8b84ce346e Rename to contributing. #4 2013-03-01 13:43:32 +02:00
JC Brand
b89155a330 Add CONTRIBUTE.rst. For #4 2013-03-01 11:10:23 +02:00
JC Brand
7a38d58e83 Update readme and add CHANGES.rst 2013-03-01 10:55:54 +02:00
JC Brand
10be57aec4 Add strinclude function 2013-02-28 20:42:08 +02:00
JC Brand
d7cb92c7af Merge pull request #3 from ichim-david/master
Optimize actions done in RosterView.
2013-02-28 00:31:46 -08:00
ichim-david
732f941e20 Fixed first jasmine test for visibility of xmpp-roster 2013-02-28 07:48:06 +02:00
JC Brand
e6c5a6c5c4 Merge pull request #2 from alecghica/master
Code clean up + updated error message
2013-02-25 23:21:58 -08:00
Alexandru Ghica
0f9c088c41 Added error_icon.png and spinner.gif images
Added error_icon.png and spinner.gif images to not make it dependent of
Plone resources.
2013-02-25 16:29:45 +02:00
ichim-david
fe0034f123 Check also if subscription === to in order to correctly move the accepted contact subscription from pending to current 2013-02-25 14:34:02 +02:00
ichim-david
63134858d7 Properly hide or show dt that no longer have dd adjacent 2013-02-24 11:31:47 +02:00
ichim-david
19caf7c448 Prevent default event for the removeContact link in order to avoid page reload when jQuery Dialog is openened from clicking on the delete link 2013-02-24 10:59:57 +02:00
ichim-david
00aba6a9cd Move the event handlers on the view instead of registering them in render method of RosterItemView 2013-02-23 22:20:53 +02:00
ichim-david
7daa681ac3 Show dt elements on xmppchat-roster only if they have length and they are not already visible to avoid making them all the time visible when they might already be so 2013-02-23 16:49:01 +02:00
ichim-david
85e9c7cecc Changed the following:
- Subscribe event with help of jQuery one instead of delegate, now that
  the rosterView is no longer emptied on every render to avoid
  registring several handlers of remove action, which meant you had to
  click 4 times for the jQuery Dialog to go away
- Remove the element from the rosterView when the remove event is
  triggered on the model which removes just that item instead of
  emptying the list and appending the remaining models again
2013-02-23 16:17:00 +02:00
ichim-david
d8d3a34737 Fixed a bug where controlbox wasn't available on xmppchat.chatboxesview, instead pass the removal of the model to rosterview.model 2013-02-23 15:43:20 +02:00
ichim-david
083f76b7cc Fixed merge conflicts for converse.js 2013-02-22 16:45:42 +02:00
Alexandru Ghica
8c45f23255 Better message on error
Changed message from "conecting" to "error" as in this case
communication was over and was an error.
2013-02-22 15:51:50 +02:00
Alexandru Ghica
b6af624b14 Code clean up
Cleaned up unnecessary spaces, replaced tabs with spaces and fixed line
terminators.
2013-02-22 15:42:35 +02:00
ichim-david
32ebfe5372 Changed the following:
- Show the xmppchat-roster only after all of the items have been added
  from first run of rosterHandler
- Resort the items only when the presence has changed and not when the
  resource attribute has changed
2013-02-22 14:29:49 +02:00
ichim-david
66d7b51535 Changed the following:
- Pass an option object to addRosterItem which can contains information about
  the object catched in the rosterHandler.
  In this case I am marking the last item available in the roster of the
  person for which this handler is triggered
2013-02-21 22:36:41 +02:00
ichim-david
a256645d6d Removed rendering of rosterview since I've added check to render only with passed item and the result is the same without the rendering 2013-02-21 22:24:09 +02:00
ichim-david
3cf671884c Fixed the following:
- Fixed function has inconsistent return points by always specifying
  returns instead of returning only on condition
- Set room-jid as data-room-jid attribute to validate html5
- Added missing semicolon
2013-02-21 21:28:40 +02:00
ichim-david
447c3a8d41 Set modifications of model attributes only if the item received from the rosterHandler has different options 2013-02-21 20:57:22 +02:00
JC Brand
ffbacad969 Merge branch 'master' of github.com:jcbrand/converse.js
Conflicts:
	converse.js
2013-02-21 14:46:05 +02:00
JC Brand
75b9a35e8d Bugfix. Time on old messages shown incorrectly.
Also other backports from production.
2013-02-21 14:42:30 +02:00
JC Brand
1c7ef1917c Merge pull request #1 from alecghica/master
Feature: added "Connecting to chat ..." info
2013-02-21 04:26:40 -08:00
Alexandru Ghica
53b2878405 Reverted cleanup made on Libraries/strophe.js 2013-02-21 11:39:38 +02:00
Alexandru Ghica
4bbf5b054d Feature: added "Connecting to chat ..." info
- Feature: added spining image and "Connecting to chat ..." info under chat panel
  when the user is not (yet) binded to the jabber server
  [alecghica]
2013-02-20 18:21:07 +02:00
ichim-david
95fdf98ea6 Pass item to render method of RosterView instead of looping over each item on every render call, Inverted visibility logic for contact titles in order to avoid multiple show and hide 2013-02-20 15:36:55 +02:00
ichim-david
a875ba51a0 Moved assignment of template for RosterView out of the render method to avoid calling empty and readding items everytime the render method is called 2013-02-19 18:16:05 +02:00
JC Brand
3224a8c522 Add underscore as a dependency and use it and jQuery
This has fixed some IE8 errors while parsing the presence stanza
2012-12-11 16:31:39 +02:00
JC Brand
aad263868a Fixed JSLint warnings 2012-12-11 15:21:56 +02:00
JC Brand
dbf20052c3 console can be defined higher up 2012-12-11 13:45:25 +02:00
JC Brand
d38af7ed89 Also handle case where AMD is not present 2012-12-11 13:45:08 +02:00
JC Brand
cc99f4f989 Cleanup and indented. Add AMD/global registrations 2012-12-11 13:41:48 +02:00