- Don't do an ajax call when a user wants to subscribe. We wanted to get the
user's fullname, but this is now handled via vCards
- openChat is now only for roster items. Call showChat for controlbox and
createChatRoom for rooms.
- removed extra jQuerify wrapping of message at onChatRoomMessage
- Construct an array of strings and add it to onChatRoomRoster only
after loop is done in order to have only 1 dom insertion
- Removed situation where extra data passed in keyPressed was overriden
with the same result because of the two assignments inside the if
statements
- Cached fullname and presence_type at initialize of ChatBoxView
- Cached length of every iteration in order to avoid having to calculate
length on every iteration
- Changed insertClientStoredMessaged length check to use the simple length of
the array instead of using underscore size since
- Added description with need of underscore size method for roster on
onChatRoomRoster since the roster is an object not an array
- Added missing var statements for variable declarations
- Added TODO entries for code that needs to be used or further tested
- Removed unused variables
- Removed check of length > 0 as it's enought to check just item.length
as a boolean
- Renamed scrolldown to scrollDown to keep a consitent style of method
naming
- Removed extra jQuery wrapping for many objects and instead define it
once and use it in the other places
- Use jQuery chaining for modifying connecting message in
jarn.disconnect
- Define wrapped message in messageReceived from line 342 instead of
expecting it to be received from the other messageReceived function
- Subscribe event with help of jQuery one instead of delegate, now that
the rosterView is no longer emptied on every render to avoid
registring several handlers of remove action, which meant you had to
click 4 times for the jQuery Dialog to go away
- Remove the element from the rosterView when the remove event is
triggered on the model which removes just that item instead of
emptying the list and appending the remaining models again
- Show the xmppchat-roster only after all of the items have been added
from first run of rosterHandler
- Resort the items only when the presence has changed and not when the
resource attribute has changed
- Pass an option object to addRosterItem which can contains information about
the object catched in the rosterHandler.
In this case I am marking the last item available in the roster of the
person for which this handler is triggered
