From 03a11c63bd9450a857b5c2d60c0c7337280918e3 Mon Sep 17 00:00:00 2001
From: Badlop <badlop@process-one.net>
Date: Tue, 11 Jan 2022 17:19:12 +0100
Subject: [PATCH] Fix login when generating client id, keep connection record
 (#3593)

---
 src/mod_mqtt_session.erl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mod_mqtt_session.erl b/src/mod_mqtt_session.erl
index ca025e3d2..e7737804e 100644
--- a/src/mod_mqtt_session.erl
+++ b/src/mod_mqtt_session.erl
@@ -1134,8 +1134,8 @@ is_expired(#publish{meta = Meta, properties = Props} = Pkt) ->
 %%% Authentication
 %%%===================================================================
 -spec parse_credentials(connect()) -> {ok, jid:jid()} | {error, reason_code()}.
-parse_credentials(#connect{client_id = <<>>}) ->
-    parse_credentials(#connect{client_id = p1_rand:get_string()});
+parse_credentials(#connect{client_id = <<>>} = C) ->
+    parse_credentials(C#connect{client_id = p1_rand:get_string()});
 parse_credentials(#connect{username = <<>>, client_id = ClientID}) ->
     Host = ejabberd_config:get_myname(),
     JID = case jid:make(ClientID, Host) of