Take in account subscriber's affiliation when checking access to moderated room

This should fix issue #3525

src/mod_muc_room.erl

@@ -939,12 +939,28 @@ process_groupchat_message(#message{from = From, lang = Lang} = Packet, StateData
 	of
       true ->
 	  {FromNick, Role} = get_participant_data(From, StateData),
-	  if (Role == moderator) or (Role == participant) or
+	  #config{members_by_default = MBD,
-	     (IsSubscriber andalso ((StateData#state.config)#config.members_by_default == true)) or
+		  moderated = Moderated} = StateData#state.config,
-	       ((StateData#state.config)#config.moderated == false) ->
+	  AllowedByModerationRules =
+	  case {Role == moderator orelse Role == participant orelse
+		not Moderated orelse MBD, IsSubscriber} of
+	      {true, _} -> true;
+	      {_, true} ->
+		  case get_default_role(get_affiliation(From, StateData),
+					StateData) of
+		      moderator -> true;
+		      participant -> true;
+		      _ -> false
+		  end;
+	      _ ->
+		  false
+	  end,
+	  if AllowedByModerationRules ->
 	      Subject = check_subject(Packet),
-		 {NewStateData1, IsAllowed} = case Subject of
+	      {NewStateData1, IsAllowed} =
-						[] -> {StateData, true};
+	      case Subject of
+		  [] ->
+		      {StateData, true};
 		  _ ->
 		      case
 			  can_change_subject(Role,
@@ -953,12 +969,8 @@ process_groupchat_message(#message{from = From, lang = Lang} = Packet, StateData
 		      of
 			  true ->
 			      NSD =
-							      StateData#state{subject
+			      StateData#state{subject = Subject,
-										  =
+					      subject_author = FromNick},
-										  Subject,
-									      subject_author
-										  =
-										  FromNick},
 			      store_room(NSD),
 			      {NSD, true};
 			  _ -> {StateData, false}