From 3c896d1c6a35f0ebc5aac9de51d3f8dd4f18826e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pawe=C5=82=20Chmielowski?= <pawel@process-one.net>
Date: Mon, 2 Sep 2024 12:49:39 +0200
Subject: [PATCH] Better handling of malformed jids in `send_direct_invitation`
 command

---
 src/mod_muc_admin.erl | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/mod_muc_admin.erl b/src/mod_muc_admin.erl
index 3fb112c2f..313a4721b 100644
--- a/src/mod_muc_admin.erl
+++ b/src/mod_muc_admin.erl
@@ -1501,8 +1501,10 @@ send_direct_invitation(RoomName, RoomService, Password, Reason, UsersStrings) ->
 get_users_to_invite(RoomJid, UsersStrings) ->
     OccupantsTuples = get_room_occupants(RoomJid#jid.luser,
 					 RoomJid#jid.lserver),
-    OccupantsJids = [jid:decode(JidString)
-		     || {JidString, _Nick, _} <- OccupantsTuples],
+    OccupantsJids = try [jid:decode(JidString)
+			 || {JidString, _Nick, _} <- OccupantsTuples]
+		    catch _:{bad_jid, _} -> throw({error, "Malformed JID of invited user"})
+		    end,
     lists:filtermap(
       fun(UserString) ->
 	      UserJid = jid:decode(UserString),