Don't expose internal FSM API of ejabberd_c2s

src/mod_admin_extra.erl

@@ -1510,16 +1510,24 @@ send_stanza(FromString, ToString, Stanza) ->
 	    {error, "JID malformed"}
     end.
 
+-spec send_stanza_c2s(binary(), binary(), binary(), binary()) -> ok | {error, any()}.
 send_stanza_c2s(Username, Host, Resource, Stanza) ->
-    case {fxml_stream:parse_element(Stanza),
+    try
-          ejabberd_sm:get_session_pid(Username, Host, Resource)}
+	#xmlel{} = El = fxml_stream:parse_element(Stanza),
-    of
+	CodecOpts = ejabberd_config:codec_options(),
-	{{error, Error}, _} ->
+	Pkt = xmpp:decode(El, ?NS_CLIENT, CodecOpts),
-	    {error, Error};
+	case ejabberd_sm:get_session_pid(Username, Host, Resource) of
-	{_, none} ->
+	    Pid when is_pid(Pid) ->
-	    {error, no_session};
+		ejabberd_c2s:send(Pid, Pkt);
-	{XmlEl, C2sPid} ->
+	    _ ->
-	    p1_fsm:send_event(C2sPid, {xmlstreamelement, XmlEl})
+		{error, no_session}
+	end
+    catch _:{badmatch, {error, Why} = Err} ->
+	    io:format("invalid xml: ~p~n", [Why]),
+	    Err;
+	  _:{xmpp_codec, Why} ->
+	    io:format("incorrect stanza: ~s~n", [xmpp:format_error(Why)]),
+	    {error, Why}
     end.
 
 privacy_set(Username, Host, QueryS) ->