From 49214d9cc5a671bf6e455bcd0ca6af89f16ca2c8 Mon Sep 17 00:00:00 2001
From: Evgeny Khramtsov <ekhramtsov@process-one.net>
Date: Mon, 24 Jun 2019 21:09:29 +0300
Subject: [PATCH] Report invalid translation strings

---
 tools/extract-tr.sh | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/tools/extract-tr.sh b/tools/extract-tr.sh
index 0375a1f21..242a81fec 100755
--- a/tools/extract-tr.sh
+++ b/tools/extract-tr.sh
@@ -10,8 +10,13 @@ main(Paths) ->
     generate_pot(Dict).
 
 extract_tr(File, [{'?', _}, {var, _, 'T'}, {'(', Line}|Tokens], Acc) ->
-    {String, Tokens1} = extract_string(Tokens, []),
-    extract_tr(File, Tokens1, dict:append(String, {File, Line}, Acc));
+    case extract_string(Tokens, "") of
+	{"", Tokens1} ->
+	    err("~s:~B: Warning: invalid string", [File, Line]),
+	    extract_tr(File, Tokens1, Acc);
+	{String, Tokens1} ->
+	    extract_tr(File, Tokens1, dict:append(String, {File, Line}, Acc))
+    end;
 extract_tr(File, [_|Tokens], Acc) ->
     extract_tr(File, Tokens, Acc);
 extract_tr(_, [], Acc) ->
@@ -19,8 +24,10 @@ extract_tr(_, [], Acc) ->
 
 extract_string([{string, _, S}|Tokens], Acc) ->
     extract_string(Tokens, [S|Acc]);
-extract_string(Tokens, Acc) ->
-    {lists:flatten(lists:reverse(Acc)), Tokens}.
+extract_string([{')', _}|Tokens], Acc) ->
+    {lists:flatten(lists:reverse(Acc)), Tokens};
+extract_string(Tokens, _) ->
+    {"", Tokens}.
 
 fold_erls(Fun, State, Paths) ->
     Paths1 = fold_paths(Paths),