Chapril/xmpp.chapril.org-ejabberd
25
1
Fork 0
mirror of https://github.com/processone/ejabberd.git synced 2024-11-22 16:20:52 +01:00
Code Releases Activity

fix previous fix misplacing (EJAB-840)

Browse Source 
SVN Revision: 1803
This commit is contained in:
Christophe Romain 2009-01-11 06:24:42 +00:00
parent 89be1c2ede
commit 56bccce713
2 changed files with 42 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
src/mod_pubsub/mod_pubsub.erl
View File

@ -1897,18 +1897,33 @@ set_affiliations(Host, Node, From, EntitiesEls) ->
{error, 'bad-request'};
_ ->
Action = fun(#pubsub_node{type = Type, owners = Owners}) ->
case lists:member(Owner, Owners) of
true ->
lists:foreach(
fun({JID, Affiliation}) ->
node_call(
Type, set_affiliation,
[Host, Node, JID, Affiliation])
end, Entities),
{result, []};
_ ->
{error, 'forbidden'}
end
case lists:member(Owner, Owners) of
true ->
lists:foreach(
fun({JID, Affiliation}) ->
node_call(Type, set_affiliation, [Host, Node, JID, Affiliation]),
case Affiliation of
owner ->
NewOwner = jlib:short_prepd_bare_jid(JID),
NewOwners = [NewOwner|Owners],
tree_call(Host, set_node, [N#pubsub_node{owners = NewOwners}]);
none ->
NewOwner = jlib:short_prepd_bare_jid(JID),
case lists:member(OldOwner, Owners) of
true ->
NewOwners = Owners--[OldOwner],
tree_call(Host, set_node, [N#pubsub_node{owners = NewOwners}]);
_ ->
ok
end;
_ ->
ok
end
end, Entities),
{result, []};
_ ->
{error, 'forbidden'}
end
end,
transaction(Host, Node, Action, sync_dirty)
end.
@ -2031,33 +2046,18 @@ set_subscriptions(Host, Node, From, EntitiesEls) ->
{error, 'bad-request'};
_ ->
Action = fun(#pubsub_node{type = Type, owners = Owners}) ->
case lists:member(Owner, Owners) of
true ->
lists:foreach(
fun({JID, Affiliation}) ->
node_call(Type, set_affiliation, [Host, Node, JID, Affiliation]),
case Affiliation of
owner ->
NewOwner = jlib:short_prepd_bare_jid(JID),
NewOwners = [NewOwner|Owners],
tree_call(Host, set_node, [N#pubsub_node{owners = NewOwners}]);
none ->
NewOwner = jlib:short_prepd_bare_jid(JID),
case lists:member(OldOwner, Owners) of
true ->
NewOwners = Owners--[OldOwner],
tree_call(Host, set_node, [N#pubsub_node{owners = NewOwners}]);
_ ->
ok
end;
_ ->
ok
end
end, Entities),
{result, []};
_ ->
{error, 'forbidden'}
end
case lists:member(Owner, Owners) of
true ->
lists:foreach(
fun({JID, Subscription}) ->
node_call(
Type, set_subscription,
[Host, Node, JID, Subscription])
end, Entities),
{result, []};
_ ->
{error, 'forbidden'}
end
end,
transaction(Host, Node, Action, sync_dirty)
end.

6
src/mod_pubsub/node_default.erl
View File

@ -358,6 +358,9 @@ unsubscribe_node(Host, Node, Sender, Subscriber, _SubId) ->
_ -> get_state(Host, Node, SubKey)
end,
if
%% Requesting entity is prohibited from unsubscribing entity
not Authorized ->
{error, 'forbidden'};
%% Entity did not specify SubID
%%SubID == "", ?? ->
%% {error, ?ERR_EXTENDED('bad-request', "subid-required")};
@ -367,9 +370,6 @@ unsubscribe_node(Host, Node, Sender, Subscriber, _SubId) ->
%% Requesting entity is not a subscriber
SubState#pubsub_state.subscription == none ->
{error, ?ERR_EXTENDED('unexpected-request', "not-subscribed")};
%% Requesting entity is prohibited from unsubscribing entity
not Authorized ->
{error, 'forbidden'};
%% Was just subscriber, remove the record
SubState#pubsub_state.affiliation == none ->
del_state(SubState#pubsub_state.stateid),