From 76447a8810844050bba2ac7dd2473be176cde2ed Mon Sep 17 00:00:00 2001 From: Christophe Romain Date: Fri, 28 May 2010 14:25:06 +0200 Subject: [PATCH] fix error code when unsubscribing from a non-existent node (needs exmpp from e8f1096) (EJAB-1227) --- src/mod_pubsub/node_flat.erl | 4 ++-- src/mod_pubsub/node_flat_odbc.erl | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mod_pubsub/node_flat.erl b/src/mod_pubsub/node_flat.erl index 985bc9421..c4f7c7311 100644 --- a/src/mod_pubsub/node_flat.erl +++ b/src/mod_pubsub/node_flat.erl @@ -356,7 +356,7 @@ unsubscribe_node(NodeId, Sender, {U, S, R} = Subscriber, SubId) -> %% {error, ?ERR_EXTENDED('not-acceptable', "invalid-subid")}; %% Requesting entity is not a subscriber Subscriptions == [] -> - {error, ?ERR_EXTENDED('unexpected-request', "not-subscribed")}; + {error, ?ERR_EXTENDED('unexpected-request-cancel', "not-subscribed")}; %% Subid supplied, so use that. SubIdExists -> Sub = first_in_list(fun({_, Id}) when Id == SubId -> true; @@ -367,7 +367,7 @@ unsubscribe_node(NodeId, Sender, {U, S, R} = Subscriber, SubId) -> delete_subscriptions(Subscriber, NodeId, [Subscribed], SubState), {result, default}; false -> - {error, ?ERR_EXTENDED('unexpected-request', "not-subscribed")} + {error, ?ERR_EXTENDED('unexpected-request-cancel', "not-subscribed")} end; %% Asking to remove all subscriptions to the given node SubId == all -> diff --git a/src/mod_pubsub/node_flat_odbc.erl b/src/mod_pubsub/node_flat_odbc.erl index f259260b6..9b7a1181d 100644 --- a/src/mod_pubsub/node_flat_odbc.erl +++ b/src/mod_pubsub/node_flat_odbc.erl @@ -369,7 +369,7 @@ unsubscribe_node(NodeId, Sender, Subscriber, SubId) -> %% {error, ?ERR_EXTENDED('not-acceptable', "invalid-subid")}; %% Requesting entity is not a subscriber Subscriptions == [] -> - {error, ?ERR_EXTENDED('unexpected-request', "not-subscribed")}; + {error, ?ERR_EXTENDED('unexpected-request-cancel', "not-subscribed")}; %% Subid supplied, so use that. SubIdExists -> Sub = first_in_list(fun(S) -> @@ -383,7 +383,7 @@ unsubscribe_node(NodeId, Sender, Subscriber, SubId) -> delete_subscription(SubKey, NodeId, S, Affiliation, Subscriptions), {result, default}; false -> - {error, ?ERR_EXTENDED('unexpected-request', "not-subscribed")} + {error, ?ERR_EXTENDED('unexpected-request-cancel', "not-subscribed")} end; %% Asking to remove all subscriptions to the given node SubId == all ->