From 9a8a8437249792b8d230e36c4bf2855f5607cc9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonah=20Br=C3=BCchert?= Date: Sat, 2 Jul 2022 20:20:24 +0200 Subject: [PATCH] Fix filter_nodes The previous implementation always returned an empty list while testing it. However I don't really understand why that happened. The list comprehension based one works, although it looks equivalent to me. --- src/mod_mix.erl | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mod_mix.erl b/src/mod_mix.erl index 256715af0..315c7b80d 100644 --- a/src/mod_mix.erl +++ b/src/mod_mix.erl @@ -593,10 +593,8 @@ known_nodes() -> -spec filter_nodes([binary()]) -> [binary()]. filter_nodes(Nodes) -> - lists:filter( - fun(Node) -> - lists:member(Node, Nodes) - end, known_nodes()). + KnownNodes = known_nodes(), + [Node || KnownNode <- KnownNodes, Node <- Nodes, KnownNode == Node]. -spec multicast(module(), binary(), binary(), binary(), binary(), fun((jid()) -> message())) -> ok.