Chapril/xmpp.chapril.org-ejabberd
25
1
Fork 0
mirror of https://github.com/processone/ejabberd.git synced 2024-11-22 16:20:52 +01:00
Code Releases Activity

Use the syntax PRIMARY KEY (field(int)) only for MySQL (EJAB-1337)

Browse Source
This commit is contained in:
Badlop 2011-09-02 13:49:46 +02:00
parent edda5e1747
commit ad6218cdf2
1 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/gen_storage_odbc.erl
View File

@ -162,12 +162,7 @@ create_table(#tabdef{name = Tab,
end, {"", []}, Attributes), end, {"", []}, Attributes),
TabS = atom_to_list(Tab), TabS = atom_to_list(Tab),
PKey = case TableType of PKey = case TableType of
%% This 105 limits the size of fields in the primary key. set -> primary_key_string(Host, K);
%% That prevents MySQL from complaining when setting the
%% last_activity key (text, text) with this error:
%% #42000Specified key was too long; max key length is 1000bytes"
%% Similarly for rosteritem and other tables, maybe also PgSQL.
set -> [", PRIMARY KEY (", string:join(K, "(105), "), "(105))"];
bag -> [] bag -> []
end, end,
case odbc_command(Host, case odbc_command(Host,
@ -192,6 +187,22 @@ create_table(#tabdef{name = Tab,
{aborted, Reason} {aborted, Reason}
end. end.
%% This 105 limits the size of fields in the primary key.
%% That prevents MySQL from complaining when setting the
%% last_activity key (text, text) with this error:
%% #42000Specified key was too long; max key length is 1000bytes"
%% Similarly for rosteritem and other tables.
primary_key_string(Host, K) ->
Dbtype = ejabberd_odbc:db_type(Host),
case Dbtype of
mysql ->
[", PRIMARY KEY (", string:join(K, "(105), "), "(105))"];
odbc ->
[", PRIMARY KEY (", string:join(K, ", "), ")"];
pgsql ->
[", PRIMARY KEY (", string:join(K, ", "), ")"]
end.
type_to_sql_type(Type, false = _NoTextKeys) -> type_to_sql_type(Type, false = _NoTextKeys) ->
type_to_sql_type(Type); type_to_sql_type(Type);
type_to_sql_type(Type, true = _NoTextKeys) -> type_to_sql_type(Type, true = _NoTextKeys) ->