From c718cbbd9fcc73bfb5b0341067e49325bae3c841 Mon Sep 17 00:00:00 2001 From: Evgeniy Khramtsov Date: Thu, 7 Jul 2016 11:34:17 +0300 Subject: [PATCH] Warn on cyclic modules dependencies --- src/gen_mod.erl | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/gen_mod.erl b/src/gen_mod.erl index 521ed1b3f..c4306577c 100644 --- a/src/gen_mod.erl +++ b/src/gen_mod.erl @@ -111,7 +111,14 @@ sort_modules(Host, ModOpts) -> [DepMod, Mod]); {DepMod, DepOpts} -> digraph:add_vertex(G, DepMod, DepOpts), - digraph:add_edge(G, DepMod, Mod) + case digraph:add_edge(G, DepMod, Mod) of + {error, {bad_edge, Path}} -> + ?WARNING_MSG("cyclic dependency detected " + "between modules: ~p", + [Path]); + _ -> + ok + end end end, Deps) end, ModOpts),