Chapril/xmpp.chapril.org-ejabberd
25
1
Fork 0
mirror of https://github.com/processone/ejabberd.git synced 2024-12-22 17:28:25 +01:00
Code Releases Activity

subscribing to a node sends only last items (EJAB-700), send_last_items bugfix

Browse Source 
SVN Revision: 1474
This commit is contained in:
Christophe Romain 2008-07-23 01:14:02 +00:00
parent 7a49880ffc
commit d8dc734d38
2 changed files with 21 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@ -2,7 +2,8 @@
* src/mod_pubsub/mod_pubsub.erl: remove_user hook removes
subscriptions (EJAB-684), send the last published and not the
first published item (EJAB-675), remove the pubsub/nodes tree.
first published item (EJAB-675), remove the pubsub/nodes tree,
subscribing to a node sends only last items (EJAB-700)
* src/mod_pubsub/node_pep.erl: added acl and jid match on node
creation permission (EJAB-663)
* src/mod_pubsub/node_default.erl: fix node creation permission

34
src/mod_pubsub/mod_pubsub.erl
View File

@ -1385,7 +1385,7 @@ subscribe_node(Host, Node, From, JID) ->
{error, Error} ->
{error, Error};
{result, {Result, subscribed, send_last}} ->
send_all_items(Host, Node, Subscriber),
send_last_item(Host, Node, Subscriber),
case Result of
default -> {result, Reply(subscribed)};
_ -> {result, Result}
@ -1732,21 +1732,25 @@ send_last_item(Host, Node, LJID) ->
%% TODO use cache-last-item feature
send_items(Host, Node, LJID, Number) ->
Items = get_items(Host, Node),
ToSend = case Number of
last -> hd(lists:reverse(Items));
all -> Items;
N when N > 0 -> lists:nthtail(length(Items)-N, Items);
_ -> Items
end,
ToSend = case get_items(Host, Node) of
[] ->
[];
Items ->
case Number of
last -> lists:sublist(lists:reverse(Items), 1);
all -> Items;
N when N > 0 -> lists:nthtail(length(Items)-N, Items);
_ -> Items
end
end,
ItemsEls = lists:map(
fun(#pubsub_item{itemid = {ItemId, _}, payload = Payload}) ->
ItemAttrs = case ItemId of
"" -> [];
_ -> [{"id", ItemId}]
end,
{xmlelement, "item", ItemAttrs, Payload}
end, ToSend),
fun(#pubsub_item{itemid = {ItemId, _}, payload = Payload}) ->
ItemAttrs = case ItemId of
"" -> [];
_ -> [{"id", ItemId}]
end,
{xmlelement, "item", ItemAttrs, Payload}
end, ToSend),
Stanza = {xmlelement, "message", [],
[{xmlelement, "event", [{"xmlns", ?NS_PUBSUB_EVENT}],
[{xmlelement, "items", [{"node", node_to_string(Node)}],