mirror of
https://github.com/processone/ejabberd.git
synced 2024-09-27 14:30:55 +02:00
836 lines
31 KiB
Diff
836 lines
31 KiB
Diff
--- mod_pubsub.erl 2010-05-03 14:32:48.000000000 +0200
|
|
+++ mod_pubsub_odbc.erl 2010-05-03 14:33:50.000000000 +0200
|
|
@@ -42,7 +42,7 @@
|
|
%%% 6.2.3.1, 6.2.3.5, and 6.3. For information on subscription leases see
|
|
%%% XEP-0060 section 12.18.
|
|
|
|
--module(mod_pubsub).
|
|
+-module(mod_pubsub_odbc).
|
|
-author('christophe.romain@process-one.net').
|
|
-version('1.13-0').
|
|
|
|
@@ -55,9 +55,9 @@
|
|
-include("adhoc.hrl").
|
|
-include("pubsub.hrl").
|
|
|
|
--define(STDTREE, "tree").
|
|
--define(STDNODE, "flat").
|
|
--define(PEPNODE, "pep").
|
|
+-define(STDTREE, "tree_odbc").
|
|
+-define(STDNODE, "flat_odbc").
|
|
+-define(PEPNODE, "pep_odbc").
|
|
|
|
%% exports for hooks
|
|
-export([presence_probe/3,
|
|
@@ -105,7 +105,7 @@
|
|
string_to_affiliation/1,
|
|
extended_error/2,
|
|
extended_error/3,
|
|
- rename_default_nodeplugin/0
|
|
+ escape/1
|
|
]).
|
|
|
|
%% API and gen_server callbacks
|
|
@@ -124,7 +124,7 @@
|
|
-export([send_loop/1
|
|
]).
|
|
|
|
--define(PROCNAME, ejabberd_mod_pubsub).
|
|
+-define(PROCNAME, ejabberd_mod_pubsub_odbc).
|
|
-define(LOOPNAME, ejabberd_mod_pubsub_loop).
|
|
-define(PLUGIN_PREFIX, "node_").
|
|
-define(TREE_PREFIX, "nodetree_").
|
|
@@ -225,8 +225,6 @@
|
|
ok
|
|
end,
|
|
ejabberd_router:register_route(Host),
|
|
- update_node_database(Host, ServerHost),
|
|
- update_state_database(Host, ServerHost),
|
|
init_nodes(Host, ServerHost, NodeTree, Plugins),
|
|
State = #state{host = Host,
|
|
server_host = ServerHost,
|
|
@@ -285,206 +283,15 @@
|
|
|
|
init_nodes(Host, ServerHost, _NodeTree, Plugins) ->
|
|
%% TODO, this call should be done plugin side
|
|
- case lists:member("hometree", Plugins) of
|
|
+ case lists:member("hometree_odbc", Plugins) of
|
|
true ->
|
|
- create_node(Host, ServerHost, string_to_node("/home"), service_jid(Host), "hometree"),
|
|
- create_node(Host, ServerHost, string_to_node("/home/" ++ ServerHost), service_jid(Host), "hometree");
|
|
+ create_node(Host, ServerHost, string_to_node("/home"), service_jid(Host), "hometree_odbc"),
|
|
+ create_node(Host, ServerHost, string_to_node("/home/" ++ ServerHost), service_jid(Host), "hometree_odbc");
|
|
false ->
|
|
ok
|
|
end.
|
|
|
|
-update_node_database(Host, ServerHost) ->
|
|
- mnesia:del_table_index(pubsub_node, type),
|
|
- mnesia:del_table_index(pubsub_node, parentid),
|
|
- case catch mnesia:table_info(pubsub_node, attributes) of
|
|
- [host_node, host_parent, info] ->
|
|
- ?INFO_MSG("upgrade node pubsub tables",[]),
|
|
- F = fun() ->
|
|
- {Result, LastIdx} = lists:foldl(
|
|
- fun({pubsub_node, NodeId, ParentId, {nodeinfo, Items, Options, Entities}}, {RecList, NodeIdx}) ->
|
|
- ItemsList =
|
|
- lists:foldl(
|
|
- fun({item, IID, Publisher, Payload}, Acc) ->
|
|
- C = {unknown, Publisher},
|
|
- M = {now(), Publisher},
|
|
- mnesia:write(
|
|
- #pubsub_item{itemid = {IID, NodeIdx},
|
|
- creation = C,
|
|
- modification = M,
|
|
- payload = Payload}),
|
|
- [{Publisher, IID} | Acc]
|
|
- end, [], Items),
|
|
- Owners =
|
|
- dict:fold(
|
|
- fun(JID, {entity, Aff, Sub}, Acc) ->
|
|
- UsrItems =
|
|
- lists:foldl(
|
|
- fun({P, I}, IAcc) ->
|
|
- case P of
|
|
- JID -> [I | IAcc];
|
|
- _ -> IAcc
|
|
- end
|
|
- end, [], ItemsList),
|
|
- mnesia:write({pubsub_state,
|
|
- {JID, NodeIdx},
|
|
- UsrItems,
|
|
- Aff,
|
|
- Sub}),
|
|
- case Aff of
|
|
- owner -> [JID | Acc];
|
|
- _ -> Acc
|
|
- end
|
|
- end, [], Entities),
|
|
- mnesia:delete({pubsub_node, NodeId}),
|
|
- {[#pubsub_node{nodeid = NodeId,
|
|
- id = NodeIdx,
|
|
- parents = [element(2, ParentId)],
|
|
- owners = Owners,
|
|
- options = Options} |
|
|
- RecList], NodeIdx + 1}
|
|
- end, {[], 1},
|
|
- mnesia:match_object(
|
|
- {pubsub_node, {Host, '_'}, '_', '_'})),
|
|
- mnesia:write(#pubsub_index{index = node, last = LastIdx, free = []}),
|
|
- Result
|
|
- end,
|
|
- {atomic, NewRecords} = mnesia:transaction(F),
|
|
- {atomic, ok} = mnesia:delete_table(pubsub_node),
|
|
- {atomic, ok} = mnesia:create_table(pubsub_node,
|
|
- [{disc_copies, [node()]},
|
|
- {attributes, record_info(fields, pubsub_node)}]),
|
|
- FNew = fun() -> lists:foreach(fun(Record) ->
|
|
- mnesia:write(Record)
|
|
- end, NewRecords)
|
|
- end,
|
|
- case mnesia:transaction(FNew) of
|
|
- {atomic, Result} ->
|
|
- ?INFO_MSG("Pubsub node tables updated correctly: ~p", [Result]);
|
|
- {aborted, Reason} ->
|
|
- ?ERROR_MSG("Problem updating Pubsub node tables:~n~p", [Reason])
|
|
- end;
|
|
- [nodeid, parentid, type, owners, options] ->
|
|
- F = fun({pubsub_node, NodeId, {_, Parent}, Type, Owners, Options}) ->
|
|
- #pubsub_node{
|
|
- nodeid = NodeId,
|
|
- id = 0,
|
|
- parents = [Parent],
|
|
- type = Type,
|
|
- owners = Owners,
|
|
- options = Options}
|
|
- end,
|
|
- mnesia:transform_table(pubsub_node, F, [nodeid, id, parents, type, owners, options]),
|
|
- FNew = fun() ->
|
|
- LastIdx = lists:foldl(fun(#pubsub_node{nodeid = NodeId} = PubsubNode, NodeIdx) ->
|
|
- mnesia:write(PubsubNode#pubsub_node{id = NodeIdx}),
|
|
- lists:foreach(fun(#pubsub_state{stateid = StateId} = State) ->
|
|
- {JID, _} = StateId,
|
|
- mnesia:delete({pubsub_state, StateId}),
|
|
- mnesia:write(State#pubsub_state{stateid = {JID, NodeIdx}})
|
|
- end, mnesia:match_object(#pubsub_state{stateid = {'_', NodeId}, _ = '_'})),
|
|
- lists:foreach(fun(#pubsub_item{itemid = ItemId} = Item) ->
|
|
- {IID, _} = ItemId,
|
|
- {M1, M2} = Item#pubsub_item.modification,
|
|
- {C1, C2} = Item#pubsub_item.creation,
|
|
- mnesia:delete({pubsub_item, ItemId}),
|
|
- mnesia:write(Item#pubsub_item{itemid = {IID, NodeIdx},
|
|
- modification = {M2, M1},
|
|
- creation = {C2, C1}})
|
|
- end, mnesia:match_object(#pubsub_item{itemid = {'_', NodeId}, _ = '_'})),
|
|
- NodeIdx + 1
|
|
- end, 1, mnesia:match_object(
|
|
- {pubsub_node, {Host, '_'}, '_', '_', '_', '_', '_'})
|
|
- ++ mnesia:match_object(
|
|
- {pubsub_node, {{'_', ServerHost, '_'}, '_'}, '_', '_', '_', '_', '_'})),
|
|
- mnesia:write(#pubsub_index{index = node, last = LastIdx, free = []})
|
|
- end,
|
|
- case mnesia:transaction(FNew) of
|
|
- {atomic, Result} ->
|
|
- rename_default_nodeplugin(),
|
|
- ?INFO_MSG("Pubsub node tables updated correctly: ~p", [Result]);
|
|
- {aborted, Reason} ->
|
|
- ?ERROR_MSG("Problem updating Pubsub node tables:~n~p", [Reason])
|
|
- end;
|
|
- [nodeid, id, parent, type, owners, options] ->
|
|
- F = fun({pubsub_node, NodeId, Id, Parent, Type, Owners, Options}) ->
|
|
- #pubsub_node{
|
|
- nodeid = NodeId,
|
|
- id = Id,
|
|
- parents = [Parent],
|
|
- type = Type,
|
|
- owners = Owners,
|
|
- options = Options}
|
|
- end,
|
|
- mnesia:transform_table(pubsub_node, F, [nodeid, id, parents, type, owners, options]),
|
|
- rename_default_nodeplugin();
|
|
- _ ->
|
|
- ok
|
|
- end,
|
|
- mnesia:transaction(fun() ->
|
|
- case catch mnesia:first(pubsub_node) of
|
|
- {_, L} when is_list(L) ->
|
|
- lists:foreach(
|
|
- fun({H, N}) when is_list(N) ->
|
|
- [Node] = mnesia:read({pubsub_node, {H, N}}),
|
|
- Type = Node#pubsub_node.type,
|
|
- BN = element(2, node_call(Type, path_to_node, [N])),
|
|
- BP = case [element(2, node_call(Type, path_to_node, [P])) || P <- Node#pubsub_node.parents] of
|
|
- [<<>>] -> [];
|
|
- Parents -> Parents
|
|
- end,
|
|
- mnesia:write(Node#pubsub_node{nodeid={H, BN}, parents=BP}),
|
|
- mnesia:delete({pubsub_node, {H, N}});
|
|
- (_) ->
|
|
- ok
|
|
- end, mnesia:all_keys(pubsub_node));
|
|
- _ ->
|
|
- ok
|
|
- end
|
|
- end).
|
|
-
|
|
-rename_default_nodeplugin() ->
|
|
- lists:foreach(fun(Node) ->
|
|
- mnesia:dirty_write(Node#pubsub_node{type = "hometree"})
|
|
- end, mnesia:dirty_match_object(#pubsub_node{type = "default", _ = '_'})).
|
|
-
|
|
-update_state_database(_Host, _ServerHost) ->
|
|
- case catch mnesia:table_info(pubsub_state, attributes) of
|
|
- [stateid, items, affiliation, subscription] ->
|
|
- ?INFO_MSG("upgrade state pubsub tables", []),
|
|
- F = fun ({pubsub_state, {JID, NodeID}, Items, Aff, Sub}, Acc) ->
|
|
- Subs = case Sub of
|
|
- none ->
|
|
- [];
|
|
- _ ->
|
|
- {result, SubID} = pubsub_subscription:subscribe_node(JID, NodeID, []),
|
|
- [{Sub, SubID}]
|
|
- end,
|
|
- NewState = #pubsub_state{stateid = {JID, NodeID},
|
|
- items = Items,
|
|
- affiliation = Aff,
|
|
- subscriptions = Subs},
|
|
- [NewState | Acc]
|
|
- end,
|
|
- {atomic, NewRecs} = mnesia:transaction(fun mnesia:foldl/3,
|
|
- [F, [], pubsub_state]),
|
|
- {atomic, ok} = mnesia:delete_table(pubsub_state),
|
|
- {atomic, ok} = mnesia:create_table(pubsub_state,
|
|
- [{disc_copies, [node()]},
|
|
- {attributes, record_info(fields, pubsub_state)}]),
|
|
- FNew = fun () ->
|
|
- lists:foreach(fun mnesia:write/1, NewRecs)
|
|
- end,
|
|
- case mnesia:transaction(FNew) of
|
|
- {atomic, Result} ->
|
|
- ?INFO_MSG("Pubsub state tables updated correctly: ~p",
|
|
- [Result]);
|
|
- {aborted, Reason} ->
|
|
- ?ERROR_MSG("Problem updating Pubsub state tables:~n~p",
|
|
- [Reason])
|
|
- end;
|
|
- _ ->
|
|
- ok
|
|
- end.
|
|
+
|
|
|
|
send_loop(State) ->
|
|
receive
|
|
@@ -496,7 +303,10 @@
|
|
%% for each node From is subscribed to
|
|
%% and if the node is so configured, send the last published item to From
|
|
lists:foreach(fun(PType) ->
|
|
- {result, Subscriptions} = node_action(Host, PType, get_entity_subscriptions, [Host, JID]),
|
|
+ Subscriptions = case catch node_action(Host, PType, get_entity_subscriptions_for_send_last, [Host, JID]) of
|
|
+ {result, S} -> S;
|
|
+ _ -> []
|
|
+ end,
|
|
lists:foreach(
|
|
fun({Node, subscribed, _, SubJID}) ->
|
|
if (SubJID == LJID) or (SubJID == BJID) ->
|
|
@@ -759,10 +569,10 @@
|
|
lists:foreach(fun(PType) ->
|
|
{result, Subscriptions} = node_action(Host, PType, get_entity_subscriptions, [Host, Entity]),
|
|
lists:foreach(fun
|
|
- ({#pubsub_node{options = Options, owners = Owners, id = NodeId}, subscribed, _, JID}) ->
|
|
+ ({#pubsub_node{options = Options, id = NodeId}, subscribed, _, JID}) ->
|
|
case get_option(Options, access_model) of
|
|
presence ->
|
|
- case lists:member(BJID, Owners) of
|
|
+ case lists:member(BJID, node_owners(Host, PType, NodeId)) of
|
|
true ->
|
|
node_action(Host, PType, unsubscribe_node, [NodeId, Entity, JID, all]);
|
|
false ->
|
|
@@ -937,10 +747,11 @@
|
|
end,
|
|
ejabberd_router:route(To, From, Res);
|
|
#iq{type = get, ns = ?NS_DISCO_ITEMS,
|
|
- payload = SubEl} ->
|
|
+ payload = SubEl} = IQ ->
|
|
QAttrs = SubEl#xmlel.attrs,
|
|
Node = exmpp_xml:get_attribute_from_list_as_list(QAttrs, 'node', ""),
|
|
- Res = case iq_disco_items(Host, Node, From) of
|
|
+ Rsm = jlib:rsm_decode(IQ),
|
|
+ Res = case iq_disco_items(Host, Node, From, Rsm) of
|
|
{result, IQRes} ->
|
|
Result = #xmlel{ns = ?NS_DISCO_ITEMS,
|
|
name = 'query', attrs = QAttrs,
|
|
@@ -1060,7 +871,7 @@
|
|
[] ->
|
|
["leaf"]; %% No sub-nodes: it's a leaf node
|
|
_ ->
|
|
- case node_call(Type, get_items, [NodeId, From]) of
|
|
+ case node_call(Type, get_items, [NodeId, From, none]) of
|
|
{result, []} -> ["collection"];
|
|
{result, _} -> ["leaf", "collection"];
|
|
_ -> []
|
|
@@ -1076,8 +887,9 @@
|
|
[];
|
|
true ->
|
|
[#xmlel{ns = ?NS_DISCO_INFO, name = 'feature', attrs = [?XMLATTR('var', ?NS_PUBSUB_s)]} |
|
|
- lists:map(fun(T) ->
|
|
- #xmlel{ns = ?NS_DISCO_INFO, name = 'feature', attrs = [?XMLATTR('var', ?NS_PUBSUB_s++"#"++T)]}
|
|
+ lists:map(fun
|
|
+ ("rsm") -> #xmlel{ns = ?NS_DISCO_INFO, name = 'feature', attrs = [?XMLATTR('var', ?NS_RSM_s)]};
|
|
+ (T) -> #xmlel{ns = ?NS_DISCO_INFO, name = 'feature', attrs = [?XMLATTR('var', ?NS_PUBSUB_s++"#"++T)]}
|
|
end, features(Type))]
|
|
end,
|
|
%% TODO: add meta-data info (spec section 5.4)
|
|
@@ -1106,8 +918,9 @@
|
|
#xmlel{ns = ?NS_DISCO_INFO, name = 'feature', attrs = [?XMLATTR('var', ?NS_PUBSUB_s)]},
|
|
#xmlel{ns = ?NS_DISCO_INFO, name = 'feature', attrs = [?XMLATTR('var', ?NS_ADHOC_s)]},
|
|
#xmlel{ns = ?NS_DISCO_INFO, name = 'feature', attrs = [?XMLATTR('var', ?NS_VCARD_s)]}] ++
|
|
- lists:map(fun(Feature) ->
|
|
- #xmlel{ns = ?NS_DISCO_INFO, name = 'feature', attrs = [?XMLATTR('var', ?NS_PUBSUB_s++"#"++Feature)]}
|
|
+ lists:map(fun
|
|
+ ("rsm") -> #xmlel{ns = ?NS_DISCO_INFO, name = 'feature', attrs = [?XMLATTR('var', ?NS_RSM_s)]};
|
|
+ (Feature) -> #xmlel{ns = ?NS_DISCO_INFO, name = 'feature', attrs = [?XMLATTR('var', ?NS_PUBSUB_s++"#"++Feature)]}
|
|
end, features(Host, Node))};
|
|
?NS_ADHOC_b ->
|
|
command_disco_info(Host, Node, From);
|
|
@@ -1117,7 +930,7 @@
|
|
node_disco_info(Host, Node, From)
|
|
end.
|
|
|
|
-iq_disco_items(Host, [], From) ->
|
|
+iq_disco_items(Host, [], From, _RSM) ->
|
|
case tree_action(Host, get_subnodes, [Host, <<>>, From]) of
|
|
Nodes when is_list(Nodes) ->
|
|
{result, lists:map(
|
|
@@ -1134,7 +947,7 @@
|
|
Other ->
|
|
Other
|
|
end;
|
|
-iq_disco_items(Host, ?NS_ADHOC_s, _From) ->
|
|
+iq_disco_items(Host, ?NS_ADHOC_s, _From, _RSM) ->
|
|
%% TODO: support localization of this string
|
|
CommandItems = [
|
|
#xmlel{ns = ?NS_DISCO_ITEMS, name = 'item',
|
|
@@ -1143,10 +956,10 @@
|
|
?XMLATTR('name', "Get Pending")
|
|
]}],
|
|
{result, CommandItems};
|
|
-iq_disco_items(_Host, ?NS_PUBSUB_GET_PENDING, _From) ->
|
|
+iq_disco_items(_Host, ?NS_PUBSUB_GET_PENDING, _From, _RSM) ->
|
|
CommandItems = [],
|
|
{result, CommandItems};
|
|
-iq_disco_items(Host, Item, From) ->
|
|
+iq_disco_items(Host, Item, From, RSM) ->
|
|
case string:tokens(Item, "!") of
|
|
[_SNode, _ItemID] ->
|
|
{result, []};
|
|
@@ -1154,10 +967,10 @@
|
|
Node = string_to_node(SNode),
|
|
Action =
|
|
fun(#pubsub_node{type = Type, id = NodeId}) ->
|
|
- % TODO call get_items/6 instead for access control (EJAB-1033)
|
|
- NodeItems = case node_call(Type, get_items, [NodeId, From]) of
|
|
+ %% TODO call get_items/6 instead for access control (EJAB-1033)
|
|
+ {NodeItems, RsmOut} = case node_call(Type, get_items, [NodeId, From, RSM]) of
|
|
{result, I} -> I;
|
|
- _ -> []
|
|
+ _ -> {[], none}
|
|
end,
|
|
Nodes = lists:map(
|
|
fun(#pubsub_node{nodeid = {_, SubNode}, options = Options}) ->
|
|
@@ -1173,9 +986,10 @@
|
|
Items = lists:map(
|
|
fun(#pubsub_item{itemid = {RN, _}}) ->
|
|
{result, Name} = node_call(Type, get_item_name, [Host, Node, RN]),
|
|
- #xmlel{ns = ?NS_DISCO_ITEMS, name = 'item', attrs = [?XMLATTR('jid', Host), ?XMLATTR('name', Name)]}
|
|
+ #xmlel{ns = ?NS_DISCO_ITEMS, name = 'item', attrs = [?XMLATTR('jid', Host),
|
|
+ ?XMLATTR('name', Name)]}
|
|
end, NodeItems),
|
|
- {result, Nodes ++ Items}
|
|
+ {result, Nodes ++ Items ++ jlib:rsm_encode(RsmOut)}
|
|
end,
|
|
case transaction(Host, Node, Action, sync_dirty) of
|
|
{result, {_, Result}} -> {result, Result};
|
|
@@ -1231,8 +1045,7 @@
|
|
iq_pubsub(Host, ServerHost, From, IQType, SubEl, Lang, Access, Plugins) ->
|
|
case exmpp_xml:remove_cdata_from_list(SubEl#xmlel.children) of
|
|
[#xmlel{name = Name, attrs = Attrs, children = Els} | Rest] ->
|
|
- %% Fix bug when owner retrieves his affiliations
|
|
- Node = string_to_node(exmpp_xml:get_attribute_from_list_as_list(Attrs, 'node', "")),
|
|
+ Node = string_to_node(exmpp_xml:get_attribute_from_list_as_list(Attrs, 'node', false)),
|
|
case {IQType, Name} of
|
|
{set, 'create'} ->
|
|
Config = case Rest of
|
|
@@ -1307,7 +1120,8 @@
|
|
(_, Acc) ->
|
|
Acc
|
|
end, [], exmpp_xml:remove_cdata_from_list(Els)),
|
|
- get_items(Host, Node, From, SubId, MaxItems, ItemIDs);
|
|
+ RSM = jlib:rsm_decode(SubEl),
|
|
+ get_items(Host, Node, From, SubId, MaxItems, ItemIDs, RSM);
|
|
{get, 'subscriptions'} ->
|
|
get_subscriptions(Host, Node, From, Plugins);
|
|
{get, 'affiliations'} ->
|
|
@@ -1464,7 +1278,8 @@
|
|
_ -> []
|
|
end
|
|
end,
|
|
- case transaction(fun () -> {result, lists:flatmap(Tr, Plugins)} end,
|
|
+ case transaction(Host,
|
|
+ fun () -> {result, lists:flatmap(Tr, Plugins)} end,
|
|
sync_dirty) of
|
|
{result, Res} -> Res;
|
|
Err -> Err
|
|
@@ -1508,7 +1323,7 @@
|
|
|
|
%%% authorization handling
|
|
|
|
-send_authorization_request(#pubsub_node{owners = Owners, nodeid = {Host, Node}}, Subscriber) ->
|
|
+send_authorization_request(#pubsub_node{nodeid = {Host, Node}, type = Type, id = NodeId}, Subscriber) ->
|
|
Lang = "en", %% TODO fix
|
|
{U, S, R} = Subscriber,
|
|
Stanza = #xmlel{ns = ?NS_JABBER_CLIENT, name = 'message', children =
|
|
@@ -1538,7 +1353,7 @@
|
|
lists:foreach(fun(Owner) ->
|
|
{U, S, R} = Owner,
|
|
ejabberd_router:route(service_jid(Host), exmpp_jid:make(U, S, R), Stanza)
|
|
- end, Owners).
|
|
+ end, node_owners(Host, Type, NodeId)).
|
|
|
|
find_authorization_response(Packet) ->
|
|
Els = Packet#xmlel.children,
|
|
@@ -1580,7 +1395,7 @@
|
|
end,
|
|
Stanza = event_stanza(
|
|
[#xmlel{ns = ?NS_PUBSUB_EVENT, name = 'subscription', attrs =
|
|
- [ ?XMLATTR('jid', exmpp_jid:to_binary(JID)) | nodeAttr(SNode)] ++ SubAttrs
|
|
+ [?XMLATTR('jid', exmpp_jid:to_binary(JID)) | nodeAttr(SNode)] ++ SubAttrs
|
|
}]),
|
|
ejabberd_router:route(service_jid(Host), JID, Stanza).
|
|
|
|
@@ -1597,8 +1412,8 @@
|
|
"true" -> true;
|
|
_ -> false
|
|
end,
|
|
- Action = fun(#pubsub_node{type = Type, owners = Owners, id = NodeId}) ->
|
|
- IsApprover = lists:member(jlib:short_prepd_bare_jid(From), Owners),
|
|
+ Action = fun(#pubsub_node{type = Type, id = NodeId}) ->
|
|
+ IsApprover = lists:member(jlib:short_prepd_bare_jid(From), node_owners_call(Type, NodeId)),
|
|
{result, Subscriptions} = node_call(Type, get_subscriptions, [NodeId, Subscriber]),
|
|
if
|
|
not IsApprover ->
|
|
@@ -1793,7 +1608,7 @@
|
|
end,
|
|
Reply = #xmlel{ns = ?NS_PUBSUB, name = 'pubsub', children =
|
|
[#xmlel{ns = ?NS_PUBSUB, name = 'create', attrs = nodeAttr(Node)}]},
|
|
- case transaction(CreateNode, transaction) of
|
|
+ case transaction(Host, CreateNode, transaction) of
|
|
{result, {Result, broadcast}} ->
|
|
%%Lang = "en", %% TODO: fix
|
|
%%OwnerKey = jlib:jid_tolower(jlib:jid_remove_resource(Owner)),
|
|
@@ -1902,7 +1717,7 @@
|
|
%%<li>The node does not exist.</li>
|
|
%%</ul>
|
|
subscribe_node(Host, Node, From, JID, Configuration) ->
|
|
- SubOpts = case pubsub_subscription:parse_options_xform(Configuration) of
|
|
+ SubOpts = case pubsub_subscription_odbc:parse_options_xform(Configuration) of
|
|
{result, GoodSubOpts} -> GoodSubOpts;
|
|
_ -> invalid
|
|
end,
|
|
@@ -1912,7 +1727,7 @@
|
|
_:_ ->
|
|
{undefined, undefined, undefined}
|
|
end,
|
|
- Action = fun(#pubsub_node{options = Options, owners = [Owner|_], type = Type, id = NodeId}) ->
|
|
+ Action = fun(#pubsub_node{options = Options, type = Type, id = NodeId}) ->
|
|
Features = features(Type),
|
|
SubscribeFeature = lists:member("subscribe", Features),
|
|
OptionsFeature = lists:member("subscription-options", Features),
|
|
@@ -1931,9 +1746,13 @@
|
|
{"", "", ""} ->
|
|
{false, false};
|
|
_ ->
|
|
- {OU, OS, _} = Owner,
|
|
- get_roster_info(OU, OS,
|
|
- Subscriber, AllowedGroups)
|
|
+ case node_owners_call(Type, NodeId) of
|
|
+ [{OU, OS, _} | _] ->
|
|
+ get_roster_info(OU, OS,
|
|
+ Subscriber, AllowedGroups);
|
|
+ _ ->
|
|
+ {false, false}
|
|
+ end
|
|
end
|
|
end,
|
|
if
|
|
@@ -2270,7 +2089,7 @@
|
|
%% <p>The permission are not checked in this function.</p>
|
|
%% @todo We probably need to check that the user doing the query has the right
|
|
%% to read the items.
|
|
-get_items(Host, Node, From, SubId, SMaxItems, ItemIDs) ->
|
|
+get_items(Host, Node, From, SubId, SMaxItems, ItemIDs, RSM) ->
|
|
MaxItems =
|
|
if
|
|
SMaxItems == "" -> get_max_items_node(Host);
|
|
@@ -2309,11 +2128,11 @@
|
|
node_call(Type, get_items,
|
|
[NodeId, From,
|
|
AccessModel, PresenceSubscription, RosterGroup,
|
|
- SubId])
|
|
+ SubId, RSM])
|
|
end
|
|
end,
|
|
case transaction(Host, Node, Action, sync_dirty) of
|
|
- {result, {_, Items}} ->
|
|
+ {result, {_, Items, RSMOut}} ->
|
|
SendItems = case ItemIDs of
|
|
[] ->
|
|
Items;
|
|
@@ -2326,7 +2145,7 @@
|
|
%% number of items sent to MaxItems:
|
|
{result, #xmlel{ns = ?NS_PUBSUB, name = 'pubsub', children =
|
|
[#xmlel{ns = ?NS_PUBSUB, name = 'items', attrs = nodeAttr(Node), children =
|
|
- itemsEls(lists:sublist(SendItems, MaxItems))}]}};
|
|
+ itemsEls(lists:sublist(SendItems, MaxItems))} | jlib:rsm_encode(RSMOut)]}};
|
|
Error ->
|
|
Error
|
|
end
|
|
@@ -2358,17 +2177,29 @@
|
|
%% @doc <p>Resend the items of a node to the user.</p>
|
|
%% @todo use cache-last-item feature
|
|
send_items(Host, Node, NodeId, Type, LJID, last) ->
|
|
- case get_cached_item(Host, NodeId) of
|
|
+ Stanza = case get_cached_item(Host, NodeId) of
|
|
undefined ->
|
|
- send_items(Host, Node, NodeId, Type, LJID, 1);
|
|
+ % special ODBC optimization, works only with node_hometree_odbc, node_flat_odbc and node_pep_odbc
|
|
+ case node_action(Host, Type, get_last_items, [NodeId, LJID, 1]) of
|
|
+ {result, [LastItem]} ->
|
|
+ {ModifNow, ModifLjid} = LastItem#pubsub_item.modification,
|
|
+ event_stanza_with_delay([#xmlel{ns = ?NS_PUBSUB_EVENT, name = 'items',
|
|
+ attrs = nodeAttr(Node),
|
|
+ children = itemsEls([])}],
|
|
+ ModifNow, ModifLjid);
|
|
+ _ ->
|
|
+ event_stanza([#xmlel{ns = ?NS_PUBSUB_EVENT, name = 'items',
|
|
+ attrs = nodeAttr(Node),
|
|
+ children = itemsEls([])}])
|
|
+ end;
|
|
LastItem ->
|
|
{ModifNow, ModifLjid} = LastItem#pubsub_item.modification,
|
|
- Stanza = event_stanza_with_delay(
|
|
+ event_stanza_with_delay(
|
|
[#xmlel{ns = ?NS_PUBSUB_EVENT, name = 'items', attrs = nodeAttr(Node),
|
|
- children = itemsEls(LastItem)}], ModifNow, ModifLjid),
|
|
- {U, S, R} = LJID,
|
|
- ejabberd_router:route(service_jid(Host), exmpp_jid:make(U, S, R), Stanza)
|
|
- end;
|
|
+ children = itemsEls(LastItem)}], ModifNow, ModifLjid)
|
|
+ end,
|
|
+ {U, S, R} = LJID,
|
|
+ ejabberd_router:route(service_jid(Host), exmpp_jid:make(U, S, R), Stanza);
|
|
send_items(Host, Node, NodeId, Type, {LU, LS, LR} = LJID, Number) ->
|
|
ToSend = case node_action(Host, Type, get_items, [NodeId, LJID]) of
|
|
{result, []} ->
|
|
@@ -2448,9 +2279,8 @@
|
|
end
|
|
end,
|
|
case transaction(Host, Node, Action, sync_dirty) of
|
|
- %% Fix bug when user retrieves his affiliations
|
|
- %{result, {_, []}} ->
|
|
- % {error, 'item-not-found'};
|
|
+ {result, {_, []}} ->
|
|
+ {error, 'item-not-found'};
|
|
{result, {_, Affiliations}} ->
|
|
Entities = lists:flatmap(
|
|
fun({_, none}) -> [];
|
|
@@ -2484,7 +2314,7 @@
|
|
_:_ -> error
|
|
end,
|
|
Affiliation = string_to_affiliation(
|
|
- exmpp_xml:get_attribute_from_list_as_list(Attrs, 'affiliation', "")),
|
|
+ exmpp_xml:get_attribute_from_list_as_list(Attrs, 'affiliation', false)),
|
|
if
|
|
(JID == error) or
|
|
(Affiliation == false) ->
|
|
@@ -2499,29 +2329,13 @@
|
|
error ->
|
|
{error, 'bad-request'};
|
|
_ ->
|
|
- Action = fun(#pubsub_node{owners = Owners, type = Type, id = NodeId}=N) ->
|
|
- case lists:member(Owner, Owners) of
|
|
+ Action = fun(#pubsub_node{type = Type, id = NodeId}) ->
|
|
+ case lists:member(Owner, node_owners_call(Type, NodeId)) of
|
|
true ->
|
|
lists:foreach(
|
|
fun({JID, Affiliation}) ->
|
|
- {result, _} = node_call(Type, set_affiliation, [NodeId, JID, Affiliation]),
|
|
- case Affiliation of
|
|
- owner ->
|
|
- NewOwner = jlib:short_prepd_bare_jid(JID),
|
|
- NewOwners = [NewOwner|Owners],
|
|
- tree_call(Host, set_node, [N#pubsub_node{owners = NewOwners}]);
|
|
- none ->
|
|
- OldOwner = jlib:short_prepd_bare_jid(JID),
|
|
- case lists:member(OldOwner, Owners) of
|
|
- true ->
|
|
- NewOwners = Owners--[OldOwner],
|
|
- tree_call(Host, set_node, [N#pubsub_node{owners = NewOwners}]);
|
|
- _ ->
|
|
- ok
|
|
- end;
|
|
- _ ->
|
|
- ok
|
|
- end
|
|
+ % TODO, check if nothing missing here about new owners
|
|
+ node_call(Type, set_affiliation, [NodeId, JID, Affiliation])
|
|
end, Entities),
|
|
{result, []};
|
|
_ ->
|
|
@@ -2555,7 +2369,7 @@
|
|
J -> jlib:short_jid(J)
|
|
catch
|
|
_ ->
|
|
- exmpp_jid:make("", "", "") %% TODO, check if use <<>> instead of ""
|
|
+ {"", "", ""} %% TODO, check if use <<>> instead of ""
|
|
end,
|
|
{result, Subs} = node_call(Type, get_subscriptions,
|
|
[NodeID, Subscriber]),
|
|
@@ -2576,14 +2390,14 @@
|
|
end.
|
|
|
|
read_sub(Subscriber, Node, NodeID, SubID, Lang) ->
|
|
- case pubsub_subscription:get_subscription(Subscriber, NodeID, SubID) of
|
|
+ case pubsub_subscription_odbc:get_subscription(Subscriber, NodeID, SubID) of
|
|
{error, notfound} ->
|
|
{error, extended_error('not-acceptable', "invalid-subid")};
|
|
{result, #pubsub_subscription{options = Options}} ->
|
|
- {result, XdataEl} = pubsub_subscription:get_options_xform(Lang, Options),
|
|
+ {result, XdataEl} = pubsub_subscription_odbc:get_options_xform(Lang, Options),
|
|
OptionsEl = #xmlel{ns = ?NS_PUBSUB, name = 'options',
|
|
attrs = [ ?XMLATTR('jid', exmpp_jid:to_binary(Subscriber)),
|
|
- ?XMLATTR('subid', SubID) | nodeAttr(Node)],
|
|
+ ?XMLATTR('Subid', SubID) | nodeAttr(Node)],
|
|
children = [XdataEl]},
|
|
PubsubEl = #xmlel{ns = ?NS_PUBSUB, name = 'pubsub', children = [OptionsEl]},
|
|
{result, PubsubEl}
|
|
@@ -2607,14 +2421,14 @@
|
|
end.
|
|
|
|
set_options_helper(Configuration, JID, NodeID, SubID, Type) ->
|
|
- SubOpts = case pubsub_subscription:parse_options_xform(Configuration) of
|
|
+ SubOpts = case pubsub_subscription_odbc:parse_options_xform(Configuration) of
|
|
{result, GoodSubOpts} -> GoodSubOpts;
|
|
_ -> invalid
|
|
end,
|
|
Subscriber = try exmpp_jid:parse(JID) of
|
|
J -> jlib:short_jid(J)
|
|
catch
|
|
- _ -> exmpp_jid:make("", "", "") %% TODO, check if use <<>> instead of ""
|
|
+ _ -> {"", "", ""} %%pablo TODO: "" or <<>> ?. short_jid uses exmpp_jid:node/1, etc. that returns binaries
|
|
end,
|
|
{result, Subs} = node_call(Type, get_subscriptions,
|
|
[NodeID, Subscriber]),
|
|
@@ -2637,7 +2451,7 @@
|
|
write_sub(_Subscriber, _NodeID, _SubID, invalid) ->
|
|
{error, extended_error('bad-request', "invalid-options")};
|
|
write_sub(Subscriber, NodeID, SubID, Options) ->
|
|
- case pubsub_subscription:set_subscription(Subscriber, NodeID, SubID, Options) of
|
|
+ case pubsub_subscription_odbc:set_subscription(Subscriber, NodeID, SubID, Options) of
|
|
{error, notfound} ->
|
|
{error, extended_error('not-acceptable', "invalid-subid")};
|
|
{result, _} ->
|
|
@@ -2810,8 +2624,8 @@
|
|
?XMLATTR('subsription', subscription_to_string(Sub)) | nodeAttr(Node)]}]}]},
|
|
ejabberd_router:route(service_jid(Host), JID, Stanza)
|
|
end,
|
|
- Action = fun(#pubsub_node{owners = Owners, type = Type, id = NodeId}) ->
|
|
- case lists:member(Owner, Owners) of
|
|
+ Action = fun(#pubsub_node{type = Type, id = NodeId}) ->
|
|
+ case lists:member(Owner, node_owners_call(Type, NodeId)) of
|
|
true ->
|
|
Result = lists:foldl(fun({JID, Subscription, SubId}, Acc) ->
|
|
|
|
@@ -3107,7 +2921,7 @@
|
|
{Depth, [{N, get_node_subs(N)} || N <- Nodes]}
|
|
end, tree_call(Host, get_parentnodes_tree, [Host, Node, service_jid(Host)]))}
|
|
end,
|
|
- case transaction(Action, sync_dirty) of
|
|
+ case transaction(Host, Action, sync_dirty) of
|
|
{result, CollSubs} -> CollSubs;
|
|
_ -> []
|
|
end.
|
|
@@ -3121,9 +2935,9 @@
|
|
|
|
get_options_for_subs(NodeID, Subs) ->
|
|
lists:foldl(fun({JID, subscribed, SubID}, Acc) ->
|
|
- case pubsub_subscription:read_subscription(JID, NodeID, SubID) of
|
|
+ case pubsub_subscription_odbc:get_subscription(JID, NodeID, SubID) of
|
|
{error, notfound} -> [{JID, SubID, []} | Acc];
|
|
- #pubsub_subscription{options = Options} -> [{JID, SubID, Options} | Acc];
|
|
+ {result, #pubsub_subscription{options = Options}} -> [{JID, SubID, Options} | Acc];
|
|
_ -> Acc
|
|
end;
|
|
(_, Acc) ->
|
|
@@ -3338,6 +3152,30 @@
|
|
Result
|
|
end.
|
|
|
|
+%% @spec (Host, Type, NodeId) -> [ljid()]
|
|
+%% NodeId = pubsubNodeId()
|
|
+%% @doc <p>Return list of node owners.</p>
|
|
+node_owners(Host, Type, NodeId) ->
|
|
+ case node_action(Host, Type, get_node_affiliations, [NodeId]) of
|
|
+ {result, Affiliations} ->
|
|
+ lists:foldl(
|
|
+ fun({LJID, owner}, Acc) -> [LJID|Acc];
|
|
+ (_, Acc) -> Acc
|
|
+ end, [], Affiliations);
|
|
+ _ ->
|
|
+ []
|
|
+ end.
|
|
+node_owners_call(Type, NodeId) ->
|
|
+ case node_call(Type, get_node_affiliations, [NodeId]) of
|
|
+ {result, Affiliations} ->
|
|
+ lists:foldl(
|
|
+ fun({LJID, owner}, Acc) -> [LJID|Acc];
|
|
+ (_, Acc) -> Acc
|
|
+ end, [], Affiliations);
|
|
+ _ ->
|
|
+ []
|
|
+ end.
|
|
+
|
|
%% @spec (Host, Options) -> MaxItems
|
|
%% Host = host()
|
|
%% Options = [Option]
|
|
@@ -3736,7 +3574,13 @@
|
|
tree_action(Host, Function, Args) ->
|
|
?DEBUG("tree_action ~p ~p ~p",[Host,Function,Args]),
|
|
Fun = fun() -> tree_call(Host, Function, Args) end,
|
|
- catch mnesia:sync_dirty(Fun).
|
|
+ case catch ejabberd_odbc:sql_bloc(odbc_conn(Host), Fun) of
|
|
+ {atomic, Result} ->
|
|
+ Result;
|
|
+ {aborted, Reason} ->
|
|
+ ?ERROR_MSG("transaction return internal error: ~p~n",[{aborted, Reason}]),
|
|
+ {error, 'internal-server-error'}
|
|
+ end.
|
|
|
|
%% @doc <p>node plugin call.</p>
|
|
node_call(Type, Function, Args) ->
|
|
@@ -3756,13 +3600,13 @@
|
|
|
|
node_action(Host, Type, Function, Args) ->
|
|
?DEBUG("node_action ~p ~p ~p ~p",[Host,Type,Function,Args]),
|
|
- transaction(fun() ->
|
|
+ transaction(Host, fun() ->
|
|
node_call(Type, Function, Args)
|
|
end, sync_dirty).
|
|
|
|
%% @doc <p>plugin transaction handling.</p>
|
|
transaction(Host, Node, Action, Trans) ->
|
|
- transaction(fun() ->
|
|
+ transaction(Host, fun() ->
|
|
case tree_call(Host, get_node, [Host, Node]) of
|
|
N when is_record(N, pubsub_node) ->
|
|
case Action(N) of
|
|
@@ -3775,8 +3619,15 @@
|
|
end
|
|
end, Trans).
|
|
|
|
-transaction(Fun, Trans) ->
|
|
- case catch mnesia:Trans(Fun) of
|
|
+transaction(Host, Fun, Trans) ->
|
|
+ transaction_retry(Host, Fun, Trans, 2).
|
|
+
|
|
+transaction_retry(Host, Fun, Trans, Count) ->
|
|
+ SqlFun = case Trans of
|
|
+ transaction -> sql_transaction;
|
|
+ _ -> sql_bloc
|
|
+ end,
|
|
+ case catch ejabberd_odbc:SqlFun(odbc_conn(Host), Fun) of
|
|
{result, Result} -> {result, Result};
|
|
{error, Error} -> {error, Error};
|
|
{atomic, {result, Result}} -> {result, Result};
|
|
@@ -3784,6 +3635,15 @@
|
|
{aborted, Reason} ->
|
|
?ERROR_MSG("transaction return internal error: ~p~n", [{aborted, Reason}]),
|
|
{error, 'internal-server-error'};
|
|
+ {'EXIT', {timeout, _} = Reason} ->
|
|
+ case Count of
|
|
+ 0 ->
|
|
+ ?ERROR_MSG("transaction return internal error: ~p~n", [{'EXIT', Reason}]),
|
|
+ {error, 'internal-server-error'};
|
|
+ N ->
|
|
+ erlang:yield(),
|
|
+ transaction_retry(Host, Fun, Trans, N-1)
|
|
+ end;
|
|
{'EXIT', Reason} ->
|
|
?ERROR_MSG("transaction return internal error: ~p~n", [{'EXIT', Reason}]),
|
|
{error, 'internal-server-error'};
|
|
@@ -3792,6 +3652,16 @@
|
|
{error, 'internal-server-error'}
|
|
end.
|
|
|
|
+odbc_conn({_U, Host, _R})->
|
|
+ Host;
|
|
+odbc_conn(Host) ->
|
|
+ lists:dropwhile(fun(A) -> A/=$. end, Host) -- ".".
|
|
+
|
|
+%% escape value for database storage
|
|
+escape({_U, _H, _R}=JID)->
|
|
+ ejabberd_odbc:escape(exmpp_jid:to_list(JID));
|
|
+escape(Value)->
|
|
+ ejabberd_odbc:escape(Value).
|
|
%%%% helpers
|
|
|
|
%% Add pubsub-specific error element
|
|
@@ -3880,7 +3750,7 @@
|
|
%% If the sender Server equals Host, the message comes from the Pubsub server
|
|
Host -> allow;
|
|
%% Else, the message comes from PEP
|
|
- _ ->
|
|
+ _ ->
|
|
case exmpp_xml:get_element(El, 'event') of
|
|
#xmlel{name = 'event', ns = ?NS_PUBSUB_EVENT} = Event ->
|
|
Items = exmpp_xml:get_element(Event, ?NS_PUBSUB_EVENT, 'items'),
|