Update eslint & plugins

Also replace eslint-plugin-node with the maintained eslint-plugin-n

.eslintrc.yml

@@ -5,21 +5,24 @@ env:
 extends:
   - eslint:recommended
   - prettier
-  - plugin:node/recommended
+  - plugin:n/recommended
   - plugin:security/recommended
 
 plugins:
-  - node
+  - n
   - security
 
 root: true
 
 rules:
-  node/no-deprecated-api: off
+  n/no-deprecated-api: off
-  node/no-unsupported-features/es-syntax: off
+  n/no-unsupported-features/es-syntax: off
-  node/no-unsupported-features/node-builtins: off
+  n/no-unsupported-features/node-builtins: off
-  node/no-unpublished-require: off
+  n/no-unpublished-require: off
-  node/no-unpublished-import: off
+  n/no-unpublished-import: off
+  n/no-process-exit: off
+  # This forces using file extensions in imports, which is a best practice, but refactoring would take some time
+  n/no-missing-import: off
 
   security/detect-non-literal-fs-filename: off
   security/detect-object-injection: off

app/.eslintrc.yml

@@ -6,4 +6,4 @@ parserOptions:
   sourceType: module
 
 rules:
-  node/no-unsupported-features: off
+  n/no-unsupported-features: off

app/storage.js

@@ -110,7 +110,7 @@ class Storage {
   }
 
   set user(info) {
-    return this.engine.setItem('user', JSON.stringify(info));
+    this.engine.setItem('user', JSON.stringify(info));
   }
 
   getFileById(id) {

app/streams.js

@@ -1,5 +1,3 @@
-/* global TransformStream */
-
 export function transformStream(readable, transformer, oncancel) {
   try {
     return readable.pipeThrough(new TransformStream(transformer));

common/assets.js

@@ -3,7 +3,7 @@ const isServer = typeof genmap === 'function';
 let prefix = '';
 let manifest = {};
 try {
-  //eslint-disable-next-line node/no-missing-require
+  //eslint-disable-next-line n/no-missing-require
   manifest = require('../dist/manifest.json');
 } catch (e) {
   // use middleware

ios/ios.js

@@ -1,4 +1,4 @@
-/* global window, document, fetch */
+/* global window, document */
 
 const MAXFILESIZE = 1024 * 1024 * 1024 * 2;
 

package.json

@@ -70,7 +70,7 @@
     "@sentry/browser": "^5.30.0",
     "asmcrypto.js": "^0.22.0",
     "babel-loader": "^8.2.4",
-    "babel-plugin-istanbul": "^5.2.0",
+    "babel-plugin-istanbul": "^6.1.1",
     "base64-js": "^1.5.1",
     "content-disposition": "^0.5.4",
     "copy-webpack-plugin": "^6.4.0",
@@ -80,18 +80,15 @@
     "css-loader": "^5.2.7",
     "css-mqpacker": "^7.0.0",
     "cssnano": "^5.1.12",
-    "eslint": "^6.6.0",
+    "eslint": "^8.21.0",
-    "eslint-config-prettier": "^6.15.0",
+    "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-mocha": "^6.2.1",
+    "eslint-plugin-mocha": "^10.1.0",
-    "eslint-plugin-node": "^10.0.0",
+    "eslint-plugin-n": "^15.2.4",
-    "eslint-plugin-security": "^1.4.0",
+    "eslint-plugin-security": "^1.5.0",
-    "expose-loader": "^0.7.5",
-    "extract-loader": "^3.2.0",
     "extract-text-webpack-plugin": "^4.0.0-beta.0",
     "fast-text-encoding": "^1.0.3",
     "file-loader": "^6.2.0",
     "git-rev-sync": "^3.0.2",
-    "html-loader": "^0.5.5",
     "http_ece": "^1.1.0",
     "husky": "^3.0.9",
     "intl-pluralrules": "^1.3.1",
@@ -111,7 +108,6 @@
     "puppeteer": "^2.0.0",
     "raw-loader": "^3.1.0",
     "rimraf": "^3.0.0",
-    "script-loader": "^0.7.2",
     "sinon": "^7.5.0",
     "string-hash": "^1.1.3",
     "stylelint": "^14.9.1",

scripts/.eslintrc.yml

@@ -1,5 +1,5 @@
 rules:
-  node/shebang: off
+  n/shebang: off
   security/detect-child-process: off
 
   no-console: off

server/initScript.js

@@ -5,7 +5,7 @@ const clientConstants = require('./clientConstants');
 
 let sentry = '';
 if (config.sentry_id) {
-  //eslint-disable-next-line node/no-missing-require
+  //eslint-disable-next-line n/no-missing-require
   const version = require('../dist/version.json');
   sentry = `
 var SENTRY_CONFIG = {

server/routes/index.js

@@ -120,7 +120,7 @@ module.exports = function(app) {
   );
   app.post(`/api/info/:id${ID_REGEX}`, auth.owner, require('./info'));
   app.get('/__version__', function(req, res) {
-    // eslint-disable-next-line node/no-missing-require
+    // eslint-disable-next-line n/no-missing-require
     res.sendFile(require.resolve('../../dist/version.json'));
   });
 

test/.eslintrc.yml

@@ -6,10 +6,10 @@ extends:
 
 plugins:
   - mocha
-  - node
+  - n
 
 rules:
-  node/no-unpublished-require: off
+  n/no-unpublished-require: off
 
   mocha/handle-done-callback: error
   mocha/no-exclusive-tests: error

test/frontend/.eslintrc.yml

@@ -5,4 +5,4 @@ parserOptions:
   sourceType: module
 
 rules:
-  node/no-unsupported-features: off
+  n/no-unsupported-features: off

test/wdio.circleci.conf.js

@@ -1,4 +1,4 @@
-// eslint-disable-next-line node/no-extraneous-require
+// eslint-disable-next-line n/no-extraneous-require
 const ip = require('ip');
 const common = require('./wdio.common.conf');
 

test/wdio.docker.conf.js

@@ -1,4 +1,4 @@
-// eslint-disable-next-line node/no-extraneous-require
+// eslint-disable-next-line n/no-extraneous-require
 const ip = require('ip');
 const common = require('./wdio.common.conf');
 const dir =

test/wdio.local.conf.js

@@ -1,4 +1,4 @@
-// eslint-disable-next-line node/no-extraneous-require
+// eslint-disable-next-line n/no-extraneous-require
 const ip = require('ip');
 const common = require('./wdio.common.conf');