Chapril/drop.chapril.org-firefoxsend
Chapril/drop.chapril.org-firefoxsend
24
1
Fork 0
Code Issues Releases Activity

Merge pull request #394 from mozilla/i393

Browse Source 
catch JSON.parse errors of storage metadata
This commit is contained in:
Danny Coates 2017-08-02 12:28:55 -07:00 committed by GitHub
commit 5b9e9d5146
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/src/storage.js
View File

@ -29,7 +29,12 @@ class Storage {
for (let i = 0; i < this.engine.length; i++) { for (let i = 0; i < this.engine.length; i++) {
const k = this.engine.key(i); const k = this.engine.key(i);
if (isFile(k)) { if (isFile(k)) {
fs.push(JSON.parse(this.engine.getItem(k))); // parse or whatever else try {
fs.push(JSON.parse(this.engine.getItem(k)));
} catch (err) {
// obviously you're not a golfer
this.engine.removeItem(k);
}
} }
} }
return fs.sort((file1, file2) => { return fs.sort((file1, file2) => {

7
frontend/src/utils.js
View File

@ -99,12 +99,7 @@ function findMetric(href) {
} }
function isFile(id) { function isFile(id) {
return ![ return /^[0-9a-fA-F]{10}$/.test(id);
'referrer',
'totalDownloads',
'totalUploads',
'testpilot_ga__cid'
].includes(id);
} }
function sendEvent() { function sendEvent() {