local filesystem tests written, all passing

package.json

@@ -17,7 +17,9 @@
     "mozlog": "^2.1.1",
     "node-fetch": "^1.7.1",
     "path": "^0.12.7",
-    "redis": "^2.7.1"
+    "proxyquire": "^1.8.0",
+    "redis": "^2.7.1",
+    "sinon": "^2.3.2"
   },
   "devDependencies": {
     "browserify": "^14.4.0",
@@ -31,6 +33,7 @@
     "prettier": "1.4.4",
     "stylelint": "7.11.0",
     "stylelint-config-standard": "16.0.0",
+    "mocha": "^3.4.2",
     "watchify": "^3.9.0"
   },
   "engines": {
@@ -46,6 +49,6 @@
     "lint:html": "htmllint 'views/*.handlebars'",
     "lint:js": "eslint .",
     "start": "watchify frontend/src/main.js -o public/bundle.js -d | cross-env NODE_ENV=production node server/portal_server.js",
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "mocha"
   }
 }

server/storage.js

@@ -19,7 +19,7 @@ const redis_client = redis.createClient({
 });
 
 redis_client.on('error', err => {
-  log.info('Redis: ', err);
+  log.info('Redis:', err);
 });
 
 if (notLocalHost) {
@@ -94,7 +94,10 @@ function localSet(id, file, filename, url) {
       });
     });
 
-    fstream.on('error', () => reject());
+    fstream.on('error', () => {
+      log.error('localSet:', 'Failed upload of ' + id);
+      reject();
+    });
   });
 }
 

test/local.storage.test.js

@@ -0,0 +1,170 @@
+const assert = require('assert');
+const sinon = require('sinon');
+const proxyquire = require('proxyquire');
+
+
+let redisStub = {};
+let exists = sinon.stub();
+let hget = sinon.stub();
+let hmset = sinon.stub();
+let expire = sinon.stub();
+let del = sinon.stub();
+
+redisStub.createClient = function() {
+  return {
+    on: sinon.spy(),
+    exists: exists,
+    hget: hget,
+    hmset: hmset,
+    expire: expire,
+    del: del
+  }
+}
+
+let fsStub = {};
+fsStub.statSync = sinon.stub();
+fsStub.createReadStream = sinon.stub();
+fsStub.createWriteStream = sinon.stub();
+fsStub.unlinkSync = sinon.stub();
+
+let logStub = {};
+logStub.info = sinon.stub();
+logStub.error = sinon.stub();
+
+const storage = proxyquire('../server/storage', {
+  'redis': redisStub,
+  'fs': fsStub,
+  './log.js': function() { return logStub }
+});
+
+describe('Testing Exists from local filesystem', function() {
+  it('Exists returns true when file exists', function() {
+    exists.callsArgWith(1, null, 1);
+    return storage.exists('test')
+           .then((reply) => assert(reply));
+  })
+
+  it('Exists returns false when file does not exist', function() {
+    exists.callsArgWith(1, null, 0);
+    return storage.exists('test')
+           .then((reply) => assert(!reply));
+  })
+});
+
+describe('Testing Filename from local filesystem', function() {
+  it('Filename returns properly if id exists', function() {
+    hget.callsArgWith(2, null, 'Filename.moz');
+    return storage.filename('test')
+           .then(reply => assert(1))
+           .catch(reply => assert.fail())
+  })
+
+  it('Filename fails if id does not exist', function() {
+    hget.callsArgWith(2, null, 'Filename.moz');
+    return storage.filename('test')
+           .then(reply => assert.fail())
+           .catch(reply => assert(1))
+  })
+})
+
+describe('Testing Length from local filesystem', function() {
+  it('Filesize returns properly if id exists', function() {
+    fsStub.statSync.returns({size: 10});
+    return storage.length('Filename.moz')
+           .then(reply => assert(1))
+           .catch(reply => assert.fail())
+  })
+
+  it('Filesize fails if the id does not exist', function() {
+    fsStub.statSync.returns(null);
+    return storage.length('Filename.moz')
+           .then(reply => assert.fail())
+           .catch(reply => assert(1))
+  })
+})
+
+describe('Testing Get from local filesystem', function() {
+  it('Get returns properly if id exists', function() {
+    fsStub.createReadStream.returns(1);
+    if (storage.get('Filename.moz')) {
+      assert(1)
+    } else {
+      assert.fail();
+    }
+  })
+
+  it('Get fails if the id does not exist', function() {
+    fsStub.createReadStream.returns(null);
+    if (storage.get('Filename.moz')) {
+      assert.fail();
+    } else {
+      assert(1);
+    }
+  })
+})
+
+describe('Testing Set to local filesystem', function() {
+  it('Successfully writes the file to the local filesystem', function() {
+    let stub = sinon.stub();
+    stub.withArgs('close', sinon.match.any).callsArgWithAsync(1)
+    stub.withArgs('error', sinon.match.any).returns(1);
+    fsStub.createWriteStream.returns({ on: stub })
+
+    return storage.set('test', { pipe: sinon.stub() }, 'Filename.moz', 'moz.la')
+           .then(reply => {
+             assert(reply.uuid);
+             assert.equal(reply.url, 'moz.la');
+           })
+           .catch(reply => assert.fail())
+  })
+
+  it('Fails when the file is not properly written to the local filesystem', function() {
+    let stub = sinon.stub();
+    stub.withArgs('error', sinon.match.any).callsArgWithAsync(1)
+    stub.withArgs('close', sinon.match.any).returns(1);
+    fsStub.createWriteStream.returns({ on: stub })
+
+    return storage.set('test', {pipe: sinon.stub()}, 'Filename.moz', 'moz.la')
+           .then(reply => assert.fail())
+           .catch(reply => assert(1))
+  })
+})
+
+describe('Testing Delete from local filesystem', function() {
+  it('Deletes properly if id exists', function() {
+    hget.callsArgWith(2, null, '123');
+    fsStub.unlinkSync.returns(1);
+    return storage.delete('Filename.moz', '123')
+                  .then(reply => assert(reply))
+                  .catch(reply => assert.fail())
+  })
+
+  it('Delete fails if id does not exist', function() {
+    hget.callsArgWith(2, null, null);
+    return storage.delete('Filename.moz', '123')
+                  .then(reply => assert.fail())
+                  .catch(reply => assert(1))
+  })
+
+  it('Delete fails if the delete token does not match', function() {
+    hget.callsArgWith(2, null, null);
+    return storage.delete('Filename.moz', '123')
+                  .then(reply => assert.fail())
+                  .catch(reply => assert(1))
+  })
+})
+
+describe('Testing Forced Delete from local filesystem', function() {
+  it('Deletes properly if id exists', function() {
+    fsStub.unlinkSync.returns(1);
+    return storage.forceDelete('Filename.moz')
+                  .then(reply => assert(reply))
+  })
+
+  it('Deletes fails if id does not exist, but no reject is called', function() {
+    fsStub.unlinkSync.returns(0);
+    return storage.forceDelete('Filename.moz')
+                  .then(reply => assert(!reply))
+  })
+
+})