Commit Graph

10 Commits

Author SHA1 Message Date
Danny Coates
6184a70ba4
fixes #1005
The upstream gcp aggressively closes the connection once it has
received Content-Length bytes. However the @google-cloud/storage
module doesn't handle this well and emits no event in this case.
We were setting Content-Length because it's slightly more
efficient and was important for our download progress
bar (not anymore). The download should function fine without
setting the Content-Length, and allows the storage stream to finish
before closing the upstream socket.
2018-11-14 16:38:46 -08:00
Emily Hou
59ba89262f
fix download count on server (#863) 2018-07-17 09:48:47 -07:00
Emily
527e9f09c9 add a test 2018-07-12 16:07:18 -07:00
Emily
5ff92c6452 fix cancelled downloads increasing count 2018-07-12 14:02:05 -07:00
Danny Coates
480a06c426
track bytes sent on download 2018-06-05 15:26:24 -07:00
Danny Coates
3fd2537311
refactored server 2018-02-09 15:03:05 -08:00
Danny Coates
aae61f9451
extracted server id validation 2018-02-05 16:37:06 -08:00
Danny Coates
7b4060f9e1
Added multiple download option 2017-12-04 15:52:31 -08:00
Danny Coates
bc24a069da
Add optional password to the download url 2017-10-10 10:45:10 -07:00
Danny Coates
53e822964e
a few changes to make A/B testing easier 2017-08-25 09:44:52 -07:00