Chapril/xmpp.chapril.org-conversejs
Chapril/xmpp.chapril.org-conversejs
25
0
Fork 0
Code Issues Pull Requests Projects Releases Activity
647ee1ff04
xmpp.chapril.org-conversejs/spec/chatroom.js

1702 lines
95 KiB
JavaScript
Raw Normal View History

Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
(function (root, factory) {
No need for two AMD-load cycles.
2016-11-30 13:18:58 +01:00
define(["mock", "converse-api", "test_utils", "utils" ], factory);
} (this, function (mock, converse_api, test_utils, utils) {
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
var _ = converse_api.env._;
var $ = converse_api.env.jQuery;
Fix failing tests after introducing AMD version of Strophe
2015-02-01 16:15:34 +01:00
var $pres = converse_api.env.$pres;
Check whether the user has a reserved nickname when they enter a chat room. If they have, we'll use that, otherwise we render a form where they can specify their nick. Some chat room tests now fail and still need to be fixed.
2016-07-20 01:59:52 +02:00
var $iq = converse_api.env.$iq;
Fix failing tests after introducing AMD version of Strophe
2015-02-01 16:15:34 +01:00
var $msg = converse_api.env.$msg;
Move changelog entry to right version and add test case.
2015-09-09 10:17:46 +02:00
var Strophe = converse_api.env.Strophe;
Fix failing tests after introducing AMD version of Strophe
2015-02-01 16:15:34 +01:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
return describe("ChatRooms", function () {
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
describe("The \"rooms\" API", function () {
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
afterEach(function () {
converse_api.user.logout();
converse_api.listen.not();
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
test_utils.clearBrowserStorage();
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("has a method 'close' which closes rooms by JID or all rooms when called with no arguments", mock.initConverse(function (converse) {
test_utils.createContacts(converse, 'current');
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
runs(function () {
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
test_utils.openChatRoom(converse, 'leisure', 'localhost', 'dummy');
test_utils.openChatRoom(converse, 'news', 'localhost', 'dummy');
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
expect(converse.chatboxviews.get('lounge@localhost').$el.is(':visible')).toBeTruthy();
expect(converse.chatboxviews.get('leisure@localhost').$el.is(':visible')).toBeTruthy();
expect(converse.chatboxviews.get('news@localhost').$el.is(':visible')).toBeTruthy();
});
waits('100');
runs(function () {
converse_api.rooms.close('lounge@localhost');
expect(converse.chatboxviews.get('lounge@localhost')).toBeUndefined();
expect(converse.chatboxviews.get('leisure@localhost').$el.is(':visible')).toBeTruthy();
expect(converse.chatboxviews.get('news@localhost').$el.is(':visible')).toBeTruthy();
converse_api.rooms.close(['leisure@localhost', 'news@localhost']);
expect(converse.chatboxviews.get('lounge@localhost')).toBeUndefined();
expect(converse.chatboxviews.get('leisure@localhost')).toBeUndefined();
expect(converse.chatboxviews.get('news@localhost')).toBeUndefined();
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
test_utils.openChatRoom(converse, 'leisure', 'localhost', 'dummy');
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
expect(converse.chatboxviews.get('lounge@localhost').$el.is(':visible')).toBeTruthy();
expect(converse.chatboxviews.get('leisure@localhost').$el.is(':visible')).toBeTruthy();
});
waits('100');
runs(function () {
converse_api.rooms.close();
expect(converse.chatboxviews.get('lounge@localhost')).toBeUndefined();
expect(converse.chatboxviews.get('leisure@localhost')).toBeUndefined();
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("has a method 'get' which returns a wrapped chat room (if it exists)", mock.initConverse(function (converse) {
test_utils.createContacts(converse, 'current');
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
waits('300'); // ChatBox.show() is debounced for 250ms
runs(function () {
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
var jid = 'lounge@localhost';
var room = converse_api.rooms.get(jid);
expect(room instanceof Object).toBeTruthy();
expect(room.is_chatroom).toBeTruthy();
var chatroomview = converse.chatboxviews.get(jid);
expect(chatroomview.$el.is(':visible')).toBeTruthy();
chatroomview.close();
});
waits('300'); // ChatBox.show() is debounced for 250ms
runs(function () {
// Test with mixed case
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
test_utils.openChatRoom(converse, 'Leisure', 'localhost', 'dummy');
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
var jid = 'Leisure@localhost';
var room = converse_api.rooms.get(jid);
expect(room instanceof Object).toBeTruthy();
var chatroomview = converse.chatboxviews.get(jid.toLowerCase());
expect(chatroomview.$el.is(':visible')).toBeTruthy();
});
waits('300'); // ChatBox.show() is debounced for 250ms
runs(function () {
var jid = 'leisure@localhost';
var room = converse_api.rooms.get(jid);
expect(room instanceof Object).toBeTruthy();
var chatroomview = converse.chatboxviews.get(jid.toLowerCase());
expect(chatroomview.$el.is(':visible')).toBeTruthy();
jid = 'leiSure@localhost';
room = converse_api.rooms.get(jid);
expect(room instanceof Object).toBeTruthy();
chatroomview = converse.chatboxviews.get(jid.toLowerCase());
expect(chatroomview.$el.is(':visible')).toBeTruthy();
chatroomview.close();
// Non-existing room
jid = 'lounge2@localhost';
room = converse_api.rooms.get(jid);
expect(typeof room === 'undefined').toBeTruthy();
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
Expand upon `rooms.open` testcase to test configuration
2016-12-02 19:12:40 +01:00
it("has a method 'open' which opens (optionally configures) and returns a wrapped chat box", mock.initConverse(function (converse) {
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
test_utils.createContacts(converse, 'current');
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
var chatroomview;
var jid = 'lounge@localhost';
var room = converse_api.rooms.open(jid);
runs(function () {
// Test on chat room that doesn't exist.
expect(room instanceof Object).toBeTruthy();
expect(room.is_chatroom).toBeTruthy();
chatroomview = converse.chatboxviews.get(jid);
expect(chatroomview.$el.is(':visible')).toBeTruthy();
});
waits('300'); // ChatBox.show() is debounced for 250ms
runs(function () {
// Test again, now that the room exists.
room = converse_api.rooms.open(jid);
expect(room instanceof Object).toBeTruthy();
expect(room.is_chatroom).toBeTruthy();
chatroomview = converse.chatboxviews.get(jid);
expect(chatroomview.$el.is(':visible')).toBeTruthy();
});
waits('300'); // ChatBox.show() is debounced for 250ms
runs(function () {
// Test with mixed case in JID
jid = 'Leisure@localhost';
room = converse_api.rooms.open(jid);
expect(room instanceof Object).toBeTruthy();
chatroomview = converse.chatboxviews.get(jid.toLowerCase());
expect(chatroomview.$el.is(':visible')).toBeTruthy();
jid = 'leisure@localhost';
room = converse_api.rooms.open(jid);
expect(room instanceof Object).toBeTruthy();
chatroomview = converse.chatboxviews.get(jid.toLowerCase());
expect(chatroomview.$el.is(':visible')).toBeTruthy();
jid = 'leiSure@localhost';
room = converse_api.rooms.open(jid);
expect(room instanceof Object).toBeTruthy();
chatroomview = converse.chatboxviews.get(jid.toLowerCase());
expect(chatroomview.$el.is(':visible')).toBeTruthy();
chatroomview.close();
});
Expand upon `rooms.open` testcase to test configuration
2016-12-02 19:12:40 +01:00
waits('300'); // ChatBox.show() is debounced for 250ms
runs(function () {
converse.muc_instant_rooms = false;
var sent_IQ, IQ_id;
var sendIQ = converse.connection.sendIQ;
spyOn(converse.connection, 'sendIQ').andCallFake(function (iq, callback, errback) {
sent_IQ = iq;
IQ_id = sendIQ.bind(this)(iq, callback, errback);
});
// Test with configuration
converse_api.rooms.open('room@conference.example.org', {
'nick': 'some1',
'auto_configure': true,
'roomconfig': {
'changesubject': false,
'membersonly': true,
'persistentroom': true,
'publicroom': true,
'roomdesc': 'Welcome to this room',
'whois': 'anyone'
}
});
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
// We pretend this is a new room, so no disco info is returned.
var features_stanza = $iq({
from: 'room@conference.example.org',
'id': IQ_id,
'to': 'dummy@localhost/desktop',
'type': 'error'
}).c('error', {'type': 'cancel'})
.c('item-not-found', {'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas"});
converse.connection._dataRecv(test_utils.createRequest(features_stanza));
Expand upon `rooms.open` testcase to test configuration
2016-12-02 19:12:40 +01:00
/* <presence xmlns="jabber:client" to="dummy@localhost/pda" from="room@conference.example.org/yo">
* <x xmlns="http://jabber.org/protocol/muc#user">
* <item affiliation="owner" jid="dummy@localhost/pda" role="moderator"/>
* <status code="110"/>
* <status code="201"/>
* </x>
* </presence>
*/
var presence = $pres({
from:'room@conference.example.org/some1',
to:'dummy@localhost/pda'
})
.c('x', {xmlns:'http://jabber.org/protocol/muc#user'})
.c('item', {
affiliation: 'owner',
jid: 'dummy@localhost/pda',
role: 'moderator'
}).up()
.c('status', {code:'110'}).up()
.c('status', {code:'201'});
converse.connection._dataRecv(test_utils.createRequest(presence));
expect(converse.connection.sendIQ).toHaveBeenCalled();
expect(sent_IQ.toLocaleString()).toBe(
"<iq to='room@conference.example.org' type='get' xmlns='jabber:client' id='"+IQ_id+
"'><query xmlns='http://jabber.org/protocol/muc#owner'/></iq>"
);
converse.connection._dataRecv(test_utils.createRequest($(
'<iq xmlns="jabber:client"'+
' type="result"'+
' to="dummy@localhost/pda"'+
' from="room@conference.example.org" id="'+IQ_id+'">'+
' <query xmlns="http://jabber.org/protocol/muc#owner">'+
' <x xmlns="jabber:x:data" type="form">'+
' <title>Configuration for room@conference.example.org</title>'+
' <instructions>Complete and submit this form to configure the room.</instructions>'+
' <field var="FORM_TYPE" type="hidden">'+
' <value>http://jabber.org/protocol/muc#roomconfig</value>'+
' </field>'+
' <field type="text-single" var="muc#roomconfig_roomname" label="Name">'+
' <value>Room</value>'+
' </field>'+
' <field type="text-single" var="muc#roomconfig_roomdesc" label="Description"><value/></field>'+
' <field type="boolean" var="muc#roomconfig_persistentroom" label="Make Room Persistent?"/>'+
' <field type="boolean" var="muc#roomconfig_publicroom" label="Make Room Publicly Searchable?"><value>1</value></field>'+
' <field type="boolean" var="muc#roomconfig_changesubject" label="Allow Occupants to Change Subject?"/>'+
' <field type="list-single" var="muc#roomconfig_whois" label="Who May Discover Real JIDs?"><option label="Moderators Only">'+
' <value>moderators</value></option><option label="Anyone"><value>anyone</value></option>'+
' </field>'+
' <field type="text-private" var="muc#roomconfig_roomsecret" label="Password"><value/></field>'+
' <field type="boolean" var="muc#roomconfig_moderatedroom" label="Make Room Moderated?"/>'+
' <field type="boolean" var="muc#roomconfig_membersonly" label="Make Room Members-Only?"/>'+
' <field type="text-single" var="muc#roomconfig_historylength" label="Maximum Number of History Messages Returned by Room">'+
' <value>20</value></field>'+
' </x>'+
' </query>'+
' </iq>')[0]));
var $sent_stanza = $(sent_IQ.toLocaleString());
expect($sent_stanza.find('field[var="muc#roomconfig_roomname"] value').text()).toBe('Room');
expect($sent_stanza.find('field[var="muc#roomconfig_roomdesc"] value').text()).toBe('Welcome to this room');
expect($sent_stanza.find('field[var="muc#roomconfig_persistentroom"] value').text()).toBe('1');
expect($sent_stanza.find('field[var="muc#roomconfig_publicroom"] value ').text()).toBe('1');
expect($sent_stanza.find('field[var="muc#roomconfig_changesubject"] value').text()).toBe('0');
expect($sent_stanza.find('field[var="muc#roomconfig_whois"] value ').text()).toBe('anyone');
expect($sent_stanza.find('field[var="muc#roomconfig_membersonly"] value').text()).toBe('1');
expect($sent_stanza.find('field[var="muc#roomconfig_historylength"] value').text()).toBe('20');
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
New API method `converse.rooms.close()`.
2016-06-03 10:22:31 +02:00
});
Use .bind instead of $.proxy
2015-10-07 10:57:11 +02:00
describe("A Chat Room", function () {
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
afterEach(function () {
converse_api.user.logout();
converse_api.listen.not();
test_utils.clearBrowserStorage();
Clean up after running tests, by closing chatboxes.
2014-01-19 06:02:18 +01:00
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("can have spaces and special characters in its name", mock.initConverse(function (converse) {
test_utils.openChatRoom(converse, 'lounge & leisure', 'localhost', 'dummy');
Move changelog entry to right version and add test case.
2015-09-09 10:17:46 +02:00
var view = converse.chatboxviews.get(
Strophe.escapeNode('lounge & leisure')+'@localhost');
expect(view instanceof converse.ChatRoomView).toBe(true);
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Move changelog entry to right version and add test case.
2015-09-09 10:17:46 +02:00
Refactoring in MUC What started as an attempt to fix a bug in parseXUserElement, turned into another large refactoring of MUC code, and it's not clear how to break this up into multiple atomic commits. So I'm just pushing it all. At least there are two new tests added to the suite.
2016-12-02 18:41:05 +01:00
it("can be configured if you're its owner", mock.initConverse(function (converse) {
converse-muc: Expand the room configuration test
2016-12-04 19:06:11 +01:00
var view;
var sent_IQ, IQ_id;
var sendIQ = converse.connection.sendIQ;
spyOn(converse.connection, 'sendIQ').andCallFake(function (iq, callback, errback) {
sent_IQ = iq;
IQ_id = sendIQ.bind(this)(iq, callback, errback);
});
runs(function () {
converse_api.rooms.open('coven@chat.shakespeare.lit', {'nick': 'some1'});
view = converse.chatboxviews.get('coven@chat.shakespeare.lit');
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
spyOn(view, 'saveAffiliationAndRole').andCallThrough();
// We pretend this is a new room, so no disco info is returned.
var features_stanza = $iq({
from: 'coven@chat.shakespeare.lit',
'id': IQ_id,
'to': 'dummy@localhost/desktop',
'type': 'error'
}).c('error', {'type': 'cancel'})
.c('item-not-found', {'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas"});
converse.connection._dataRecv(test_utils.createRequest(features_stanza));
converse-muc: Expand the room configuration test
2016-12-04 19:06:11 +01:00
/* <presence to="dummy@localhost/converse.js-29092160"
* from="coven@chat.shakespeare.lit/some1">
* <x xmlns="http://jabber.org/protocol/muc#user">
* <item affiliation="owner" jid="dummy@localhost/converse.js-29092160" role="moderator"/>
* <status code="110"/>
* </x>
* </presence></body>
*/
var presence = $pres({
to: 'dummy@localhost/converse.js-29092160',
from: 'coven@chat.shakespeare.lit/some1'
}).c('x', {xmlns: Strophe.NS.MUC_USER})
.c('item', {
'affiliation': 'owner',
'jid': 'dummy@localhost/converse.js-29092160',
'role': 'moderator'
}).up()
.c('status', {code: '110'});
converse.connection._dataRecv(test_utils.createRequest(presence));
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
expect(view.saveAffiliationAndRole).toHaveBeenCalled();
converse-muc: Expand the room configuration test
2016-12-04 19:06:11 +01:00
expect(view.$('.configure-chatroom-button').is(':visible')).toBeTruthy();
expect(view.$('.toggle-chatbox-button').is(':visible')).toBeTruthy();
expect(view.$('.toggle-bookmark').is(':visible')).toBeTruthy();
view.$('.configure-chatroom-button').click();
});
waits(50);
runs (function () {
/* Check that an IQ is sent out, asking for the
* configuration form.
* See: // http://xmpp.org/extensions/xep-0045.html#example-163
*
* <iq from='crone1@shakespeare.lit/desktop'
* id='config1'
* to='coven@chat.shakespeare.lit'
* type='get'>
* <query xmlns='http://jabber.org/protocol/muc#owner'/>
* </iq>
*/
expect(sent_IQ.toLocaleString()).toBe(
"<iq to='coven@chat.shakespeare.lit' type='get' xmlns='jabber:client' id='"+IQ_id+"'>"+
"<query xmlns='http://jabber.org/protocol/muc#owner'/>"+
"</iq>");
Refactoring in MUC What started as an attempt to fix a bug in parseXUserElement, turned into another large refactoring of MUC code, and it's not clear how to break this up into multiple atomic commits. So I'm just pushing it all. At least there are two new tests added to the suite.
2016-12-02 18:41:05 +01:00
converse-muc: Expand the room configuration test
2016-12-04 19:06:11 +01:00
/* Server responds with the configuration form.
* See: // http://xmpp.org/extensions/xep-0045.html#example-165
*/
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
var config_stanza = $iq({from: 'coven@chat.shakespeare.lit',
converse-muc: Expand the room configuration test
2016-12-04 19:06:11 +01:00
'id': IQ_id,
'to': 'dummy@localhost/desktop',
'type': 'result'})
.c('query', { 'xmlns': 'http://jabber.org/protocol/muc#owner'})
.c('x', { 'xmlns': 'jabber:x:data', 'type': 'form'})
.c('title').t('Configuration for "coven" Room').up()
.c('instructions').t('Complete this form to modify the configuration of your room.').up()
Add eslint with lodash checking and apply its suggestions
2017-01-26 15:49:02 +01:00
.c('field', {'type': 'hidden', 'var': 'FORM_TYPE'})
.c('value').t('http://jabber.org/protocol/muc#roomconfig').up().up()
converse-muc: Expand the room configuration test
2016-12-04 19:06:11 +01:00
.c('field', {
'label': 'Natural-Language Room Name',
'type': 'text-single',
'var': 'muc#roomconfig_roomname'})
.c('value').t('A Dark Cave').up().up()
.c('field', {
'label': 'Short Description of Room',
'type': 'text-single',
'var': 'muc#roomconfig_roomdesc'})
.c('value').t('The place for all good witches!').up().up()
.c('field', {
'label': 'Enable Public Logging?',
'type': 'boolean',
'var': 'muc#roomconfig_enablelogging'})
.c('value').t(0).up().up()
.c('field', {
'label': 'Allow Occupants to Change Subject?',
'type': 'boolean',
'var': 'muc#roomconfig_changesubject'})
.c('value').t(0).up().up()
.c('field', {
'label': 'Allow Occupants to Invite Others?',
'type': 'boolean',
'var': 'muc#roomconfig_allowinvites'})
.c('value').t(0).up().up()
.c('field', {
'label': 'Who Can Send Private Messages?',
'type': 'list-single',
'var': 'muc#roomconfig_allowpm'})
.c('value').t('anyone').up()
.c('option', {'label': 'Anyone'})
.c('value').t('anyone').up().up()
.c('option', {'label': 'Anyone with Voice'})
.c('value').t('participants').up().up()
.c('option', {'label': 'Moderators Only'})
.c('value').t('moderators').up().up()
.c('option', {'label': 'Nobody'})
.c('value').t('none').up().up().up()
.c('field', {
'label': 'Roles for which Presence is Broadcasted',
'type': 'list-multi',
'var': 'muc#roomconfig_presencebroadcast'})
.c('value').t('moderator').up()
.c('value').t('participant').up()
.c('value').t('visitor').up()
.c('option', {'label': 'Moderator'})
.c('value').t('moderator').up().up()
.c('option', {'label': 'Participant'})
.c('value').t('participant').up().up()
.c('option', {'label': 'Visitor'})
.c('value').t('visitor').up().up().up()
.c('field', {
'label': 'Roles and Affiliations that May Retrieve Member List',
'type': 'list-multi',
'var': 'muc#roomconfig_getmemberlist'})
.c('value').t('moderator').up()
.c('value').t('participant').up()
.c('value').t('visitor').up()
.c('option', {'label': 'Moderator'})
.c('value').t('moderator').up().up()
.c('option', {'label': 'Participant'})
.c('value').t('participant').up().up()
.c('option', {'label': 'Visitor'})
.c('value').t('visitor').up().up().up()
.c('field', {
'label': 'Make Room Publicly Searchable?',
'type': 'boolean',
'var': 'muc#roomconfig_publicroom'})
.c('value').t(0).up().up()
.c('field', {
'label': 'Make Room Publicly Searchable?',
'type': 'boolean',
'var': 'muc#roomconfig_publicroom'})
.c('value').t(0).up().up()
.c('field', {
'label': 'Make Room Persistent?',
'type': 'boolean',
'var': 'muc#roomconfig_persistentroom'})
.c('value').t(0).up().up()
.c('field', {
'label': 'Make Room Moderated?',
'type': 'boolean',
'var': 'muc#roomconfig_moderatedroom'})
.c('value').t(0).up().up()
.c('field', {
'label': 'Make Room Members Only?',
'type': 'boolean',
'var': 'muc#roomconfig_membersonly'})
.c('value').t(0).up().up()
.c('field', {
'label': 'Password Required for Entry?',
'type': 'boolean',
'var': 'muc#roomconfig_passwordprotectedroom'})
.c('value').t(1).up().up()
.c('field', {'type': 'fixed'})
.c('value').t('If a password is required to enter this room,'+
'you must specify the password below.').up().up()
.c('field', {
'label': 'Password',
'type': 'text-private',
'var': 'muc#roomconfig_roomsecret'})
.c('value').t('cauldronburn');
converse.connection._dataRecv(test_utils.createRequest(config_stanza));
});
waits(50);
runs (function () {
expect(view.$('form.chatroom-form').length).toBe(1);
expect(view.$('form.chatroom-form fieldset').length).toBe(2);
var $membersonly = view.$('input[name="muc#roomconfig_membersonly"]');
expect($membersonly.length).toBe(1);
expect($membersonly.attr('type')).toBe('checkbox');
$membersonly.prop('checked', true);
var $moderated = view.$('input[name="muc#roomconfig_moderatedroom"]');
expect($moderated.length).toBe(1);
expect($moderated.attr('type')).toBe('checkbox');
$moderated.prop('checked', true);
var $password = view.$('input[name="muc#roomconfig_roomsecret"]');
expect($password.length).toBe(1);
expect($password.attr('type')).toBe('password');
var $allowpm = view.$('select[name="muc#roomconfig_allowpm"]');
expect($allowpm.length).toBe(1);
$allowpm.val('moderators');
var $presencebroadcast = view.$('select[name="muc#roomconfig_presencebroadcast"]');
expect($presencebroadcast.length).toBe(1);
$presencebroadcast.val(['moderator']);
view.$('input[type="submit"]').click();
});
waits(50);
runs (function () {
var $sent_stanza = $(sent_IQ.toLocaleString());
expect($sent_stanza.find('field[var="muc#roomconfig_membersonly"] value').text()).toBe('1');
expect($sent_stanza.find('field[var="muc#roomconfig_moderatedroom"] value').text()).toBe('1');
expect($sent_stanza.find('field[var="muc#roomconfig_allowpm"] value').text()).toBe('moderators');
expect($sent_stanza.find('field[var="muc#roomconfig_presencebroadcast"] value').text()).toBe('moderator');
});
Refactoring in MUC What started as an attempt to fix a bug in parseXUserElement, turned into another large refactoring of MUC code, and it's not clear how to break this up into multiple atomic commits. So I'm just pushing it all. At least there are two new tests added to the suite.
2016-12-02 18:41:05 +01:00
}));
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("shows users currently present in the room", mock.initConverse(function (converse) {
test_utils.openAndEnterChatRoom(converse, 'lounge', 'localhost', 'dummy');
Refactor other tests. All tests pass now again. updates #307
2015-03-01 11:58:07 +01:00
var name;
Refactor rooms to have separate handlers for presence and message stanzas
2016-10-13 18:22:37 +02:00
var view = converse.chatboxviews.get('lounge@localhost'),
Rename participants to occupants.
2015-10-31 17:30:06 +01:00
$occupants = view.$('.occupant-list');
Add jshint checking and fix errors.
2015-10-25 18:49:35 +01:00
var presence, role;
for (var i=0; i<mock.chatroom_names.length; i++) {
Refactor other tests. All tests pass now again. updates #307
2015-03-01 11:58:07 +01:00
name = mock.chatroom_names[i];
role = mock.chatroom_roles[name].role;
// See example 21 http://xmpp.org/extensions/xep-0045.html#enter-pres
Also test for users leaving a room. updates #307
2015-03-01 13:28:24 +01:00
presence = $pres({
Refactor other tests. All tests pass now again. updates #307
2015-03-01 11:58:07 +01:00
to:'dummy@localhost/pda',
from:'lounge@localhost/'+name
}).c('x').attrs({xmlns:'http://jabber.org/protocol/muc#user'})
.c('item').attrs({
affiliation: mock.chatroom_roles[name].affiliation,
Also test for users leaving a room. updates #307
2015-03-01 13:28:24 +01:00
jid: name.replace(/ /g,'.').toLowerCase() + '@localhost',
Refactor other tests. All tests pass now again. updates #307
2015-03-01 11:58:07 +01:00
role: role
}).up()
.c('status').attrs({code:'110'}).nodeTree;
Check whether the user has a reserved nickname when they enter a chat room. If they have, we'll use that, otherwise we render a form where they can specify their nick. Some chat room tests now fail and still need to be fixed.
2016-07-20 01:59:52 +02:00
converse.connection._dataRecv(test_utils.createRequest(presence));
Fix failing tests. We now need to mock some extra XMPP stanzas being received when a user enters a chat room in tests.
2016-07-20 09:20:56 +02:00
expect($occupants.find('li').length).toBe(2+i);
expect($($occupants.find('li')[i+1]).text()).toBe(mock.chatroom_names[i]);
expect($($occupants.find('li')[i+1]).hasClass('moderator')).toBe(role === "moderator");
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
}
Also test for users leaving a room. updates #307
2015-03-01 13:28:24 +01:00
// Test users leaving the room
// http://xmpp.org/extensions/xep-0045.html#exit
for (i=mock.chatroom_names.length-1; i>-1; i--) {
name = mock.chatroom_names[i];
role = mock.chatroom_roles[name].role;
// See example 21 http://xmpp.org/extensions/xep-0045.html#enter-pres
presence = $pres({
to:'dummy@localhost/pda',
from:'lounge@localhost/'+name,
type: 'unavailable'
}).c('x').attrs({xmlns:'http://jabber.org/protocol/muc#user'})
.c('item').attrs({
affiliation: mock.chatroom_roles[name].affiliation,
jid: name.replace(/ /g,'.').toLowerCase() + '@localhost',
role: 'none'
}).nodeTree;
Check whether the user has a reserved nickname when they enter a chat room. If they have, we'll use that, otherwise we render a form where they can specify their nick. Some chat room tests now fail and still need to be fixed.
2016-07-20 01:59:52 +02:00
converse.connection._dataRecv(test_utils.createRequest(presence));
Remove the members-list work and keep the nickname form stuff It's not stable yet and XMPP server support is very patchy. However, the nickname form work can be merged into master.
2016-07-26 08:59:34 +02:00
expect($occupants.find('li').length).toBe(i+1);
Also test for users leaving a room. updates #307
2015-03-01 13:28:24 +01:00
}
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("indicates moderators by means of a special css class and tooltip", mock.initConverse(function (converse) {
test_utils.openAndEnterChatRoom(converse, 'lounge', 'localhost', 'dummy');
Fix failing tests. We now need to mock some extra XMPP stanzas being received when a user enters a chat room in tests.
2016-07-20 09:20:56 +02:00
var view = converse.chatboxviews.get('lounge@localhost');
Refactor other tests. All tests pass now again. updates #307
2015-03-01 11:58:07 +01:00
var presence = $pres({
to:'dummy@localhost/pda',
from:'lounge@localhost/moderatorman'
}).c('x').attrs({xmlns:'http://jabber.org/protocol/muc#user'})
.c('item').attrs({
affiliation: 'admin',
Also test for users leaving a room. updates #307
2015-03-01 13:28:24 +01:00
jid: name.replace(/ /g,'.').toLowerCase() + '@localhost',
Refactor other tests. All tests pass now again. updates #307
2015-03-01 11:58:07 +01:00
role: 'moderator',
}).up()
.c('status').attrs({code:'110'}).nodeTree;
Fix failing tests. We now need to mock some extra XMPP stanzas being received when a user enters a chat room in tests.
2016-07-20 09:20:56 +02:00
converse.connection._dataRecv(test_utils.createRequest(presence));
Rename participants to occupants.
2015-10-31 17:30:06 +01:00
var occupant = view.$el.find('.occupant-list').find('li');
Fix failing tests. We now need to mock some extra XMPP stanzas being received when a user enters a chat room in tests.
2016-07-20 09:20:56 +02:00
expect(occupant.length).toBe(2);
expect($(occupant).first().text()).toBe("dummy");
expect($(occupant).last().text()).toBe("moderatorman");
expect($(occupant).last().attr('class').indexOf('moderator')).not.toBe(-1);
Add nickname to chat message when clicking on room occupant. Allows you to easily mention someone in your message.
2016-07-26 11:04:05 +02:00
expect($(occupant).last().attr('title')).toBe('This user is a moderator. Click to mention this user in your message.');
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Add a test to check that moderators are highlighted
2013-05-11 14:34:36 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("will use the user's reserved nickname, if it exists", mock.initConverse(function (converse) {
Check whether the user has a reserved nickname when they enter a chat room. If they have, we'll use that, otherwise we render a form where they can specify their nick. Some chat room tests now fail and still need to be fixed.
2016-07-20 01:59:52 +02:00
var sent_IQ, IQ_id;
var sendIQ = converse.connection.sendIQ;
spyOn(converse.connection, 'sendIQ').andCallFake(function (iq, callback, errback) {
sent_IQ = iq;
IQ_id = sendIQ.bind(this)(iq, callback, errback);
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
// We pretend this is a new room, so no disco info is returned.
var features_stanza = $iq({
from: 'lounge@localhost',
'id': IQ_id,
'to': 'dummy@localhost/desktop',
'type': 'error'
}).c('error', {'type': 'cancel'})
.c('item-not-found', {'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas"});
converse.connection._dataRecv(test_utils.createRequest(features_stanza));
Check whether the user has a reserved nickname when they enter a chat room. If they have, we'll use that, otherwise we render a form where they can specify their nick. Some chat room tests now fail and still need to be fixed.
2016-07-20 01:59:52 +02:00
var view = converse.chatboxviews.get('lounge@localhost');
spyOn(view, 'join').andCallThrough();
/* <iq from='hag66@shakespeare.lit/pda'
* id='getnick1'
* to='coven@chat.shakespeare.lit'
* type='get'>
* <query xmlns='http://jabber.org/protocol/disco#info'
* node='x-roomuser-item'/>
* </iq>
*/
expect(sent_IQ.toLocaleString()).toBe(
"<iq to='lounge@localhost' from='dummy@localhost/resource' "+
"type='get' xmlns='jabber:client' id='"+IQ_id+"'>"+
"<query xmlns='http://jabber.org/protocol/disco#info' node='x-roomuser-item'/></iq>"
);
/* <iq from='coven@chat.shakespeare.lit'
* id='getnick1'
* to='hag66@shakespeare.lit/pda'
* type='result'>
* <query xmlns='http://jabber.org/protocol/disco#info'
* node='x-roomuser-item'>
* <identity
* category='conference'
* name='thirdwitch'
* type='text'/>
* </query>
* </iq>
*/
var stanza = $iq({
'type': 'result',
'id': IQ_id,
'from': view.model.get('jid'),
Refactored notification code responsible for showing messages based on the extended presence information. - Use DOM API instead of jQuery - Make info messages overridable (allows also for disabling them) - Break up large function with inline callbacks into smaller ones
2016-11-21 13:55:19 +01:00
'to': converse.connection.jid
Check whether the user has a reserved nickname when they enter a chat room. If they have, we'll use that, otherwise we render a form where they can specify their nick. Some chat room tests now fail and still need to be fixed.
2016-07-20 01:59:52 +02:00
}).c('query', {'xmlns': 'http://jabber.org/protocol/disco#info', 'node': 'x-roomuser-item'})
.c('identity', {'category': 'conference', 'name': 'thirdwitch', 'type': 'text'});
converse.connection._dataRecv(test_utils.createRequest(stanza));
expect(view.join).toHaveBeenCalled();
// The user has just entered the room (because join was called)
// and receives their own presence from the server.
// See example 24:
// http://xmpp.org/extensions/xep-0045.html#enter-pres
var presence = $pres({
to:'dummy@localhost/resource',
from:'lounge@localhost/thirdwitch',
id:'DC352437-C019-40EC-B590-AF29E879AF97'
}).c('x').attrs({xmlns:'http://jabber.org/protocol/muc#user'})
.c('item').attrs({
affiliation: 'member',
jid: 'dummy@localhost/resource',
role: 'occupant'
}).up()
.c('status').attrs({code:'110'}).up()
.c('status').attrs({code:'210'}).nodeTree;
converse.connection._dataRecv(test_utils.createRequest(presence));
var info_text = view.$el.find('.chat-content .chat-info').text();
expect(info_text).toBe('Your nickname has been automatically set to: thirdwitch');
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Check whether the user has a reserved nickname when they enter a chat room. If they have, we'll use that, otherwise we render a form where they can specify their nick. Some chat room tests now fail and still need to be fixed.
2016-07-20 01:59:52 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("allows the user to invite their roster contacts to enter the chat room", mock.initConverse(function (converse) {
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
Add some initial tests for the room invite feature. updates #215
2014-08-31 22:48:26 +02:00
spyOn(converse, 'emit');
spyOn(window, 'prompt').andCallFake(function () {
return null;
});
Add jshint checking and fix errors.
2015-10-25 18:49:35 +01:00
var $input;
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
var view = converse.chatboxviews.get('lounge@localhost');
Add some initial tests for the room invite feature. updates #215
2014-08-31 22:48:26 +02:00
view.$el.find('.chat-area').remove();
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
test_utils.createContacts(converse, 'current'); // We need roster contacts, so that we have someone to invite
Add some initial tests for the room invite feature. updates #215
2014-08-31 22:48:26 +02:00
$input = view.$el.find('input.invited-contact.tt-input');
Add jshint checking and fix errors.
2015-10-25 18:49:35 +01:00
var $hint = view.$el.find('input.invited-contact.tt-hint');
Add some initial tests for the room invite feature. updates #215
2014-08-31 22:48:26 +02:00
runs (function () {
expect($input.length).toBe(1);
Small translation tweaks and then compiled i18n files
2016-04-07 12:35:07 +02:00
expect($input.attr('placeholder')).toBe('Invite');
Add some initial tests for the room invite feature. updates #215
2014-08-31 22:48:26 +02:00
$input.val("Felix");
$input.trigger('input');
});
waits(350); // Needed, due to debounce
runs (function () {
expect($input.val()).toBe('Felix');
expect($hint.val()).toBe('Felix Amsel');
var $sugg = view.$el.find('[data-jid="felix.amsel@localhost"]');
expect($sugg.length).toBe(1);
$sugg.trigger('click');
expect(window.prompt).toHaveBeenCalled();
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
updates #215, see below. * Filter by both fullname and jid when searching for users to invite. * Combine the confirm and prompt popups into a single confirm popup. * Bugfix in groups filter. Make sure to show group that were previously filtered out.
2014-08-31 19:25:54 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("can be joined automatically, based upon a received invite", mock.initConverse(function (converse) {
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
test_utils.createContacts(converse, 'current'); // We need roster contacts, who can invite us
Add a test for the onInvite method. refs #215
2014-09-02 20:01:49 +02:00
spyOn(window, 'confirm').andCallFake(function () {
return true;
});
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
test_utils.openAndEnterChatRoom(converse, 'lounge', 'localhost', 'dummy');
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
var view = converse.chatboxviews.get('lounge@localhost');
Add a test for the onInvite method. refs #215
2014-09-02 20:01:49 +02:00
view.close();
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
view.model.destroy(); // Manually calling this, otherwise we have to mock stanzas.
Add a test for the onInvite method. refs #215
2014-09-02 20:01:49 +02:00
var name = mock.cur_names[0];
var from_jid = name.replace(/ /g,'.').toLowerCase() + '@localhost';
var room_jid = 'lounge@localhost';
var reason = "Please join this chat room";
var message = $(
"<message from='"+from_jid+"' to='"+converse.bare_jid+"'>" +
"<x xmlns='jabber:x:conference'" +
"jid='"+room_jid+"'" +
"reason='"+reason+"'/>"+
"</message>"
)[0];
Remember toggle state of control box. updates #222
2014-09-22 12:55:14 +02:00
expect(converse.chatboxes.models.length).toBe(1);
expect(converse.chatboxes.models[0].id).toBe("controlbox");
Refactored MUC plugin to not have to override ChatBoxes collection. Instead we use event handlers.
2016-03-22 08:49:25 +01:00
converse.onDirectMUCInvitation(message);
Rename the nick changed tests. updates #307 Test from a lower level (stanza request received by strophe) and also test the case where the server automatically changed the nick.
2015-03-01 11:22:37 +01:00
expect(window.confirm).toHaveBeenCalledWith(
Add a test for the onInvite method. refs #215
2014-09-02 20:01:49 +02:00
name + ' has invited you to join a chat room: '+ room_jid +
', and left the following reason: "'+reason+'"');
Remember toggle state of control box. updates #222
2014-09-22 12:55:14 +02:00
expect(converse.chatboxes.models.length).toBe(2);
expect(converse.chatboxes.models[0].id).toBe('controlbox');
expect(converse.chatboxes.models[1].id).toBe(room_jid);
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Add a test for the onInvite method. refs #215
2014-09-02 20:01:49 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("shows received groupchat messages", mock.initConverse(function (converse) {
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
Add event emitter tests for chatrooms. Updates #48
2013-12-16 18:19:25 +01:00
spyOn(converse, 'emit');
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
var view = converse.chatboxviews.get('lounge@localhost');
Test chatroom message
2013-05-14 23:20:59 +02:00
if (!view.$el.find('.chat-area').length) { view.renderChatArea(); }
Move mock.js to tests dir. Add utils.js Both changes from tests-refactor branch
2013-11-02 09:56:20 +01:00
var nick = mock.chatroom_names[0];
Test chatroom message
2013-05-14 23:20:59 +02:00
var text = 'This is a received message';
var message = $msg({
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
from: 'lounge@localhost/'+nick,
Test chatroom message
2013-05-14 23:20:59 +02:00
id: '1',
to: 'dummy@localhost',
type: 'groupchat'
}).c('body').t(text);
view.onChatRoomMessage(message.nodeTree);
var $chat_content = view.$el.find('.chat-content');
expect($chat_content.find('.chat-message').length).toBe(1);
Rename chat-message-* class to chat-msg-*
2015-10-28 09:52:19 +01:00
expect($chat_content.find('.chat-msg-content').text()).toBe(text);
Fix tests. Emitted events weren't yet renamed in the tests.
2014-07-14 23:29:08 +02:00
expect(converse.emit).toHaveBeenCalledWith('message', message.nodeTree);
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Add event emitter tests for chatrooms. Updates #48
2013-12-16 18:19:25 +01:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("shows sent groupchat messages", mock.initConverse(function (converse) {
test_utils.openAndEnterChatRoom(converse, 'lounge', 'localhost', 'dummy');
Add event emitter tests for chatrooms. Updates #48
2013-12-16 18:19:25 +01:00
spyOn(converse, 'emit');
Bugfix, room subject wasn't being shown. Also added a test for it.
2016-05-25 11:22:27 +02:00
var view = converse.chatboxviews.get('lounge@localhost');
Add event emitter tests for chatrooms. Updates #48
2013-12-16 18:19:25 +01:00
if (!view.$el.find('.chat-area').length) { view.renderChatArea(); }
var text = 'This is a sent message';
view.$el.find('.chat-textarea').text(text);
view.$el.find('textarea.chat-textarea').trigger($.Event('keypress', {keyCode: 13}));
Fix tests. Emitted events weren't yet renamed in the tests.
2014-07-14 23:29:08 +02:00
expect(converse.emit).toHaveBeenCalledWith('messageSend', text);
Fix failing tests. We now need to mock some extra XMPP stanzas being received when a user enters a chat room in tests.
2016-07-20 09:20:56 +02:00
var $chat_content = view.$el.find('.chat-content');
expect($chat_content.find('.chat-message').length).toBe(1);
Add event emitter tests for chatrooms. Updates #48
2013-12-16 18:19:25 +01:00
Fix failing tests. We now need to mock some extra XMPP stanzas being received when a user enters a chat room in tests.
2016-07-20 09:20:56 +02:00
// Let's check that if we receive the same message again, it's
// not shown.
Add event emitter tests for chatrooms. Updates #48
2013-12-16 18:19:25 +01:00
var message = $msg({
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
from: 'lounge@localhost/dummy',
Add event emitter tests for chatrooms. Updates #48
2013-12-16 18:19:25 +01:00
to: 'dummy@localhost.com',
Fix tests by depending on jquery obj. Also fixed groupchat test by getting and including correct msg id.
2014-10-15 19:16:02 +02:00
type: 'groupchat',
id: view.model.messages.at(0).get('msgid')
Add event emitter tests for chatrooms. Updates #48
2013-12-16 18:19:25 +01:00
}).c('body').t(text);
view.onChatRoomMessage(message.nodeTree);
expect($chat_content.find('.chat-message').length).toBe(1);
Rename chat-message-* class to chat-msg-*
2015-10-28 09:52:19 +01:00
expect($chat_content.find('.chat-msg-content').last().text()).toBe(text);
Add event emitter tests for chatrooms. Updates #48
2013-12-16 18:19:25 +01:00
// We don't emit an event if it's our own message
expect(converse.emit.callCount, 1);
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Bugfix, room subject wasn't being shown. Also added a test for it.
2016-05-25 11:22:27 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("will cause the chat area to be scrolled down only if it was at the bottom already", mock.initConverse(function (converse) {
Indicate to the user when there are unread messages further down in the chat box.
2016-05-28 10:55:03 +02:00
var message = 'This message is received while the chat area is scrolled up';
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
test_utils.openAndEnterChatRoom(converse, 'lounge', 'localhost', 'dummy');
Indicate to the user when there are unread messages further down in the chat box.
2016-05-28 10:55:03 +02:00
var view = converse.chatboxviews.get('lounge@localhost');
spyOn(view, 'scrollDown').andCallThrough();
runs(function () {
/* Create enough messages so that there's a
* scrollbar.
*/
for (var i=0; i<20; i++) {
converse.chatboxes.onMessage(
$msg({
from: 'lounge@localhost/someone',
to: 'dummy@localhost.com',
type: 'groupchat',
id: (new Date()).getTime(),
}).c('body').t('Message: '+i).tree());
}
});
waits(50);
runs(function () {
view.$content.scrollTop(0);
});
waits(250);
runs(function () {
expect(view.model.get('scrolled')).toBeTruthy();
converse.chatboxes.onMessage(
$msg({
from: 'lounge@localhost/someone',
to: 'dummy@localhost.com',
type: 'groupchat',
id: (new Date()).getTime(),
}).c('body').t(message).tree());
});
waits(150);
runs(function () {
// Now check that the message appears inside the chatbox in the DOM
var $chat_content = view.$el.find('.chat-content');
var msg_txt = $chat_content.find('.chat-message:last').find('.chat-msg-content').text();
expect(msg_txt).toEqual(message);
expect(view.$content.scrollTop()).toBe(0);
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Indicate to the user when there are unread messages further down in the chat box.
2016-05-28 10:55:03 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("shows received chatroom subject messages", mock.initConverse(function (converse) {
test_utils.openAndEnterChatRoom(converse, 'jdev', 'conference.jabber.org', 'jc');
Fix failing tests. We now need to mock some extra XMPP stanzas being received when a user enters a chat room in tests.
2016-07-20 09:20:56 +02:00
Bugfix, room subject wasn't being shown. Also added a test for it.
2016-05-25 11:22:27 +02:00
var text = 'Jabber/XMPP Development | RFCs and Extensions: http://xmpp.org/ | Protocol and XSF discussions: xsf@muc.xmpp.org';
var stanza = Strophe.xmlHtmlNode(
'<message xmlns="jabber:client" to="jc@opkode.com/converse.js-60429116" type="groupchat" from="jdev@conference.jabber.org/ralphm">'+
' <subject>'+text+'</subject>'+
' <delay xmlns="urn:xmpp:delay" stamp="2014-02-04T09:35:39Z" from="jdev@conference.jabber.org"/>'+
' <x xmlns="jabber:x:delay" stamp="20140204T09:35:39" from="jdev@conference.jabber.org"/>'+
'</message>').firstChild;
converse.connection._dataRecv(test_utils.createRequest(stanza));
var view = converse.chatboxviews.get('jdev@conference.jabber.org');
var $chat_content = view.$el.find('.chat-content');
expect($chat_content.find('.chat-info').length).toBe(1);
expect($chat_content.find('.chat-info').text()).toBe('Topic set by ralphm to: '+text);
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Test chatroom message
2013-05-14 23:20:59 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("informs users if their nicknames has been changed.", mock.initConverse(function (converse) {
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
/* The service then sends two presence stanzas to the full JID
* of each occupant (including the occupant who is changing his
* or her room nickname), one of type "unavailable" for the old
* nickname and one indicating availability for the new
* nickname.
*
* See: http://xmpp.org/extensions/xep-0045.html#changenick
*
* <presence
* from='coven@localhost/thirdwitch'
* id='DC352437-C019-40EC-B590-AF29E879AF98'
* to='hag66@shakespeare.lit/pda'
* type='unavailable'>
* <x xmlns='http://jabber.org/protocol/muc#user'>
* <item affiliation='member'
* jid='hag66@shakespeare.lit/pda'
* nick='oldhag'
Rename participants to occupants.
2015-10-31 17:30:06 +01:00
* role='occupant'/>
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
* <status code='303'/>
* <status code='110'/>
* </x>
* </presence>
Rename the nick changed tests. updates #307 Test from a lower level (stanza request received by strophe) and also test the case where the server automatically changed the nick.
2015-03-01 11:22:37 +01:00
*
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
* <presence
* from='coven@localhost/oldhag'
* id='5B4F27A4-25ED-43F7-A699-382C6B4AFC67'
* to='hag66@shakespeare.lit/pda'>
* <x xmlns='http://jabber.org/protocol/muc#user'>
* <item affiliation='member'
* jid='hag66@shakespeare.lit/pda'
Rename participants to occupants.
2015-10-31 17:30:06 +01:00
* role='occupant'/>
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
* <status code='110'/>
* </x>
* </presence>
*/
Use .bind instead of $.proxy
2015-10-07 10:57:11 +02:00
var __ = utils.__.bind(converse);
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
test_utils.openAndEnterChatRoom(converse, 'lounge', 'localhost', 'oldnick');
Remove the members-list work and keep the nickname form stuff It's not stable yet and XMPP server support is very patchy. However, the nickname form work can be merged into master.
2016-07-26 08:59:34 +02:00
var view = converse.chatboxviews.get('lounge@localhost');
Rename the nick changed tests. updates #307 Test from a lower level (stanza request received by strophe) and also test the case where the server automatically changed the nick.
2015-03-01 11:22:37 +01:00
var $chat_content = view.$el.find('.chat-content');
// The user has just entered the room and receives their own
// presence from the server.
// See example 24:
// http://xmpp.org/extensions/xep-0045.html#enter-pres
var presence = $pres({
to:'dummy@localhost/pda',
from:'lounge@localhost/oldnick',
id:'DC352437-C019-40EC-B590-AF29E879AF97'
}).c('x').attrs({xmlns:'http://jabber.org/protocol/muc#user'})
.c('item').attrs({
affiliation: 'member',
jid: 'dummy@localhost/pda',
Rename participants to occupants.
2015-10-31 17:30:06 +01:00
role: 'occupant'
Rename the nick changed tests. updates #307 Test from a lower level (stanza request received by strophe) and also test the case where the server automatically changed the nick.
2015-03-01 11:22:37 +01:00
}).up()
.c('status').attrs({code:'110'}).up()
.c('status').attrs({code:'210'}).nodeTree;
Remove the members-list work and keep the nickname form stuff It's not stable yet and XMPP server support is very patchy. However, the nickname form work can be merged into master.
2016-07-26 08:59:34 +02:00
converse.connection._dataRecv(test_utils.createRequest(presence));
Rename participants to occupants.
2015-10-31 17:30:06 +01:00
var $occupants = view.$('.occupant-list');
expect($occupants.children().length).toBe(1);
expect($occupants.children().first(0).text()).toBe("oldnick");
Fix failing tests
2016-07-19 15:24:22 +02:00
Rename the nick changed tests. updates #307 Test from a lower level (stanza request received by strophe) and also test the case where the server automatically changed the nick.
2015-03-01 11:22:37 +01:00
expect($chat_content.find('div.chat-info').length).toBe(1);
Rename variables to adhere to coding style.
2016-11-22 09:54:17 +01:00
expect($chat_content.find('div.chat-info').html()).toBe(__(converse.muc.new_nickname_messages["210"], "oldnick"));
Rename the nick changed tests. updates #307 Test from a lower level (stanza request received by strophe) and also test the case where the server automatically changed the nick.
2015-03-01 11:22:37 +01:00
presence = $pres().attrs({
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
from:'lounge@localhost/oldnick',
id:'DC352437-C019-40EC-B590-AF29E879AF98',
to:'dummy@localhost/pda',
type:'unavailable'
})
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc#user'})
.c('item').attrs({
affiliation: 'member',
jid: 'dummy@localhost/pda',
nick: 'newnick',
Rename participants to occupants.
2015-10-31 17:30:06 +01:00
role: 'occupant'
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
}).up()
.c('status').attrs({code:'303'}).up()
.c('status').attrs({code:'110'}).nodeTree;
Remove the members-list work and keep the nickname form stuff It's not stable yet and XMPP server support is very patchy. However, the nickname form work can be merged into master.
2016-07-26 08:59:34 +02:00
converse.connection._dataRecv(test_utils.createRequest(presence));
Rename the nick changed tests. updates #307 Test from a lower level (stanza request received by strophe) and also test the case where the server automatically changed the nick.
2015-03-01 11:22:37 +01:00
expect($chat_content.find('div.chat-info').length).toBe(2);
Rename variables to adhere to coding style.
2016-11-22 09:54:17 +01:00
expect($chat_content.find('div.chat-info').last().html()).toBe(__(converse.muc.new_nickname_messages["303"], "newnick"));
Fix failing tests
2016-07-19 15:24:22 +02:00
Rename participants to occupants.
2015-10-31 17:30:06 +01:00
$occupants = view.$('.occupant-list');
Remove the members-list work and keep the nickname form stuff It's not stable yet and XMPP server support is very patchy. However, the nickname form work can be merged into master.
2016-07-26 08:59:34 +02:00
expect($occupants.children().length).toBe(0);
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
presence = $pres().attrs({
from:'lounge@localhost/newnick',
id:'5B4F27A4-25ED-43F7-A699-382C6B4AFC67',
to:'dummy@localhost/pda'
})
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc#user'})
.c('item').attrs({
affiliation: 'member',
jid: 'dummy@localhost/pda',
Rename participants to occupants.
2015-10-31 17:30:06 +01:00
role: 'occupant'
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
}).up()
.c('status').attrs({code:'110'}).nodeTree;
Rename the nick changed tests. updates #307 Test from a lower level (stanza request received by strophe) and also test the case where the server automatically changed the nick.
2015-03-01 11:22:37 +01:00
Remove the members-list work and keep the nickname form stuff It's not stable yet and XMPP server support is very patchy. However, the nickname form work can be merged into master.
2016-07-26 08:59:34 +02:00
converse.connection._dataRecv(test_utils.createRequest(presence));
Rename the nick changed tests. updates #307 Test from a lower level (stanza request received by strophe) and also test the case where the server automatically changed the nick.
2015-03-01 11:22:37 +01:00
expect($chat_content.find('div.chat-info').length).toBe(2);
Rename variables to adhere to coding style.
2016-11-22 09:54:17 +01:00
expect($chat_content.find('div.chat-info').last().html()).toBe(__(converse.muc.new_nickname_messages["303"], "newnick"));
Rename participants to occupants.
2015-10-31 17:30:06 +01:00
$occupants = view.$('.occupant-list');
expect($occupants.children().length).toBe(1);
expect($occupants.children().first(0).text()).toBe("newnick");
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Test that user is properly informed when kicked out of a room
2014-09-06 12:46:24 +02:00
When inviting to a members-only room, first add to user to the member-list
2016-12-05 11:50:01 +01:00
it("queries for the room information before attempting to join the user", mock.initConverse(function (converse) {
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
var sent_IQ, IQ_id;
var sendIQ = converse.connection.sendIQ;
spyOn(converse.connection, 'sendIQ').andCallFake(function (iq, callback, errback) {
sent_IQ = iq;
IQ_id = sendIQ.bind(this)(iq, callback, errback);
});
converse_api.rooms.open('coven@chat.shakespeare.lit', {'nick': 'some1'});
// Check that the room queried for the feautures.
expect(sent_IQ.toLocaleString()).toBe(
"<iq from='dummy@localhost/resource' to='coven@chat.shakespeare.lit' type='get' xmlns='jabber:client' id='"+IQ_id+"'>"+
"<query xmlns='http://jabber.org/protocol/disco#info'/>"+
"</iq>");
/* <iq from='coven@chat.shakespeare.lit'
* id='ik3vs715'
* to='hag66@shakespeare.lit/pda'
* type='result'>
* <query xmlns='http://jabber.org/protocol/disco#info'>
* <identity
* category='conference'
* name='A Dark Cave'
* type='text'/>
* <feature var='http://jabber.org/protocol/muc'/>
* <feature var='muc_passwordprotected'/>
* <feature var='muc_hidden'/>
* <feature var='muc_temporary'/>
* <feature var='muc_open'/>
* <feature var='muc_unmoderated'/>
* <feature var='muc_nonanonymous'/>
* </query>
* </iq>
*/
var features_stanza = $iq({
from: 'coven@chat.shakespeare.lit',
'id': IQ_id,
'to': 'dummy@localhost/desktop',
'type': 'result'
})
.c('query', { 'xmlns': 'http://jabber.org/protocol/disco#info'})
.c('identity', {
'category': 'conference',
'name': 'A Dark Cave',
'type': 'text'
}).up()
.c('feature', {'var': 'http://jabber.org/protocol/muc'}).up()
When inviting to a members-only room, first add to user to the member-list
2016-12-05 11:50:01 +01:00
.c('feature', {'var': 'muc_passwordprotected'}).up()
.c('feature', {'var': 'muc_hidden'}).up()
.c('feature', {'var': 'muc_temporary'}).up()
.c('feature', {'var': 'muc_open'}).up()
.c('feature', {'var': 'muc_unmoderated'}).up()
.c('feature', {'var': 'muc_nonanonymous'});
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
converse.connection._dataRecv(test_utils.createRequest(features_stanza));
var view = converse.chatboxviews.get('coven@chat.shakespeare.lit');
polyfill startsWith, to make the tests pass.
2016-12-05 19:55:11 +01:00
expect(view.model.get('features_fetched')).toBe(true);
When inviting to a members-only room, first add to user to the member-list
2016-12-05 11:50:01 +01:00
expect(view.model.get('passwordprotected')).toBe(true);
expect(view.model.get('hidden')).toBe(true);
expect(view.model.get('temporary')).toBe(true);
expect(view.model.get('open')).toBe(true);
expect(view.model.get('unmoderated')).toBe(true);
expect(view.model.get('nonanonymous')).toBe(true);
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
}));
Refactoring in MUC What started as an attempt to fix a bug in parseXUserElement, turned into another large refactoring of MUC code, and it's not clear how to break this up into multiple atomic commits. So I'm just pushing it all. At least there are two new tests added to the suite.
2016-12-02 18:41:05 +01:00
it("indicates when a room is no longer anonymous", mock.initConverse(function (converse) {
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
var sent_IQ, IQ_id;
var sendIQ = converse.connection.sendIQ;
spyOn(converse.connection, 'sendIQ').andCallFake(function (iq, callback, errback) {
sent_IQ = iq;
IQ_id = sendIQ.bind(this)(iq, callback, errback);
Refactoring in MUC What started as an attempt to fix a bug in parseXUserElement, turned into another large refactoring of MUC code, and it's not clear how to break this up into multiple atomic commits. So I'm just pushing it all. At least there are two new tests added to the suite.
2016-12-02 18:41:05 +01:00
});
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
converse_api.rooms.open('coven@chat.shakespeare.lit', {'nick': 'some1'});
// We pretend this is a new room, so no disco info is returned.
var features_stanza = $iq({
from: 'coven@chat.shakespeare.lit',
'id': IQ_id,
'to': 'dummy@localhost/desktop',
'type': 'error'
}).c('error', {'type': 'cancel'})
.c('item-not-found', {'xmlns': "urn:ietf:params:xml:ns:xmpp-stanzas"});
converse.connection._dataRecv(test_utils.createRequest(features_stanza));
var view = converse.chatboxviews.get('coven@chat.shakespeare.lit');
Refactoring in MUC What started as an attempt to fix a bug in parseXUserElement, turned into another large refactoring of MUC code, and it's not clear how to break this up into multiple atomic commits. So I'm just pushing it all. At least there are two new tests added to the suite.
2016-12-02 18:41:05 +01:00
/* <message xmlns="jabber:client"
* type="groupchat"
* to="dummy@localhost/converse.js-27854181"
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
* from="coven@chat.shakespeare.lit">
Refactoring in MUC What started as an attempt to fix a bug in parseXUserElement, turned into another large refactoring of MUC code, and it's not clear how to break this up into multiple atomic commits. So I'm just pushing it all. At least there are two new tests added to the suite.
2016-12-02 18:41:05 +01:00
* <x xmlns="http://jabber.org/protocol/muc#user">
* <status code="104"/>
* <status code="172"/>
* </x>
* </message>
*/
var message = $msg({
type:'groupchat',
to: 'dummy@localhost/converse.js-27854181',
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
from: 'coven@chat.shakespeare.lit'
Refactoring in MUC What started as an attempt to fix a bug in parseXUserElement, turned into another large refactoring of MUC code, and it's not clear how to break this up into multiple atomic commits. So I'm just pushing it all. At least there are two new tests added to the suite.
2016-12-02 18:41:05 +01:00
}).c('x', {xmlns: Strophe.NS.MUC_USER})
.c('status', {code: '104'}).up()
.c('status', {code: '172'});
converse.connection._dataRecv(test_utils.createRequest(message));
var $chat_body = view.$('.chatroom-body');
expect($chat_body.html().trim().indexOf(
'<div class="chat-info">This room is now no longer anonymous</div>'
)).not.toBe(-1);
}));
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("informs users if they have been kicked out of the chat room", mock.initConverse(function (converse) {
Test that user is properly informed when kicked out of a room
2014-09-06 12:46:24 +02:00
/* <presence
* from='harfleur@chat.shakespeare.lit/pistol'
* to='pistol@shakespeare.lit/harfleur'
* type='unavailable'>
* <x xmlns='http://jabber.org/protocol/muc#user'>
* <item affiliation='none' role='none'>
converse-muc: Cache the room configuration on the Backbone.Model object
2016-12-03 17:39:59 +01:00
* <actor nick='Fluellen'/>
* <reason>Avaunt, you cullion!</reason>
Test that user is properly informed when kicked out of a room
2014-09-06 12:46:24 +02:00
* </item>
converse-muc: Cache the room configuration on the Backbone.Model object
2016-12-03 17:39:59 +01:00
* <status code='110'/>
Test that user is properly informed when kicked out of a room
2014-09-06 12:46:24 +02:00
* <status code='307'/>
* </x>
* </presence>
*/
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
test_utils.openAndEnterChatRoom(converse, 'lounge', 'localhost', 'dummy');
Test that user is properly informed when kicked out of a room
2014-09-06 12:46:24 +02:00
var presence = $pres().attrs({
from:'lounge@localhost/dummy',
to:'dummy@localhost/pda',
type:'unavailable'
})
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc#user'})
.c('item').attrs({
affiliation: 'none',
jid: 'dummy@localhost/pda',
role: 'none'
})
.c('actor').attrs({nick: 'Fluellen'}).up()
.c('reason').t('Avaunt, you cullion!').up()
.up()
converse-muc: Cache the room configuration on the Backbone.Model object
2016-12-03 17:39:59 +01:00
.c('status').attrs({code:'110'}).up()
Test that user is properly informed when kicked out of a room
2014-09-06 12:46:24 +02:00
.c('status').attrs({code:'307'}).nodeTree;
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
var view = converse.chatboxviews.get('lounge@localhost');
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
view.onChatRoomPresence(presence);
Fix tests. Elements in chat rooms are now hidden, instead of removed. Update tests to reflect this.
2014-09-21 00:47:36 +02:00
expect(view.$('.chat-area').is(':visible')).toBeFalsy();
Rename participants to occupants.
2015-10-31 17:30:06 +01:00
expect(view.$('.occupants').is(':visible')).toBeFalsy();
Fix CSS and horizontal dragresize for chat rooms. - Rename .chat-body to .chatroom-body - Upate SASS for chat rooms - Hide the room occupants view by toggling the class "hidden" - The chatroom chat area and occupants list are now shown as table cells.
2015-10-24 21:52:54 +02:00
var $chat_body = view.$('.chatroom-body');
Mention the actor (if available) when removed from room
2016-11-21 14:10:36 +01:00
expect($chat_body.html().trim().indexOf(
'<p>You have been kicked from this room</p>'+
'<p>This action was done by <strong>Fluellen</strong>.</p>'+
'<p>The reason given is: <em>"Avaunt, you cullion!"</em>.</p>'
)).not.toBe(-1);
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("can be saved to, and retrieved from, browserStorage", mock.initConverse(function (converse) {
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
// We instantiate a new ChatBoxes collection, which by default
// will be empty.
Let tests pass again
2014-08-08 22:06:01 +02:00
test_utils.openControlBox();
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
var newchatboxes = new converse.ChatBoxes();
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
expect(newchatboxes.length).toEqual(0);
Fixing tests after latest refactoring
2014-06-30 19:21:16 +02:00
// The chatboxes will then be fetched from browserStorage inside the
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
// onConnected method
newchatboxes.onConnected();
Remove the last calls to connection.muc. updates #307
2015-03-04 22:27:11 +01:00
expect(newchatboxes.length).toEqual(2);
Fixing tests after latest refactoring
2014-06-30 19:21:16 +02:00
// Check that the chatrooms retrieved from browserStorage
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
// have the same attributes values as the original ones.
Add jshint checking and fix errors.
2015-10-25 18:49:35 +01:00
var attrs = ['id', 'box_id', 'visible'];
var new_attrs, old_attrs;
for (var i=0; i<attrs.length; i++) {
Add eslint with lodash checking and apply its suggestions
2017-01-26 15:49:02 +01:00
new_attrs = _.map(_.map(newchatboxes.models, 'attributes'), attrs[i]);
old_attrs = _.map(_.map(converse.chatboxes.models, 'attributes'), attrs[i]);
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
// FIXME: should have have to sort here? Order must
// probably be the same...
// This should be fixed once the controlbox always opens
// only on the right.
expect(_.isEqual(new_attrs.sort(), old_attrs.sort())).toEqual(true);
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
}
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
converse.rosterview.render();
}));
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("can be minimized by clicking a DOM element with class 'toggle-chatbox-button'", mock.initConverse(function (converse) {
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
var view = converse.chatboxviews.get('lounge@localhost'),
trimmed_chatboxes = converse.minimized_chats;
Fix chatroom tests
2014-06-02 05:13:53 +02:00
spyOn(view, 'minimize').andCallThrough();
spyOn(view, 'maximize').andCallThrough();
Add toggle test for chatrooms
2014-03-14 20:35:43 +01:00
spyOn(converse, 'emit');
view.delegateEvents(); // We need to rebind all events otherwise our spy won't be called
runs(function () {
view.$el.find('.toggle-chatbox-button').click();
});
Updates #729. Minimized chat boxes don't stay hidden Bug got introduced during fix for #677 Eventually had to do a significant refactoring, to more consistently use the `hidden` class instead of `display: None`. (relevant for #695)
2016-11-22 17:42:58 +01:00
waits(350);
Add toggle test for chatrooms
2014-03-14 20:35:43 +01:00
runs(function () {
Fix chatroom tests
2014-06-02 05:13:53 +02:00
expect(view.minimize).toHaveBeenCalled();
Fix tests. Emitted events weren't yet renamed in the tests.
2014-07-14 23:29:08 +02:00
expect(converse.emit).toHaveBeenCalledWith('chatBoxMinimized', jasmine.any(Object));
Fix chatroom tests
2014-06-02 05:13:53 +02:00
expect(view.$el.is(':visible')).toBeFalsy();
Add toggle test for chatrooms
2014-03-14 20:35:43 +01:00
expect(view.model.get('minimized')).toBeTruthy();
Fix chatroom tests
2014-06-02 05:13:53 +02:00
expect(view.minimize).toHaveBeenCalled();
Add jshint checking and fix errors.
2015-10-25 18:49:35 +01:00
var trimmedview = trimmed_chatboxes.get(view.model.get('id'));
Fix chatroom tests
2014-06-02 05:13:53 +02:00
trimmedview.$("a.restore-chat").click();
Add toggle test for chatrooms
2014-03-14 20:35:43 +01:00
});
Updates #729. Minimized chat boxes don't stay hidden Bug got introduced during fix for #677 Eventually had to do a significant refactoring, to more consistently use the `hidden` class instead of `display: None`. (relevant for #695)
2016-11-22 17:42:58 +01:00
waits(350);
Add toggle test for chatrooms
2014-03-14 20:35:43 +01:00
runs(function () {
Fix chatroom tests
2014-06-02 05:13:53 +02:00
expect(view.maximize).toHaveBeenCalled();
Fix tests. Emitted events weren't yet renamed in the tests.
2014-07-14 23:29:08 +02:00
expect(converse.emit).toHaveBeenCalledWith('chatBoxMaximized', jasmine.any(Object));
Fix chatroom tests
2014-06-02 05:13:53 +02:00
expect(view.$el.is(':visible')).toBeTruthy();
Add toggle test for chatrooms
2014-03-14 20:35:43 +01:00
expect(view.model.get('minimized')).toBeFalsy();
expect(converse.emit.callCount, 3);
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Add toggle test for chatrooms
2014-03-14 20:35:43 +01:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("can be closed again by clicking a DOM element with class 'close-chatbox-button'", mock.initConverse(function (converse) {
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
Indicate whether a chatroom has been bookmarked.
2016-09-22 11:30:06 +02:00
var view = converse.chatboxviews.get('lounge@localhost');
More working on trimming chats. (still very buggy) More flesh on the view and superview for trimmed chats. Add event handlers. Renamed some methods to make them shorter, more consistent.
2014-05-27 18:34:22 +02:00
spyOn(view, 'close').andCallThrough();
Add event emitter tests for chatrooms. Updates #48
2013-12-16 18:19:25 +01:00
spyOn(converse, 'emit');
Refactor other tests. All tests pass now again. updates #307
2015-03-01 11:58:07 +01:00
spyOn(view, 'leave');
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
view.delegateEvents(); // We need to rebind all events otherwise our spy won't be called
Fix tests after all the refactoring...
2014-02-28 03:04:52 +01:00
runs(function () {
view.$el.find('.close-chatbox-button').click();
});
Fix chatroom tests
2014-06-02 05:13:53 +02:00
waits(50);
Fix tests after all the refactoring...
2014-02-28 03:04:52 +01:00
runs(function () {
More working on trimming chats. (still very buggy) More flesh on the view and superview for trimmed chats. Add event handlers. Renamed some methods to make them shorter, more consistent.
2014-05-27 18:34:22 +02:00
expect(view.close).toHaveBeenCalled();
Refactor other tests. All tests pass now again. updates #307
2015-03-01 11:58:07 +01:00
expect(view.leave).toHaveBeenCalled();
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
// XXX: After refactoring, the chat box only gets closed
// once we have confirmation from the server. To test this,
// we would have to mock the returned presence stanza.
// See the "leave" method on the ChatRoomView.
// expect(converse.emit).toHaveBeenCalledWith('chatBoxClosed', jasmine.any(Object));
Indicate whether a chatroom has been bookmarked.
2016-09-22 11:30:06 +02:00
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
});
Indicate to the user when there are unread messages further down in the chat box.
2016-05-28 10:55:03 +02:00
Fixes #472 Cannot read property 'splitOnce' of undefined
2015-10-12 16:23:05 +02:00
describe("Each chat room can take special commands", function () {
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
afterEach(function () {
converse_api.user.logout();
converse_api.listen.not();
test_utils.clearBrowserStorage();
Fixes #472 Cannot read property 'splitOnce' of undefined
2015-10-12 16:23:05 +02:00
});
Case-insensitive matching of moderation commands. Also add `/subject` as alias to `/topic`
2017-02-01 18:36:20 +01:00
it("to set the room subject", mock.initConverse(function (converse) {
var sent_stanza;
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
var view = converse.chatboxviews.get('lounge@localhost');
spyOn(view, 'onMessageSubmitted').andCallThrough();
spyOn(view, 'clearChatRoomMessages');
spyOn(converse.connection, 'send').andCallFake(function (stanza) {
sent_stanza = stanza;
});
// Check the alias /topic
var $textarea = view.$el.find('.chat-textarea');
$textarea.val('/topic This is the room subject');
$textarea.trigger($.Event('keypress', {keyCode: 13}));
expect(view.onMessageSubmitted).toHaveBeenCalled();
expect(converse.connection.send).toHaveBeenCalled();
expect(sent_stanza.outerHTML).toBe(
'<message to="lounge@localhost" from="dummy@localhost/resource" type="groupchat" xmlns="jabber:client">'+
'<subject xmlns="jabber:client">This is the room subject</subject>'+
'</message>');
// Check /subject
$textarea.val('/subject This is a new subject');
$textarea.trigger($.Event('keypress', {keyCode: 13}));
expect(sent_stanza.outerHTML).toBe(
'<message to="lounge@localhost" from="dummy@localhost/resource" type="groupchat" xmlns="jabber:client">'+
'<subject xmlns="jabber:client">This is a new subject</subject>'+
'</message>');
// Check case insensitivity
$textarea.val('/Subject This is yet another subject');
$textarea.trigger($.Event('keypress', {keyCode: 13}));
expect(sent_stanza.outerHTML).toBe(
'<message to="lounge@localhost" from="dummy@localhost/resource" type="groupchat" xmlns="jabber:client">'+
'<subject xmlns="jabber:client">This is yet another subject</subject>'+
'</message>');
}));
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("to clear messages", mock.initConverse(function (converse) {
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
Add jshint checking and fix errors.
2015-10-25 18:49:35 +01:00
var view = converse.chatboxviews.get('lounge@localhost');
Chat state notifications are now also sent out from chat rooms.
2016-08-12 14:52:33 +02:00
spyOn(view, 'onMessageSubmitted').andCallThrough();
Fixes #472 Cannot read property 'splitOnce' of undefined
2015-10-12 16:23:05 +02:00
spyOn(view, 'clearChatRoomMessages');
view.$el.find('.chat-textarea').text('/clear');
view.$el.find('textarea.chat-textarea').trigger($.Event('keypress', {keyCode: 13}));
Chat state notifications are now also sent out from chat rooms.
2016-08-12 14:52:33 +02:00
expect(view.onMessageSubmitted).toHaveBeenCalled();
Fixes #472 Cannot read property 'splitOnce' of undefined
2015-10-12 16:23:05 +02:00
expect(view.clearChatRoomMessages).toHaveBeenCalled();
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Fixes #472 Cannot read property 'splitOnce' of undefined
2015-10-12 16:23:05 +02:00
Use $.when to keep track of all outgoing promises Now that we are sending multiple IQ stanzas when setting affiliations. We now again have a sendAffiliation method, so we use that.
2016-12-08 08:28:20 +01:00
it("to make a user an owner", mock.initConverse(function (converse) {
var sent_IQ, IQ_id;
var sendIQ = converse.connection.sendIQ;
spyOn(converse.connection, 'sendIQ').andCallFake(function (iq, callback, errback) {
sent_IQ = iq;
IQ_id = sendIQ.bind(this)(iq, callback, errback);
});
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
var view = converse.chatboxviews.get('lounge@localhost');
spyOn(view, 'onMessageSubmitted').andCallThrough();
spyOn(view, 'setAffiliation').andCallThrough();
spyOn(view, 'showStatusNotification').andCallThrough();
spyOn(view, 'validateRoleChangeCommand').andCallThrough();
view.$el.find('.chat-textarea').text('/owner');
view.$el.find('textarea.chat-textarea').trigger($.Event('keypress', {keyCode: 13}));
expect(view.onMessageSubmitted).toHaveBeenCalled();
expect(view.validateRoleChangeCommand).toHaveBeenCalled();
expect(view.showStatusNotification).toHaveBeenCalledWith(
"Error: the \"owner\" command takes two arguments, the user's nickname and optionally a reason.",
true
);
expect(view.setAffiliation).not.toHaveBeenCalled();
// Call now with the correct amount of arguments.
// XXX: Calling onMessageSubmitted directly, trying
// again via triggering Event doesn't work for some weird
// reason.
view.onMessageSubmitted('/owner annoyingGuy@localhost You\'re annoying');
expect(view.validateRoleChangeCommand.callCount).toBe(2);
expect(view.showStatusNotification.callCount).toBe(1);
expect(view.setAffiliation).toHaveBeenCalled();
// Check that the member list now gets updated
expect(sent_IQ.toLocaleString()).toBe(
"<iq to='lounge@localhost' type='set' xmlns='jabber:client' id='"+IQ_id+"'>"+
"<query xmlns='http://jabber.org/protocol/muc#admin'>"+
"<item affiliation='owner' jid='annoyingGuy@localhost'>"+
"<reason>You&apos;re annoying</reason>"+
"</item>"+
"</query>"+
"</iq>");
}));
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("to ban a user", mock.initConverse(function (converse) {
Use $.when to keep track of all outgoing promises Now that we are sending multiple IQ stanzas when setting affiliations. We now again have a sendAffiliation method, so we use that.
2016-12-08 08:28:20 +01:00
var sent_IQ, IQ_id;
var sendIQ = converse.connection.sendIQ;
spyOn(converse.connection, 'sendIQ').andCallFake(function (iq, callback, errback) {
sent_IQ = iq;
IQ_id = sendIQ.bind(this)(iq, callback, errback);
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
test_utils.openChatRoom(converse, 'lounge', 'localhost', 'dummy');
Add jshint checking and fix errors.
2015-10-25 18:49:35 +01:00
var view = converse.chatboxviews.get('lounge@localhost');
Chat state notifications are now also sent out from chat rooms.
2016-08-12 14:52:33 +02:00
spyOn(view, 'onMessageSubmitted').andCallThrough();
Use $.when to keep track of all outgoing promises Now that we are sending multiple IQ stanzas when setting affiliations. We now again have a sendAffiliation method, so we use that.
2016-12-08 08:28:20 +01:00
spyOn(view, 'setAffiliation').andCallThrough();
Fixes #472 Cannot read property 'splitOnce' of undefined
2015-10-12 16:23:05 +02:00
spyOn(view, 'showStatusNotification').andCallThrough();
spyOn(view, 'validateRoleChangeCommand').andCallThrough();
view.$el.find('.chat-textarea').text('/ban');
view.$el.find('textarea.chat-textarea').trigger($.Event('keypress', {keyCode: 13}));
Chat state notifications are now also sent out from chat rooms.
2016-08-12 14:52:33 +02:00
expect(view.onMessageSubmitted).toHaveBeenCalled();
Fixes #472 Cannot read property 'splitOnce' of undefined
2015-10-12 16:23:05 +02:00
expect(view.validateRoleChangeCommand).toHaveBeenCalled();
expect(view.showStatusNotification).toHaveBeenCalledWith(
"Error: the \"ban\" command takes two arguments, the user's nickname and optionally a reason.",
true
);
Use $.when to keep track of all outgoing promises Now that we are sending multiple IQ stanzas when setting affiliations. We now again have a sendAffiliation method, so we use that.
2016-12-08 08:28:20 +01:00
expect(view.setAffiliation).not.toHaveBeenCalled();
Fixes #472 Cannot read property 'splitOnce' of undefined
2015-10-12 16:23:05 +02:00
// Call now with the correct amount of arguments.
Chat state notifications are now also sent out from chat rooms.
2016-08-12 14:52:33 +02:00
// XXX: Calling onMessageSubmitted directly, trying
Fixes #472 Cannot read property 'splitOnce' of undefined
2015-10-12 16:23:05 +02:00
// again via triggering Event doesn't work for some weird
// reason.
Use $.when to keep track of all outgoing promises Now that we are sending multiple IQ stanzas when setting affiliations. We now again have a sendAffiliation method, so we use that.
2016-12-08 08:28:20 +01:00
view.onMessageSubmitted('/ban annoyingGuy@localhost You\'re annoying');
Fixes #472 Cannot read property 'splitOnce' of undefined
2015-10-12 16:23:05 +02:00
expect(view.validateRoleChangeCommand.callCount).toBe(2);
expect(view.showStatusNotification.callCount).toBe(1);
Use $.when to keep track of all outgoing promises Now that we are sending multiple IQ stanzas when setting affiliations. We now again have a sendAffiliation method, so we use that.
2016-12-08 08:28:20 +01:00
expect(view.setAffiliation).toHaveBeenCalled();
// Check that the member list now gets updated
expect(sent_IQ.toLocaleString()).toBe(
"<iq to='lounge@localhost' type='set' xmlns='jabber:client' id='"+IQ_id+"'>"+
"<query xmlns='http://jabber.org/protocol/muc#admin'>"+
"<item affiliation='outcast' jid='annoyingGuy@localhost'>"+
"<reason>You&apos;re annoying</reason>"+
"</item>"+
"</query>"+
"</iq>");
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
});
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
Use .bind instead of $.proxy
2015-10-07 10:57:11 +02:00
describe("When attempting to enter a chatroom", function () {
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
afterEach(function () {
converse_api.user.logout();
converse_api.listen.not();
test_utils.clearBrowserStorage();
});
Refactored notification code responsible for showing messages based on the extended presence information. - Use DOM API instead of jQuery - Make info messages overridable (allows also for disabling them) - Break up large function with inline callbacks into smaller ones
2016-11-21 13:55:19 +01:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
var submitRoomForm = function (converse) {
var roomspanel = converse.chatboxviews.get('controlbox').roomspanel;
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
var $input = roomspanel.$el.find('input.new-chatroom-name');
Fix tests after adding nick input field
2013-05-21 16:49:10 +02:00
var $nick = roomspanel.$el.find('input.new-chatroom-nick');
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
var $server = roomspanel.$el.find('input.new-chatroom-server');
$input.val('problematic');
Fix tests after adding nick input field
2013-05-21 16:49:10 +02:00
$nick.val('dummy');
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
$server.val('muc.localhost');
roomspanel.$el.find('form').submit();
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
};
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("will show an error message if the room requires a password", mock.initConverse(function (converse) {
submitRoomForm(converse);
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
var presence = $pres().attrs({
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
from:'lounge@localhost/thirdwitch',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
id:'n13mt3l',
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
to:'dummy@localhost/pda',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
type:'error'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc'}).up()
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
.c('error').attrs({by:'lounge@localhost', type:'auth'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('not-authorized').attrs({xmlns:'urn:ietf:params:xml:ns:xmpp-stanzas'}).nodeTree;
Fix tests
2013-05-14 09:43:49 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
var view = converse.chatboxviews.get('problematic@muc.localhost');
Fix tests
2013-05-14 09:43:49 +02:00
spyOn(view, 'renderPasswordForm').andCallThrough();
runs(function () {
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
view.onChatRoomPresence(presence);
Fix tests
2013-05-14 09:43:49 +02:00
});
waits(250);
runs(function () {
Fix CSS and horizontal dragresize for chat rooms. - Rename .chat-body to .chatroom-body - Upate SASS for chat rooms - Hide the room occupants view by toggling the class "hidden" - The chatroom chat area and occupants list are now shown as table cells.
2015-10-24 21:52:54 +02:00
var $chat_body = view.$el.find('.chatroom-body');
Fix tests
2013-05-14 09:43:49 +02:00
expect(view.renderPasswordForm).toHaveBeenCalled();
expect($chat_body.find('form.chatroom-form').length).toBe(1);
Bugfix in jquery element query
2013-06-02 22:32:33 +02:00
expect($chat_body.find('legend').text()).toBe('This chatroom requires a password');
Fix tests
2013-05-14 09:43:49 +02:00
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("will show an error message if the room is members-only and the user not included", mock.initConverse(function (converse) {
submitRoomForm(converse);
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
var presence = $pres().attrs({
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
from:'lounge@localhost/thirdwitch',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
id:'n13mt3l',
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
to:'dummy@localhost/pda',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
type:'error'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc'}).up()
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
.c('error').attrs({by:'lounge@localhost', type:'auth'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('registration-required').attrs({xmlns:'urn:ietf:params:xml:ns:xmpp-stanzas'}).nodeTree;
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
var view = converse.chatboxviews.get('problematic@muc.localhost');
Refactored status message rendering code As a result we now implement more status codes from the spec. Specifically the codes related to forced removal form the room Also fixed a bug related to wrong authentication when logging in.
2013-05-30 21:24:00 +02:00
spyOn(view, 'showErrorMessage').andCallThrough();
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
view.onChatRoomPresence(presence);
Fix tests after small markup change
2015-10-30 18:44:24 +01:00
expect(view.$el.find('.chatroom-body p:last').text()).toBe('You are not on the member list of this room');
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("will show an error message if the user has been banned", mock.initConverse(function (converse) {
submitRoomForm(converse);
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
var presence = $pres().attrs({
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
from:'lounge@localhost/thirdwitch',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
id:'n13mt3l',
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
to:'dummy@localhost/pda',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
type:'error'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc'}).up()
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
.c('error').attrs({by:'lounge@localhost', type:'auth'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('forbidden').attrs({xmlns:'urn:ietf:params:xml:ns:xmpp-stanzas'}).nodeTree;
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
var view = converse.chatboxviews.get('problematic@muc.localhost');
Refactored status message rendering code As a result we now implement more status codes from the spec. Specifically the codes related to forced removal form the room Also fixed a bug related to wrong authentication when logging in.
2013-05-30 21:24:00 +02:00
spyOn(view, 'showErrorMessage').andCallThrough();
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
view.onChatRoomPresence(presence);
Fix tests after small markup change
2015-10-30 18:44:24 +01:00
expect(view.$el.find('.chatroom-body p:last').text()).toBe('You have been banned from this room');
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("will render a nickname form if a nickname conflict happens and muc_nickname_from_jid=false", mock.initConverse(function (converse) {
submitRoomForm(converse);
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
var presence = $pres().attrs({
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
from:'lounge@localhost/thirdwitch',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
id:'n13mt3l',
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
to:'dummy@localhost/pda',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
type:'error'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc'}).up()
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
.c('error').attrs({by:'lounge@localhost', type:'cancel'})
.c('conflict').attrs({xmlns:'urn:ietf:params:xml:ns:xmpp-stanzas'}).nodeTree;
var view = converse.chatboxviews.get('problematic@muc.localhost');
Refactored status message rendering code As a result we now implement more status codes from the spec. Specifically the codes related to forced removal form the room Also fixed a bug related to wrong authentication when logging in.
2013-05-30 21:24:00 +02:00
spyOn(view, 'showErrorMessage').andCallThrough();
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
view.onChatRoomPresence(presence);
expect(view.$el.find('.chatroom-body form.chatroom-form label:first').text()).toBe('Please choose your nickname');
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("will automatically choose a new nickname if a nickname conflict happens and muc_nickname_from_jid=true", mock.initConverse(function (converse) {
Fetch the room information before opening the room.
2016-12-05 07:03:44 +01:00
/* <presence
* from='coven@chat.shakespeare.lit/thirdwitch'
* id='n13mt3l'
* to='hag66@shakespeare.lit/pda'
* type='error'>
* <x xmlns='http://jabber.org/protocol/muc'/>
* <error by='coven@chat.shakespeare.lit' type='cancel'>
* <conflict xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
* </error>
* </presence>
*/
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
submitRoomForm(converse);
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
converse.muc_nickname_from_jid = true;
var attrs = {
from:'lounge@localhost/dummy',
id:'n13mt3l',
to:'dummy@localhost/pda',
type:'error'
};
var presence = $pres().attrs(attrs)
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc'}).up()
.c('error').attrs({by:'lounge@localhost', type:'cancel'})
.c('conflict').attrs({xmlns:'urn:ietf:params:xml:ns:xmpp-stanzas'}).nodeTree;
var view = converse.chatboxviews.get('problematic@muc.localhost');
spyOn(view, 'showErrorMessage').andCallThrough();
spyOn(view, 'join').andCallThrough();
// Simulate repeatedly that there's already someone in the room
// with that nickname
view.onChatRoomPresence(presence);
expect(view.join).toHaveBeenCalledWith('dummy-2');
attrs.from = 'lounge@localhost/dummy-2';
presence = $pres().attrs(attrs)
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc'}).up()
.c('error').attrs({by:'lounge@localhost', type:'cancel'})
.c('conflict').attrs({xmlns:'urn:ietf:params:xml:ns:xmpp-stanzas'}).nodeTree;
view.onChatRoomPresence(presence);
expect(view.join).toHaveBeenCalledWith('dummy-3');
attrs.from = 'lounge@localhost/dummy-3';
presence = $pres().attrs(attrs)
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc'}).up()
.c('error').attrs({by:'lounge@localhost', type:'cancel'})
.c('conflict').attrs({xmlns:'urn:ietf:params:xml:ns:xmpp-stanzas'}).nodeTree;
view.onChatRoomPresence(presence);
expect(view.join).toHaveBeenCalledWith('dummy-4');
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("will show an error message if the user is not allowed to have created the room", mock.initConverse(function (converse) {
submitRoomForm(converse);
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
var presence = $pres().attrs({
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
from:'lounge@localhost/thirdwitch',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
id:'n13mt3l',
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
to:'dummy@localhost/pda',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
type:'error'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc'}).up()
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
.c('error').attrs({by:'lounge@localhost', type:'cancel'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('not-allowed').attrs({xmlns:'urn:ietf:params:xml:ns:xmpp-stanzas'}).nodeTree;
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
var view = converse.chatboxviews.get('problematic@muc.localhost');
Refactored status message rendering code As a result we now implement more status codes from the spec. Specifically the codes related to forced removal form the room Also fixed a bug related to wrong authentication when logging in.
2013-05-30 21:24:00 +02:00
spyOn(view, 'showErrorMessage').andCallThrough();
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
view.onChatRoomPresence(presence);
Fix tests after small markup change
2015-10-30 18:44:24 +01:00
expect(view.$el.find('.chatroom-body p:last').text()).toBe('You are not allowed to create new rooms');
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("will show an error message if the user's nickname doesn't conform to room policy", mock.initConverse(function (converse) {
submitRoomForm(converse);
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
var presence = $pres().attrs({
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
from:'lounge@localhost/thirdwitch',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
id:'n13mt3l',
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
to:'dummy@localhost/pda',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
type:'error'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc'}).up()
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
.c('error').attrs({by:'lounge@localhost', type:'cancel'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('not-acceptable').attrs({xmlns:'urn:ietf:params:xml:ns:xmpp-stanzas'}).nodeTree;
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
var view = converse.chatboxviews.get('problematic@muc.localhost');
Refactored status message rendering code As a result we now implement more status codes from the spec. Specifically the codes related to forced removal form the room Also fixed a bug related to wrong authentication when logging in.
2013-05-30 21:24:00 +02:00
spyOn(view, 'showErrorMessage').andCallThrough();
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
view.onChatRoomPresence(presence);
Fix tests after small markup change
2015-10-30 18:44:24 +01:00
expect(view.$el.find('.chatroom-body p:last').text()).toBe("Your nickname doesn't conform to this room's policies");
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("will show an error message if the room doesn't yet exist", mock.initConverse(function (converse) {
submitRoomForm(converse);
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
var presence = $pres().attrs({
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
from:'lounge@localhost/thirdwitch',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
id:'n13mt3l',
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
to:'dummy@localhost/pda',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
type:'error'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc'}).up()
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
.c('error').attrs({by:'lounge@localhost', type:'cancel'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('item-not-found').attrs({xmlns:'urn:ietf:params:xml:ns:xmpp-stanzas'}).nodeTree;
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
var view = converse.chatboxviews.get('problematic@muc.localhost');
Refactored status message rendering code As a result we now implement more status codes from the spec. Specifically the codes related to forced removal form the room Also fixed a bug related to wrong authentication when logging in.
2013-05-30 21:24:00 +02:00
spyOn(view, 'showErrorMessage').andCallThrough();
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
view.onChatRoomPresence(presence);
Fix tests after small markup change
2015-10-30 18:44:24 +01:00
expect(view.$el.find('.chatroom-body p:last').text()).toBe("This room does not (yet) exist");
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
it("will show an error message if the room has reached its maximum number of occupants", mock.initConverse(function (converse) {
submitRoomForm(converse);
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
var presence = $pres().attrs({
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
from:'lounge@localhost/thirdwitch',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
id:'n13mt3l',
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
to:'dummy@localhost/pda',
Fixed some failing tests. Some of the tests were failing because they didn't expect the controlbox to be returned from localStorage. It's too long ago that I've looked at this branch for me to say whether this is a legitimate bug or not. Will have to investigate further.
2014-04-18 17:42:11 +02:00
type:'error'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('x').attrs({xmlns:'http://jabber.org/protocol/muc'}).up()
Refactor showing of chat room status messages. onChatRoomPresence and showStatusMessages have been refactored to give more detailed information and to also show the reasons given to actions taken by moderators.
2014-09-06 12:25:37 +02:00
.c('error').attrs({by:'lounge@localhost', type:'cancel'})
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
.c('service-unavailable').attrs({xmlns:'urn:ietf:params:xml:ns:xmpp-stanzas'}).nodeTree;
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
var view = converse.chatboxviews.get('problematic@muc.localhost');
Refactored status message rendering code As a result we now implement more status codes from the spec. Specifically the codes related to forced removal form the room Also fixed a bug related to wrong authentication when logging in.
2013-05-30 21:24:00 +02:00
spyOn(view, 'showErrorMessage').andCallThrough();
Add new config option `muc_nickname_from_jid` which if set to `true` will let converse.js automatically take the node part of a user's JID as their nickname when entering a room. If there is a nickname clash, then the nickname will be disambiguated by adding integers to it. For example, john will become john-1, then john-2 and so forth.
2016-08-11 14:00:52 +02:00
view.onChatRoomPresence(presence);
Fix grammar
2016-04-04 12:34:23 +02:00
expect(view.$el.find('.chatroom-body p:last').text()).toBe("This room has reached its maximum number of occupants");
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
}));
});
When inviting to a members-only room, first add to user to the member-list
2016-12-05 11:50:01 +01:00
describe("Someone being invited to a chat room", function () {
it("will first be added to the member list if the chat room is members only", mock.initConverse(function (converse) {
Refactor to send out 3 affiliation request stanzas. One for each affiliation (member, owner, admin). Unfortunately Prosody doesn't give you correct results if you query for all three affiliations in one stanza. We'll have to see whether setting all three in one stanza actually works.
2016-12-06 19:34:54 +01:00
var sent_IQs = [], IQ_ids = [];
When inviting to a members-only room, first add to user to the member-list
2016-12-05 11:50:01 +01:00
var sendIQ = converse.connection.sendIQ;
spyOn(converse.connection, 'sendIQ').andCallFake(function (iq, callback, errback) {
Refactor to send out 3 affiliation request stanzas. One for each affiliation (member, owner, admin). Unfortunately Prosody doesn't give you correct results if you query for all three affiliations in one stanza. We'll have to see whether setting all three in one stanza actually works.
2016-12-06 19:34:54 +01:00
sent_IQs.push(iq);
IQ_ids.push(sendIQ.bind(this)(iq, callback, errback));
When inviting to a members-only room, first add to user to the member-list
2016-12-05 11:50:01 +01:00
});
test_utils.openChatRoom(converse, 'coven', 'chat.shakespeare.lit', 'dummy');
// State that the chat is members-only via the features IQ
var features_stanza = $iq({
from: 'coven@chat.shakespeare.lit',
Refactor to send out 3 affiliation request stanzas. One for each affiliation (member, owner, admin). Unfortunately Prosody doesn't give you correct results if you query for all three affiliations in one stanza. We'll have to see whether setting all three in one stanza actually works.
2016-12-06 19:34:54 +01:00
'id': IQ_ids.pop(),
When inviting to a members-only room, first add to user to the member-list
2016-12-05 11:50:01 +01:00
'to': 'dummy@localhost/desktop',
'type': 'result'
})
.c('query', { 'xmlns': 'http://jabber.org/protocol/disco#info'})
.c('identity', {
'category': 'conference',
'name': 'A Dark Cave',
'type': 'text'
}).up()
.c('feature', {'var': 'http://jabber.org/protocol/muc'}).up()
.c('feature', {'var': 'muc_hidden'}).up()
.c('feature', {'var': 'muc_temporary'}).up()
.c('feature', {'var': 'muc_membersonly'}).up();
converse.connection._dataRecv(test_utils.createRequest(features_stanza));
var view = converse.chatboxviews.get('coven@chat.shakespeare.lit');
expect(view.model.get('membersonly')).toBeTruthy();
test_utils.createContacts(converse, 'current');
var sent_stanza,
sent_id;
spyOn(converse.connection, 'send').andCallFake(function (stanza) {
if (stanza.nodeTree && stanza.nodeTree.nodeName === 'message') {
sent_id = stanza.nodeTree.getAttribute('id');
sent_stanza = stanza;
}
});
var name = mock.cur_names[0];
var invitee_jid = name.replace(/ /g,'.').toLowerCase() + '@localhost';
var reason = "Please join this chat room";
view.directInvite(invitee_jid, reason);
Refactor to send out 3 affiliation request stanzas. One for each affiliation (member, owner, admin). Unfortunately Prosody doesn't give you correct results if you query for all three affiliations in one stanza. We'll have to see whether setting all three in one stanza actually works.
2016-12-06 19:34:54 +01:00
var admin_iq_id = IQ_ids.pop();
var owner_iq_id = IQ_ids.pop();
var member_iq_id = IQ_ids.pop();
// Check in reverse order that we requested all three lists
// (member, owner and admin).
expect(sent_IQs.pop().toLocaleString()).toBe(
"<iq to='coven@chat.shakespeare.lit' type='get' xmlns='jabber:client' id='"+admin_iq_id+"'>"+
"<query xmlns='http://jabber.org/protocol/muc#admin'>"+
"<item affiliation='admin'/>"+
"</query>"+
"</iq>");
expect(sent_IQs.pop().toLocaleString()).toBe(
"<iq to='coven@chat.shakespeare.lit' type='get' xmlns='jabber:client' id='"+owner_iq_id+"'>"+
"<query xmlns='http://jabber.org/protocol/muc#admin'>"+
"<item affiliation='owner'/>"+
"</query>"+
"</iq>");
expect(sent_IQs.pop().toLocaleString()).toBe(
"<iq to='coven@chat.shakespeare.lit' type='get' xmlns='jabber:client' id='"+member_iq_id+"'>"+
converse-muc: Only send the delta when setting the member list. As required by XEP-0045. This requires that we first fetch the existing member list, compute the delta and then send that if there is one.
2016-12-06 16:18:33 +01:00
"<query xmlns='http://jabber.org/protocol/muc#admin'>"+
"<item affiliation='member'/>"+
"</query>"+
"</iq>");
/* Now the service sends the member list to the user
*
* <iq from='coven@chat.shakespeare.lit'
* id='member3'
* to='crone1@shakespeare.lit/desktop'
* type='result'>
* <query xmlns='http://jabber.org/protocol/muc#admin'>
* <item affiliation='member'
* jid='hag66@shakespeare.lit'
* nick='thirdwitch'
* role='participant'/>
* </query>
* </iq>
*/
var member_list_stanza = $iq({
'from': 'coven@chat.shakespeare.lit',
Refactor to send out 3 affiliation request stanzas. One for each affiliation (member, owner, admin). Unfortunately Prosody doesn't give you correct results if you query for all three affiliations in one stanza. We'll have to see whether setting all three in one stanza actually works.
2016-12-06 19:34:54 +01:00
'id': member_iq_id,
converse-muc: Only send the delta when setting the member list. As required by XEP-0045. This requires that we first fetch the existing member list, compute the delta and then send that if there is one.
2016-12-06 16:18:33 +01:00
'to': 'dummy@localhost/resource',
'type': 'result'
}).c('query', {'xmlns': Strophe.NS.MUC_ADMIN})
.c('item', {
'affiliation': 'member',
'jid': 'hag66@shakespeare.lit',
'nick': 'thirdwitch',
'role': 'participant'
});
converse.connection._dataRecv(test_utils.createRequest(member_list_stanza));
Refactor to send out 3 affiliation request stanzas. One for each affiliation (member, owner, admin). Unfortunately Prosody doesn't give you correct results if you query for all three affiliations in one stanza. We'll have to see whether setting all three in one stanza actually works.
2016-12-06 19:34:54 +01:00
var admin_list_stanza = $iq({
'from': 'coven@chat.shakespeare.lit',
'id': admin_iq_id,
'to': 'dummy@localhost/resource',
'type': 'result'
}).c('query', {'xmlns': Strophe.NS.MUC_ADMIN})
.c('item', {
'affiliation': 'admin',
'jid': 'wiccarocks@shakespeare.lit',
'nick': 'secondwitch'
});
converse.connection._dataRecv(test_utils.createRequest(admin_list_stanza));
var owner_list_stanza = $iq({
'from': 'coven@chat.shakespeare.lit',
'id': owner_iq_id,
'to': 'dummy@localhost/resource',
'type': 'result'
}).c('query', {'xmlns': Strophe.NS.MUC_ADMIN})
.c('item', {
'affiliation': 'owner',
'jid': 'crone1@shakespeare.lit',
});
converse.connection._dataRecv(test_utils.createRequest(owner_list_stanza));
converse-muc: Only send the delta when setting the member list. As required by XEP-0045. This requires that we first fetch the existing member list, compute the delta and then send that if there is one.
2016-12-06 16:18:33 +01:00
// Check that the member list now gets updated
Refactor to send out 3 affiliation request stanzas. One for each affiliation (member, owner, admin). Unfortunately Prosody doesn't give you correct results if you query for all three affiliations in one stanza. We'll have to see whether setting all three in one stanza actually works.
2016-12-06 19:34:54 +01:00
expect(sent_IQs.pop().toLocaleString()).toBe(
"<iq to='coven@chat.shakespeare.lit' type='set' xmlns='jabber:client' id='"+IQ_ids.pop()+"'>"+
When inviting to a members-only room, first add to user to the member-list
2016-12-05 11:50:01 +01:00
"<query xmlns='http://jabber.org/protocol/muc#admin'>"+
Specify the reason (if given) when setting someone's affiliation This changed required me to go back to an array of maps instead of a single map to store jids and affiliations.
2016-12-07 12:30:28 +01:00
"<item affiliation='member' jid='"+invitee_jid+"'>"+
"<reason>Please join this chat room</reason>"+
"</item>"+
When inviting to a members-only room, first add to user to the member-list
2016-12-05 11:50:01 +01:00
"</query>"+
"</iq>");
converse-muc: Only send the delta when setting the member list. As required by XEP-0045. This requires that we first fetch the existing member list, compute the delta and then send that if there is one.
2016-12-06 16:18:33 +01:00
// Finally check that the user gets invited.
When inviting to a members-only room, first add to user to the member-list
2016-12-05 11:50:01 +01:00
expect(sent_stanza.toLocaleString()).toBe( // Strophe adds the xmlns attr (although not in spec)
"<message from='dummy@localhost/resource' to='"+invitee_jid+"' id='"+sent_id+"' xmlns='jabber:client'>"+
"<x xmlns='jabber:x:conference' jid='coven@chat.shakespeare.lit' reason='Please join this chat room'/>"+
"</message>"
);
}));
});
Add unit tests for how the affiliations delta is computed.
2016-12-08 13:44:18 +01:00
describe("The affiliations delta", function () {
it("can be computed in various ways", mock.initConverse(function (converse) {
test_utils.openChatRoom(converse, 'coven', 'chat.shakespeare.lit', 'dummy');
var roomview = converse.chatboxviews.get('coven@chat.shakespeare.lit');
var exclude_existing = false;
var remove_absentees = false;
var new_list = [];
var old_list = [];
var delta = roomview.computeAffiliationsDelta(exclude_existing, remove_absentees, new_list, old_list);
expect(delta.length).toBe(0);
new_list = [{'jid': 'wiccarocks@shakespeare.lit', 'affiliation': 'member'}];
old_list = [{'jid': 'wiccarocks@shakespeare.lit', 'affiliation': 'member'}];
delta = roomview.computeAffiliationsDelta(exclude_existing, remove_absentees, new_list, old_list);
expect(delta.length).toBe(0);
// When remove_absentees is false, then affiliations in the old
// list which are not in the new one won't be removed.
old_list = [{'jid': 'oldhag666@shakespeare.lit', 'affiliation': 'owner'},
{'jid': 'wiccarocks@shakespeare.lit', 'affiliation': 'member'}];
delta = roomview.computeAffiliationsDelta(exclude_existing, remove_absentees, new_list, old_list);
expect(delta.length).toBe(0);
// With exclude_existing set to false, any changed affiliations
// will be included in the delta (i.e. existing affiliations
// are included in the comparison).
old_list = [{'jid': 'wiccarocks@shakespeare.lit', 'affiliation': 'owner'}];
delta = roomview.computeAffiliationsDelta(exclude_existing, remove_absentees, new_list, old_list);
expect(delta.length).toBe(1);
expect(delta[0].jid).toBe('wiccarocks@shakespeare.lit');
expect(delta[0].affiliation).toBe('member');
// To also remove affiliations from the old list which are not
// in the new list, we set remove_absentees to true
remove_absentees = true;
old_list = [{'jid': 'oldhag666@shakespeare.lit', 'affiliation': 'owner'},
{'jid': 'wiccarocks@shakespeare.lit', 'affiliation': 'member'}];
delta = roomview.computeAffiliationsDelta(exclude_existing, remove_absentees, new_list, old_list);
expect(delta.length).toBe(1);
expect(delta[0].jid).toBe('oldhag666@shakespeare.lit');
expect(delta[0].affiliation).toBe('none');
delta = roomview.computeAffiliationsDelta(exclude_existing, remove_absentees, [], old_list);
expect(delta.length).toBe(2);
expect(delta[0].jid).toBe('oldhag666@shakespeare.lit');
expect(delta[0].affiliation).toBe('none');
expect(delta[1].jid).toBe('wiccarocks@shakespeare.lit');
expect(delta[1].affiliation).toBe('none');
// To only add a user if they don't already have an
// affiliation, we set 'exclude_existing' to true
exclude_existing = true;
old_list = [{'jid': 'wiccarocks@shakespeare.lit', 'affiliation': 'owner'}];
delta = roomview.computeAffiliationsDelta(exclude_existing, remove_absentees, new_list, old_list);
expect(delta.length).toBe(0);
}));
});
All tests suites now updated and isolated.
2016-11-03 11:01:09 +01:00
});
Split ChatRooms tests out into their own spec file
2013-05-11 14:20:07 +02:00
}));
Reference in New Issue Copy Permalink