Fix eslint warnings

Signed-off-by: Thomas Citharel <tcit@tcit.fr>

js/.eslintrc.js

@@ -48,6 +48,8 @@ module.exports = {
     "import/prefer-default-export": "off",
     "import/extensions": "off",
     "import/no-unresolved": "off",
+    "no-shadow": "off",
+    "@typescript-eslint/no-shadow": ["error"],
   },
 
   ignorePatterns: ["src/typings/*.d.ts", "vue.config.js"],

js/src/@types/dom.d.ts

@@ -0,0 +1,18 @@
+declare global {
+  interface GeolocationCoordinates {
+    readonly accuracy: number;
+    readonly altitude: number | null;
+    readonly altitudeAccuracy: number | null;
+    readonly heading: number | null;
+    readonly latitude: number;
+    readonly longitude: number;
+    readonly speed: number | null;
+  }
+
+  interface GeolocationPosition {
+    readonly coords: GeolocationCoordinates;
+    readonly timestamp: number;
+  }
+}
+
+export {};

js/src/apollo/user.ts

@@ -1,8 +1,11 @@
+import { ICurrentUserRole } from "@/types/enums";
 import { ApolloCache } from "apollo-cache";
 import { NormalizedCacheObject } from "apollo-cache-inmemory";
-import { ICurrentUserRole } from "@/types/current-user.model";
+import { Resolvers } from "apollo-client/core/types";
 
-export default function buildCurrentUserResolver(cache: ApolloCache<NormalizedCacheObject>) {
+export default function buildCurrentUserResolver(
+  cache: ApolloCache<NormalizedCacheObject>
+): Resolvers {
   cache.writeData({
     data: {
       currentUser: {

js/src/components/Account/Identities.vue

@@ -53,7 +53,7 @@ export default class Identities extends Vue {
 
   errors: string[] = [];
 
-  isCurrentIdentity(identity: IPerson) {
+  isCurrentIdentity(identity: IPerson): boolean {
     return identity.preferredUsername === this.currentIdentityName;
   }
 }

js/src/components/Account/ParticipantCard.vue

@@ -1,94 +0,0 @@
-<docs>
-```vue
-<participant-card :participant="{ actor: { preferredUsername: 'user1', name: 'someoneIDontLike' }, role: 'REJECTED' }" />
-```
-
-```vue
-<participant-card :participant="{ actor: { preferredUsername: 'user2', name: 'someoneWhoWillWait' }, role: 'NOT_APPROVED' }" />
-```
-
-```vue
-<participant-card :participant="{ actor: { preferredUsername: 'user3', name: 'a_participant' }, role: 'PARTICIPANT' }" />
-```
-
-```vue
-<participant-card :participant="{ actor: { preferredUsername: 'me', name: 'myself' }, role: 'CREATOR' }" />
-```
-</docs>
-<template>
-  <article class="card">
-    <div class="card-content">
-      <div class="media">
-        <div class="media-left" v-if="participant.actor.avatar">
-          <figure class="image is-48x48">
-            <img :src="participant.actor.avatar.url" />
-          </figure>
-        </div>
-        <div class="media-content">
-          <span ref="title">{{ actorDisplayName }}</span
-          ><br />
-          <small class="has-text-grey" v-if="participant.actor.domain"
-            >@{{ participant.actor.preferredUsername }}@{{ participant.actor.domain }}</small
-          >
-          <small class="has-text-grey" v-else>@{{ participant.actor.preferredUsername }}</small>
-        </div>
-      </div>
-    </div>
-    <footer class="card-footer">
-      <b-button
-        v-if="[ParticipantRole.NOT_APPROVED, ParticipantRole.REJECTED].includes(participant.role)"
-        @click="accept(participant)"
-        type="is-success"
-        class="card-footer-item"
-        >{{ $t("Approve") }}</b-button
-      >
-      <b-button
-        v-if="participant.role === ParticipantRole.NOT_APPROVED"
-        @click="reject(participant)"
-        type="is-danger"
-        class="card-footer-item"
-        >{{ $t("Reject") }}</b-button
-      >
-      <b-button
-        v-if="participant.role === ParticipantRole.PARTICIPANT"
-        @click="exclude(participant)"
-        type="is-danger"
-        class="card-footer-item"
-        >{{ $t("Exclude") }}</b-button
-      >
-      <span v-if="participant.role === ParticipantRole.CREATOR" class="card-footer-item">{{
-        $t("Creator")
-      }}</span>
-    </footer>
-  </article>
-</template>
-
-<script lang="ts">
-import { Component, Prop, Vue } from "vue-property-decorator";
-import { IParticipant, ParticipantRole } from "../../types/participant.model";
-import { IPerson, Person } from "../../types/actor";
-
-@Component
-export default class ParticipantCard extends Vue {
-  @Prop({ required: true }) participant!: IParticipant;
-
-  @Prop({ type: Function }) accept!: Function;
-
-  @Prop({ type: Function }) reject!: Function;
-
-  @Prop({ type: Function }) exclude!: Function;
-
-  ParticipantRole = ParticipantRole;
-
-  get actorDisplayName(): string {
-    const actor = new Person(this.participant.actor as IPerson);
-    return actor.displayName();
-  }
-}
-</script>
-
-<style lang="scss">
-.card-footer-item {
-  height: $control-height;
-}
-</style>

js/src/components/Account/PopoverActorCard.vue

@@ -12,8 +12,9 @@
   </v-popover>
 </template>
 <script lang="ts">
+import { ActorType } from "@/types/enums";
 import { Component, Vue, Prop } from "vue-property-decorator";
-import { IActor, ActorType } from "../../types/actor";
+import { IActor } from "../../types/actor";
 import ActorCard from "./ActorCard.vue";
 
 @Component({

js/src/components/Admin/Followings.vue

@@ -103,7 +103,6 @@ import { SnackbarProgrammatic as Snackbar } from "buefy";
 import { formatDistanceToNow } from "date-fns";
 import { ADD_RELAY, REMOVE_RELAY } from "../../graphql/admin";
 import { IFollower } from "../../types/actor/follower.model";
-import { Paginate } from "../../types/paginate";
 import RelayMixin from "../../mixins/relay";
 
 @Component({

js/src/components/Comment/Comment.vue

@@ -137,7 +137,7 @@ import { Component, Prop, Vue, Ref } from "vue-property-decorator";
 import EditorComponent from "@/components/Editor.vue";
 import { SnackbarProgrammatic as Snackbar } from "buefy";
 import { formatDistanceToNow } from "date-fns";
-import { CommentModeration } from "../../types/event-options.model";
+import { CommentModeration } from "@/types/enums";
 import { CommentModel, IComment } from "../../types/comment.model";
 import { CURRENT_ACTOR_CLIENT } from "../../graphql/actor";
 import { IPerson, usernameWithDomain } from "../../types/actor";

js/src/components/Comment/CommentTree.vue

@@ -51,7 +51,7 @@
 import { Prop, Vue, Component, Watch } from "vue-property-decorator";
 import Comment from "@/components/Comment/Comment.vue";
 import IdentityPickerWrapper from "@/views/Account/IdentityPickerWrapper.vue";
-import { CommentModeration } from "../../types/event-options.model";
+import { CommentModeration } from "@/types/enums";
 import { CommentModel, IComment } from "../../types/comment.model";
 import {
   CREATE_COMMENT_FROM_EVENT,

js/src/components/Editor.vue

@@ -395,15 +395,7 @@ export default class EditorComponent extends Vue {
         new Image(),
         new MaxSize({ maxSize: this.maxSize }),
       ],
-      onUpdate: ({
-        getHTML,
-        transaction,
-        getJSON,
-      }: {
-        getHTML: Function;
-        getJSON: Function;
-        transaction: unknown;
-      }) => {
+      onUpdate: ({ getHTML }: { getHTML: Function }) => {
         this.$emit("input", getHTML());
       },
     });

js/src/components/Editor/MaxSize.ts

@@ -1,11 +1,14 @@
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-nocheck
 import { Extension, Plugin } from "tiptap";
 
 export default class MaxSize extends Extension {
+  // eslint-disable-next-line class-methods-use-this
   get name() {
     return "maxSize";
   }
 
+  // eslint-disable-next-line class-methods-use-this
   get defaultOptions() {
     return {
       maxSize: null,
@@ -21,7 +24,7 @@ export default class MaxSize extends Extension {
           const newLength = newState.doc.content.size;
 
           if (newLength > max && newLength > oldLength) {
-            let newTr = newState.tr;
+            const newTr = newState.tr;
             newTr.insertText("", max + 1, newLength);
 
             return newTr;

js/src/components/Event/AddressAutoComplete.vue

@@ -50,7 +50,7 @@
 <script lang="ts">
 import { Component, Prop, Vue, Watch } from "vue-property-decorator";
 import { LatLng } from "leaflet";
-import { debounce } from "lodash";
+import { debounce, DebouncedFunc } from "lodash";
 import { Address, IAddress } from "../../types/address.model";
 import { ADDRESS, REVERSE_GEOCODE } from "../../graphql/address";
 import { CONFIG } from "../../graphql/config";
@@ -81,7 +81,7 @@ export default class AddressAutoComplete extends Vue {
 
   private gettingLocation = false;
 
-  private location!: Position;
+  private location!: GeolocationPosition;
 
   private gettingLocationError: any;
 
@@ -89,7 +89,7 @@ export default class AddressAutoComplete extends Vue {
 
   config!: IConfig;
 
-  fetchAsyncData!: Function;
+  fetchAsyncData!: DebouncedFunc<(query: string) => Promise<void>>;
 
   // We put this in data because of issues like
   // https://github.com/vuejs/vue-class-component/issues/263
@@ -207,7 +207,7 @@ export default class AddressAutoComplete extends Vue {
     this.gettingLocation = false;
   }
 
-  static async getLocation(): Promise<Position> {
+  static async getLocation(): Promise<GeolocationPosition> {
     return new Promise((resolve, reject) => {
       if (!("geolocation" in navigator)) {
         reject(new Error("Geolocation is not available."));

js/src/components/Event/EventCard.vue

@@ -77,7 +77,7 @@ import { IEvent, IEventCardOptions } from "@/types/event.model";
 import { Component, Prop, Vue } from "vue-property-decorator";
 import DateCalendarIcon from "@/components/Event/DateCalendarIcon.vue";
 import { Actor, Person } from "@/types/actor";
-import { ParticipantRole } from "../../types/participant.model";
+import { ParticipantRole } from "@/types/enums";
 import RouteName from "../../router/name";
 
 @Component({

js/src/components/Event/EventListCard.vue

@@ -187,8 +187,9 @@ import { Component, Prop } from "vue-property-decorator";
 import DateCalendarIcon from "@/components/Event/DateCalendarIcon.vue";
 import { mixins } from "vue-class-component";
 import { RawLocation, Route } from "vue-router";
-import { IParticipant, ParticipantRole } from "../../types/participant.model";
-import { EventVisibility, IEventCardOptions } from "../../types/event.model";
+import { EventVisibility, ParticipantRole } from "@/types/enums";
+import { IParticipant } from "../../types/participant.model";
+import { IEventCardOptions } from "../../types/event.model";
 import { IPerson } from "../../types/actor";
 import ActorMixin from "../../mixins/actor";
 import { CURRENT_ACTOR_CLIENT } from "../../graphql/actor";

js/src/components/Event/EventListViewCard.vue

@@ -51,7 +51,7 @@
 </template>
 
 <script lang="ts">
-import { EventVisibility, IEventCardOptions, IEvent } from "@/types/event.model";
+import { IEventCardOptions, IEvent } from "@/types/event.model";
 import { Component, Prop } from "vue-property-decorator";
 import DateCalendarIcon from "@/components/Event/DateCalendarIcon.vue";
 import { IPerson, usernameWithDomain } from "@/types/actor";
@@ -59,7 +59,7 @@ import { mixins } from "vue-class-component";
 import ActorMixin from "@/mixins/actor";
 import { CURRENT_ACTOR_CLIENT } from "@/graphql/actor";
 import EventMixin from "@/mixins/event";
-import { ParticipantRole } from "../../types/participant.model";
+import { EventVisibility, ParticipantRole } from "@/types/enums";
 import RouteName from "../../router/name";
 
 const defaultOptions: IEventCardOptions = {

js/src/components/Event/EventMinimalistCard.vue

@@ -56,7 +56,7 @@
 import { Component, Prop, Vue } from "vue-property-decorator";
 import { IEvent } from "@/types/event.model";
 import DateCalendarIcon from "@/components/Event/DateCalendarIcon.vue";
-import { ParticipantRole } from "../../types/participant.model";
+import { ParticipantRole } from "@/types/enums";
 import RouteName from "../../router/name";
 
 @Component({

js/src/components/Event/FullAddressAutoComplete.vue

@@ -102,7 +102,7 @@
 <script lang="ts">
 import { Component, Prop, Vue, Watch } from "vue-property-decorator";
 import { LatLng } from "leaflet";
-import { debounce } from "lodash";
+import { debounce, DebouncedFunc } from "lodash";
 import { Address, IAddress } from "../../types/address.model";
 import { ADDRESS, REVERSE_GEOCODE } from "../../graphql/address";
 import { CONFIG } from "../../graphql/config";
@@ -133,7 +133,7 @@ export default class FullAddressAutoComplete extends Vue {
 
   private gettingLocation = false;
 
-  private location!: Position;
+  private location!: GeolocationPosition;
 
   private gettingLocationError: any;
 
@@ -141,11 +141,11 @@ export default class FullAddressAutoComplete extends Vue {
 
   config!: IConfig;
 
-  fetchAsyncData!: Function;
+  fetchAsyncData!: DebouncedFunc<(query: string) => Promise<void>>;
 
   // We put this in data because of issues like
   // https://github.com/vuejs/vue-class-component/issues/263
-  data() {
+  data(): Record<string, unknown> {
     return {
       fetchAsyncData: debounce(this.asyncData, 200),
     };
@@ -266,7 +266,7 @@ export default class FullAddressAutoComplete extends Vue {
     return window.isSecureContext;
   }
 
-  static async getLocation(): Promise<Position> {
+  static async getLocation(): Promise<GeolocationPosition> {
     return new Promise((resolve, reject) => {
       if (!("geolocation" in navigator)) {
         reject(new Error("Geolocation is not available."));

js/src/components/Event/OrganizerPicker.vue

@@ -23,9 +23,11 @@
 </template>
 <script lang="ts">
 import { Component, Prop, Vue, Watch } from "vue-property-decorator";
-import { IMember, IPerson, MemberRole, IActor, Actor } from "@/types/actor";
+import { IPerson, IActor, Actor } from "@/types/actor";
 import { PERSON_MEMBERSHIPS } from "@/graphql/actor";
 import { Paginate } from "@/types/paginate";
+import { IMember } from "@/types/actor/member.model";
+import { MemberRole } from "@/types/enums";
 
 @Component({
   apollo: {

js/src/components/Event/OrganizerPickerWrapper.vue

@@ -115,7 +115,8 @@
 </template>
 <script lang="ts">
 import { Component, Prop, Vue, Watch } from "vue-property-decorator";
-import { IActor, IGroup, IMember, IPerson } from "../../types/actor";
+import { IMember } from "@/types/actor/member.model";
+import { IActor, IGroup, IPerson } from "../../types/actor";
 import OrganizerPicker from "./OrganizerPicker.vue";
 import { PERSON_MEMBERSHIPS_WITH_MEMBERS } from "../../graphql/actor";
 import { Paginate } from "../../types/paginate";
@@ -182,7 +183,7 @@ export default class OrganizerPickerWrapper extends Vue {
       ({ parent: { id } }) => id === this.currentActor.id
     );
     if (currentMembership) {
-      return currentMembership.parent.members.elements.map(({ actor }) => actor);
+      return currentMembership.parent.members.elements.map(({ actor }: { actor: IActor }) => actor);
     }
     return [];
   }

js/src/components/Event/ParticipationButton.vue

@@ -142,8 +142,9 @@ A button to set your participation
 
 <script lang="ts">
 import { Component, Prop, Vue } from "vue-property-decorator";
-import { IParticipant, ParticipantRole } from "../../types/participant.model";
-import { EventJoinOptions, IEvent } from "../../types/event.model";
+import { EventJoinOptions, ParticipantRole } from "@/types/enums";
+import { IParticipant } from "../../types/participant.model";
+import { IEvent } from "../../types/event.model";
 import { IPerson, Person } from "../../types/actor";
 import { CURRENT_ACTOR_CLIENT, IDENTITIES } from "../../graphql/actor";
 import { CURRENT_USER_CLIENT } from "../../graphql/user";

js/src/components/Event/ShareEventModal.vue

@@ -76,7 +76,9 @@
 
 <script lang="ts">
 import { Component, Prop, Vue, Ref } from "vue-property-decorator";
-import { IEvent, EventVisibility, EventStatus } from "../../types/event.model";
+import { EventStatus, EventVisibility } from "@/types/enums";
+import { IEvent } from "../../types/event.model";
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 import DiasporaLogo from "../../assets/diaspora-icon.svg?inline";
 
@@ -124,7 +126,7 @@ export default class ShareEventModal extends Vue {
     )}&url=${encodeURIComponent(this.event.url)}`;
   }
 
-  copyURL() {
+  copyURL(): void {
     this.eventURLInput.$refs.input.select();
     document.execCommand("copy");
     this.showCopiedTooltip = true;

js/src/components/Event/TagInput.vue

@@ -40,7 +40,6 @@ import { ITag } from "../../types/tag.model";
           if (typeof tag !== "string") {
             return tag;
           }
-          // @ts-ignore
           return { title: tag, slug: tag } as ITag;
         });
         this.$emit("input", tagEntities);
@@ -57,14 +56,10 @@ export default class TagInput extends Vue {
 
   filteredTags: ITag[] = [];
 
-  getFilteredTags(text: string) {
+  getFilteredTags(text: string): void {
     this.filteredTags = differenceBy(this.data, this.value, "id").filter(
       (option) => get(option, this.path).toString().toLowerCase().indexOf(text.toLowerCase()) >= 0
     );
   }
-
-  static isTag(x: any): x is ITag {
-    return x.slug !== undefined;
-  }
 }
 </script>

js/src/components/Group/GroupMemberCard.vue

@@ -54,7 +54,9 @@
 
 <script lang="ts">
 import { Component, Prop, Vue } from "vue-property-decorator";
-import { IMember, MemberRole, usernameWithDomain } from "@/types/actor";
+import { usernameWithDomain } from "@/types/actor";
+import { IMember } from "@/types/actor/member.model";
+import { MemberRole } from "@/types/enums";
 import RouteName from "../../router/name";
 
 @Component

js/src/components/Group/GroupPicker.vue

@@ -36,9 +36,11 @@
 </template>
 <script lang="ts">
 import { Component, Prop, Vue } from "vue-property-decorator";
-import { IGroup, IMember, IPerson, Group, MemberRole } from "@/types/actor";
+import { IGroup, IPerson, Group } from "@/types/actor";
 import { PERSON_MEMBERSHIPS } from "@/graphql/actor";
 import { Paginate } from "@/types/paginate";
+import { IMember } from "@/types/actor/member.model";
+import { MemberRole } from "@/types/enums";
 
 @Component({
   apollo: {

js/src/components/Group/GroupPickerWrapper.vue

@@ -61,7 +61,8 @@
 </template>
 <script lang="ts">
 import { Component, Prop, Vue, Watch } from "vue-property-decorator";
-import { IGroup, IMember, IPerson } from "../../types/actor";
+import { IMember } from "@/types/actor/member.model";
+import { IGroup, IPerson } from "../../types/actor";
 import GroupPicker from "./GroupPicker.vue";
 import { PERSON_MEMBERSHIPS } from "../../graphql/actor";
 import { Paginate } from "../../types/paginate";

js/src/components/Group/InvitationCard.vue

@@ -54,7 +54,8 @@
 
 <script lang="ts">
 import { Component, Prop, Vue } from "vue-property-decorator";
-import { IMember, usernameWithDomain } from "@/types/actor";
+import { usernameWithDomain } from "@/types/actor";
+import { IMember } from "@/types/actor/member.model";
 import RouteName from "../../router/name";
 
 @Component

js/src/components/Group/Invitations.vue

@@ -11,10 +11,10 @@
 </template>
 <script lang="ts">
 import { ACCEPT_INVITATION, REJECT_INVITATION } from "@/graphql/member";
-import { IMember } from "@/types/actor";
 import { Component, Prop, Vue } from "vue-property-decorator";
 import InvitationCard from "@/components/Group/InvitationCard.vue";
 import { LOGGED_USER_MEMBERSHIPS } from "@/graphql/actor";
+import { IMember } from "@/types/actor/member.model";
 
 @Component({
   components: {

js/src/components/Map.vue

@@ -53,10 +53,10 @@ export default class Map extends Vue {
 
   @Prop({ type: Object, required: false }) marker!: { text: string | string[]; icon: string };
 
-  @Prop({ type: Object, required: false }) options!: object;
+  @Prop({ type: Object, required: false }) options!: Record<string, unknown>;
 
   @Prop({ type: Function, required: false })
-  updateDraggableMarkerCallback!: Function;
+  updateDraggableMarkerCallback!: (latlng: LatLng, zoom: number) => void;
 
   defaultOptions: {
     zoom: number;
@@ -86,45 +86,47 @@ export default class Map extends Vue {
   }
   /* eslint-enable */
 
-  openPopup(event: LeafletEvent) {
+  openPopup(event: LeafletEvent): void {
     this.$nextTick(() => {
       event.target.openPopup();
     });
   }
 
-  get mergedOptions(): object {
+  get mergedOptions(): Record<string, unknown> {
     return { ...this.defaultOptions, ...this.options };
   }
 
-  get lat() {
+  get lat(): number {
     return this.$props.coords.split(";")[1];
   }
 
-  get lon() {
+  get lon(): number {
     return this.$props.coords.split(";")[0];
   }
 
-  get popupMultiLine() {
+  get popupMultiLine(): Array<string> {
     if (Array.isArray(this.marker.text)) {
       return this.marker.text;
     }
     return [this.marker.text];
   }
 
-  clickMap(event: LeafletMouseEvent) {
+  clickMap(event: LeafletMouseEvent): void {
     this.updateDraggableMarkerPosition(event.latlng);
   }
 
-  updateDraggableMarkerPosition(e: LatLng) {
+  updateDraggableMarkerPosition(e: LatLng): void {
     this.updateDraggableMarkerCallback(e, this.zoom);
   }
 
-  updateZoom(zoom: number) {
+  updateZoom(zoom: number): void {
     this.zoom = zoom;
   }
 
-  get attribution() {
-    return this.config.maps.tiles.attribution || this.$t("© The OpenStreetMap Contributors");
+  get attribution(): string {
+    return (
+      this.config.maps.tiles.attribution || (this.$t("© The OpenStreetMap Contributors") as string)
+    );
   }
 }
 </script>

js/src/components/Map/Vue2LeafletLocateControl.vue

@@ -17,13 +17,13 @@ import { Component, Prop, Vue } from "vue-property-decorator";
 
 @Component({
   beforeDestroy() {
-    // eslint-disable-next-line @typescript-eslint/ban-ts-ignore
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore
     this.parentContainer.removeLayer(this);
   },
 })
 export default class Vue2LeafletLocateControl extends Vue {
-  @Prop({ type: Object, default: () => ({}) }) options!: object;
+  @Prop({ type: Object, default: () => ({}) }) options!: Record<string, unknown>;
 
   @Prop({ type: Boolean, default: true }) visible = true;
 
@@ -33,7 +33,7 @@ export default class Vue2LeafletLocateControl extends Vue {
 
   parentContainer: any;
 
-  mounted() {
+  mounted(): void {
     this.mapObject = L.control.locate(this.options);
     DomEvent.on(this.mapObject, this.$listeners as any);
     propsBinder(this, this.mapObject, this.$props);
@@ -42,7 +42,7 @@ export default class Vue2LeafletLocateControl extends Vue {
     this.mapObject.addTo(this.parentContainer.mapObject, !this.visible);
   }
 
-  public locate() {
+  public locate(): void {
     this.mapObject.start();
   }
 }

js/src/components/NavBar.vue

@@ -109,13 +109,14 @@ import { Component, Vue, Watch } from "vue-property-decorator";
 import Logo from "@/components/Logo.vue";
 import { GraphQLError } from "graphql";
 import { loadLanguageAsync } from "@/utils/i18n";
+import { ICurrentUserRole } from "@/types/enums";
 import { CURRENT_USER_CLIENT, USER_SETTINGS } from "../graphql/user";
 import { changeIdentity, logout } from "../utils/auth";
 import { CURRENT_ACTOR_CLIENT, IDENTITIES, UPDATE_DEFAULT_ACTOR } from "../graphql/actor";
 import { IPerson, Person } from "../types/actor";
 import { CONFIG } from "../graphql/config";
 import { IConfig } from "../types/config.model";
-import { ICurrentUser, ICurrentUserRole, IUser } from "../types/current-user.model";
+import { ICurrentUser, IUser } from "../types/current-user.model";
 import SearchField from "./SearchField.vue";
 import RouteName from "../router/name";
 

js/src/components/Participation/ConfirmParticipation.vue

@@ -38,9 +38,9 @@
 <script lang="ts">
 import { Component, Prop, Vue } from "vue-property-decorator";
 import { confirmLocalAnonymousParticipation } from "@/services/AnonymousParticipationStorage";
+import { EventJoinOptions } from "@/types/enums";
 import { IParticipant } from "../../types/participant.model";
 import RouteName from "../../router/name";
-import { EventJoinOptions } from "../../types/event.model";
 import { CONFIRM_PARTICIPATION } from "../../graphql/event";
 
 @Component

js/src/components/Participation/ParticipationWithoutAccount.vue

@@ -74,12 +74,13 @@
 </template>
 <script lang="ts">
 import { Component, Prop, Vue } from "vue-property-decorator";
-import { EventModel, IEvent, EventJoinOptions } from "@/types/event.model";
+import { EventModel, IEvent } from "@/types/event.model";
 import { FETCH_EVENT, JOIN_EVENT } from "@/graphql/event";
 import { IConfig } from "@/types/config.model";
 import { CONFIG } from "@/graphql/config";
 import { addLocalUnconfirmedAnonymousParticipation } from "@/services/AnonymousParticipationStorage";
-import { IParticipant, ParticipantRole } from "../../types/participant.model";
+import { EventJoinOptions, ParticipantRole } from "@/types/enums";
+import { IParticipant } from "../../types/participant.model";
 
 @Component({
   apollo: {

js/src/components/Post/PostElementItem.vue

@@ -43,9 +43,10 @@
 </template>
 <script lang="ts">
 import { usernameWithDomain } from "@/types/actor";
+import { PostVisibility } from "@/types/enums";
 import { Component, Prop, Vue } from "vue-property-decorator";
 import RouteName from "../../router/name";
-import { IPost, PostVisibility } from "../../types/post.model";
+import { IPost } from "../../types/post.model";
 
 @Component
 export default class PostElementItem extends Vue {

js/src/components/Report/ReportCard.vue

@@ -36,7 +36,7 @@
 <script lang="ts">
 import { Component, Prop, Vue } from "vue-property-decorator";
 import { IReport } from "@/types/report.model";
-import { ActorType } from "@/types/actor";
+import { ActorType } from "@/types/enums";
 
 @Component
 export default class ReportCard extends Vue {

js/src/components/Report/ReportModal.vue

@@ -82,7 +82,7 @@ import { IComment } from "../../types/comment.model";
   },
 })
 export default class ReportModal extends Vue {
-  @Prop({ type: Function }) onConfirm!: Function;
+  @Prop({ type: Function }) onConfirm!: (content: string, forward: boolean) => void;
 
   @Prop({ type: String }) title!: string;
 

js/src/components/Resource/ResourceDropdown.vue

@@ -17,7 +17,7 @@
   </b-dropdown>
 </template>
 <script lang="ts">
-import { Component, Vue, Prop } from "vue-property-decorator";
+import { Component, Vue } from "vue-property-decorator";
 
 @Component
 export default class ResourceDropdown extends Vue {}

js/src/components/Resource/ResourceSelector.vue

@@ -47,7 +47,7 @@
     <b-button type="is-primary" @click="updateResource" :disabled="moveDisabled">{{
       $t("Move resource to {folder}", { folder: resource.title })
     }}</b-button>
-    <b-button type="is-text" @click="$emit('closeMoveModal')">{{ $t("Cancel") }}</b-button>
+    <b-button type="is-text" @click="$emit('close-move-modal')">{{ $t("Cancel") }}</b-button>
   </div>
 </template>
 <script lang="ts">
@@ -81,15 +81,15 @@ export default class ResourceSelector extends Vue {
 
   resource: IResource | undefined = this.initialResource.parent;
 
-  goDown(element: IResource) {
+  goDown(element: IResource): void {
     if (element.type === "folder" && element.id !== this.initialResource.id) {
       this.resource = element;
     }
   }
 
-  updateResource() {
+  updateResource(): void {
     this.$emit(
-      "updateResource",
+      "update-resource",
       {
         id: this.initialResource.id,
         title: this.initialResource.title,
@@ -100,12 +100,12 @@ export default class ResourceSelector extends Vue {
     );
   }
 
-  get moveDisabled() {
+  get moveDisabled(): boolean | undefined {
     return (
       (this.initialResource.parent &&
         this.resource &&
         this.initialResource.parent.path === this.resource.path) ||
-      (this.initialResource.parent == undefined && this.resource && this.resource.path === "/")
+      (this.initialResource.parent === undefined && this.resource && this.resource.path === "/")
     );
   }
 }

js/src/components/SearchField.vue

@@ -23,9 +23,9 @@ export default class SearchField extends Vue {
 
   search = "";
 
-  enter() {
+  async enter(): Promise<void> {
     this.$emit("navbar-search");
-    this.$router.push({
+    await this.$router.push({
       name: RouteName.SEARCH,
       query: { term: this.search },
     });

js/src/components/Settings/SettingMenuItem.vue

@@ -16,7 +16,7 @@ export default class SettingMenuItem extends Vue {
 
   @Prop({ required: true, type: Object }) to!: Route;
 
-  get isActive() {
+  get isActive(): boolean {
     if (!this.to) return false;
     if (this.to.name === this.$route.name) {
       if (this.to.params) {

js/src/components/Settings/SettingMenuSection.vue

@@ -20,11 +20,12 @@ export default class SettingMenuSection extends Vue {
 
   @Prop({ required: true, type: Object }) to!: Route;
 
-  get sectionActive() {
+  get sectionActive(): boolean {
     if (this.$slots.default) {
       return this.$slots.default.some(
         ({
           componentOptions: {
+            // eslint-disable-next-line @typescript-eslint/ban-ts-comment
             // @ts-ignore
             propsData: { to },
           },

js/src/components/Settings/SettingsMenu.vue

@@ -55,13 +55,14 @@
   </aside>
 </template>
 <script lang="ts">
-import { Component, Prop, Vue } from "vue-property-decorator";
+import { Component, Vue } from "vue-property-decorator";
+import { ICurrentUserRole } from "@/types/enums";
 import SettingMenuSection from "./SettingMenuSection.vue";
 import SettingMenuItem from "./SettingMenuItem.vue";
 import { IDENTITIES } from "../../graphql/actor";
 import { IPerson, Person } from "../../types/actor";
 import { CURRENT_USER_CLIENT } from "../../graphql/user";
-import { ICurrentUser, ICurrentUserRole } from "../../types/current-user.model";
+import { ICurrentUser } from "../../types/current-user.model";
 
 import RouteName from "../../router/name";
 

js/src/components/Todo/FullTodo.vue

@@ -18,7 +18,7 @@
 </template>
 <script lang="ts">
 import { Component, Prop, Vue } from "vue-property-decorator";
-import { debounce } from "lodash";
+import { debounce, DebouncedFunc } from "lodash";
 import { SnackbarProgrammatic as Snackbar } from "buefy";
 import { ITodo } from "../../types/todos";
 import RouteName from "../../router/name";
@@ -36,7 +36,7 @@ export default class Todo extends Vue {
 
   editMode = false;
 
-  debounceUpdateTodo!: Function;
+  debounceUpdateTodo!: DebouncedFunc<(obj: Record<string, unknown>) => Promise<void>>;
 
   // We put this in data because of issues like
   // https://github.com/vuejs/vue-class-component/issues/263

js/src/components/Utils/RedirectWithAccount.vue

@@ -54,7 +54,7 @@
 import { Component, Prop, Vue } from "vue-property-decorator";
 import VerticalDivider from "@/components/Utils/VerticalDivider.vue";
 import Subtitle from "@/components/Utils/Subtitle.vue";
-import { LoginErrorCode } from "@/types/login-error-code.model";
+import { LoginErrorCode } from "@/types/enums";
 import RouteName from "../../router/name";
 
 @Component({

js/src/mixins/actor.ts

@@ -4,9 +4,9 @@ import { Component, Vue } from "vue-property-decorator";
 
 @Component
 export default class ActorMixin extends Vue {
-  static actorIsOrganizer(actor: IActor, event: IEvent) {
+  static actorIsOrganizer(actor: IActor, event: IEvent): boolean {
     console.log("actorIsOrganizer actor", actor.id);
     console.log("actorIsOrganizer event", event);
-    return event.organizerActor && actor.id === event.organizerActor.id;
+    return event.organizerActor !== undefined && actor.id === event.organizerActor.id;
   }
 }

js/src/mixins/event.ts

@@ -1,7 +1,8 @@
 import { mixins } from "vue-class-component";
 import { Component, Vue } from "vue-property-decorator";
 import { SnackbarProgrammatic as Snackbar } from "buefy";
-import { IParticipant, ParticipantRole } from "../types/participant.model";
+import { ParticipantRole } from "@/types/enums";
+import { IParticipant } from "../types/participant.model";
 import { IEvent } from "../types/event.model";
 import {
   DELETE_EVENT,

js/src/mixins/group.ts

@@ -2,7 +2,8 @@ import { PERSON_MEMBERSHIPS, CURRENT_ACTOR_CLIENT } from "@/graphql/actor";
 import { GROUP_MEMBERSHIP_SUBSCRIPTION_CHANGED } from "@/graphql/event";
 import { FETCH_GROUP } from "@/graphql/group";
 import RouteName from "@/router/name";
-import { Group, IActor, IGroup, IPerson, MemberRole } from "@/types/actor";
+import { Group, IActor, IGroup, IPerson } from "@/types/actor";
+import { MemberRole } from "@/types/enums";
 import { Component, Vue } from "vue-property-decorator";
 
 @Component({

js/src/mixins/relay.ts

@@ -1,8 +1,9 @@
 import { Component, Vue, Ref } from "vue-property-decorator";
-import { ActorType, IActor } from "@/types/actor";
+import { IActor } from "@/types/actor";
 import { IFollower } from "@/types/actor/follower.model";
 import { RELAY_FOLLOWERS, RELAY_FOLLOWINGS } from "@/graphql/admin";
 import { Paginate } from "@/types/paginate";
+import { ActorType } from "@/types/enums";
 
 @Component({
   apollo: {

js/src/router/event.ts

@@ -18,7 +18,6 @@ export enum EventRouteName {
   EVENT_PARTICIPATE_WITHOUT_ACCOUNT = "EVENT_PARTICIPATE_WITHOUT_ACCOUNT",
   EVENT_PARTICIPATE_LOGGED_OUT = "EVENT_PARTICIPATE_LOGGED_OUT",
   EVENT_PARTICIPATE_CONFIRM = "EVENT_PARTICIPATE_CONFIRM",
-  LOCATION = "Location",
   TAG = "Tag",
 }
 
@@ -46,14 +45,17 @@ export const eventRoutes: RouteConfig[] = [
     name: EventRouteName.EDIT_EVENT,
     component: editEvent,
     meta: { requiredAuth: true },
-    props: (route: Route) => ({ ...route.params, ...{ isUpdate: true } }),
+    props: (route: Route): Record<string, unknown> => ({ ...route.params, ...{ isUpdate: true } }),
   },
   {
     path: "/events/duplicate/:eventId",
     name: EventRouteName.DUPLICATE_EVENT,
     component: editEvent,
     meta: { requiredAuth: true },
-    props: (route: Route) => ({ ...route.params, ...{ isDuplicate: true } }),
+    props: (route: Route): Record<string, unknown> => ({
+      ...route.params,
+      ...{ isDuplicate: true },
+    }),
   },
   {
     path: "/events/:eventId/participations",
@@ -62,12 +64,6 @@ export const eventRoutes: RouteConfig[] = [
     meta: { requiredAuth: true },
     props: true,
   },
-  {
-    path: "/location/new",
-    name: EventRouteName.LOCATION,
-    component: () => import(/* webpackChunkName: "Location" */ "@/views/Location.vue"),
-    meta: { requiredAuth: true },
-  },
   {
     path: "/events/:uuid",
     name: EventRouteName.EVENT,

js/src/router/guards/auth-guard.ts

@@ -1,7 +1,7 @@
 import { NavigationGuard } from "vue-router";
 import { UserRouteName } from "@/router/user";
-import { LoginErrorCode } from "@/types/login-error-code.model";
 import { AUTH_ACCESS_TOKEN } from "@/constants";
+import { LoginErrorCode } from "@/types/enums";
 
 // eslint-disable-next-line import/prefer-default-export
 export const authGuardIfNeeded: NavigationGuard = async (to, from, next) => {

js/src/router/guards/register-guard.ts

@@ -1,6 +1,6 @@
+import { ErrorCode } from "@/types/enums";
 import { NavigationGuard } from "vue-router";
 import { CONFIG } from "../../graphql/config";
-import { ErrorCode } from "../../types/error-code.model";
 import apolloProvider from "../../vue-apollo";
 
 // eslint-disable-next-line import/prefer-default-export

js/src/router/settings.ts

@@ -1,4 +1,4 @@
-import { RouteConfig } from "vue-router";
+import { Route, RouteConfig } from "vue-router";
 
 export enum SettingsRouteName {
   SETTINGS = "SETTINGS",
@@ -199,7 +199,10 @@ export const settingsRoutes: RouteConfig[] = [
           import(
             /* webpackChunkName: "EditIdentity" */ "@/views/Account/children/EditIdentity.vue"
           ),
-        props: (route) => ({ identityName: route.params.identityName, isUpdate: false }),
+        props: (route: Route): Record<string, unknown> => ({
+          identityName: route.params.identityName,
+          isUpdate: false,
+        }),
         meta: { requiredAuth: true },
       },
       {
@@ -209,7 +212,10 @@ export const settingsRoutes: RouteConfig[] = [
           import(
             /* webpackChunkName: "EditIdentity" */ "@/views/Account/children/EditIdentity.vue"
           ),
-        props: (route) => ({ identityName: route.params.identityName, isUpdate: true }),
+        props: (route: Route): Record<string, unknown> => ({
+          identityName: route.params.identityName,
+          isUpdate: true,
+        }),
         meta: { requiredAuth: true },
       },
     ],

js/src/router/user.ts

@@ -1,5 +1,5 @@
 import { beforeRegisterGuard } from "@/router/guards/register-guard";
-import { RouteConfig } from "vue-router";
+import { Route, RouteConfig } from "vue-router";
 
 export enum UserRouteName {
   REGISTER = "Register",
@@ -27,7 +27,7 @@ export const userRoutes: RouteConfig[] = [
     component: () =>
       import(/* webpackChunkName: "RegisterProfile" */ "@/views/Account/Register.vue"),
     // We can only pass string values through params, therefore
-    props: (route) => ({
+    props: (route: Route): Record<string, unknown> => ({
       email: route.params.email,
       userAlreadyActivated: route.params.userAlreadyActivated === "true",
     }),

js/src/services/AnonymousParticipationStorage.ts

@@ -16,6 +16,14 @@ class AnonymousParticipationNotFoundError extends Error {
   }
 }
 
+function jsonToMap(jsonStr: string): Map<string, IAnonymousParticipation> {
+  return new Map(JSON.parse(jsonStr));
+}
+
+function mapToJson(map: Map<any, any>): string {
+  return JSON.stringify([...map]);
+}
+
 /**
  * Fetch existing anonymous participations saved inside this browser
  */